Richard Brooksby
|
fb01ffab89
|
Clarifying what "interface" means, in response to comment by @unaa008 <https://github.com/ravenbrook/mps/pull/97#discussion_r1085574318>.
|
2023-01-25 21:22:29 +00:00 |
|
Richard Brooksby
|
04b54287ad
|
Adding time-to-execute estimates based on measurements.
|
2023-01-23 09:40:47 +00:00 |
|
Richard Brooksby
|
58aa9a0e08
|
Adding document tag proc.merge.pull-request.
|
2023-01-20 10:27:47 +00:00 |
|
Richard Brooksby
|
cab1bf047e
|
Adding instruction to record the revision of the procedure being followed in the pull request.
|
2023-01-19 12:54:14 +00:00 |
|
Richard Brooksby
|
f8b327b17c
|
Process improvement: check that the code review is recent. response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1384095096>.
|
2023-01-16 22:24:11 +00:00 |
|
Richard Brooksby
|
f341d2cbb3
|
Linking justification of durable branch naming convention. adding step to eyeball results and protect against losing issues.
|
2023-01-14 13:07:28 +00:00 |
|
Richard Brooksby
|
407942da3f
|
Explaining where to look for build results in step 6.
|
2023-01-14 12:58:49 +00:00 |
|
Richard Brooksby
|
baadb2eae0
|
Unfortunately, inserting this reference resets the numbered list. backed out for now.
|
2023-01-14 12:54:25 +00:00 |
|
Richard Brooksby
|
cb813a125f
|
Short explanation of basis for deciding after checklist, in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818>.
|
2023-01-14 12:45:46 +00:00 |
|
Richard Brooksby
|
d9fa8d07e7
|
Clarifying that local/ci build step conditions are the same, in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818>.
|
2023-01-14 12:41:47 +00:00 |
|
Richard Brooksby
|
54aa9bb04e
|
Unifying and simplifying checklist item for build results in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818>.
|
2023-01-14 12:37:11 +00:00 |
|
Richard Brooksby
|
c1d21cb221
|
Adding more thorough check that perforce is in sync with github in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818> item 4.
|
2023-01-14 12:20:08 +00:00 |
|
Richard Brooksby
|
d5e15d6387
|
Stating purpose of procedure in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818>.
|
2023-01-14 12:04:06 +00:00 |
|
Richard Brooksby
|
3f619f57bc
|
Updating document history with references back to github conversations.
|
2023-01-14 11:54:09 +00:00 |
|
Richard Brooksby
|
74b3fdc0c2
|
Adding check for approval in response to <https://github.com/ravenbrook/mps/pull/97#issuecomment-1381771818>.
|
2023-01-14 11:47:37 +00:00 |
|
Richard Brooksby
|
9d48c089a3
|
More neutral wording about fast-forwards and squashes, suggested in <https://github.com/ravenbrook/mps/pull/97#discussion_r1070033916>.
|
2023-01-14 11:09:36 +00:00 |
|
Richard Brooksby
|
e7a0fe4d1c
|
Fixing typo <https://github.com/ravenbrook/mps/pull/97#discussion_r1069972466>.
|
2023-01-14 10:52:52 +00:00 |
|
Richard Brooksby
|
93675f652f
|
Further generalisation of ci to include both travis and github.
|
2023-01-13 18:57:03 +00:00 |
|
Richard Brooksby
|
0f860789a6
|
Making it clearer how to do a fetch from a pull request by number.
|
2023-01-13 18:16:57 +00:00 |
|
Richard Brooksby
|
d2ab43afa1
|
Clarifying that "this procedure" in the checklist means the merging procedure, and linking it.
|
2023-01-13 18:12:45 +00:00 |
|
Richard Brooksby
|
5538e40910
|
Explaining more clearly where to find build results, and generalising from travis ci to ci in general.
|
2023-01-13 18:07:14 +00:00 |
|
Richard Brooksby
|
1a032793c6
|
Clarifying not to start the merging procedure when there are licensing issues to resolve.
|
2023-01-13 17:48:18 +00:00 |
|
Richard Brooksby
|
55045fbc1d
|
Clarifying what "not having" ci results means.
|
2023-01-13 13:06:05 +00:00 |
|
Richard Brooksby
|
13112a07ef
|
Explaining why we edit the merge comment.
|
2023-01-13 11:58:12 +00:00 |
|
Richard Brooksby
|
4b42fc6be0
|
Clarifying what failure of pull might look like.
|
2023-01-13 11:48:58 +00:00 |
|
Richard Brooksby
|
af15f67720
|
Clarifying why we might pull from a pull request not a branch.
|
2023-01-13 11:37:57 +00:00 |
|
Richard Brooksby
|
bbf6fc7fba
|
Updating document history.
|
2023-01-13 05:07:43 +00:00 |
|
Richard Brooksby
|
e2aab4f405
|
Explaining when to run tests.
|
2023-01-13 05:05:34 +00:00 |
|
Richard Brooksby
|
dba43ff7c2
|
Clarifying where to get the branch from and moving common case to top.
|
2023-01-13 04:55:22 +00:00 |
|
Richard Brooksby
|
de1f95fa0d
|
Adding example command for when the branch is already in the ravenbrook repo.
|
2023-01-13 04:49:52 +00:00 |
|
Richard Brooksby
|
31ff76abea
|
Adding step to configure git email address.
|
2023-01-13 04:46:56 +00:00 |
|
Richard Brooksby
|
285016a095
|
Clarifying what to do if contributor varies licensing.
|
2023-01-13 04:43:00 +00:00 |
|
Richard Brooksby
|
1cf9efeb18
|
Adding instructions for the checklist.
|
2023-01-13 04:39:45 +00:00 |
|
Richard Brooksby
|
1a09d9c140
|
Forgot to push to a fresh branch in the previous change.
|
2023-01-12 21:53:51 +00:00 |
|
Richard Brooksby
|
fbcc92139f
|
Implementing a more natural strategy by separating the use of ci from updating the branch. see also <https://github.com/ravenbrook/mps/pull/97#issuecomment-1380980005>.
|
2023-01-12 21:34:30 +00:00 |
|
Richard Brooksby
|
3e4bb50338
|
Attempt to prevent github rewriting links to github by using a code quotation.
|
2023-01-12 18:15:35 +00:00 |
|
Richard Brooksby
|
790d46258b
|
Adding instructions for the commit message on the merge.
|
2023-01-11 02:08:30 +00:00 |
|
Richard Brooksby
|
f1a329c27b
|
Using travis ci's "blocklisting" to exclude branches, rather than a conditional expression, for easier management and diffs.
|
2023-01-10 22:13:07 +00:00 |
|
Richard Brooksby
|
91b02cdf1b
|
Adding note about varying the procedure for pull requests not on github.
|
2023-01-10 13:34:37 +00:00 |
|
Richard Brooksby
|
2c58a15841
|
Adding link to pull request template docs.
|
2023-01-10 11:04:56 +00:00 |
|
Richard Brooksby
|
904a344200
|
Removing draft status.
|
2023-01-10 10:19:38 +00:00 |
|
Richard Brooksby
|
01bdb0c1c2
|
Linking refs to github repo for ease-of-use.
|
2023-01-10 10:19:11 +00:00 |
|
Richard Brooksby
|
ab87f23af5
|
Adding reference to github branch protection rules.
|
2023-01-10 10:17:38 +00:00 |
|
Richard Brooksby
|
11a02bf064
|
Removing comment about customer-specific branches. this case is covered by asking whether the contribution is licensed.
|
2023-01-10 09:05:03 +00:00 |
|
Richard Brooksby
|
9a63055809
|
Minor clarifications.
|
2023-01-10 09:04:28 +00:00 |
|
Richard Brooksby
|
b4d14479c6
|
I was mislead by [chaser324_2017]. removed it and arguments from it. improved the rationale. explained how and when we can use the github merge button.
|
2023-01-10 08:54:34 +00:00 |
|
Richard Brooksby
|
b3ca307426
|
Attempt to disable builds for this branch, branch/2023-01-07/pull-request-merge-procedure, in response to travis ci support case 42422.
|
2023-01-10 08:10:53 +00:00 |
|
Richard Brooksby
|
853c82b784
|
Adding note about [chaser324_2017]_ being misleading about the merge button.
|
2023-01-10 08:08:55 +00:00 |
|
Richard Brooksby
|
b2d5fd440c
|
Improving language and fixing a typo.
|
2023-01-09 09:31:09 +00:00 |
|
Richard Brooksby
|
2c8bf3dac1
|
Avoid renaming correctly named branches.
|
2023-01-09 09:29:18 +00:00 |
|