mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-03-26 08:41:47 -07:00
Code Issues Projects Releases Wiki Activity

Clarifying what "interface" means, in response to comment by @unaa008 <https://github.com/ravenbrook/mps/pull/97#discussion_r1085574318>.

Browse source
This commit is contained in:
Richard Brooksby 2023-01-25 21:22:29 +00:00
parent 04b54287ad
commit fb01ffab89
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
mps/procedure/pull-request-merge.rst
View file

@ -79,7 +79,7 @@ by considering `2. Purpose`_.
(without the branch) and that that the problem is solved (with the
branch)?
#. If there are interface changes, are they documented?
#. If there changes to the `MPS interface`_, are they documented?
#. If the changes are significant and user-visible, is there an update
to the release notes (``manual/source/release.rst``)?
@ -140,6 +140,8 @@ by considering `2. Purpose`_.
.. _GitHub workflows for the repo: https://github.com/Ravenbrook/mps/actions
.. _MPS interface: https://www.ravenbrook.com/project/mps/master/manual/html/topic/interface.html
4. Prerequisite steps
---------------------
@ -329,13 +331,13 @@ These steps will only rarely need repeating.
on Berunda and restart it if necessary, or ask a sysadmin to do
this.
.. _Fetch the pull request branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally
9. Eyeball the pull request and related issues on GitHub to make sure
the merge was recorded correctly. Check that any issues *not
completely resolved* by the merge were not closed. Re-open them if
necessary.
.. _Fetch the pull request branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally
6. Rationale
------------