mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-04-19 04:21:45 -07:00
Code Issues Projects Releases Wiki Activity

Linking justification of durable branch naming convention. adding step to eyeball results and protect against losing issues.

Browse source
This commit is contained in:
Richard Brooksby 2023-01-14 13:07:28 +00:00
parent 407942da3f
commit f341d2cbb3
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
mps/procedure/pull-request-merge.rst
View file

@ -166,7 +166,7 @@ These steps will only rarely need repeating.
--------------------
1. `Fetch the pull request branch`_ to a local branch using the MPS
durable branch naming convention, "branch/DATE/TOPIC".
`durable branch naming convention`_, "branch/DATE/TOPIC".
If the branch already has a conventional name, and it's in the
`Ravenbrook MPS repo on GitHub`_ then fetch it with the existing
@ -319,6 +319,11 @@ These steps will only rarely need repeating.
.. _Fetch the pull request branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally
9. Eyeball the pull request and related issues on GitHub to make sure
the merge was recorded correctly. Check that any issues *not
completely resolved* by the merge were not closed. Re-open them if
necessary.
6. Rationale
------------
@ -406,6 +411,8 @@ checklist into GitHub's interface using a `pull request template
<https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository>`_.
.. _durable branch naming convention:
6.3. Why the "durable" branch names?
------------------------------------