stable-diffusion-webui/docs/milestones/M05/M05_summary.md
2026-03-09 22:53:27 -07:00

1.7 KiB

M05 Summary — Override Isolation / Temporary Opts Seam

Project: Serena
Phase: Phase II — Runtime Seam Preparation
Milestone: M05 — Override isolation / temporary opts seam
Status: Closed
Branch: m05-override-isolation
PR: #18 (implementation), #19 (CI harness fix)
Commit: ae161cbb (merge PR #19)
Quality Run: 22888808682 ✓


Accomplished

Item Status
Introduced temporary_opts() context manager ✓ modules/runtime_utils.py
Isolated override_settings mutation from global runtime ✓ process_images refactored
Preserved existing behavior ✓ opts.set(is_api=True, run_callbacks=False), setattr restore, k in opts.data
Model/VAE reload left in process_images
Token merging unchanged
Added seam tests ✓ test/quality/test_opts_override.py
CI harness stabilized ✓ test/conftest.py — minimal config.json when missing

CI Layout After M05

Workflow Trigger Coverage Security
Smoke Tests pull_request (main) No gate None
Linter pull_request
Quality Tests push to main ≥40% pip-audit (informational)

Invariants Preserved

  • API response schemas
  • CLI behavior
  • Extension compatibility
  • Generation semantics
  • CI truthfulness

Blast Radius

File Change
modules/runtime_utils.py New
modules/processing.py Modified
test/quality/test_opts_override.py New
test/conftest.py CI harness fix

Refactor Result

Global override mutation replaced with scoped context manager. First runtime seam in Phase II; enables future opts snapshot injection (M07).