1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-30 09:00:31 -08:00
Commit graph

130819 commits

Author SHA1 Message Date
Stefan Monnier
ef3d8505ec * lisp/help-fns.el (describe-function-1):
Fix help-fns-test-dangling-alias.  (Bug#28918)

(cherry picked from commit e1d42f8f4a)
2017-10-20 16:58:32 -04:00
Glenn Morris
11bd8aa24b Fix flymake's loading of subr-x
* lisp/progmodes/flymake.el, test/lisp/progmodes/flymake-tests.el:
No need to load subr-x at run-time.
2017-10-20 13:07:30 -04:00
Michael Albinus
b500e06f4d Fix Bug#28896
* lisp/net/tramp-adb.el (tramp-adb-handle-rename-file):
* lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
* lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file): Handle FILENAME
being a directory.  (Bug#28896)

* test/lisp/net/tramp-tests.el (tramp-test11-copy-file)
(tramp-test12-rename-file): Test also FILENAME being a directory.
2017-10-20 12:46:54 +02:00
João Távora
d815de017b Skip a Flymake test for old gcc versions
Fixes: 28906

* test/lisp/progmodes/flymake-tests.el
(different-diagnostic-types): Skip this test for gcc versions
< 5.
2017-10-20 11:28:07 +01:00
Eli Zaretskii
fd3d8610b2 Make :align-to account for display-line-numbers
These changes also update the various bundled packages to use
new feature, and better support customizations of the line-number
face.
* src/xdisp.c (calc_pixel_width_or_height): Improve commentary.
Make :align-to count from the end of the line-number display when
the offset or the width form reference that of the text area.
(Bug#28855)

* src/indent.c (Fline_number_display_width): Implement support for
the PIXELWISE argument being 'columns'.  Update the doc string.
(syms_of_indent): New symbol 'columns'.

* lisp/ruler-mode.el (ruler-mode-window-col, ruler-mode-ruler):
Call line-number-display-width with last argument 'columns'.

* lisp/proced.el (proced-header-line): Call
line-number-display-width with 2nd arg 'columns', which also fixes
a problem when display-line-numbers is nil.

* lisp/emacs-lisp/tabulated-list.el
(tabulated-list-line-number-width): Call line-number-display-width
with 2nd arg 'columns.
(tabulated-list-entry-lnum-width): Remove unneeded defvar.
(tabulated-list-print, tabulated-list-print-entry): No need to
account for the value of tabulated-list-entry-lnum-width.
(tabulated-list--current-lnum-width): New defvar.
(tabulated-list-watch-line-number-width): New function.
(tabulated-list-mode): Bind tabulated-list--current-lnum-width
locally, and set up tabulated-list-watch-line-number-width as
pre-redisplay-functions hook.

* doc/lispref/display.texi (Size of Displayed Text): Document the
'columns' value of the PIXELWISE argument.
(Pixel Specification): Update and improve the documentation of the
supported forms.
2017-10-20 12:36:12 +03:00
João Távora
831eafc8ae Augment Flymake API for third-party extensions
See
https://lists.gnu.org/archive/html/emacs-devel/2017-10/msg00619.html

* doc/misc/flymake.texi (Flymake error types): Rewrite
example.
(Flymake utility functions): Augment with new API.

* lisp/progmodes/flymake.el (flymake-diagnostics): New function.
(flymake--diag-accessor): New helper macro.
(flymake-diagnostic-buffer, flymake-diagnostic-text)
(flymake-diagnostic-beg, flymake-diagnostic-end)
(flymake-diagnostic-backend): Accessors for diagnostic objects.
(flymake--overlays): Use flymake-diagnostic property.
(flymake--highlight-line): Simplify.  Only set
flymake-diagnostic property.
(flymake--handle-report, flymake-goto-next-error): Use
flymake-diagnostic property.
(flymake-show-diagnostic): Use diagnostic object.
(flymake--diagnostics-buffer-entries): Use
flymake-diagnostics.
2017-10-20 10:00:19 +01:00
Glenn Morris
ddd547fada Improve treatment of Fortran's "class default"
* lisp/progmodes/f90.el (f90-start-block-re, f90-no-block-limit):
Handle "class default".  (Bug#28786)
* test/automated/f90.el (f90-test-bug25039): Add "class default".
2017-10-19 20:05:48 -04:00
João Távora
234b1e3864 Flymake backends must check proc obsoleteness in source buffer
Flymake backends that rely on sentinels running asynchronously and
checking buffer-local variables that hold running processes should
check for obsoleteness in the correct buffers, otherwise a (harmless)
warning might be triggered.

* doc/misc/flymake.texi (An annotated example backend):
Check buffer-local proc in the current buffer.

* lisp/progmodes/elisp-mode.el (elisp-flymake-byte-compile):
Check buffer-local proc in the current buffer.
2017-10-20 00:50:34 +01:00
Michael Albinus
3ea6a4d4ba Skip an rsync test in tramp-tests.el
* test/lisp/net/tramp-tests.el (tramp-test17-dired-with-wildcards):
Skip for "rsync".
2017-10-19 17:47:14 +02:00
Bastian Beischer
25f83fa7c5 ; Indentation fixes 2017-10-19 13:03:27 +03:00
Martin Rudalics
4d578d432d On Windows default a frame's border width to zero (Bug#28873)
* src/w32fns.c (Fx_create_frame): Default `border-width' to zero
as everywhere else, see Bug#28873.
2017-10-19 09:51:12 +02:00
Paul Eggert
6f1dea5c74 Spelling fixes
* lisp/cedet/semantic/analyze/refs.el:
(semantic-analyze-proto-impl-toggle): Fix recently-introduced
misspelling of pop-to-buffer-same-window.
2017-10-18 18:43:44 -07:00
Bastian Beischer
b8433b0954 Use pop-to-buffer-same-window instead of switch-to-buffer
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-include-visit):
Use pop-to-buffer-same-window instead of switch-to-buffer
(bug#28645).

* lisp/cedet/semantic/analyze/refs.el
(semantic-analyze-proto-impl-toggle): Same.

* lisp/cedet/semantic/senator.el (senator-go-to-up-reference):
Same.

* lisp/cedet/semantic/mru-bookmark.el (semantic-mrub-visit):
Same.

* lisp/cedet/semantic/complete.el (semantic-complete-jump):
Same.

Copyright-paperwork-exempt: yes
2017-10-19 02:45:17 +03:00
Eli Zaretskii
2f7163fb72 Fix the MSDOS build.
* msdos/sed1v2.inp (GETADDRINFO_A_LIBS, LIBLCMS2, XDBE_LIBS)
(XDBE_FLAGS, HYBRID_MALLOC, LIBSYSTEMD_CFLAGS)
(LIBSYSTEMD_LIBS): Edit to empty.
(LIBRESOLV, DEPFLAGS, MKDEPDIR, YMF_PASS_LDFLAGS)
(PRE_EDIT_LDFLAGS, POST_EDIT_LDFLAGS): Remove editing.
Remove editing of lines that are no longer present in
src/Makefile.in.
* msdos/sed2v2.inp (NEED_MKTIME_INTERNAL)
(NEED_MKTIME_WORKING): Define to 1.
(HAVE_STRUCT_DIRENT_D_TYPE): Define to 1 for
DJGPP >= 2.05.
(HAVE_STRUCT_ATTRIBUTE_ALIGNED): Define to 1.
Define PACKAGE_VERSION, not VERSION.
(FLEXIBLE_ARRAY_MEMBER): Define to empty.
(HAVE_DECL_*_UNLOCKED): Define to 0.
(HAVE___BUILTIN_FRAME_ADDRESS): Define to 1.
(PENDING_*): Don't define, as Gnulib no longer supports that.
Instead, define _IOERR as it is in libc/file.h.
* msdos/sed3v2.inp: Use $(CURDIR) instead of $(shell cd) to
determine the current directory.
(UPDATE_MANIFEST, UTILITIES): Don't edit.
* msdos/sedlisp.inp (FIND_DELETE): Edit to "-delete".
* msdos/sedlibmk.inp (AUTO_DEPEND): Define to yes.
(HYBRID_MALLOC): Edit to empty.
(am__cd): Don't edit.
(../config.status): Replaces $(top_builddir)/config.status.
Define OMIT_GNULIB_MODULE_foo = true for modules not built for
MS-DOS.  Convert GL_GENERATE_xxx_H_TRUE and
GL_GENERATE_xxx_H_FALSE into values of GL_GENERATE_xxx_H.
* msdos/mainmake.v2 (src): Use 'compile-one-process', and make
the command line shorter to fit into 126-char limit of
command.com.
* config.bat: Generate src/deps/*.d files.  Rename more files
like djtar on plain DOS would.
Don't rename src/dir.h: it is long gone.  Edit
lib/gnulib.mk.in using the same scripts as for
lib/Makefile.in.
* msdos/depfiles.bat: Create *.d files, not *.Po.

* src/thread.c (Fmake_thread) [!THREADS_ENABLED]: Improve the
error message.
* src/thread.h [MSDOS]: Include <signal.h>.
* src/sysselect.h (select) [MSDOS]: Undefine, to avoid
compilation errors.
* src/sysdep.c (block_interrupt_signal, restore_signal_mask):
Expose to MSDOS build.
* src/process.c (update_processes_for_thread_death)
[!subprocess]: No-op implementation.
[HAVE_SETRLIMIT]: Move inclusion of sys/resource.h and
declaration of nofile_limit outside "#ifdef subprocesses", as
it's needed for MSDOS.
* src/msdos.c (faccessat): Declare fullname[].
* src/msdos.h (ENOTSUP): Define to be identical to ENOSYS.
Include termhooks.h.
* src/conf_post.h [WINDOWSNT]: Include ms-w32.h only on
WINDOWSNT, not DOS_NT.

* admin/admin.el (set-version): Set version on PACKAGE_VERSION.
2017-10-18 20:21:25 +03:00
Eli Zaretskii
2551d28fe8 Fix line number display after 'widen'
* src/xdisp.c (maybe_produce_line_number): Don't use data cached
by line-number-mode on the first redisplay after the buffer is
widened.  (Bug#28879)
2017-10-18 19:16:16 +03:00
Alan Third
dc8812829b Remove resizable attribute on macOS undecorated frames (bug#28512)
* src/nsterm.m (FRAME_DECORATED_FLAGS): Remove Cocoa specific #define.
(initFrameFromEmacs): Remove Cocoa specific window style attributes.
2017-10-18 09:25:33 +01:00
Martin Rudalics
b970a4a52a Fix handling of border-width' in frameset--restore-frame' (Bug#28873)
* lisp/frameset.el (frameset--restore-frame): Don't process
`border-width' parameter via ‘modify-frame-parameters’
(Bug#28873).
2017-10-18 10:04:40 +02:00
Tino Calancha
445e92658f Mention how to send CC to > 1 address in a bug report
* admin/notes/bugtracker (* More detailed information):
mention how to CC to more than 1 address (Bug#28833).
2017-10-18 12:12:59 +09:00
Paul Eggert
8ca6fa585a Improve format-time-string doc
* doc/lispref/os.texi (Time Parsing): Fix some errors in the
documentation for format-time-string.  Document ^, #, %s, and %z
with colons.  Say that unrecognized sequences are output as-is.
* src/editfns.c (Fformat_time_string): %S can stand for 60.
Also mention unrecognized sequences.
2017-10-17 18:26:01 -07:00
Eli Zaretskii
2e1b3522b8 Improve documentation of 'line-number-display-width'
* doc/lispref/display.texi (Size of Displayed Text): Document the
additional 2 columns used for line-number display.

* src/indent.c (Fline_number_display_width): Doc fix.  (Bug#28248)
2017-10-17 19:17:22 +03:00
İ. Göktuğ Kayaalp
5b6e59cfdb Implement vc-default-dir-extra-headers for vc-rcs
Add a do-nothing implementation for vc-rcs to suppress the message which
the default function adds to the vc-dir buffer (Bug#28570).
* lisp/vc/vc-rcs.el (vc-rcs-dir-extra-headers): New function.
2017-10-17 13:38:04 +03:00
Martin Rudalics
22adeca42a In NEWS give advice on use of `switch-to-buffer' (Bug#28645)
* etc/NEWS: Mention that applications should prefer
`pop-to-buffer-same-window' to `switch-to-buffer'.  (Bug#28645)
2017-10-17 10:24:54 +02:00
Tino Calancha
2c3e6f1ddc Dont update primary selection with winner-undo
* lisp/winner.el (winner-set):
Dont update primary selection when select-enable-primary
is non-nil (Bug#28631).

Co-authored-by: Noam Postavsky <npostavs@gmail.com>
2017-10-17 16:20:08 +09:00
Paul Eggert
b38724ab67 Work around ImageMagick bug 825
This should fix several bugs reported recently against Emacs
(Bug#28518, Bug#28626, Bug#28632, Bug#28633, Bug#28770).
* src/image.c (imagemagick_load_image):
Do not call MagickWandTerminus.
2017-10-16 23:45:31 -07:00
Noam Postavsky
20cc68e871 Document rectangle-preview option more (Bug#27974)
* lisp/rect.el (string-rectangle):
* etc/NEWS.25: Mention `rectangle-preview'.
2017-10-16 20:10:55 -04:00
Paul Eggert
a0b7b301dd Do not reject https://gnu.org in commit messages
* build-aux/git-hooks/commit-msg: Do not reject commit messages
containing http: or ftp: URLs to gnu.org or fsf.org.  Instead,
rewrite the messages to use https: URLs.
2017-10-16 15:54:55 -07:00
Gemini Lasswell
fb4200a875 Fix Edebug spec for cl-defun (bug#24255)
* lisp/emacs-lisp/cl-macs.el: Modify the Edebug spec for
`cl-lambda-list' to support destructuring argument lists.
(cl-defun, cl-defmacro): Fix spelling errors in docstrings.
* lisp/textmodes/rst.el: Remove alternate version of Edebug
specs for `cl-lambda-list' and `cl-type-spec'.
2017-10-16 11:09:29 -07:00
Eli Zaretskii
db68cefe72 Fix errors in kmacro.el post-command-hook
* lisp/kmacro.el (kmacro-step-edit-active): Initialize to nil to
avoid 'void-variable' errors.  (Bug#28818)
* test/lisp/kmacro-tests.el
(kmacro-tests-step-edit-cleans-up-hook): Now succeeds.  (Bug#18708)
2017-10-16 19:36:06 +03:00
Eli Zaretskii
c63b344c3d Fix range-error in image-dired.el
* lisp/image-dired.el (image-dired-create-thumb-1): Avoid
overflowing an Emacs integer on 32-bit hosts.  (Bug#28809)
2017-10-16 19:25:01 +03:00
Eli Zaretskii
081d2187c4 Fix 'line-number-display-width' in hscrolled windows
* src/indent.c (line_number_display_width): Make sure a line
number is generated even when the first line of the window is
completely hscrolled out of view.  (Bug#28854)
2017-10-16 18:51:32 +03:00
Michael Albinus
16e85456e7 Fix error in tramp-smb-handle-insert-directory
* lisp/net/tramp-smb.el (tramp-smb-handle-insert-directory):
Insert size information only when FULL-DIRECTORY-P is non-nil.
2017-10-16 11:35:02 +02:00
Andy Moreton
613db8d35c Don't reject PBM header whitespace unnecessarily
* lisp/image.el (image-type-header-regexps):
Allow two or more CRs or LFs in initial whitespace sequences.  See:
http://netpbm.sourceforge.net/doc/pbm.html
2017-10-16 01:24:27 -07:00
Paul Eggert
3205b12a78 Fix regression in display of PPM images
Problem reported by Roland Winkler (Bug#28824#35).
Based on a patch proposed by Andy Moreton (Bug#28824#38).
* src/image.c (pbm_scan_index): New function.
(pbm_load): Use it to decode raw data correctly when its top bit
is set.
2017-10-16 01:24:27 -07:00
Eric Abrahamsen
1ca9ae7069 Require subr-x when compiling nnimap.el
* lisp/gnus/nnimap.el (require): For the when-let* macro.
2017-10-15 20:21:35 -07:00
Noam Postavsky
de60992053 Fix ert-test finding by symbol (Bug#28849)
In 2017-07-28 "* lisp/subr.el (define-symbol-prop): New function", the
symbol used for ert tests in load-history was changed from
`ert-deftest' to `ert--test', but a couple of other places were not
updated accordingly.
* lisp/emacs-lisp/ert.el (ert-find-test-other-window): Pass
`ert--test' as the TYPE to `find-function-do-it'.
(top-level): Use `ert--test' as the key to the
`find-function-regexp-alist' entry.
2017-10-15 13:58:45 -04:00
Noam Postavsky
51615a8082 Don't remember old debugger window (Bug#17882)
* lisp/emacs-lisp/debug.el (debug): Unset debugger-previous-window
when `debugger-will-be-back' is nil.
2017-10-15 13:58:45 -04:00
Noam Postavsky
5980de3727 Disable python native completion on w32 (Bug#28580)
* lisp/progmodes/python.el
(python-shell-completion-native-disabled-interpreters): For windows-nt
systems, put an empty string to match interpreters.
2017-10-15 13:58:45 -04:00
Noam Postavsky
616b4c5956 Let select-frame-by-name choose any frame when called from lisp (Bug#25521)
* lisp/frame.el (select-frame-by-name): Choose from the whole list of
frames in the non-interactive part, if not found on the current
display.
2017-10-15 13:58:45 -04:00
Eli Zaretskii
8eb3c01dbd * lisp/dired-aux.el (dired-create-directory): Doc fix. 2017-10-15 19:36:58 +03:00
Eli Zaretskii
325dfdae13 Avoid compilation warnings in optimized builds
* src/process.c (Fmake_network_process):
* src/image.c (xbm_scan, gif_load):
* src/fileio.c (Frename_file):
* src/data.c (Fmake_local_variable):
* src/buffer.c (fix_start_end_in_overlays):
* lib-src/etags.c (process_file_name): Mark variables with UNINIT
to avoid compiler warnings in optimized builds.
2017-10-15 19:20:58 +03:00
Eli Zaretskii
f79382819c ; * src/composite.c (Fclear_composition_cache): Fix last change. 2017-10-15 19:13:34 +03:00
K. Handa
f95cd5cd70 Improve customization of arabic-shaper-ZWNJ-handling.
Make the effect of customizing arabic-shaper-ZWNJ-handling appear
immediately.
* lisp/language/misc-lang.el (arabic-shaper-ZWNJ-handling): Add :set
value.
* src/composite.c (Fclear_composition_cache): New function.
(syms_of_composite): Defsubr it.
2017-10-15 23:15:47 +09:00
Charles A. Roelli
a7f154688d Improve customization type of 'mouse-drag-and-drop-region'
* lisp/mouse.el (mouse-drag-and-drop-region): Provide a more
precise customization type.
2017-10-15 12:40:34 +02:00
Paul Eggert
864734d112 ; Prefer https: to http: in GNU URLs 2017-10-14 19:19:24 -07:00
Paul Eggert
3c78960a47 Encourage https: in commit messages
* CONTRIBUTE: Prefer https: when citing.
* build-aux/git-hooks/commit-msg:
Diagnose http: and ftp: URLs to FSF or GNU hosts.
2017-10-14 19:19:24 -07:00
Michael Albinus
def9715282 ; Cleanup of etc/NEWS 2017-10-14 12:52:05 +02:00
Martin Rudalics
4e59ecc646 Fix wording in Elisp manual's child frames section (Bug#28819)
* doc/lispref/frames.texi (Child Frames): Fix wording (Bug#28819).
2017-10-14 10:30:09 +02:00
Eli Zaretskii
eda9f5018c Another fix for C mode fontification of w32 source files
* .dir-locals.el (c-mode) <c-noise-macro-names>: Add
"CALLBACK", to correctly fontify functions with this attribute.
2017-10-14 11:19:56 +03:00
Eli Zaretskii
05aadd8990 Fix fontification of ALIGN_STACK functions
* .dir-locals.el (c-mode) <c-noise-macro-names>: Add
"ALIGN_STACK", to correctly fontify functions with this attribute.
2017-10-14 11:17:34 +03:00
Eli Zaretskii
aa0c38f358 Make sure thread stack is properly aligned on MS-Windows
* src/systhread.c: Include w32term.h instead of windows.h.
(w32_beginthread_wrapper): Add ALIGN_STACK attribute, to ensure
the thread's stack is correctly aligned.
* src/w32term.h (ALIGN_STACK): Update commentary.
2017-10-14 11:13:47 +03:00