1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-09 13:10:57 -08:00
Commit graph

130934 commits

Author SHA1 Message Date
João Távora
e950f329c0 New xref-quit-and-goto-xref command bound to TAB (bug#28814)
This is like xref-goto-xref, but quits the *xref* window just before
the user jump to ref.

* lisp/progmodes/xref.el (xref--show-location): Handle 'quit
value for SELECT.
(xref-goto-xref): Take optional QUIT arg.
(xref-quit-and-goto-xref): New command.
(xref--xref-buffer-mode-map): Bind "Q" and "TAB" to
xref-quit-and-goto-xref.

* doc/emacs/maintaining.texi (Xref Commands): Describe new bindings in
*xref*.

* etc/NEWS (Xref): Describe new binding.
2017-11-03 16:13:39 +00:00
João Távora
5d34e1b288 Allow split-window-sensibly to split threshold in further edge case
As a fallback, and to avoid creating a frame, split-window-sensibly
would previously disregard split-height-threshold if the window to be
split is the frame's root window.

This change generalizes that: it disregards the threshold if the
window to be split is the frame's only _usable_ window (it is either
the only one, as before, or all the other windows are dedicated to
some buffer and thus cannot be touched).

This is required for the fix to bug#28814.

* lisp/window.el (split-height-threshold): Adjust doc to match
split-window-sensibly.
(split-window-sensibly): Also disregard threshold if all other
windows are dedicated.
2017-11-03 16:13:37 +00:00
João Távora
2a973edeac Honor window-switching intents in xref-find-definitions (bug#28814)
When there is more than one xref to jump to, and an *xref* window
appears to help the user choose, the original intent to open a
definition in another window or frame is remembered when the choice to
go to or show a reference is finally made.

* lisp/progmodes/xref.el (xref--show-pos-in-buf): Rewrite.
(xref--original-window-intent): New variable.
(xref--original-window): Rename from xref--window and move up
here for clarity.
(xref--show-pos-in-buf): Rewrite.  Don't take SELECT arg here.
(xref--show-location): Handle window selection decision here.
(xref--window): Rename to xref--original-window.
(xref-show-location-at-point): Don't attempt window management here.
(xref--show-xrefs): Ensure display-action intent is saved.
2017-11-03 16:13:35 +00:00
Paul Pogonyshev
78e9065e9f * lisp/emacs-lisp/generator.el (iter-do): Add a debug declaration. 2017-11-03 15:49:51 +02:00
Stefan Monnier
caa63cc96c * lisp/progmodes/flymake.el (flymake-start): Fix dead buffer case
Don't try to flymake-start within a buffer that doesn't exist any more.
2017-11-03 08:33:13 -04:00
Basil L. Contovounesios
9f4f130b79 Fix buffer name comparison in async shell-command
* lisp/simple.el (shell-command): Keep track of output-buffer
by its name, not by its object.  (Bug#28997)
2017-11-03 11:50:13 +02:00
Paul Eggert
c911b27aff Change GCALIGNMENT back to an integer literal
* src/lisp.h (GCALIGNMENT): Change it back to a macro
that expands to a literal integer constant, for older GCC.
I had mistakenly thought that only MSVC had the problem.
Problem repored by Eli Zaretskii (Bug#29040#69).
2017-11-03 02:20:55 -07:00
Paul Eggert
a87ce5c4b4 * src/lisp.h (GCALIGNED): Clarify comment (Bug#29040). 2017-11-02 20:05:33 -07:00
Hong Xu
8a31e9993f ; etc/NEWS: Add cpp-message-min-time-interval. (Bug#28961) 2017-11-02 20:44:12 -04:00
Hong Xu
ac0bb9a192 Improve the doc of eshell-cmpl-* custom variables (Bug#25069)
* lisp/eshell/em-cmpl.el (eshell-cmpl--custom-variable-docstring): New
function to generate the docstring for custom variables derived from
pcomplete-* variables.
(eshell-cmpl-file-ignore, eshell-cmpl-dir-ignore)
(eshell-cmpl-ignore-case, eshell-cmpl-autolist)
(eshell-cmpl-suffix-list, eshell-cmpl-recexact)
(eshell-cmpl-man-function, eshell-cmpl-compare-entry-function)
(eshell-cmpl-expand-before-complete, eshell-cmpl-cycle-completions)
(eshell-cmpl-cycle-cutoff-length, eshell-cmpl-restore-window-delay)
(eshell-command-completion-function, eshell-cmpl-command-name-function)
(eshell-default-completion-function, eshell-cmpl-use-paring): Use it
to set the docstring.
2017-11-02 20:38:09 -04:00
Alan Third
36400c7dc9 Fix mouse-scrollbar offset on GNUstep and old macOS (bug#29053)
* src/nsterm.m (EmacsScroller::mouseDown,
EmacsScroller::mouseDragged): Take scroller buttons into account when
calculating scroller knob position.
2017-11-02 22:41:42 +00:00
Paul Eggert
04bc1410c2 Merge from Gnulib
This incorporates:
2017-10-29 timespec: prefer ‘assume’ to ‘assure’
2017-10-27 timespec.h: use "assure" to avoid a spurious warning
2017-10-09 getopt-posix: Fix build failure if ac_cv_header_getopt_h=no
* build-aux/config.guess, build-aux/config.sub:
* lib/timespec.h, lib/unistd.in.h:
Copy from Gnulib.
2017-11-02 13:21:33 -07:00
Paul Eggert
6b08ad5263 Fix alignment portability problems
Do not assume that the natural alignment of Lisp objects is a
multiple of GCALIGNMENT.  This improves on the portability of the
recent fix for Bug#29040.
* lib-src/make-docfile.c (close_emacs_globals):
* src/buffer.c (buffer_defaults, buffer_local_symbols):
* src/lisp.h (DEFUN):
* src/thread.c (main_thread):
Use GCALIGNED, not alignas (GCALIGNMENT).
* src/alloc.c (COMMON_MULTIPLE):
Move back here from lisp.h, since it is no longer used elsewhere.
* src/lisp.h (GCALIGNMENT): No longer a macro, since we need not
worry about MSVC.  Omit no-longer-needed consistency check.
* src/thread.c (THREAD_ALIGNMENT): Remove.
2017-11-02 13:21:33 -07:00
Simen Heggestøyl
a9f8706fa8 Fix completion of colon after CSS property (Bug#29056)
* lisp/textmodes/css-mode.el (css-completion-at-point): Don't insert
": ;" after completing a CSS property unless the rest of the line is
empty.
2017-11-02 20:39:39 +01:00
Eli Zaretskii
9031dec527 ; * src/alloc.c (sweep_symbols): Fix last change. 2017-11-02 18:53:20 +02:00
Stefan Monnier
fdd3dcfa4e * src/alloc.c (sweep_symbols): Tweak last change
Avoid the double-free without the extra check.  Add an explanatory comment.
2017-11-02 10:03:16 -04:00
Martin Rudalics
27964af438 In frame parameters documentation mention desktop saving/restoring
* doc/lispref/frames.texi (Frame Parameters): Mention that
applications have to care about which parameters they want to
get saved and restored by the desktop library.
2017-11-02 09:28:25 +01:00
Martin Rudalics
1bd4e7c243 ; Fix typo in ChangeLog.3 2017-11-02 08:37:45 +01:00
Martin Rudalics
4182a60d31 Don't have frameset save the 'client' parameter (Bug#29067)
* lisp/frameset.el (frameset-persistent-filter-alist): Never
save 'client' parameter (Bug#29067).
2017-11-02 08:34:18 +01:00
Paul Eggert
9d31a97092 ; Spelling fixes 2017-11-01 22:07:43 -07:00
Gemini Lasswell
460a25f212 Handle generic variables in cl-defgeneric Edebug spec
*lisp/emacs-lisp/cl-generic.el (cl-defgeneric): Fix Edebug spec to
match (setf name) and replace incorrect cl-lambda-list with listp
(Bug#27747).
2017-11-01 17:07:40 -07:00
Noam Postavsky
dc0a25c2f9 Give a more sensible message if file-attributes fails (Bug#29070)
* lisp/server.el (server-ensure-safe-dir): Don't claim the directory
is a file if we fail to get anything from `file-attributes'.
2017-11-01 19:39:34 -04:00
Andreas Schwab
8453423c7c Avoid wrong value from file-attributes on Linux kernel before 3.6
* dired.c (file_attributes): Handle unsupported fstat on O_PATH
descriptors.  (bug#29070)
2017-11-01 21:44:49 +01:00
Noam Postavsky
70621e2571 Fix customization of debugger-print-function (Bug#29077)
* lisp/emacs-lisp/debug.el (debugger-print-function): The :options
keyword has no effect for :type 'function, use :type '(choice ...)
instead.
2017-11-01 08:54:02 -04:00
Glenn Morris
ebdcfc294d ; Auto-commit of loaddefs files. 2017-11-01 06:33:24 -04:00
Charles A. Roelli
460fe4a1bc ; Doc fixes
* lisp/progmodes/xref.el (xref-file-location)
(xref-backend-apropos):
* etc/NEWS (Lisp Changes in Emacs 26.1):
* doc/emacs/msdos.texi (Windows Keyboard):
* lisp/vc/vc.el (vc-print-branch-log):
* src/buffer.c (word-wrap): Doc additions and fixes.
2017-10-31 22:01:34 +01:00
Eli Zaretskii
41adf3281e Avoid duplicate calls to xfree for the same pointer
* src/alloc.c (sweep_symbols): Avoid freeing an already freed
pointer to a symbol's buffer-local value.  (Bug#29066)
2017-10-31 21:08:35 +02:00
Phil Sainty
3e7ebbe1bd Don't clobber docstrings of explicitly-defined mode hook variables
* lisp/emacs-lisp/derived.el (define-derived-mode):
* lisp/emacs-lisp/easy-mmode.el (define-minor-mode): When defining the
mode hook variable, do not clobber pre-existing docstrings.
2017-10-31 08:20:30 -04:00
Martin Rudalics
9c8fe0248b Avoid fullscreen ediff control frames by default (Bug#29026)
* lisp/vc/ediff-wind.el (ediff-control-frame-parameters):
Add parameter to avoid fullscreen control frames (Bug#29026).
2017-10-31 08:59:27 +01:00
Katsumi Yamaoka
7d32176acc Fix the bug#24034 change (revno 9eb028f) causing infloop (bug#29047)
* lisp/net/shr.el (shr-fill-line): Copy only face and image-displayer
properties to gaps (bug#29047).
2017-10-30 23:30:19 +00:00
Eli Zaretskii
ee493663ba Merge branch 'emacs-26' of git.savannah.gnu.org:/srv/git/emacs into emacs-26 2017-10-30 20:47:06 +02:00
Eli Zaretskii
ca5eb0d0b7 Fix a typo in the ELisp manual
* doc/lispref/functions.texi (Obsolete Functions): Fix a typo.
(Bug#29068)
2017-10-30 20:45:39 +02:00
Martin Rudalics
d10c9479ca Fix doc and doc-strings for minibuffer window related functions (Bug#28978)
These fixes were suggested by Drew Adams.

* src/window.c (Fminibuffer_selected_window): Disambiguate
doc-string.
* doc/lispref/minibuf.texi (Intro to Minibuffers)
(Minibuffer Windows, Recursive Mini, Minibuffer Misc):  Avoid
the term "currently active minibuffer window".  Disambiguate
documentation of `minibuffer-selected-window'.
2017-10-30 19:43:29 +01:00
Alan Mackenzie
18331d00da Fix "Args out of range" error in c-determine-limit. Fixes bug #28598.
* lisp/progmodes/cc-engine.el (c-determine-limit-get-base): If the candidate
position for BASE is below point-min, scan forward to the end of the current
literal.
(c-determine-limit): Add an extra arm to the final cond form, testing for BASE
being at point-min.
2017-10-30 17:33:03 +00:00
Stefan Monnier
edde35e6f8 * lisp/progmodes/perl-mode.el: Fix electric indentation with RET
(perl-electric-noindent-p): The `eolp' check should not apply to RET.
Reported in https://emacs.stackexchange.com/questions/36337.
2017-10-30 10:24:47 -04:00
Tom Tromey
056587c45f Extend mhtml submode region when in comment
* lisp/textmodes/mhtml-mode.el (mhtml-syntax-propertize): Extend
submode when start happens to be in a comment.
2017-10-29 13:03:51 -06:00
Tom Tromey
4c4ad80848 Fix mthml submode lighting at end of buffer
* lisp/textmodes/mhtml-mode.el (mhtml--submode-lighter): Handle end of
buffer correctly.
2017-10-29 12:05:28 -06:00
Tom Tromey
557e252aa2 Remember more variables in mhtml-mode
* lisp/textmodes/mhtml-mode.el (mhtml--crucial-variable-prefix): Add
"completion-" and "major-mode".
(mhtml--variable-prefix): Remove "major-mode".
2017-10-29 11:50:16 -06:00
Philipp Stephani
336cd0a11a ; * lisp/select.el (select-enable-primary): Add missing period. 2017-10-29 17:32:35 +01:00
Eli Zaretskii
134099bc90 ; * etc/NEWS (EUDC): Mark as not requiring documentation. 2017-10-29 16:34:03 +02:00
Thomas Fitzsimmons
1a340274bf * etc/NEWS (EUDC): Deprecate BBDB 2.x backward compatibility. 2017-10-29 10:21:54 -04:00
Martin Rudalics
4189d0ef7b Fix minibuffer window related docs and strings (Bug#28978)
* src/frame.c (Vdefault_minibuffer_frame): Fix doc-string.
* src/window.c (Fminibuffer_selected_window): Fix doc-string.
* doc/lispref/frames.texi (Buffer Parameters): Rewrite
description of `minibuffer' parameter.
* doc/lispref/minibuf.texi (Minibuffer Windows): Reorder
entries and partly rewrite section.
(Minibuffer Misc): Clarify description of
`minibuffer-selected-window'.
* etc/NEWS: Mention new semantics of 'minibuffer' frame
parameter.
2017-10-29 11:35:32 +01:00
Mark Oteiza
2ebdde6e9c Add ChkTeX flymake backend for latex-mode
* lisp/textmodes/tex-mode.el (tex-flymake): New custom group.
(tex-chktex-program, tex-chktex-extra-flags): New custom variables.
(latex-mode): Add backend to flymake-diagnostic-functions.
(tex-chktex--process): New variable.
(tex-chktex-command, tex-chktex): New functions.
2017-10-28 20:32:50 -04:00
Glenn Morris
5b59841791 Fix doc typos
* lisp/simple.el (line-move-ignore-invisible):
* lisp/sort.el (sort-regexp-fields):
* lisp/cedet/ede.el (project-add-file):
* lisp/gnus/message.el (message-bogus-recipient-p):
* lisp/international/mule.el (define-coding-system):
* lisp/progmodes/ebrowse.el (ebrowse-member-buffer-object-menu):
* lisp/progmodes/xscheme.el (xscheme-allow-output-p)
(scheme-interaction-mode, scheme-debugger-mode)
(xscheme-yank-pop, xscheme-yank-push): Doc fixes.
2017-10-28 17:10:25 -07:00
Glenn Morris
82a16c547b Fix some duplicate word typos
* doc/misc/ede.texi (ede-target):
* doc/misc/flymake.texi (Using Flymake):
* doc/misc/gnus.texi (The namazu Engine): Fix typos.
2017-10-28 16:42:23 -07:00
Eli Zaretskii
266888b1d7 * doc/lispref/commands.texi (Adjusting Point): Fix wording. (Bug#29042) 2017-10-28 19:48:49 +03:00
Eli Zaretskii
00c3c6d88d Avoid segfaults in 64-bit Windows builds
* src/lisp.h (COMMON_MULTIPLE): Move here from alloc.c.
* src/thread.c (THREAD_ALIGNMENT): New macro.
(main_thread): Use THREAD_ALIGNMENT to align propertly.  (Bug#29040)
2017-10-28 19:39:48 +03:00
Eli Zaretskii
a8e6741066 Fix conversion of pixel coordinates to buffer position
* src/dispnew.c (buffer_posn_from_coords): Adapt to
auto-hscroll-mode == current-line.
2017-10-28 16:51:46 +03:00
Eli Zaretskii
d43b486f6c Fix doc strings in desktop.el
* lisp/desktop.el (desktop-auto-save-timeout)
(desktop-auto-save-set-timer): Doc fixes.  (Bug#28945)
2017-10-28 15:11:08 +03:00
Eli Zaretskii
9102fb603e Add Index to ERT manual
* doc/misc/ert.texi: Add @syncodeindex directives.
(Index): New node.
(Top): Add Index to the top-level menus.
Add index entries to all nodes.
2017-10-28 14:25:07 +03:00