1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-04-28 01:00:52 -07:00
Commit graph

170763 commits

Author SHA1 Message Date
Eli Zaretskii
e2d1ac2f25 ; * doc/lispref/sequences.texi (Sequence Functions): Fix typo. 2024-02-02 18:33:54 +02:00
Eli Zaretskii
eb9bdb8948 ; And another fix... 2024-02-02 17:48:28 +02:00
Eli Zaretskii
02bdb1e4c5 ; Another fix of last change. 2024-02-02 17:46:19 +02:00
Eli Zaretskii
f9a15b8a15 ; Fix last change
* lisp/sort.el (sort-on): Doc fix.

* doc/lispref/sequences.texi (Sequence Functions): Fix description
of 'sort-on'.
2024-02-02 17:39:23 +02:00
Eli Zaretskii
dcce1e07fe ; Fix last change
* doc/lispref/sequences.texi (Sequence Functions): Improve
indexing of last change
2024-02-02 15:27:25 +02:00
Eli Zaretskii
4b79c80c99 New function 'sort-on'
* lisp/sort.el (sort-on): New function.  Patch by John Wiegley
<jwiegley@gmail.com>.

* etc/NEWS:
* doc/lispref/sequences.texi (Sequence Functions): Document
'sort-on'.
2024-02-02 15:24:55 +02:00
Stefan Kangas
72b1379f07 Increase emacs-lisp-docstring-fill-column to 72
Monitors are wider now than when these defaults were first set, and it
is useful to take better advantage of that, to fit text on fewer lines.
Yet, it has repeatedly been shown that overly long lines reduce
readability:
   "A reasonable guideline would be 55 to 75 characters per line."[1]

We also don't want to disfavor narrow displays, like mobile phones; a
more promising direction here might be to automatically word wrap
docstrings and make their maximum width customizable.  That might
require a new docstring format, however.

Bumping it by 7 characters, from 65 to 72, seems a reasonable compromise
for now.  Consideration was given to increasing it to 70 or 75, but 72
happens to be a commonly recommended maximum line width elsewhere (see
Fortran 66, Python docstrings, commit message recommendations, etc.),
and we might as well do the same.

This change was discussed in:
https://lists.gnu.org/r/emacs-devel/2022-07/msg00217.html

[1] "Optimal Line Length in Reading — A Literature Review", Nanavati and
    Bias, Visible Language, Vol. 39 No. 2 (2005).
    https://journals.uc.edu/index.php/vl/article/view/5765

* lisp/emacs-lisp/lisp-mode.el (emacs-lisp-docstring-fill-column):
* .dir-locals.el (fill-column, emacs-lisp-docstring-fill-column):
Bump default to 72.
2024-02-02 13:33:35 +01:00
Juri Linkov
d89e427852 * lisp/simple.el (read-from-kill-ring): Ignore `read-only' text property.
Add `read-only' to the list of text properties removed from history items
(bug#68847).
2024-02-01 19:16:37 +02:00
Stefan Monnier
8b92449b70 * src/lread.c (bytecode_from_rev_list): Fix thinko 2024-02-01 11:08:56 -05:00
Stefan Monnier
886f4207ab * src/lread.c (bytecode_from_rev_list): Re-group checks
Bring together all the conditions for well-formedness of the resulting
bytecode object.
2024-02-01 11:06:51 -05:00
Thierry Volpiatto
d0766c0999 Fix search error in woman.el
* lisp/woman.el (woman-if-body): Avoid signaling an error
if "el }" is not found.  (Bug#68852)
2024-02-01 12:34:50 +02:00
Graham Marlow
4adb4b2ac5 Fix 'fill-paragraph' in 'yaml-ts-mode'
* lisp/textmodes/yaml-ts-mode.el (yaml-ts-mode--fill-paragraph):
Avoid 'fill-paragraph' when outside of block_scalar or comment
nodes.  (Bug#68781)
2024-02-01 12:29:53 +02:00
Stanislav Yaglo
ff63da26b6 macfont.m: Fix values for font widths and weights on macOS
* src/macfont.m (mac_font_get_glyphs_for_variants)
(macfont_variation_glyphs): Fix width values.  (Bug#64013)
2024-02-01 12:18:50 +02:00
Sacha Chua
169c704d74 shr: Correct SVG attribute case
* lisp/net/shr.el (shr-correct-attribute-case): New constant.
(shr-correct-dom-case): New function to correct SVG attribute case.
(shr-tag-svg): Correct SVG attribute cases before using them.
2024-02-01 12:00:25 +02:00
Po Lu
849f8c1d49 ; * doc/emacs/basic.texi (Continuation Lines): Rearrange pxref. 2024-02-01 16:25:09 +08:00
Po Lu
4e1661e96c * src/term.c (produce_glyphs): Synchronize with gui_produce_glyphs. 2024-02-01 16:18:53 +08:00
Po Lu
881a1ade30 Prevent continuation from affecting tab width in/after line prefix
* src/dispextern.h (struct it) <wrap_prefix_width>: New field,
synchronized with current_x when producing glyphs for wrap
prefixes, and subtracted from it->current_x when computing tab
widths.

* src/term.c (produce_glyphs): Set wrap_prefix_width.

* src/xdisp.c (start_display, display_min_width, move_it_to)
(move_it_vertically_backward, move_it_by_lines)
(window_text_pixel_size, display_tab_bar_line)
(display_tool_bar_line, redisplay_internal, redisplay_window)
(try_window_id, insert_left_trunc_glyphs)
(extend_face_to_end_of_line, display_line)
(Fmove_point_visually): Set or clear wrap_prefix_width as
appropriate.
(gui_produce_glyphs): Set or clear it->wrap_prefix_width.  When
computing the base position of a tab character, do not subtract
the continuation line width if a line prefix is the current
iterator method.  Subtract the wrap_prefix_width otherwise, in
order that the width of the tab is computed free of influence
from the wrap prefix.
2024-02-01 16:16:09 +08:00
Po Lu
b86bc02096 Introduce a global variant of visual-wrap-prefix-mode
* doc/emacs/basic.texi (Continuation Lines):

* etc/NEWS:

* lisp/visual-wrap.el (visual-wrap-prefix-mode): Document this
new global minor mode.
(global-visual-wrap-prefix-mode): New global minor mode.
2024-02-01 16:08:47 +08:00
Mattias Engdegård
cd2c45a389 ; hierarchy-tests.el: keep doc string within 80 columns 2024-01-31 17:55:53 +01:00
Mattias Engdegård
344a846b07 Bytecode engine fast-path streamlining of plain symbols
* src/bytecode.c (exec_byte_code):
Only use fast-path optimisations for calls and dynamic variable
reference and setting where the symbol is plain, which is much faster.
2024-01-31 17:35:59 +01:00
Mattias Engdegård
9bcc9690a8 Eliminate lazy bytecode loading
The obsolete lazy-loaded bytecode feature, enabled by
`byte-compile-dynamic`, slows down Lisp execution even when not in use
because every call to a bytecode function has to check that function
for laziness.

This change forces up-front loading of all lazy bytecode so that we
can remove all those checks.  (Dynamically loaded doc strings are not
affected.)

There is no point in generating lazy bytecode any more so we stop
doing that; this simplifies the compiler.  `byte-compile-dynamic` now
has no effect.

This is a fully compatible change; the few remaining users of
`byte-compile-dynamic` should not notice any difference.

* src/lread.c (bytecode_from_rev_list): Force eager loading of
lazy bytecode.
* src/bytecode.c (exec_byte_code): Remove lazy bytecode checks.
* src/eval.c (fetch_and_exec_byte_code, Ffetch_bytecode): Remove.
(funcall_lambda): Call exec_byte_code directly, avoiding checks.
* lisp/subr.el (fetch-bytecode): New definition, obsolete no-op.
* lisp/emacs-lisp/disass.el (disassemble-1):
* lisp/emacs-lisp/bytecomp.el (byte-compile-unfold-bcf):
Remove calls to fetch-bytecode.
(byte-compile-dynamic): Update doc string.
(byte-compile-close-variables, byte-compile-from-buffer)
(byte-compile-insert-header, byte-compile-output-file-form)
(byte-compile--output-docform-recurse, byte-compile-output-docform)
(byte-compile-file-form-defmumble):
Remove effects of byte-compile-dynamic.
* doc/lispref/compile.texi (Dynamic Loading): Remove node now that
the entire `byte-compile-dynamic` facility has been rendered inert.
* etc/NEWS: Announce changes.
2024-01-31 17:12:25 +01:00
Mattias Engdegård
7e85311a91 Allow equal user-defined hash table tests with different names
Hash tables using different user-defined tests defined identically
sometimes ended up using the wrong test (bug#68668).

* src/fns.c (get_hash_table_user_test): Take test name into account
when matching the test object.
* test/src/fns-tests.el (fns--define-hash-table-test): New.
2024-01-31 12:48:48 +01:00
Po Lu
5f24c9a4c8 Don't hang when display objects are displaced by line or wrap-prefixes
This fixes a hang that would frequently rear its ugly head while
displaying messages in the `telega.el' instant messenger client,
which inserts images approaching the width of the window with
line and wrap prefixes.

* src/xdisp.c (move_it_in_display_line_to): If a line or wrap
prefix is set in place, do not generate continuation lines until
a minimum of one glyph has been produced outside that prefix.
(move_it_to): Remove the previous workaround that could not
recover from errors caused by display strings.
(display_line): Synchronize with move_it_in_display_line_to;
remove old workaround that only provided for oversized wrap
prefixes comprising `space' display objects.
2024-01-31 14:50:37 +08:00
Yuan Fu
f63bcf2dfe
Fix treesit--indent-1 regarding local parsers
Take this code as an example:

1 class Foo
2 {
3     /**
4      * Block comment
5      */
6     function foo($c) {
7     }
8 }

Suppose the block comment is covered by a local parser.  When we
indent line 3, treesit--indent-1 will try to get the local parser at
the BOL, and it'll get the local parser.  But it shouldn't use the
local parser to indent this line, it should use the host parser of
that local parser instead.

So now, if treesit--indent-1 gets a local parser, but the local
parser's root node's start coincides with BOL, treesit--indent-1 will
use the host parser to indent this line.

We also need to make treesit--update-ranges-local to save the host
parser along with the local parser, and make
treesit-local-parsers-at/on extract and return the host parser.

I also switch the two cases in the cond form in treesit--indent-1:
(null (treesit-parser-list)) and (car local-parsers), (car
local-parsers) now takes precedence.

* lisp/treesit.el (treesit-local-parsers-at):
(treesit-local-parsers-on): Add WITH-HOST parameter.
(treesit--update-ranges-local): Save the host parser to the local
overlay.
(treesit--indent-1): If the root node of the local parser is at BOL,
use the host parser instead.
2024-01-30 22:28:47 -08:00
Paul Eggert
dd177b7b88 Update from Gnulib by running admin/merge-gnulib 2024-01-30 17:23:26 -08:00
Paul Eggert
17771b2a42 ; Spelling fixes 2024-01-30 17:23:25 -08:00
Stefan Monnier
3afbab2f1d * lisp/emacs-lisp/inline.el (inline-const-val): Improve docstring 2024-01-30 13:14:32 -05:00
Eli Zaretskii
c8b9ec923f ; Rename a lexical variable in vhdl-mode.el
* lisp/progmodes/vhdl-mode.el (vhdl-speedbar-insert-hierarchy):
Rename a variable to avoid shadowing a global.  (Bug#68810)
2024-01-30 16:15:59 +02:00
Jim Porter
a470dfb7f8 Fix typo in Eshell's "du" command
This option is supposed to be "--si", for "International System of
Units", not "--is".

* lisp/eshell/em-unix.el (eshell/du): Change "is" to "si".
2024-01-29 17:33:35 -08:00
Stefan Monnier
c385e966e1 derived.el: Delete old code (bug#68625)
* lisp/emacs-lisp/derived.el (derived-mode-setup-function-name)
(derived-mode-init-mode-variables, derived-mode-set-keymap)
(derived-mode-set-syntax-table, derived-mode-set-abbrev-table)
(derived-mode-run-hooks, derived-mode-merge-keymaps)
(derived-mode-merge-syntax-tables, derived-mode-merge-abbrev-tables):
Delete functions.
2024-01-29 19:04:59 -05:00
Stefan Monnier
e625f2044a (byte-compile): Try and make it a bit more readable
* lisp/emacs-lisp/bytecomp.el (byte-compile--reify-function):
Use `macroexp-parse-body` and only handle closures.
(byte-compile): Clarify the control and data flow a bit.
2024-01-29 18:56:19 -05:00
Andrea Corallo
cfc1779f46 * Better type comparison in comp tests
* test/src/comp-tests.el (comp-tests--type-lists-equal): New function.
(comp-tests--types-equal): Handle function types.
2024-01-29 21:24:38 +01:00
Eli Zaretskii
98c906e5be ; * lisp/minibuffer.el (minibuffer-visible-completions): Doc fix. 2024-01-29 21:21:50 +02:00
Daniel Brooks
e3620796ff Fix 'calc-math-read-preprocess-string' test (bug#66944).
Copyright-paperwork-exempt: yes
2024-01-29 14:50:45 +02:00
Po Lu
5d81371cc4 ; * src/sfnt.c: Fix standalone compilation. 2024-01-29 20:28:50 +08:00
Po Lu
59d0b353d5 * src/haiku_select.cc: Include stdckdint.h. 2024-01-29 12:17:26 +00:00
Paul Eggert
116c47874e ; Spelling fixes 2024-01-29 00:22:37 -08:00
Po Lu
0aec3117b5 Don't open a new line for long defuns being inserted at column 0
* lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Don't
open a new line for long defuns at column 0.

* test/lisp/vc/log-edit-tests.el
(log-edit-fill-entry-space-substitution): Adjust expected
results to match change.
(log-edit-fill-entry-initial-wrapping): New test.
2024-01-29 15:45:47 +08:00
Po Lu
b9f348ce1e * exec/configure.ac (OPENAT_SYSCALL): Define on MIPS. 2024-01-29 11:54:46 +08:00
Po Lu
f83d9e16d0 ; * test/lisp/vc/log-edit-tests.el: Pacify compiler warnings. 2024-01-29 11:01:33 +08:00
Po Lu
e9cf215d70 Prevent filling from mangling ChangeLog defun lists
* lisp/vc/log-edit.el (log-edit-fill-entry): Replace space
characters within defun lists with NBSPs for the duration of
`fill-region''s execution, so that they are never considered
break points.

* test/lisp/vc/log-edit-tests.el
(log-edit-fill-entry-space-substitution): New test.
2024-01-29 10:59:30 +08:00
Jim Porter
d2abe91d4b In Eshell, don't expand quoted tildes into a user's home directory
* lisp/eshell/em-dirs.el (eshell-parse-user-reference): Don't expand
quoted tildes.

* test/lisp/eshell/em-dirs-tests.el
(em-dirs-test/expand-user-reference/local)
(em-dirs-test/expand-user-reference/quoted): New tests.
2024-01-28 16:02:05 -08:00
Jim Porter
1f5a13d584 In Eshell, allow an escaped newline at the end of a command
Normally, "echo<RET>" runs the command "echo".  Likewise,
"echo\<RET><RET>" should too: we escape the first newline, and then
the second one is unescaped and should send the command input to
Eshell.  Previously, you had to press RET a third time, but now it
works as expected.

* lisp/eshell/esh-arg.el (eshell-looking-at-backslash-return): Make
obsolete.
(eshell-parse-backslash): A backslash sequence is only incomplete if
there's nothing at all after it.

* test/lisp/eshell/esh-arg-tests.el (esh-arg-test/escape/newline)
(esh-arg-test/escape-quoted/newline): Remove inaccurate comment;
escaped newlines are always special.
(esh-arg-test/escape/trailing-newline): New test.
2024-01-28 15:54:46 -08:00
Stefan Monnier
e734f8e502 xt-mouse.el: Obey mouse-wheel-*-event variables (bug#68698)
* lisp/xt-mouse.el (xterm-mouse--same-button-p): New function.
(xterm-mouse--read-event-sequence): Use it to obey
`mouse-wheel-*-event` variables.
* lisp/mwheel.el (mouse-wheel-obey-old-style-wheel-buttons):
Update docstring.
2024-01-28 18:51:11 -05:00
Stefan Kangas
71b5d5a979 ; Fix typos 2024-01-28 17:11:51 +01:00
Michael Albinus
6ebd5aa337 Merge from origin/emacs-29
e11c9f9c6e Handle wrong login program in Tramp

# Conflicts:
#	lisp/net/tramp-sh.el
2024-01-28 11:51:51 +01:00
Michael Albinus
af10fe49fb ; Merge from origin/emacs-29
The following commits were skipped:

b2db82c5ae * doc/lispref/package.texi (Multi-file Packages): Documen...
3c2baa1b95 Avoid signaling errors in emoji.el on empty input
2024-01-28 11:49:59 +01:00
Michael Albinus
e11c9f9c6e Handle wrong login program in Tramp
* lisp/net/tramp-sh.el (tramp-maybe-open-connection): Exit remote
shell when login fails.
2024-01-28 10:31:45 +01:00
Po Lu
833d2636ff ; * lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Fix typos. 2024-01-28 17:09:29 +08:00
Po Lu
adf32eb69e ; Correct typo
* lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Correct
typo in alignment constants.
2024-01-28 16:58:28 +08:00