1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-20 12:40:56 -08:00
Commit graph

4699 commits

Author SHA1 Message Date
Lars Ingebrigtsen
874a724734 Clarify menu entry in previous check-in
* lisp/gnus/gnus-sum.el (gnus-summary-make-menu-bar): Menu bar
entry for it.
2018-04-15 18:13:23 +02:00
Lars Ingebrigtsen
bea6ae4e3e Add new command `gnus-summary-attach-article'
* doc/misc/gnus.texi (Summary Message Commands): Document it.

* lisp/gnus/gnus-msg.el (gnus-summary-attach-article): New command
and keystroke (bug#19788).

* lisp/gnus/gnus-sum.el (gnus-summary-make-menu-bar): Menu bar
entry for it.
2018-04-15 18:02:50 +02:00
Daiki Ueno
c3ca885f49 Divert to call `gnus-activate-group' with the SCAN argument set
* lisp/gnus/gnus-group.el (gnus-group-get-new-news-this-group):
Divert to call `gnus-activate-group' with the SCAN argument set,
if request-group-scan is not defined for the backend.  Ensure that
the server is open when calling `gnus-request-group-scan'
(bug#22649).
2018-04-15 16:11:46 +02:00
Lars Ingebrigtsen
eceb047cdb Abort Gnus exit if we have unsaved Message buffers
* lisp/gnus/gnus-group.el
(gnus--abort-on-unsaved-message-buffers): New function (bug#28843).
(gnus-group-exit): Use it to abort exit if we have unsaved Message
buffers.
2018-04-15 15:48:44 +02:00
Lars Ingebrigtsen
ef599f6cac Remove calls from string-to-multibyte in nnheader/nntp
* lisp/gnus/nntp.el (nntp-copy-to-buffer): Apparently `insert' now
behaves more like string-make-multibyte, but it now behaves more
like string-to-multibyte, so remove that call here.  I'm not quite
sure I follow that logic, but apparently there are no ill effects.

* lisp/gnus/nnheader.el (nnheader-insert-buffer-substring): Ditto.
2018-04-15 01:07:38 +02:00
Lars Ingebrigtsen
1ad6184c37 Remove a string-to-multibyte from nnmh.el
* lisp/gnus/nnmh.el (nnmh-request-list-1): Remove superfluous
string-to-multibyte.
2018-04-15 00:57:40 +02:00
Lars Ingebrigtsen
3250651e9c Remove call to string-to-multibyte from nndoc.el
* lisp/gnus/nndoc.el (nndoc-oe-dbx-type-p): My testing shows that
no matter whether we're in a unibyte or a multibyte buffer, doing
the looking-at here without the string-to-multibyte, we'll get a
match.  We did not get a match with the call in and if we were in
a unibyte buffer, but we presumably never are.
2018-04-15 00:48:27 +02:00
Lars Ingebrigtsen
466693416d Fix calculation in gnus-update-group-mark-positions
* lisp/gnus/gnus-group.el (gnus-update-group-mark-positions):
Rewrite a call to string-to-multibyte that didn't even work.
After the rewrite it gives the correct result and should allow
people to customise Gnus group process mark positions (but that's
a pretty obscure feature).
2018-04-15 00:40:23 +02:00
Lars Ingebrigtsen
f0ec607d53 Removed outdated comment from nnweb.el
* lisp/gnus/nnweb.el (nnweb-insert-html): Removed ten year old
comment from Stefan about string-as-multibyte.
2018-04-15 00:32:10 +02:00
Lars Ingebrigtsen
9c5a9d4dd4 Rewrite Gnus calls to compat function mm-multibyte-p 2018-04-15 00:30:14 +02:00
Lars Ingebrigtsen
ad2c4d3c61 Rewrite string-as-unibyte/string-as-multibyte logic in nnmail
* lisp/gnus/nnmail.el (nnmail-insert-xref): Rewrite
string-as-unibyte/string-as-multibyte logic and confirm that the
result is the same in both multibyte and unibyte buffers after the
change.
2018-04-15 00:24:02 +02:00
Lars Ingebrigtsen
25487b921b Remove call to string-as-unibyte from nnmail
* lisp/gnus/nnmail.el (nnmail-parse-active): Remove call to
string-as-unibyte; the alist before and after the change are
`equal' to each other, so it should presumably have no impact.
2018-04-15 00:17:28 +02:00
Lars Ingebrigtsen
86bbde2808 Remove calls to string-as-unibyte from nnir.el
* lisp/gnus/nnir.el (nnir-get-active): Remove two calls to
string-as-unibyte from code that seems cargo-culted from Gnus
functions where it is not needed, so it's presumably not needed
here, either.
2018-04-15 00:14:30 +02:00
Lars Ingebrigtsen
30f5fa75da Remove call to string-as-unibyte in gnus-start.el
* lisp/gnus/gnus-start.el (gnus-read-newsrc-el-file): Remove
string-as-unibyte call, which appears not to do anything much in
modern Emacsen.
2018-04-15 00:09:47 +02:00
Lars Ingebrigtsen
07672a06d3 Remove call to string-as-unibyte from gnus-start.el
* lisp/gnus/gnus-start.el (gnus-update-active-hashtb-from-killed):
Remove a string-as-unibyte call here, which appears not to be
necessary: I'm able to complete over non-ASCII names both before
and after.
2018-04-15 00:07:08 +02:00
Lars Ingebrigtsen
6500684001 Modernise a Gnus function a bit
* lisp/gnus/gnus-start.el (gnus-update-active-hashtb-from-killed):
Modernise code a bit.
2018-04-14 23:58:59 +02:00
Lars Ingebrigtsen
4b0c425047 Remove two string-as-unibyte in gnus-srvr.el
* lisp/gnus/gnus-srvr.el (gnus-browse-foreign-server): We do not
seem to need the string-as-unibyte here: We read a multibyte
string from the *nntpd* buffer and then decode it later, and this
apparently by some strange magic leads to the correct results in
my test cases.
2018-04-14 23:54:07 +02:00
Lars Ingebrigtsen
679a433744 Fix a `string-to-multibyte' in Gnus
* lisp/gnus/gnus-art.el (gnus-request-article-this-buffer): The
original article buffer is multibyte, and we're inserting into the
article buffer, which is also multibyte, so the `string-to-multibyte'
here should be unnecessary?
2018-04-14 23:25:01 +02:00
Lars Ingebrigtsen
9f767b3ec8 Fix a string-as-unibyte in Gnus
* lisp/gnus/gnus-art.el (gnus-article-browse-html-parts): Get rid
of a string-as-unibyte.
2018-04-14 23:17:24 +02:00
Lars Ingebrigtsen
0b0d3815da Revert "Revert "Give better errors in signing failures in Gnus""
This reverts commit 42141da5b0.

This patch was reverted in error.  I misinterpreted an email saying that
it didn't work, but apparently it worked as it should.
2018-04-14 17:18:53 +02:00
Lars Ingebrigtsen
132b3a9ace Change the default From style to `angles' and make obsolete
* lisp/gnus/message.el (message-from-style): Make `angles' the
default (bug#29309) and mark as obsolete.

* lisp/mail/sendmail.el (mail-from-style): Ditto.
2018-04-14 15:52:16 +02:00
Lars Ingebrigtsen
42141da5b0 Revert "Give better errors in signing failures in Gnus"
This reverts commit ef2059e877.

Apparently this test triggered both when signing was successful
and unsuccessful (bug#26298).
2018-04-14 15:12:48 +02:00
Tino Calancha
e1c2ec5086 Subject: Fix circular dependency for mm-decode
* lisp/gnus/mm-decode.el: Do not require shr.el at the top
of the file; `mm-shr' already requires shr.el in its body, and
this function is the only `mm-convert-shr-links' caller (Bug#31151).
2018-04-14 12:56:22 +02:00
Lars Ingebrigtsen
3ba07bfc3e Move utility function to mm-util.el
* lisp/gnus/mm-util.el (mm-images-in-region-p): Move from
mm-decode.el and renamed, since it is generally useful.
2018-04-14 00:15:15 +02:00
Lars Ingebrigtsen
4575ae5a9c Don't bind image commands on non-image links in Gnus
* lisp/gnus/mm-decode.el (mm--images-in-region-p): New utility
function.
(mm-convert-shr-links): Only use the shr image map on links that
contain images.  This avoids binding commands like `r' on links
that don't need it.
2018-04-13 23:49:58 +02:00
Lars Ingebrigtsen
52a5bc89c9 Revert "Add colors to faces that lack them."
This reverts commit 16748a5f6b.

From the discussion on the ding mailing list, I said:

I think the colours should be reverted back to what they were before the
change.  Normal text should be white on black (if you have a dark
background), and colours should be used to emphasise or de-emphasise
certain text.  Following that principle, normal Gnus groups should be
white, not ... er...  what are they now?  Teal?
2018-04-13 22:52:16 +02:00
Lars Ingebrigtsen
0eb68feed4 Further tweak point placement on gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Place point in the empty space between headers and body.
2018-04-13 21:58:25 +02:00
Lars Ingebrigtsen
9f5f26c2b6 Tweak point placement in *Group* on `Q' exit
* lisp/gnus/gnus-sum.el (gnus-summary-exit-no-update): When
exiting the summary buffer with `Q', move point to the next unread
group (which is the same thing that happens on `q' exit.)
2018-04-13 21:33:37 +02:00
Lars Ingebrigtsen
e9f1260773 Tweak point placement in gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Tweak where point is placed because when the user selects the
article buffer, it's probably to cite something or click on
something, and not do anything with the headers.
2018-04-13 21:18:51 +02:00
Lars Ingebrigtsen
b7ac2761fc Clean up some defvoo doc strings
* lisp/gnus/nndiary.el: Remove "*" from doc strings from defvoo
elements (bug#23392).

* lisp/gnus/nndir.el: Ditto

* lisp/gnus/nndoc.el: Ditto.

* lisp/gnus/nnrss.el: Ditto.

* lisp/gnus/nnspool.el: Ditto.

* lisp/gnus/nntp.el: Ditto.
2018-04-13 20:00:52 +02:00
Lars Ingebrigtsen
de28ae70ef Make nnimap parse pathological spam headers better
* lisp/gnus/nnimap.el (nnimap-transform-headers): Unfold certain
pathological IMAP headers more correctly (bug#25502).  Perhaps
this function should be re-implemented.
2018-04-13 19:28:17 +02:00
Lars Ingebrigtsen
bd7601f21b (nnimap-sequence): Add comment
* lisp/gnus/nnimap.el (nnimap-sequence): Add comment.
2018-04-13 16:50:45 +02:00
Lars Ingebrigtsen
c7abc5760b Tweak nnimap sequence numbers to avoid reuse
* lisp/gnus/nnimap.el (nnimap-sequence): Start the sequence at a
higher number to avoid reusing the sequence number used by
`open-network-stream' (bug#30022).
2018-04-13 13:41:31 +02:00
martin rudalics
a20d2e6625 * lisp/gnus/gnus-art.el (gnus-article-prepare): Fix previous commit,
in which selecting the article window is not necessary (bug#25526).
2018-04-13 07:42:19 +00:00
Katsumi Yamaoka
306a6f8d43 * lisp/gnus/gnus-art.el (gnus-article-prepare): Make sure the article
begins with the top of the header (bug#25526).
2018-04-12 23:19:17 +00:00
Jonathan Marten
7643fbb452 From: Lars Ingebrigtsen <larsi@gnus.org>
* lisp/gnus/nnimap.el (nnimap-login): Allow anonymous logins
(bug#24704).

Copyright-paperwork-exempt: yes
2018-04-12 22:24:11 +02:00
Lars Ingebrigtsen
c22677bf00 Default message-forward-as-mime to nil
* doc/misc/gnus.texi (Summary Mail Commands): Ditto.

* doc/misc/message.texi (Forwarding): Note the new default.

* lisp/gnus/message.el (message-forward-as-mime): Default to nil
since it's been reported that many recipients can't read MIME
digest forwards (bug#24878).
2018-04-12 22:04:09 +02:00
Lars Ingebrigtsen
e7c813e912 Load w3m in Gnus if required
* lisp/gnus/gnus-art.el (gnus-article-show-images): Ensure that
w3m is loaded if the user requests that we use it.
2018-04-12 21:34:37 +02:00
Tim Landscheidt
271d8510c4 Don't autoload function from w3m
* lisp/gnus/gnus-art.el (w3m-toggle-inline-images): Don't use
autoload for packages that may not be installed (bug#25604).
2018-04-12 21:31:49 +02:00
Oleg Pykhalov
2892b4b99c From: Lars Ingebrigtseb <larsi@gnus.org>
* lisp/gnus/gnus-sum.el (gnus-summary-limit-to-score): Allow limit
to articles that have a score below the stated number, too
(bug#30356).
2018-04-12 21:19:23 +02:00
Lars Ingebrigtsen
02f4d79222 message-forward-as-mime doc clarification
* lisp/gnus/message.el (message-forward-as-mime): Doc
clarification (bug#27714).
2018-04-12 21:13:47 +02:00
Lars Ingebrigtsen
57fbf0cf7b message-forward-ignored-headers doc clarification
* lisp/gnus/message.el (message-forward-ignored-headers): Doc
clarification (bug#27715).
2018-04-12 21:11:12 +02:00
Lars Ingebrigtsen
6499285898 Restore point in summary buffer after sorting
* lisp/gnus/gnus-sum.el (gnus-summary-sort): Keep point on the
current article when sorting (bug#30615).
2018-04-12 19:36:28 +02:00
Lars Ingebrigtsen
17174d3f77 nil is no longer an allowed value for mm-inline-text-html
* doc/misc/emacs-mime.texi (Display Customization): Remove the doc
for the nil case of mm-inline-text-html.

* doc/misc/mh-e.texi (HTML): Ditto.

* lisp/gnus/mm-view.el (mm-inline-text-html): If no
mm-text-html-renderer is specified, just insert the raw text
instead of erroring out (bug#30870).
2018-04-12 19:18:26 +02:00
Lars Ingebrigtsen
4616ddc131 Ensure that non-QRESYNC nnimap can proceed after a QRESYNC fail
* lisp/gnus/nnimap.el (nnimap-update-info): If we don't have a
start-article in the non-QRESYNC case, then the start has to be 1
(bug#23241).
2018-04-12 18:12:03 +02:00
Lars Ingebrigtsen
d9d90def6e Make it possible to exit Gnus without saving .newsrc.eld
* lisp/gnus/gnus-start.el (gnus-save-newsrc-file): Don't error out
here so that we can proceed with shutting down Gnus without saving
the .newsrc.eld file when it has been updated externally (bug#23761).
2018-04-12 17:50:14 +02:00
Lars Ingebrigtsen
f4692fa290 Make nnml save the .overview file when used as an expiry target
* lisp/gnus/nnmail.el (nnmail-expiry-target-group): Always pass in
the `last' parameter to the acceptance function so that backends
like nnml save the .overview file (bug#24499).  This may slow down
some use cases.
2018-04-12 16:53:07 +02:00
Lars Ingebrigtsen
c0593bfc7c Clarify Gnus doc string
* lisp/gnus/gnus-cite.el (gnus-article-fill-cited-article):
Clarify doc string (bug#24578).
2018-04-12 16:33:36 +02:00
Lars Ingebrigtsen
aa9d9e5e10 Elide XEmacs-relevant comment
* lisp/gnus/gnus-cite.el (gnus-article-fill-cited-article): Remove
mention of XEmacs, since we no longer support XEmacs.
2018-04-12 16:32:00 +02:00
Lars Ingebrigtsen
4f95846833 Make message-simplify-recipients obsolete
* lisp/gnus/message.el (message-simplify-recipients)
(message-recipients-without-full-name): Made obsolete since
Message now simplifies all addresses by default.
2018-04-12 15:17:40 +02:00