1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-06 03:40:56 -08:00
Commit graph

139876 commits

Author SHA1 Message Date
Mattias Engdegård
9b6872b4e4 ; * test/lisp/calc/calc-tests.el: Fix warnings 2019-12-30 21:02:10 +01:00
Mattias Engdegård
957cdca6f0 Make minibuffer-tests work in out-of-tree builds (bug#38816)
* test/lisp/minibuffer-tests.el (completion-table-test-quoting):
Set default-directory.
2019-12-30 21:01:14 +01:00
Mattias Engdegård
2065316749 Make comint-tests more robust (bug#38813)
* test/lisp/comint-tests.el (comint-test-no-password-function)
(comint-test-password-function-with-value)
(comint-test-password-function-with-nil):
Call accept-process-output as many times as needed, with a slightly
more generous timeout (100 ms), after sending the Password: prompt to
the process, since there must be time for some back-and-forth
communication.  Also clear the process-query-on-exit flag, since it
doesn't go well with noninteractive tests.
2019-12-30 21:00:27 +01:00
Eli Zaretskii
59f71d20ea Fix tar-mode reading the oldgnu Tar format
This makes sure an entry for a long file name will not
accidentally appear as a directory, and thus its size will be
disregarded, causing corrupted file headers for all the subsequent
entries.  The original problem happened because the long file name
truncated to 99 bytes happened to end in a slash, which tar-mode
takes to be the indication of a directory.
* lisp/tar-mode.el (tar-header-block-tokenize): Accept an
additional argument DISABLE-SLASH; if non-nil, don't set the
link-type field of the descriptor to 5 (meaning a directory) just
because the name ends in a slash.  Use this argument when calling
itself recursively, to read the entry of the file with a long
name.  Set the link-type to 5 if the long name ends in a slash.
(Bug#38777)
2019-12-30 18:17:03 +02:00
Eli Zaretskii
e3ec84fd7d Ensure mini-window is resized to show active minibuffer contents
* src/keyboard.c (read_char, command_loop_1): Resize the
mini-window after clearing the echo area while minibuffer is
active.  (Bug#38645)
2019-12-30 18:00:17 +02:00
Eli Zaretskii
450633f85a Fix mini-window resizing under resize-mini-windows = t
* src/window.c (grow_mini_window): Fix resizing of mini-window
when the echo area is cleared, and the caller asks for the
mini-window to have zero lines.  (Bug#38791)
2019-12-30 17:53:52 +02:00
Glenn Morris
219d47893a Fixes for makeinfo 4.13
* doc/lispref/customize.texi (Variable Definitions): Fix xref.
* doc/lispref/internals.texi (Writing Emacs Primitives)
(Module Values): Follow xref with comma.
2019-12-29 15:41:52 -08:00
Robert Pluim
4bbfd2b42f ; fix previous NEWS entry 2019-12-29 22:21:48 +01:00
Robert Pluim
81b697d106 Fix crash under -nw on macOS properly this time
* src/dispextern.h (FACE_COLOR_TO_PIXEL): Only use
ns_color_index_to_rgba when we're running under the NS gui
(Bug#38564).
2019-12-29 21:15:34 +01:00
Robert Pluim
9ce4207969 Revert "Check for GUI frame in ns_color_index_to_rgba"
This reverts commit ea84a95bd8.
2019-12-29 21:15:33 +01:00
Robert Pluim
732dcfc850 Ignore all color fonts when using XFT
* etc/NEWS: Announce change to matching color fonts when using XFT.

* src/ftfont.c (ftfont_list) [HAVE_XFT && FC_COLOR]: Query for the
color attribute of the matched font, and skip it if it is not
FcFalse (Bug#37786).
2019-12-29 20:08:38 +01:00
Mattias Engdegård
aa0c679f48 Avoid unbounded growth of cl-random-state components (bug#38753)
* lisp/emacs-lisp/cl-extra.el (cl-random):
Perform the modulo 2**23 operation before updating the state instead
of after.  The result is always the same, but it prevents the state
from growing into arbitrary large bignums.

Patch from Christopher Wellons.
2019-12-29 13:55:25 +01:00
Michael Albinus
d6922db49d Sync with Tramp 2.4.3
* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.4.3".

* lisp/net/tramp.el: Bump version.
(tramp-handle-shell-command): The temp file for error-buffer is remote.

* test/lisp/net/tramp-tests.el (tramp-test30-make-process):
Simplify buffer generation.
(tramp-test32-shell-command): Extend test.
2019-12-29 13:53:06 +01:00
Dmitry Gutov
70fe552c61 ; xref-references-in-directory: Autoload as well 2019-12-29 15:46:44 +03:00
Dmitry Gutov
181f571651 Fix up requires
* lisp/progmodes/project.el (project-files):
Remove (require 'xref).
(project--files-in-directory): Add it here instead.
(project-find-regexp, project-or-external-find-regexp): And here.
For 'xref--show-xrefs'.
2019-12-29 15:46:44 +03:00
Dmitry Gutov
43f66c3368 Extract xref-matches-in-files from project--find-regexp-in-files
* lisp/progmodes/xref.el (xref-matches-in-files): Extract from
project--find-regexp-in-files.

* lisp/dired-aux.el (dired-do-find-regexp): Also use it here.
2019-12-29 15:46:44 +03:00
Dmitry Gutov
65af18d86e Rename xref-collect-references and xref-collect-matches
* lisp/progmodes/xref.el (xref-references-in-directory): Rename
from xref-collect-references.  Update the sole caller.
(xref-matches-in-directory): Rename from xref-collect-matches.
Update all callers (all of them are in the /tests/ dir).

* test/lisp/progmodes/xref-tests.el (xref-tests-data-dir):
Don't use the EMACS_TEST_DIRECTORY env var. It doesn't work when
running interactively.
2019-12-29 15:46:44 +03:00
Dmitry Gutov
98788bf976 ; Improve the docstring some more 2019-12-29 15:46:44 +03:00
Dmitry Gutov
c190e91a1e Improve docstrings
* lisp/progmodes/xref.el (xref-collect-matches)
(xref-collect-references): Improve docstrings.
2019-12-29 15:46:44 +03:00
Alan Third
012c12a05e Fix when expose draws partially visible first glyph (bug#38731)
* src/xdisp.c (expose_area): When the face extends to the end of the
line draw text from the correct x coordinate.
2019-12-29 10:42:42 +00:00
Dmitry Gutov
d915b8c3f1 Don't require semantic/fw
* lisp/progmodes/xref.el (xref-collect-matches): Don't require
semantic/fw, we haven't been using semantic-find-file-noselect
here for a while.
2019-12-28 19:37:22 +03:00
Dmitry Gutov
50a0126402 Do some renames for clarity
* lisp/progmodes/xref.el (xref--last-file-buffer):
Rename from xref--last-visiting-buffer.  Update users.
(xref--find-file-buffer): Rename from xref--find-buffer-visiting
to match the standard function that gets called inside.  Ditto.
2019-12-28 19:30:39 +03:00
Eli Zaretskii
74261ff301 Rearrange NEWS, add missing documentation
* etc/NEWS: Rearrange and mark entries whether documented or not.

* doc/lispref/streams.texi (Output Variables): Document the new
default of 'print-quoted'.
* doc/lispref/keymaps.texi (Functions for Key Lookup): Document
that KEYMAP arg to 'lookup-key' can also be a list.
* doc/lispref/customize.texi (Variable Definitions): Document the
:local keyword of 'defcustom'.
* doc/lispref/numbers.texi (Float Basics): Document changes in
'logb'.
* doc/lispref/hooks.texi (Standard Hooks): Document
'comint-password-function'.

* doc/emacs/display.texi (Text Scale): Document text-size
adjustment using the mouse wheel.
* doc/emacs/frames.texi (Mouse Commands): Document image scaling
with the mouse wheel.
* doc/emacs/windows.texi (Window Convenience): Document
'global-tab-line-mode'.
* doc/emacs/search.texi (Repeat Isearch, Symbol Search)
(Isearch Yank): Document the new support for numeric arguments in
Isearch commands.
(Special Isearch): Document 'M-s M->' and 'M-s M-<'.
(Search Customizations): Document 'isearch-lazy-count'.  Improve
indexing.
(Not Exiting Isearch): Document the new value of
'isearch-allow-scroll'.
* doc/emacs/maintaining.texi (Xref Commands): Document the new 'g'
key binding.
* doc/emacs/package.texi (Package Installation): Document changes
in 'package-check-signature'.
* doc/emacs/maintaining.texi (VC Change Log): Document
'vc-log-search'.
* doc/emacs/dired.texi (Operating on Files): Document
'dired-vc-rename'.
2019-12-28 15:19:05 +02:00
Xu Chunyang
6c9571379e Fix interactive spec in netrc-parse
* lisp/net/netrc.el (netrc-parse): Fix placement of interactive
spec (bug#38773).
2019-12-28 13:41:04 +01:00
Eli Zaretskii
32222fb34c Fix documentation of define-obsolete-* functions
* doc/lispref/functions.texi (Obsolete Functions): Make
documentation of functions that obsolete symbols match the
advertised calling conventions.

* lisp/emacs-lisp/byte-run.el (define-obsolete-function-alias)
(define-obsolete-variable-alias, define-obsolete-face-alias):
State in the doc strings that WHEN is a mandatory argument, to be
consistent with the advertised calling convention.  (Bug#38675)
2019-12-28 11:13:25 +02:00
Lars Ingebrigtsen
3434ac67b9 Fix recent gnus-start.el breakage
* lisp/gnus/gnus-start.el (gnus-group-change-level): Fix previous
patch that made info nil when adding new groups (thereby making
gnus-newsrc-alist invalid).
2019-12-28 01:45:23 +01:00
Dmitry Gutov
8224ed7d40 (xref--find-buffer-visiting): Speed up by using get-file-buffer
* lisp/progmodes/xref.el (xref--find-buffer-visiting):
Speed up by using get-file-buffer.
(xref--collect-matches): Remove the condition on remote-id.
(https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00753.html)
2019-12-27 19:17:48 +03:00
Dmitry Gutov
3f2788d4ac project--vc-list-files: Recurse into submodules
* lisp/progmodes/project.el (project-try-vc): Do not treat a Git
submodule as a project root, go up to the parent repo.
(project--git-submodules): New function.
(project--vc-list-files): Use it.  Recurse into submodules.
2019-12-27 18:30:16 +03:00
Eli Zaretskii
f0da3aa83e Merge branch 'emacs-27' of git.savannah.gnu.org:/srv/git/emacs into emacs-27 2019-12-27 16:20:27 +02:00
Eli Zaretskii
3b199614cc Minor improvements of buffer documentation
* doc/emacs/buffers.texi (Buffers): Say that buffers are killed
when no longer needed.  Suggested by Jean-Christophe Helary
<jean.christophe.helary@traduction-libre.org>.
2019-12-27 16:19:09 +02:00
Dmitry Gutov
e1e0a7a751 xref--collect-matches: Speed up on remote
* lisp/progmodes/xref.el (xref--collect-matches):
Don't call find-buffer-visiting on remote file names, it's pretty
slow (bug#34343).
2019-12-27 17:19:00 +03:00
Dmitry Gutov
219b91eb2c ; project--find-regexp-in-files: Avoid prepending remote-id twice (bug#34343) 2019-12-27 17:19:00 +03:00
Mattias Engdegård
d627fc7d55 ; Use regexp type in tramp-adb-prompt (backport, do not merge)
* lisp/net/tramp-adb.el (tramp-adb-prompt): Use 'regexp' instead
of 'string' as type for values that are regexps in defcustom
declarations.
2019-12-27 10:25:05 +01:00
Phillip Lord
8aad80d661 Fix installer build
* admin/nt/dist-build/build-zips.sh: Ensure that NSIS build always
  uses the actual build number to locate its files.
2019-12-26 23:01:02 +01:00
Phillip Lord
47a73e3e14 Update Windows build documentation
* admin/nt/dist-build/README-scripts: Update with branch and snapshot
  information.
2019-12-26 21:13:38 +01:00
Mattias Engdegård
cd55984153 Calc: add missing dynamic variable declarations
* lisp/calc/calc-alg.el (math-simplify-only, calc-simplify-mode)
(math-expand-formulas, calc-poly-div-remainder)
(math-living-dangerously, math-simplifying, calc-angle-mode)
(calc-prefer-frac, math-poly-base-variable):
Declare dynamic variables.
* test/lisp/calc/calc-tests.el (calc-poly-div):
Add test for at least one bug caused by missing declarations.
2019-12-26 19:37:10 +01:00
Eli Zaretskii
e8aa6f19e9 * doc/emacs/buffers.texi (Kill Buffer): Improve indexing. 2019-12-26 18:20:12 +02:00
Dmitry Gutov
ccd7cd2c51 Speed up dired-do-find-regexp
* lisp/dired-aux.el (dired-do-find-regexp): Speed up (bug#36857).
Previously, 'find' was called for every marked file (for plain
files and directories both).  Now 'find' is only called for
directories.
2019-12-26 17:39:48 +02:00
Dmitry Gutov
7edb1f0773 ; Remove outdated declarations 2019-12-26 17:32:30 +02:00
Dmitry Gutov
6ab40c1a51 ; Clarify the assumption 2019-12-26 17:31:11 +02:00
Dmitry Gutov
be38e39fcc project--find-regexp-in-files: Support remote files
* lisp/progmodes/project.el (project--find-regexp-in-files):
Support remote files (bug#34343).
2019-12-26 16:00:06 +02:00
Philipp Stephani
21c3020fce Document some restrictions for module functions.
* doc/lispref/internals.texi (Module Functions): Document some
restrictions for module functions.
2019-12-26 11:31:51 +01:00
Philipp Stephani
e1ce9f3423 Don't recommend using 'module-load' for loading modules.
'module-load' most likely doesn't do what users expect.  Users should
use 'load' and its wrappers, which do the right thing.

* doc/lispref/loading.texi (Dynamic Modules): Document
disadvantages of 'module-load' and recommend normal 'load' and
its wrappers instead.

* doc/lispref/internals.texi (Module Functions): Recommend
'load' over 'module-load'.
2019-12-26 11:08:56 +01:00
Paul Eggert
03f962a486 Port x_get_monitor_attributes_fallback to !HAVE_GTK3
* src/xfns.c (x_get_net_workarea) [!HAVE_GTK3]:
Define in this case too, since x_get_monitor_attributes_fallback
contains a call to it regardless whether HAVE_GTK3 is defined.
2019-12-25 12:01:48 -08:00
Lars Ingebrigtsen
0b32f59764 Fix compilation warning in gnus-start.el
* lisp/gnus/gnus-start.el (gnus-gnus-to-quick-newsrc-format): Fix
compilation warning by not binding XEmacs-only variable.

* lisp/gnus/gnus-util.el (gnus-bind-print-variables): Ditto.
(gnus-prin1, gnus-prin1-to-string, gnus-pp, gnus-pp-to-string):
Adjust doc string.
2019-12-25 17:14:45 +01:00
Eli Zaretskii
91c16acbe2 Improve doc string of 'files--message'
* lisp/files.el (files--message): Improve the wording of doc
string.  (Bug#38737)
2019-12-25 17:00:06 +02:00
Wolfgang Scherer
c3be58a8f5 Improve vc--add-line, vc--remove-regexp
* lisp/vc/vc.el (vc--add-line): Create file if it does not exist.
Use existing buffer to avoid discrepancies with filesytem.  Make sure
that the file ends with a newline.
(vc--remove-line): Do not create file if it does not exist.  Use
existing buffer to avoid discrepancies with filesytem. (bug#37185)
2019-12-25 00:33:36 +02:00
Dmitry Gutov
9ea9ac9a61 Apply the 'xref-group' property properly
* lisp/progmodes/xref.el (xref--insert-xrefs):
Apply the 'xref-group' property properly (bug#36974).
2019-12-24 22:30:02 +02:00
Philipp Stephani
41f0cf266e * src/pdumper.c (Fdump_emacs_portable): Reword error message.
(cherry picked from commit ac7b260773)
2019-12-24 19:56:16 +02:00
Philipp Stephani
719a6924c4 Don’t allow portable dumping in interactive mode (Bug#38453).
* src/pdumper.c (Fdump_emacs_portable): Don’t allow dumping in
interactive mode.

(cherry picked from commit e7edba42c8)
2019-12-24 19:55:31 +02:00