1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-09 13:10:57 -08:00
Commit graph

128195 commits

Author SHA1 Message Date
Juanma Barranquero
2f90bbb5fe lisp/*.el: Fix some warnings
* lisp/battery.el (dbus-get-property):
* lisp/dired-aux.el (format-spec): Declare function.

* lisp/net/zeroconf.el (zeroconf-list-service-names)
(zeroconf-list-service-types, zeroconf-list-services):
Mark unused lexical arg.

* lisp/progmodes/hideshow.el (hs-hide-block-at-point):
* lisp/progmodes/sql.el (sql-end-of-statement):
Pass LIMIT to 'looking-back'.
2017-01-29 19:34:35 +01:00
Noam Postavsky
9bf94639b8 Don't warn about obsolete defgenerics when defining them
* lisp/emacs-lisp/cl-generic.el (cl-defgeneric): The declaration code
should run after the definition code (Bug#25556).
2017-01-29 11:16:06 -05:00
Tino Calancha
0073223c23 Fix Bug#25524
* lisp/vc/diff-mode.el (diff-beginning-of-hunk):
Return position at the beginning off the hunk.
(diff-file-junk-re): Add SVN keywords.
2017-01-29 18:49:10 +09:00
Stephen Berman
d12e1ddf42 hl-line.el: Don't try to operate on a killed buffer
* lisp/hl-line.el (hl-line-maybe-unhighlight): Examine only
live buffers (bug#25522).
2017-01-28 20:49:19 +01:00
Mark Oteiza
c7bbddf0ea Use access-file in EWW to check before downloading a file
* lisp/net/eww.el (eww-download): Check accessibility of
eww-download-directory to prevent starting a download that will fail
to write.
* src/fileio.c (Faccess_file): Clarify the use of string argument in
the docstring.
2017-01-28 12:06:41 -05:00
Yuri D'Elia
f83363d30e Subject: Check Bcc after the Messag hook has run
* lisp/gnus/message.el (message-send): If the hook modifies
the message (mml tags or headers), we should check bcc on the
final message, not on the original.
2017-01-28 15:21:28 +01:00
Juanma Barranquero
375c70fd9e test/*.el: Avoid byte-compiler warnings
* test/lisp/abbrev-tests.el (abbrev-table-p-test): Remove unused 'let*'.

* test/lisp/faces-tests.el (faces--test): New customization group.
(faces--test1, faces--test2): Use it.

* test/lisp/ffap-tests.el (ffap-tests-25243):
Call 'mark-whole-buffer' interactively.

* test/lisp/ibuffer-tests.el (ibuffer-filter-groups, ibuffer-filtering-alist)
(ibuffer-filtering-qualifiers, ibuffer-save-with-custom)
(ibuffer-saved-filter-groups, ibuffer-saved-filters): Defvar.
(ibuffer-format-qualifier, ibuffer-unary-operand): Declare.

* test/lisp/minibuffer-tests.el (completion-test1):
Mark unused lexical arguments.

* test/lisp/simple-tests.el (simple-test--dummy-buffer): Wrap result in
'with-no-warnings' to avoid them when the macro is invoked for effect.

* test/lisp/emacs-lisp/cl-seq-tests.el (cl-seq-count-test):
Mark unused lexical arguments.

* test/lisp/emacs-lisp/let-alist-tests.el (let-alist-surface-test):
Mark unused lexical arguments.
(let-alist-cons): Remove unused let binding.

* test/lisp/net/dbus-tests.el (dbus-debug): Defvar.
(dbus-get-unique-name): Declare.

* test/lisp/progmodes/python-tests.el (python-bob-infloop-avoid):
Call 'font-lock-fontify-buffer' interactively.

* test/lisp/textmodes/tildify-tests.el (tildify-space-undo-test--test):
Mark unused lexical argument.
2017-01-28 04:40:36 +01:00
Eli Zaretskii
3979d8f457 Restore a test that was removed by a recent commit
* src/fileio.c (Ffile_accessible_directory_p): Don't overwrite the
errno value unless it's necessary.  (Bug#25419)
2017-01-27 21:58:10 +02:00
Mark Oteiza
2d07895151 Fix a couple eww customization types
* lisp/new/eww.el (eww-download-directory, eww-bookmarks-directory):
Change customization type to "directory".
2017-01-27 13:19:38 -05:00
Philipp Stephani
107a0c4caa Don't require a shell when loading htmlfontify
* lisp/htmlfontify.el (hfy-which-etags): Don't call a shell for
detecting the etags version (Bug#25468).
* test/lisp/htmlfontify-tests.el (htmlfontify-bug25468): Add unit
test.
2017-01-27 18:37:58 +01:00
Paul Eggert
412b8dac52 Slightly tune file-accessible-directory-p fix
* src/fileio.c (Ffile_accessible_directory_p):
Remove unnecessary test (Bug#25419).
2017-01-27 08:58:02 -08:00
Arash Esbati
21d661d5f7 Add \citetitle to biblatex cite format
* lisp/textmodes/reftex-vars.el (reftex-cite-format-builtin): Add
\citetitle[*] to `reftex-cite-format' and bind them to keys i/I
per user request
http://lists.gnu.org/archive/html/auctex/2017-01/msg00049.html.
2017-01-27 17:47:03 +01:00
Lars Ingebrigtsen
03c1080cd4 Fix charsets and encodings from non-file MIME parts
* lisp/gnus/mml.el (mml-generate-mime-1): Get the charsets and
encoding right for parts that do not originate from files.
2017-01-27 13:54:50 +01:00
Eli Zaretskii
90c7634674 Fix 'describe-variable' for longish variable values
* lisp/help-fns.el (describe-variable): Don't accidentally remove
the last character of a variable's value.  (Bug#25545)
2017-01-27 12:27:50 +02:00
Eli Zaretskii
d7ac7b15ca Ensure last line is at window bottom in shell buffers
* lisp/shell.el (shell-mode): Use setq-local.  Set
scroll-conservatively to 101 locally.  See the discussion at
http://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00736.html
for the reasons.
2017-01-27 11:39:31 +02:00
Michael Hoffman
87027734e9 Support Bash Ctrl-Z indication of directory name in term.el
* term.el (term-emulate-terminal): Do not display ?\032 escape
codes even when 'handled-ansi-message' is non-nil.  (Bug#11919)

Copyright-paperwork-exempt: yes
2017-01-27 11:26:36 +02:00
Eli Zaretskii
525a6d2c4f Don't report zero errno for inaccessible directory
* src/fileio.c (Ffile_accessible_directory_p): Report EACCES when
a file handler reports a failure.  (Bug#25419)
2017-01-27 10:51:53 +02:00
Eli Zaretskii
e26166aae0 Fix filenotify-tests on MS-Windows
* test/lisp/filenotify-tests.el (file-notify-test04-file-validity)
(file-notify-test05-dir-validity)
(file-notify-test06-many-events)
(file-notify-test08-watched-file-in-watched-dir): Manually remove
the watch descriptor before calling file-notify--test-cleanup-p.
(Bug#25539)
2017-01-27 10:28:15 +02:00
Hong Xu
7cb7a582f4 python-mode: Fix detection for opening blocks.
* python.el (python-info-dedenter-opening-block-positions): There
	can't be any back-indented lines between an opening block and the
	current line.

	* python-tests.el (python-indent-electric-colon-4): Add an indent
	test case where there is one-more indented previous opening block.
2017-01-26 20:14:19 -05:00
Lars Ingebrigtsen
3485c1693e Fix Message check for bogus domain names
* lisp/gnus/message.el (message-make-fqdn): Fix check for
bogus system names (bug#24570).
2017-01-27 01:04:59 +01:00
Øyvind Stegard
7416f008f0 Subject: Restore correct Gnus newsgroup name after sending message
* lisp/gnus/gnus-msg.el (gnus-msg-mail): Set the value of
gnus-newsgroup-name in the correct buffer (bug#24329).

Copyright-paperwork-exempt: yes
2017-01-27 01:02:23 +01:00
Lars Ingebrigtsen
110cd0b439 Mention the new Gnus sorting command 2017-01-27 00:33:03 +01:00
Lars Ingebrigtsen
5dd303fe77 Don't try to find charsets of non-text MIME parts
* lisp/gnus/mml.el (mml-generate-mime-1): It seems nonsensical
to try to determine the charset of non-text message parts, so
skip that (bug#24190).  This will also remove messages like
"bunzip2ing /tmp/acsb.cpio.bz2...done" while sending messages
if you include such files.
2017-01-27 00:30:54 +01:00
Lars Ingebrigtsen
a3b6d8e2eb Add new command gnus-article-sort-by-marks
* doc/misc/gnus.texi (Summary Sorting): Mention
gnus-summary-sort-by-marks.

* lisp/gnus/gnus-sum.el (gnus-article-sort-by-marks): New
function (bug#23393).
(gnus-thread-sort-by-marks): Ditto.
(gnus-summary-sort-by-mark): New command suggested by Dan Jacobson.
(gnus-summary-mode-map): Add keystroke.
(gnus-summary-make-menu-bar): Add to menu.
2017-01-27 00:30:54 +01:00
Katsumi Yamaoka
f15bbbec0b Make `C-h b' work correctly in Gnus article buffer (bug#18257)
* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys keys (bug#18257).
2017-01-26 22:43:31 +00:00
Lars Ingebrigtsen
ffdf409ebb Fix crossposting in non-primary groups
* lisp/gnus/message.el
(message-cross-post-followup-to-header): Gnus server prefixes
shouldn't be included in the group names (bug#21661).
(message-cross-post-followup-to): Ditto.
2017-01-26 23:11:50 +01:00
Lars Ingebrigtsen
2db8794fca Gnus doc clarification
* doc/misc/gnus.texi (Unavailable Servers): Explicitly say
that "unreachable" is the same as disabling it (bug#21630).
2017-01-26 23:00:24 +01:00
Lars Ingebrigtsen
3539657bb7 Remove dead code from rfc2047
* lisp/mail/rfc2047.el (rfc2047-fold-field): Remove dead code.

It's been disabled since 2005, when I made the change with the
following comment.

(rfc2047-encode-message-header): Disabled header folding -- not
all headers can be folded, and this should be done by the message
composition mode.  Probably.  I think.
2017-01-26 22:52:16 +01:00
Lars Ingebrigtsen
77bbca8c82 Fill too long mail headers
* lisp/gnus/message.el (message--fold-long-headers): New
function to fold too-long headers (bug#21608).
(message-send-mail): Use it to fill headers longer than 998
characters (which is the protocol limit).
2017-01-26 22:51:19 +01:00
Lars Ingebrigtsen
47e82854ba Make nndoc more resilient against corrupted files
* lisp/gnus/nndoc.el (nndoc-possibly-change-buffer): Don't bug
out on invalid files, like invalid .gz files (bug#21538).
This may hinder Gnus from starting up.
2017-01-26 22:28:17 +01:00
Lars Ingebrigtsen
3a9e56d840 Respect buffer-local message-fcc-handler-function
* lisp/gnus/message.el (message-do-fcc): Copy the local
variables from the Message buffer so that local settings of
`message-fcc-handler-function' etc are respected (bug#21174).
2017-01-26 21:38:40 +01:00
Lars Ingebrigtsen
eba8046f05 (message-do-fcc): Modernise the code slightly.
* lisp/gnus/message.el (message-do-fcc): Modernise the code slightly.
2017-01-26 21:35:58 +01:00
Lars Ingebrigtsen
301ee3d031 Avoid a regexp overflow in message-goto-body
* lisp/gnus/message.el (message-goto-body-1): Avoid using a
complicated backtracking regexp, because they may overflow on
large headers (bug#21160).
2017-01-26 21:12:05 +01:00
Lars Ingebrigtsen
b720f1a336 Refactor message-goto-body
* lisp/gnus/message.el (message-goto-body-1): Refactor out for reuse.
2017-01-26 21:04:00 +01:00
Lars Ingebrigtsen
aeecbc09ad Fix typo in last checkin
* lisp/gnus/nnimap.el (nnimap-shell-program): Document
nnimap-shell-program (bug#20651).
2017-01-26 19:46:27 +01:00
Lars Ingebrigtsen
a1cb68be6c Document nnimap-shell-program
* lisp/gnus/nnimap.el (nnimap-shell-program): Document
nnimap-shell-program (bug#20651).
2017-01-26 19:46:27 +01:00
Lars Ingebrigtsen
d32623f040 Document :shell-command in `make-network-process'
* doc/lispref/processes.texi (Network): Document :shell-command.

* lisp/net/network-stream.el (open-network-stream): Document
the :shell-command parameter (bug#20651).
2017-01-26 19:46:27 +01:00
Lars Ingebrigtsen
079b6bebcb Gnus doc clarification
* lisp/gnus/gnus-sum.el (gnus-summary-save-article): Mention
the gnus-prompt-before-saving variable (bug#20500).
2017-01-26 19:46:27 +01:00
Lars Ingebrigtsen
d47dadd168 Fix the previous mml patch better
* lisp/gnus/mml.el (mml-minibuffer-read-file): Fix the
previous patch in a better way (bug#20480).
2017-01-26 19:46:27 +01:00
Lars Ingebrigtsen
9fc67ae2dd Give a slight better error message in mml-minibuffer-read-file
* lisp/gnus/mml.el (mml-minibuffer-read-file): Give a slightly
better error message when the user enters nothing (bug#20480).
2017-01-26 19:46:27 +01:00
Mark Oteiza
cf60608803 ; Just use octal
* lisp/recentf.el (recentf-save-file-modes): Write file mode in octal.
2017-01-26 13:12:54 -05:00
Lars Ingebrigtsen
950c0d8969 Make eww buffers prettier in the buffer listing
* lisp/net/eww.el (eww-render): Put the currently visited URL
into the buffer listing (bug#23738).
(eww-render): Ditto.
2017-01-26 18:32:48 +01:00
Lars Ingebrigtsen
9527d201c1 Allow mml-attach-file to prompt less
* lisp/gnus/mml.el (mml-attach-file): If given a prefix, don't
prompt for type/description/disposition, but use defaults
(bug#19202).
2017-01-26 18:19:46 +01:00
Lars Ingebrigtsen
eff6c6ac85 Don't allow message-newline-and-reformat to be run outside the body
* lisp/gnus/message.el (message-newline-and-reformat): Error
out if run outside the body of a message (bug#18820).
2017-01-26 15:07:38 +01:00
Paul Eggert
b3a3ed526d Replace QUIT with maybe_quit
There’s no longer need to have QUIT stand for a slug of C statements.
Use the more-obvious function-call syntax instead.
Also, use true and false when setting immediate_quit.
These changes should not affect the generated machine code.
* src/lisp.h (QUIT): Remove.  All uses replaced by maybe_quit.
2017-01-25 21:25:37 -08:00
Paul Eggert
1392ec7420 A quicker check for quit
On some microbenchmarks this lets Emacs run 60% faster on my
platform (AMD Phenom II X4 910e, Fedora 25 x86-64).
* src/atimer.c: Include keyboard.h, for pending_signals.
* src/editfns.c (Fcompare_buffer_substrings):
* src/fns.c (Fnthcdr, Fmemq, Fmemql, Fassq, Frassq, Fplist_put)
(Fnconc, Fplist_member):
Set and clear immediate_quit before and after loop instead of
executing QUIT each time through the loop.  This is OK for loops
that affect only locals.
* src/eval.c (process_quit_flag): Now static.
(maybe_quit): New function, containing QUIT’s old body.
* src/fns.c (rarely_quit): New function.
(Fmember, Fassoc, Frassoc, Fdelete, Fnreverse, Freverse)
(Flax_plist_get, Flax_plist_put, internal_equal, Fnconc):
Use it instead of QUIT, for
speed in tight loops that might modify non-locals.
* src/keyboard.h (pending_signals, process_pending_signals):
These belong to keyboard.c, so move them here ...
* src/lisp.h: ... from here.
(QUIT): Redefine in terms of the new maybe_quit function, which
contains this macro’s old definiens.  This works well with branch
prediction on processors with return stack buffers, e.g., x86
other than the original Pentium.
2017-01-25 21:25:37 -08:00
Paul Eggert
0dfd9a6918 Simplify make-list implementation
* src/alloc.c (Fmake_list): Don’t unroll loop, as the complexity
is not worth it these days.
2017-01-25 21:25:36 -08:00
Mark Oteiza
44765de200 Make use of cl-loop destructuring
* lisp/progmodes/js.el (js--get-tabs): Replace extraneous bits with
destructuring.
(with-js): Add declare forms.
2017-01-25 21:34:46 -05:00
Lars Ingebrigtsen
d32dfc2c7a Revert "Bind C-c keys in the article buffer"
This reverts commit 6b4195f2ac.

The commit somehow lead to problems in other parts of Emacs.
2017-01-25 22:53:07 +01:00
Eli Zaretskii
cd0e636524 ; * doc/lispref/lists.texi (List Elements): Fix last change. 2017-01-25 22:49:35 +02:00