1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-03-12 09:51:05 -07:00
Commit graph

149293 commits

Author SHA1 Message Date
Andrea Corallo
46e7613ad3 Merge remote-tracking branch 'savannah/master' into HEAD 2020-08-13 12:22:07 +02:00
Andrea Corallo
f6502f9592 ; * lisp/emacs-lisp/comp.el (comp-deferred-compilation): Fix doc. 2020-08-13 12:21:28 +02:00
Dima Kogan
53720a9bde gcc-include compilation lines are now INFO, instead of WARNING
* lisp/progmodes/compile.el
(compilation-error-regexp-alist-alist): Prior to this patch the
line that contains "from a.h:1:0," was seen as INFO and the line
that contains "from a.c:1:" was seen as a WARNING.  This patch
makes them both INFO (bug#17826).
2020-08-13 12:20:53 +02:00
Lars Ingebrigtsen
e9eafd2268 Ensure that server-socket-dir doesn't have "//" in the path
* lisp/server.el (server-socket-dir): Use expand-file-name to
avoid "//" in the path name (if either XDG_RUNTIME_DIR or TMPDIR
ends in a slash) (bug#18658).
2020-08-13 12:01:01 +02:00
H. Dieter Wilhelm
eb090f65ce Handle negative prefix arguments to mark-paragraph correctly
* textmodes/paragraph.el (mark-paragraph): Handle negative
arguments correctly (bug#18847).  This makes `M- M-h M-h' do the
correct thing with expanding the region (like other marking
commands) backwards.  Also fix problem at the end of the buffer,
where the numbers of paragraphs left in the buffer is less than
ARG, then paragraphs would also be marked *before* the current
paragraph.  Also clarify the doc string.
2020-08-13 11:51:26 +02:00
Jonas Bernoulli
838a1a313c Update section heading conventions for libraries
* doc/lispref/tips.texi (Comment Tips): Update information on section
  headings to reflect common usage.

Previously the tips stated that if the code is split up into multiple
sections, then that should be done by splitting up the ";;; Code:"
section into multiple sub-sections.

However about half the libraries in Emacs instead use multiple
top-level sections.  We update the tips (aka conventions) to allow
this common usage, but because it is awkward if there is a section
named "Code", which contains only some of the code instead of all of
it, we now recommend that that section should be empty in this case.

We cannot just give up on the "Code:" section/heading because that is
an old convention that is followed be nearly every library and because
it is likely that there are some utilities out there that depend on
its presence.

This was discussed in
https://lists.gnu.org/archive/html/emacs-devel/2020-07/msg00444.html
https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00001.html
2020-08-13 11:34:49 +02:00
Jonas Bernoulli
7cb029d4d3 ; * lisp/emacs-lisp/autoload.el: Begin summary line with three semicolons. 2020-08-13 11:34:49 +02:00
Jonas Bernoulli
2d93342a27 * lisp/font-lock.el: No longer use headings as end of section markers.
Each section ends right before the following section begins and IMO
that means that it is unnecessary to mark the end of sections.

For users of `outline-minor-mode' the old end-of-section markers were
a distraction.  They made it much harder to parse the overview outline
state because each section heading was followed by a end-of-section
marker that was formatted as a section heading.  Because of this I
wanted to remove the end-of-section markers.

But as Eli pointed out these sections are long and not everyone uses
`outline-minor-mode'.

So instead of removing them, I am turning the end-of-section markers
into regular comments (beginning with just two semicolons) instead of
section headings (beginning with tree semicolons).  That way users of
`outline-minor-mode' won't be distracted by them and others can still
benefit from the markers as before.
2020-08-13 11:34:49 +02:00
Jonas Bernoulli
b88e5b4e6d * lisp/font-lock.el: Split the Commentary into subsections.
The "Commentary" was already split into multiple sections, but
these sections where on the same level as "Commentary" itself,
which is less convenient for users of `outline-minor-mode'.
2020-08-13 11:34:49 +02:00
Jonas Bernoulli
54097328c5 * lisp/net/imap.el: Use proper outline headings
This library already used section headings but it used just two
instead of three semicolons, making them indistinguishable from
plain comments.  One heading is new.
2020-08-13 11:34:49 +02:00
Jonas Bernoulli
e118b79773 * lisp/obsolete/longlines.el: Use proper outline headings.
This library already used section headings but it used just two
instead of three semicolons, making them indistinguishable from
plain comments.  One heading is new.
2020-08-13 11:30:16 +02:00
Jonas Bernoulli
cb58a3c552 * test/src/emacs-module-tests.el: Use proper outline headings.
This library already used section headings but it used just two
instead of three semicolons, making them indistinguishable from
plain comments.
2020-08-13 11:30:16 +02:00
Jonas Bernoulli
9d267db8fa * lisp/mail/smtpmail.el: Use outline headings. 2020-08-13 11:30:16 +02:00
Jonas Bernoulli
d59c018a20 ; * lisp/whitespace.el: Capitalize "Code" section heading. 2020-08-13 11:30:16 +02:00
Jonas Bernoulli
aaa69dc923 * lisp/progmodes/compile.el: Remove unnecessary comments.
These comments are unnecessary because the doc-strings that follow
already cover the same ground, while being more concise.  These
comments were also prefixed with too many semicolons, causing them
to be treated as outline headings.
2020-08-13 11:30:16 +02:00
Jonas Bernoulli
0bc9e7b8f5 Merge two conditions and fix indentation
The motivation behind this change is that the indentation of some
lines was outright wrong.  If we address that issue, then we might
as well also address the issue that some code is needlessly nested
an additional level.  That we can fix by merging the conditions.

By doing these two changes in on commit we have to change the fewest
lines.  Even though we are moving to using just spaces for indentation
of the modified lines, other lines in the same function are left alone
and continue to us tabs+spaces for indentation.  That is not "wrong",
but just the style we are slowly migrating away from when touching
lines for other reasons.

Discussed in bug#42397.

* lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Merge two
conditions and fix indentation.
2020-08-13 11:30:16 +02:00
Jonas Bernoulli
c5b9d2a4b4 Split EasyPG libraries into outline sections
* lisp/epa-dired.el:
lisp/epa-file.el:
lisp/epa-hook.el:
lisp/epa-mail.el:
lisp/epa.el:
lisp/epg-config.el:
lisp/epg.el: Split into outline sections.
* lisp/epg.el (epg-error): Move definition.
2020-08-13 11:30:16 +02:00
Jonas Bernoulli
562bbd0a36 ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. 2020-08-13 11:29:35 +02:00
Jonas Bernoulli
7ba75919ab ; * lisp/epg.el (epg-signature-to-string): Tiny refactor.
`concat' treats arguments that are nil as if they were empty strings.
We therefore do not have to write (if TEST THEN "") and can just use
(and TEST THEN).
2020-08-13 11:29:35 +02:00
Jonas Bernoulli
944608851c ; * lisp/epg.el (epg-signature-to-string): Use cl-case.
In this case we can greatly increase readability by using `cl-case'
instead of `cond'.
2020-08-13 11:29:35 +02:00
Lars Ingebrigtsen
804a0e82f2 Don't output emacsclient warning if both -a and --quiet
* lib-src/emacsclient.c (set_local_socket): Don't output the
warning if both -a and --quiet are specified (bug#16117).
Inspired by a patch from Scott Turner <srt19170@gmail.com>.
2020-08-13 10:29:44 +02:00
Emilio Lopes
991e145450 Notify the user if we errors when querying for registered git files
* lisp/vc/vc-git.el (vc-git-registered): Notify the user when
something fails here (bug#18481).
2020-08-13 10:01:00 +02:00
Paul Eggert
97896e68f9 mml-secure-en-decrypt-sign-2 is unstable
* test/lisp/gnus/mml-sec-tests.el (mml-secure-en-decrypt-sign-2):
Mark as unstable (Bug#42720).
2020-08-12 18:39:06 -07:00
Stefan Kangas
63b7697a67 Remove Emacs 22 compat code from dns.el
* lisp/net/dns.el (dns-servers-up-to-date-p, dns-set-servers):
Remove check for function that is always there.
2020-08-13 01:39:53 +02:00
Stefan Kangas
434ebb51ed Declare semantic XEmacs compat code obsolete
* lisp/cedet/semantic/grammar.el
(semantic-grammar-setup-menu-xemacs): Declare obsolete.
2020-08-13 01:29:47 +02:00
Stefan Kangas
2a0a47ce52 Remove XEmacs compat code from allout-widgets.el
* lisp/allout-widgets.el
(allout-widgets-item-image-properties-xemacs)
(allout-item-widget, allout-fetch-icon-image)
(allout-widgets-copy-list): Remove XEmacs compat code.
2020-08-13 01:24:57 +02:00
Stefan Monnier
fd6058b8fb * lisp/net/mailcap.el (mailcap-mime-data): Remove long-forgotten ee
It referred apparently to the "Electric Eyes" image viewer:
https://archive.org/details/tucows_31588_Electric_Eyes
2020-08-12 14:46:47 -04:00
Paul Eggert
7e3fd65bb9 Stop using Gnulib inttypes module
It wasn’t needed for MinGW after all, no other platform
seems to need it, and it slows down ‘configure’.
* admin/merge-gnulib (GNULIB_MODULES): Remove inttypes.
* m4/gnulib-comp.m4: Regenerate.
2020-08-12 11:45:55 -07:00
Paul Eggert
e697ca1525 Update from Gnulib
This incorporates:
2020-08-12 stdint: port intptr_t to more-recent MinGW
2020-08-11 Use __restrict also on clang
2020-08-11 Use flexible array syntax also on clang
2020-08-11 fcntl: On native Windows, use _setmode, not setmode
* lib/binary-io.h, lib/cdefs.h, lib/fcntl.c, lib/regex.h:
* lib/stdint.in.h: Copy from Gnulib.
2020-08-12 11:45:55 -07:00
Lars Ingebrigtsen
9102ecc63b Remove some compat code from mm-util.el
* lisp/gnus/mm-util.el (mm-charset-to-coding-system): Remove the
non-mule case, because it's always false.
2020-08-12 19:54:48 +02:00
Lars Ingebrigtsen
36466ed666 Simplify the computation of mm-mime-mule-charset-alist
* lisp/gnus/mm-util.el (mm-mime-mule-charset-alist): For
compatibility with XEmacs, mm-mime-mule-charset-alist was first
set to a list of hard-coded entries, and then overwritten on Emacs
from `coding-system-list'.  Remove the hard-coded values and
simplify the code.
2020-08-12 19:54:48 +02:00
Lars Ingebrigtsen
b8062be488 Remove some compat code from eudc-bob.el
* lisp/net/eudc-bob.el (eudc-bob-save-object)
(eudc-bob-pipe-object-to-external-program): Remove checks for
functions that are always defined in Emacs.
2020-08-12 19:54:48 +02:00
Lars Ingebrigtsen
b02bd6d0bb Remove some compat code from url-handlers.el
* lisp/url/url-handlers.el (url-insert-buffer-contents): Remove
check for function that's always defined in Emacs.
2020-08-12 19:54:48 +02:00
Lars Ingebrigtsen
c0c24267b3 Remove some compat code from gnus.el
* lisp/gnus/gnus.el: Remove a check for a function that is always
defined.
2020-08-12 19:54:48 +02:00
Amin Bandali
2b69a4df78
Add support for italic text in ERC
* lisp/erc/erc-goodies.el (erc-italic-face): New face for italic text.
(erc-controls-interpret), (erc-controls-highlight): Add `italicp'.
(erc-controls-remove-regexp),
(erc-controls-highlight-regexp): Handle C-] for italic.
(erc-controls-propertize): Add `italicp' argument and use it to
conditionally propertize text with the new `erc-italic-face'.
* etc/NEWS: Announce italic text support.
2020-08-12 13:39:07 -04:00
Lars Ingebrigtsen
56a44a882c Remove some compat code from viper-cmd.el
* lisp/emulation/viper-cmd.el (viper-register-to-point):
frame-configuration-p is always available in Emacs now.
2020-08-12 18:56:47 +02:00
Lars Ingebrigtsen
9a929de29b Remove some compat code from viper*.el
* lisp/emulation/viper.el (viper-go-away, viper-set-hooks)
(viper-non-hook-settings, viper-mode):
* lisp/emulation/viper-cmd.el (viper-normalize-minor-mode-map-alist)
(viper-harness-minor-mode): Remove a bunch of checks to do (or
not do) things based on whether add-to-ordered-list is fbound and
emulation-mode-map-alists is bound, because in Emacs now, these
are always true.
2020-08-12 18:52:53 +02:00
Lars Ingebrigtsen
1dfb170476 Mark some unused defaliases in semantic/fw.el obsolete
* lisp/cedet/semantic/fw.el (semantic-run-mode-hooks)
(semantic-subst-char-in-string): Make two unused defaliases obsolete.
2020-08-12 18:46:27 +02:00
Lars Ingebrigtsen
e97d3e1a26 Remove some compat code from epa.el
* lisp/epa.el (epa--derived-mode-p, epa-import-keys): Make
defalias obsolete, and adjust a comment.
2020-08-12 18:43:06 +02:00
Lars Ingebrigtsen
af6ea5578a Remove some compat code from bubbles.el
* lisp/play/bubbles.el (bubbles--remove-overlays): Make into an
obsolete alias.
(bubbles--initialize, bubbles--show-images): Adjust callers.
2020-08-12 18:39:17 +02:00
Lars Ingebrigtsen
74909e1ec2 Fix a check for whether Emacs can play sounds in eudc-bob
* lisp/net/eudc-bob.el (eudc-bob-sound-menu)
(eudc-bob-play-sound-at-point): Check for play-sound-internal
instead of play-sound, because the latter is always defined.
2020-08-12 18:37:18 +02:00
Lars Ingebrigtsen
6ac22bc00c Remove some compat code from allout.el
* lisp/allout.el (allout-numbered-bullet)
(allout-file-xref-bullet): string-or-null-p is always defined.
2020-08-12 18:35:29 +02:00
Lars Ingebrigtsen
67bd8a4874 Remove some compat code from allout*.el
* lisp/allout-widgets.el (allout-widgets-mode-inhibit): Ditto.

* lisp/allout.el (allout-use-hanging-indents)
(allout-show-bodies, allout-old-style-prefixes)
(allout-stylish-prefixes): `booleanp' is always defined.
2020-08-12 18:34:29 +02:00
Lars Ingebrigtsen
77907b29e0 Remove some compat code from prolog.el
* lisp/progmodes/prolog.el (match-string): Remove alias to
function that always exists.
2020-08-12 18:31:50 +02:00
Lars Ingebrigtsen
a459e5256c Remove some compat code from idlwave.el
* lisp/progmodes/idlwave.el: Remove some checks for functions that
always exist.
2020-08-12 18:29:05 +02:00
Lars Ingebrigtsen
51ea541710 Remove some compat code from ediff-init.el
* lisp/vc/ediff-init.el (subst-char-in-string, format-message):
Remove aliases to functions that always exist.
2020-08-12 18:26:20 +02:00
Lars Ingebrigtsen
6cddb736e4 Check make-process to determine if we support multi-processing
* lisp/eshell/esh-proc.el (eshell-gather-process-output):
* lisp/comint.el (make-comint-in-buffer): Check that make-process
exists instead of start-file-process (which always exists).
2020-08-12 18:09:24 +02:00
Lars Ingebrigtsen
e3a0801993 Revert "Remove compat code from esh-proc.el"
This reverts commit 97c4d941da.

We still have Emacs builds on systems with no multi-tasking.
2020-08-12 18:06:50 +02:00
Lars Ingebrigtsen
a5b24a0c44 Revert "Remove compat code from comint.el"
This reverts commit 4d00db5538.

We still have Emacs builds on systems with no multi-taskin.
2020-08-12 18:06:13 +02:00
Tino Calancha
76098d39c9 Do not truncate /foo//bar to /bar/ in parse-colon-path
* lisp/files.el (parse-colon-path): Use substitute-env-vars and
expand-file-name instead of substitute-in-file-name (Bug#21454).
2020-08-12 16:30:17 +02:00