Paul Eggert
0da09c43ea
* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
...
the race-condition problem the old DOWNCASE.
2011-03-15 14:23:02 -07:00
Paul Eggert
880433015d
Add ChangeLog entry for previous change.
2011-03-15 14:22:21 -07:00
Paul Eggert
5da9919f99
Use functions, not macros, for up- and down-casing.
2011-03-15 14:14:06 -07:00
Paul Eggert
b313f9d863
* regex.c (RETALLOC_IF): Define only if needed.
...
(WORDCHAR_P): Likewise. This one is never needed, but is used
only in a comment talking about a compiler bug, so put inside
the #if 0 of that comment.
(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
Remove; unused.
2011-03-15 11:53:29 -07:00
Paul Eggert
da053e48b1
* regex.c (regex_compile, re_match_2_internal): Mark locals as initialized.
2011-03-15 11:43:04 -07:00
Paul Eggert
952db0d7ad
* regex.c (FREE_VAR): Rewrite so as not to use empty "else",
...
which gcc can warn about.
2011-03-15 11:40:00 -07:00
Paul Eggert
8fb3179241
* regex.c (re_match_2_internals): Fix one more "not".
2011-03-15 11:37:02 -07:00
Paul Eggert
abbd1bcfec
* regex.c: (regex_compile, re_search_2, re_match_2_internal):
...
Remove unused local vars.
2011-03-15 11:32:28 -07:00
Paul Eggert
19ed544587
* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
...
Rename locals to avoid shadowing.
(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2011-03-15 11:27:53 -07:00
Paul Eggert
1f3561e4ca
* search.c (boyer_moore): Rename locals to avoid shadowing.
...
* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): Likewise.
2011-03-15 11:13:15 -07:00
Paul Eggert
ded6f8f72e
* search.c (simple_search): Remove unused var.
2011-03-15 11:08:50 -07:00
Paul Eggert
dbd37a958f
* dired.c (compile_pattern): Move decl from here ...
...
* lisp.h: ... to here, so that it can be checked.
(struct re_registers): New forward decl.
2011-03-15 11:08:06 -07:00
Paul Eggert
7e47afad45
* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2011-03-15 11:02:42 -07:00
Paul Eggert
5671df8f51
* indent.c (Fvertical_motion): Mark locals as initialized.
2011-03-15 10:59:31 -07:00
Paul Eggert
85f24f6159
* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
...
All uses changed.
(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
Rename locals to avoid shadowing.
2011-03-15 10:57:31 -07:00
Paul Eggert
e45a141a5b
* casefiddle.c (casify_region): Mark local as initialized.
2011-03-15 10:18:02 -07:00
Paul Eggert
181aa2be71
* casefiddle.c (casify_object, casify_region): Now static.
2011-03-15 10:16:14 -07:00
Paul Eggert
930d429ccc
* cmds.c (internal_self_insert): Rename local to avoid shadowing.
2011-03-15 10:16:01 -07:00
Paul Eggert
7082eac679
* lisp.h: New macros GCPRO2_VAR, GCPRO3_VAR, etc.
2011-03-15 10:13:02 -07:00
Paul Eggert
38b2c0769f
* dired.c (directory_files_internal, file_name_completion):
...
Rename locals to avoid shadowing.
2011-03-15 01:38:32 -07:00
Paul Eggert
15206ed923
Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
...
An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
dired.c's scmp function, had undefined behavior.
* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
* buffer.h: ... to here, because these macros use current_buffer,
and the new implementation with inline functions needs to have
current_buffer in scope now, rather than later when the macros
are used.
(downcase, upcase1): New static inline functions.
(DOWNCASE, UPCASE1): Reimplement using these functions.
This avoids undefined behavior in expressions like
DOWNCASE (x) == DOWNCASE (y), which previously suffered
from race conditions in accessing the global variables
case_temp1 and case_temp2.
* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
* lisp.h (case_temp1, case_temp2): Remove their decls.
* character.h (ASCII_CHAR_P): Move from here ...
* lisp.h: ... to here, so that the inline functions mentioned
above can use them.
2011-03-15 00:04:00 -07:00
Paul Eggert
4a6bea268f
* dired.c (directory_files_internal_unwind): Now static.
2011-03-14 20:59:26 -07:00
Paul Eggert
f839df0cf5
* fileio.c: (Fset_file_times, Finsert_file_contents, auto_save_error):
...
Rename locals to avoid shadowing.
2011-03-14 20:17:20 -07:00
Paul Eggert
b14aac08d0
* fileio.c (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
...
signedness issues.
2011-03-14 19:50:36 -07:00
Paul Eggert
fd4ead5206
* fileio.c (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2011-03-14 19:48:24 -07:00
Paul Eggert
2893f1463d
* fileio.c (file_name_as_directory): Use const pointers when appropriate.
...
(Fexpand_file_name): Likewise. In particular, newdir might
point at constant storage, so make it a const pointer.
2011-03-14 19:46:32 -07:00
Paul Eggert
f14b7e14bb
* fileio.c (file_name_as_directory, directory_file_name):
...
(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
Now static.
2011-03-14 18:42:54 -07:00
Paul Eggert
62137a95f3
* minibuf.c (Ftry_completion, Fall_completions): Rename or remove locals
...
to avoid shadowing.
2011-03-14 18:39:30 -07:00
Paul Eggert
5716756ee3
* minibuf.c (choose_minibuf_frame_1): Now static.
2011-03-14 18:34:35 -07:00
Paul Eggert
b4c3046a73
* marker.c (bytepos_to_charpos): Remove; unused.
2011-03-14 18:33:14 -07:00
Paul Eggert
b45db52287
* lisp.h (verify_bytepos, count_markers): New decls,
...
so that gcc does not warn that these functions aren't declared.
2011-03-14 18:32:33 -07:00
Paul Eggert
40ef059ee2
* insdel.c (copy_text): Remove unused local var.
2011-03-14 18:26:16 -07:00
Paul Eggert
f0cb4a6079
* insdel.c (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2011-03-14 18:25:31 -07:00
Paul Eggert
85876d0794
* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
...
(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2011-03-14 18:22:56 -07:00
Paul Eggert
b3dd38aba9
* filelock.c (lock_file_1): Rename local to avoid shadowing.
2011-03-14 18:19:50 -07:00
Paul Eggert
03d78a21be
* filelock.c (within_one_second): Now static.
2011-03-14 18:16:59 -07:00
Paul Eggert
5df8f01bab
* buffer.c (fix_overlays_before): Mark locals as initialized.
...
(fix_start_end_in_overlays): Likewise. This function should be
simplified by using pointers-to-pointers, but that's a different
matter.
2011-03-14 18:15:56 -07:00
Paul Eggert
8f54f30aec
* buffer.c: (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
...
(report_overlay_modification): Rename locals to avoid shadowing.
2011-03-14 16:43:16 -07:00
Paul Eggert
c3bd59b510
* buffer.c (switch_to_buffer_1): Now static.
2011-03-14 16:32:27 -07:00
Paul Eggert
15dfd3d9d6
* sysdep.c (MAXPATHLEN): Define only if needed.
2011-03-14 16:31:21 -07:00
Paul Eggert
edced198e3
* sysdep.c (sys_subshell): Mark local as volatile if checking for lint,
...
to suppress a gcc -Wclobbered warning that does not seem to be right.
2011-03-14 16:30:06 -07:00
Paul Eggert
fbd02d7b06
* sysdep.c: Fix pointer signedness issue.
2011-03-14 15:56:24 -07:00
Paul Eggert
a70072c9a5
* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2011-03-14 15:52:28 -07:00
Paul Eggert
a0977c4454
* process.c (serial_open, serial_configure): Move decls from here ...
...
* systty.h: ... to here, so that they can be checked.
2011-03-14 15:49:41 -07:00
Paul Eggert
a884fdcc41
* fns.c (get_random, seed_random): Move extern decls from here ...
...
* lisp.h: ... to here, so that they can be checked.
2011-03-14 15:42:10 -07:00
Paul Eggert
b8950c9480
* sysdep.c (wait_for_termination_signal): Remove; unused.
2011-03-14 15:37:08 -07:00
Paul Eggert
604efe86a9
* sysdep.c (reset_io): Now static.
2011-03-14 15:36:12 -07:00
Paul Eggert
c1141155ba
* keymap.c: (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
...
(describe_map_tree):
Rename locals to avoid shadowing.
2011-03-14 08:53:19 -07:00
Paul Eggert
dbbb842771
* keymap.c (DENSE_TABLE_SIZE): Remove; unused.
2011-03-14 08:42:21 -07:00
Paul Eggert
1004a21a8f
* keymap.c (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2011-03-14 08:40:57 -07:00