1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-05 22:20:24 -08:00

Eglot: revert changes to eglot-rename's interface (bug#79757)

After some weeks of testing, I've changed by mind on this.  Having the
current name appear passed the INITIAL-VALUE to read-from-minibuffer is
a jarring backward-incompatible change.  There is no evidence that the
majority of renames are simple tweaks to the existing names, and even
less evidence that these tweaks happen frequently at the end of the
symbol.

Therefore it's better for the ergonomics of this commonly used command
to leave the code as it was and simply rely on C-n to bring in the
default value (which is the current symbol name), instead of forcing
users accustomed to the previous behaviour remember to press sth like
M-DEL to clean the input.

* lisp/progmodes/eglot.el (eglot-rename): Tweak.
This commit is contained in:
João Távora 2025-11-30 13:44:30 +00:00
parent ae36ee3655
commit 27f0a3fd86

View file

@ -4083,7 +4083,7 @@ edit proposed by the server."
(let ((tap (thing-at-point 'symbol t)))
(list (read-from-minibuffer
(format "Rename `%s' to: " (or tap "unknown symbol"))
tap nil nil nil tap))))
nil nil nil nil tap))))
(eglot-server-capable-or-lose :renameProvider)
(eglot--apply-workspace-edit
(eglot--request (eglot--current-server-or-lose)