From 27f0a3fd869d3a73074f2023584430f6a5fd1162 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Sun, 30 Nov 2025 13:44:30 +0000 Subject: [PATCH] Eglot: revert changes to eglot-rename's interface (bug#79757) After some weeks of testing, I've changed by mind on this. Having the current name appear passed the INITIAL-VALUE to read-from-minibuffer is a jarring backward-incompatible change. There is no evidence that the majority of renames are simple tweaks to the existing names, and even less evidence that these tweaks happen frequently at the end of the symbol. Therefore it's better for the ergonomics of this commonly used command to leave the code as it was and simply rely on C-n to bring in the default value (which is the current symbol name), instead of forcing users accustomed to the previous behaviour remember to press sth like M-DEL to clean the input. * lisp/progmodes/eglot.el (eglot-rename): Tweak. --- lisp/progmodes/eglot.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 24ee1df749f..b8d29f966fc 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -4083,7 +4083,7 @@ edit proposed by the server." (let ((tap (thing-at-point 'symbol t))) (list (read-from-minibuffer (format "Rename `%s' to: " (or tap "unknown symbol")) - tap nil nil nil tap)))) + nil nil nil nil tap)))) (eglot-server-capable-or-lose :renameProvider) (eglot--apply-workspace-edit (eglot--request (eglot--current-server-or-lose)