mirror of
https://github.com/tiddly-gittly/TidGi-Desktop.git
synced 2026-01-21 03:51:15 -08:00
* fix: not removed
* Optimize tidgi.config.json writes for workspace updates
Update logic to write tidgi.config.json only for the modified workspace instead of all wiki workspaces on each update. This reduces redundant file operations and improves performance during workspace updates.
* Refactor workspace saving and UI update logic
Introduced a private saveWorkspacesToSettings method to centralize logic for saving workspaces and removing syncable fields from wiki workspaces. The set and setWorkspaces methods now support skipping UI updates for batch operations, improving performance. Fixed minor issues in legacy migration and error messages.
* Add 'Ask AI' context menu and wiki embed split view
Introduces an 'Ask AI' option to the wiki context menu, enabling users to send selected text to an agent chat in a split view with the wiki embedded. Implements new tab type WIKI_EMBED, updates tab and channel types, adds localization, manages BrowserView bounds for embedding, and ensures persistence and IPC wiring for the new workflow.
* Update wiki
* electron chrome mcp mode sometimes wont show browser view
Clarified troubleshooting steps in docs/MCP.md regarding browser view issues and updated the instructions. Reordered the 'start:dev:mcp' script in package.json for better organization.
* Add agent selection to 'Talk with AI' context menu
Replaces the 'Ask AI' context menu with 'Talk with AI' and adds a submenu for selecting different agent definitions. Updates translations for all supported languages, modifies the askAIWithSelection channel to support agentDefId, and refactors tab creation logic to support split view with agent selection. Improves robustness in view management by handling case-insensitive workspace IDs and custom bounds logic.
* Add e2e test and refactor 'Talk with AI' split view logic
Introduces a new Cucumber feature for 'Talk with AI' from wiki selection, adds a step definition to trigger the workflow via IPC, and refactors split view tab creation to reuse existing tabs when possible. Updates the agent browser service to support finding or creating the appropriate split view tab, and adjusts menu and view services for improved robustness and code clarity. Also adds test IDs to relevant components for more reliable UI testing.
* Update defaultWiki.feature
* Add config error handling and i18n for agent errors
Introduces a new feature test for configuration error handling, adds step definition to remove AI settings for testing, and updates error message rendering to support new error types. Internationalized error messages and button labels for configuration issues are added in both English and Chinese locales. The error message renderer now uses a data-testid for easier testing and recognizes additional error types as fixable in settings.
* Refactor feature files to use two-column selector tables
Updated all feature files to use a standardized two-column format for selector tables, with explicit 'element description' and 'selector' columns. Step definitions in ui.ts were refactored to support this format, improving readability and maintainability of test steps and error handling.
* Delete tiddlywiki
* test: allow parallel
* test: implement scenario isolation for E2E tests
- Isolate each test scenario in test-artifacts/{scenarioSlug}/ directory
- Use dynamic ports for mock OpenAI server to avoid port conflicts
- Log VIEW_LOADED event via did-finish-load in main process (more reliable)
- Search all .log files when waiting for log markers
- Increase timeout for log marker steps to 15 seconds
- Fix ts-node cache issues by clearing cache before tests
- Move application launch to individual scenarios (required for mock server setup)
All 45 E2E test scenarios now pass consistently.
* refactor: optimize agent.feature by moving common steps to Background
- Add MockOpenAIServer.addRules() method to append responses dynamically
- Add 'I have started the mock OpenAI server without rules' step for Background
- Add 'I add mock OpenAI responses:' step to inject responses per scenario
- Move application launch and navigation to Background (shared by all scenarios)
- Keep scenario-specific mock responses in individual scenarios
This improves test maintainability by reducing duplication while keeping
scenario-specific configuration flexible.
* lint
* Refactor scenario path helpers into shared module
Moved scenario-specific path helper functions from individual step definition files to a centralized 'features/supports/paths.ts' module. Updated imports in step definitions to use the shared helpers, improving code reuse and maintainability. Also enhanced test for ContextService to skip optional runtime keys.
* Refactor slug generation to use shared slugify helper
Introduced a new src/helpers/slugify.ts utility for consistent slug generation across the codebase. Updated appPaths.ts to use the shared slugify function, improving maintainability and ensuring identical behavior for test scenario slugs. Added documentation and clarified slugification rules in relevant files. Minor comments and clarifications were added to E2E and mock server code.
* Enforce strict timeout rules in E2E test steps
Added and clarified critical warnings for AI agents regarding timeout modifications in application, cleanup, and wiki step definitions. All timeouts are now strictly limited to 5s local and 10s CI, with explicit comments and environment-based values. Updated documentation and code comments to reinforce that timeouts indicate real bugs and should not be increased.
* Update features/stepDefinitions/application.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor E2E helpers, improve test reliability and cleanup
Centralizes data table parsing for UI step definitions, refactors mock OpenAI server setup, and improves workspace settings path handling for tests. Adjusts timeouts for window and app closing to better reflect real-world performance. Fixes type usage in workspace ID lookups and adds error handling for resize observer and cleanup in WikiEmbedTabContent. Enhances agent browser tab logic and view service cleanup to prevent memory leaks and catch workspace ID casing issues.
* Update agent.ts
* fix: resolve all E2E test timeout issues
* fix: improve CI test reliability with better timing and cleanup
- Use exponential-backoff library for agent creation retry logic
- Extend agent cancel delay to 1000ms for CI environments
- Fix git log refresh marker timing with queueMicrotask
- Improve cleanup timeout handling with force close strategy
All E2E tests passing locally including previously failing CI tests.
* Improve Git log E2E signal and add debug logging
Renames the test artifact in the CI workflow for clarity. Moves the E2E test timing log in useGitLogData to after entries are rendered, using a more reliable signal. Adds a debug log to notifyGitStateChange for better traceability.
* test-artifacts-ci
* Optimize test artifact handling and Git log logging
Update CI workflow to clean up large cache folders in test artifacts and only upload logs, settings, and screenshots to reduce artifact size. Refactor useGitLogData to log immediately after state updates for improved E2E test reliability, removing unnecessary setTimeout.
* Update useGitLogData.ts
* Improve Git log E2E test logging and .gitignore
Added 'test-artifacts-ci.zip' to .gitignore. Moved the '[test-id-git-log-refreshed]' log to immediately after data load for more reliable E2E test detection, and removed redundant logging from the render effect in useGitLogData.ts.
* Update useGitLogData.ts
* Update useGitLogData.ts
* Fix git log refresh marker not appearing in CI
- Move git-log-refreshed marker before RAF to ensure it's recorded
- RAF callbacks may not execute reliably in headless CI environments
- Add debug logging to track loadGitLog execution
- Add try-catch around log call to catch any errors
- Keep git-log-data-rendered in useEffect for UI tracking
* Update useGitLogData.ts
* Update useGitLogData.ts
* Add comprehensive logging to diagnose git-log-refreshed issue
- Log before RAF and inside RAF to pinpoint exact failure location
- Add try-catch to capture any errors
- Two log markers: before-raf and in-raf
- This will definitively show where the logging fails in CI
* Fix race condition: prevent concurrent loadGitLog calls
Root cause: commit triggers 2 refreshes (gitStateChange$ + handleCommitSuccess)
- First loadGitLog (refreshTrigger=1) succeeds
- Second loadGitLog (refreshTrigger=2) starts but never completes
- Add loadGitLogInProgress guard to prevent concurrent execution
- Log when loadGitLog is skipped due to in-progress call
This ensures git-log-refreshed is always logged after commit.
* Remove redundant triggerRefresh calls causing race condition
- handleCommitSuccess/Revert/Undo no longer call triggerRefresh
- gitStateChange\$ observable already triggers refresh for these operations
- Redundant calls caused 2 concurrent loadGitLog, causing CI test failures
- Local tests passed because both completed; CI failed because 2nd never completed
This ensures only 1 loadGitLog runs per git operation.
* Remove unused triggerRefresh parameter from useCommitSelection
- triggerRefresh no longer used in handlers
- Remove from interface and call site
- Clean up lint errors
* Remove triggerRefresh completely - no longer needed
- Observable subscription handles all git state changes
- Remove function definition and exports
- Fix all lint errors
Root cause resolved: commit triggered double refresh causing race condition.
Now only single refresh via observable.
* Remove fixed time waits from gitLog.feature and fix race condition
- Remove all fixed time wait steps from gitLog.feature (14 instances)
- Remove redundant triggerRefresh calls in handleCommitSuccess/Revert/Undo
- Add loadGitLogInProgress guard to prevent concurrent loadGitLog
- Root cause: commit triggered 2 refreshes causing race condition
- Only gitStateChange\$ observable now triggers refresh
- All 4 gitLog tests pass locally
* Fix clear timing: clear log BEFORE commit, not after
Root cause: test cleared git-log-refreshed AFTER commit completed
- But commit already triggered refresh and logged git-log-refreshed
- Clear deleted it, then test waited for new log that would never come
- Solution: clear BEFORE clicking commit button
- This way commit's git-log-refreshed is the first one after clear
Test now passes locally.
* Update cleanup.ts
* Initial commit when init a new git.
* Refactor feature steps for multi-element and log marker tables
Updated multiple feature files and step definitions to support table-driven steps for clicking and asserting multiple elements, and for waiting for multiple log markers in sequence. This reduces redundant waits, improves test reliability, and streamlines Gherkin syntax for multi-element actions and assertions. Also removed unnecessary manual wait steps where content or element checks now handle waiting automatically.
* Minor code cleanup and formatting improvements
Reordered imports in browserView.ts, fixed whitespace in cleanup.ts and useGitLogData.ts, and improved line formatting in GitLog/index.tsx for better readability and consistency.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: tidgi <tiddlygit@gmail.com>
201 lines
8.5 KiB
Markdown
201 lines
8.5 KiB
Markdown
# Deal with error when pnpm start
|
||
|
||
## `Uncaught ReferenceError: require is not defined`
|
||
|
||
Or `Uncaught TypeError: Cannot read properties of undefined (reading 'call') at __webpack_require__ (index.js:4317:33)`
|
||
|
||
`pnpm run clean:cache` can fix this.
|
||
|
||
## Electron download slow
|
||
|
||
Add `.npmrc` on this project (sometimes the one at home folder is not working).
|
||
|
||
```npmrc
|
||
electron-mirror=https://registry.npmmirror.com/-/binary/electron/
|
||
electron_custom_dir={{ version }}
|
||
```
|
||
|
||
and run `node node_modules/electron/install.js` manually.
|
||
|
||
## Preparing native dependencies `Error: ENOENT: no such file or directory, stat 'xxx/node_modules/.pnpm/node_modules/@types/lodash-es'`
|
||
|
||
Or `[FAILED: ENOENT: no such file or directory, stat 'C:\Users\linonetwo\Documents\repo-c\TidGi-Desktop\node_modules\.pnpm\node_modules\@radix-ui\react-compose-refs']`
|
||
|
||
Remove it by run `rm 'xxx/node_modules/.pnpm/node_modules/@types/lodash-es'` fixes it. Maybe pnpm install gets interrupted, and make a file-like symlink, get recognized as binary file. Remove it will work.
|
||
|
||
## An unhandled rejection has occurred inside Forge about node-abi
|
||
|
||
Solution: Update `@electron/rebuild` to latest version:
|
||
|
||
```shell
|
||
pnpm up @electron/rebuild@latest
|
||
```
|
||
|
||
## Fetch failed at fetchAvailableUpdates
|
||
|
||
We use [electron-chrome-web-store](https://github.com/samuelmaddock/electron-browser-shell/blob/master/packages/electron-chrome-web-store/README.md) to load react dev tools, so you need to add `https://clients2.google.com/service/update2/crx` to your Clash/Proxifier list. May need to enable system proxy and TUN mode or so.
|
||
|
||
## Finalizing package postPackage error
|
||
|
||
Add `DEBUG=electron-packager` to package, like:
|
||
|
||
`cross-env NODE_ENV=production DEBUG=electron-packager electron-forge make --platform=win32 --arch=x64`
|
||
|
||
<https://github.com/electron/forge/issues/3645>
|
||
|
||
Usually you need to fix [scripts\afterPack.js](../scripts/afterPack.js)
|
||
|
||
If use pnpm, need to copy dependency binary from `.pnpm` folder, but if add `node-linker=hoisted` to [.npmrc](../.npmrc) then we can simply copy from node_modules folder.
|
||
|
||
## no such file or directory dprint
|
||
|
||
> no such file or directory, stat 'TiddlyGit-Desktop/node_modules/.pnpm/node_modules/@dprint/darwin-arm64'
|
||
|
||
Solution:
|
||
|
||
```sh
|
||
pnpm store prune
|
||
pnpm uninstall dprint
|
||
pnpm i -D dprint -f
|
||
```
|
||
|
||
## node-gyp failed to rebuild
|
||
|
||
```js
|
||
Running generateAssets hook
|
||
|
||
› TOUCH ba23eeee118cd63e16015df367567cb043fed872.intermediate
|
||
ACTION deps_sqlite3_gyp_locate_sqlite3_target_copy_builtin_sqlite3 ba23eeee118cd63e16015df367567cb043fed872.intermediate
|
||
TOUCH Release/obj.target/deps/locate_sqlite3.stamp
|
||
CC(target) Release/obj.target/sqlite3/gen/sqlite3/sqlite3.o
|
||
LIBTOOL-STATIC Release/sqlite3.a
|
||
Usage: /opt/anaconda3/bin/libtool [OPTION]... [MODE-ARG]...
|
||
Try 'libtool --help' for more information.
|
||
libtool: error: unrecognised option: '-static'
|
||
make: *** [Release/sqlite3.a] Error 1
|
||
rm ba23eeee118cd63e16015df367567cb043fed872.intermediate
|
||
Error: `make` failed with exit code: 2
|
||
at ChildProcess.onExit TiddlyGit-Desktop/node_modules/.pnpm/node-gyp@9.4.0/node_modules/node-gyp/lib/build.js:203:23)
|
||
at ChildProcess.emit (node:events:511:28)
|
||
at ChildProcess._handle.onexit (node:internal/child_process:293:12)
|
||
|
||
An unhandled rejection has occurred inside Forge:
|
||
Error: node-gyp failed to rebuild '/Users/linonetwo/Desktop/repo/TiddlyGit-Desktop/node_modules/.pnpm/better-sqlite3@8.4.0/node_modules/better-sqlite3'
|
||
at ChildProcess.<anonymous> TiddlyGit-Desktop/node_modules/.pnpm/@electron+rebuild@3.2.13/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:118:24)
|
||
at ChildProcess.emit (node:events:511:28)
|
||
at ChildProcess._handle.onexit (node:internal/child_process:293:12)
|
||
ELIFECYCLE Command failed with exit code 1.
|
||
```
|
||
|
||
Solution:
|
||
|
||
```sh
|
||
node_modules/.bin/electron-rebuild -f -w better-sqlite3
|
||
```
|
||
|
||
## Error: The module '/Users/linonetwo/Desktop/repo/TidGi-Desktop/node_modules/opencv4nodejs-prebuilt/build/Release/opencv4nodejs.node'
|
||
|
||
```log
|
||
was compiled against a different Node.js version using
|
||
NODE_MODULE_VERSION 127. This version of Node.js requires
|
||
NODE_MODULE_VERSION 135. Please try re-compiling or re-installing
|
||
the module (for instance, using `npm rebuild` or `npm install`).
|
||
```
|
||
|
||
(The number above is smaller)
|
||
|
||
Don't use `npm rebuild` or `npm install`, it doesn't works, it will still build for nodejs. We need to build with electron:
|
||
|
||
```sh
|
||
./node_modules/.bin/electron-rebuild
|
||
```
|
||
|
||
See <https://github.com/justadudewhohacks/opencv4nodejs/issues/401#issuecomment-463434713> if you still have problem rebuild opencv for @nut-tree/nut-js
|
||
|
||
## During test, The module 'node_modules\better-sqlite3\build\Release\better_sqlite3.node' was compiled against a different Node.js version using
|
||
|
||
```log
|
||
NODE_MODULE_VERSION 135. This version of Node.js requires
|
||
NODE_MODULE_VERSION 127. Please try re-compiling or re-installing
|
||
the module (for instance, using `npm rebuild` or `npm install`).
|
||
```
|
||
|
||
(The number above is larger)
|
||
|
||
Don't need to recompile, nodejs and electron have different NODE_MODULE_VERSION. You need to run test using electron as nodejs.
|
||
|
||
```sh
|
||
cross-env ELECTRON_RUN_AS_NODE=true ./node_modules/.bin/electron ./node_modules/vitest/vitest.mjs run
|
||
```
|
||
|
||
### 测试运行有中文乱码 `鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆[4/4]鈳?`
|
||
|
||
救急可以用 `chcp 65001 && pnpm run test:unit`,如果有空重启电脑,则在时区设置里找到「系统区域设置」里勾选「Unicode Beta版」,重启即可。
|
||
|
||
## Command failed with exit code 1
|
||
|
||
When you see an error like:
|
||
|
||
```log
|
||
ELIFECYCLE Command failed with exit code 1.
|
||
```
|
||
|
||
This is a generic error and the real cause is usually shown earlier in the log. Sometimes, the actual error is hidden. You can set `DEBUG=electron-packager` to get more detailed logs (see [Show electron-packager debug logs](./Development.md#show-electron-packager-debug-logs)).
|
||
|
||
For example, after setting the debug variable, you may see:
|
||
|
||
```log
|
||
An unhandled exception has occurred inside Forge:
|
||
listen EACCES: permission denied 0.0.0.0:9000
|
||
Error: listen EACCES: permission denied 0.0.0.0:9000
|
||
```
|
||
|
||
This means the port 9000 is not accessible, possibly due to permission issues or the port already being in use. Try disable some startup service and restart computer. Some app may occupies port for its own use on startup.
|
||
|
||
## RangeError: Maximum call stack size exceeded at cloneObjectDeep
|
||
|
||
```js
|
||
const esbuild = require('esbuild');
|
||
//...
|
||
implementation: esbuild,
|
||
```
|
||
|
||
If tried to add this to `esbuildLoaderRule` will cause this error. The object contains an internal reference chain (`.default.default`) that triggers recursion when webpack-merge/clone-deep attempts to merge it.
|
||
|
||
## Error: Can't resolve 'os' in
|
||
|
||
```log
|
||
@ ./src/services/libs/i18n/i18next-electron-fs-backend.ts 3:0-44 147:10-22 172:10-22
|
||
@ ./src/services/libs/i18n/renderer.ts 4:0-77 8:20-37
|
||
@ ./src/renderer.tsx 20:0-65 36:5-21
|
||
|
||
ERROR in ./node_modules/winston/dist/winston/transports/stream.js 26:9-22
|
||
Module not found: Error: Can't resolve 'os' in 'C:\Users\linonetwo\Documents\repo-c\TidGi-Desktop\node_modules\winston\dist\winston\transports'
|
||
|
||
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
|
||
This is no longer the case. Verify if you need this module and configure a polyfill for it.
|
||
|
||
If you want to include a polyfill, you need to:
|
||
- add a fallback 'resolve.fallback: { "os": require.resolve("os-browserify/browser") }'
|
||
- install 'os-browserify'
|
||
If you don't want to include a polyfill, you can use an empty module like this:
|
||
resolve.fallback: { "os": false }
|
||
```
|
||
|
||
Usually because you import the server-side `logger` in renderer process code. You have to use `console` or add new transport in [rendererTransport.ts](src/services/libs/log/rendererTransport.ts).
|
||
|
||
## Error: ENOTDIR, not a directory at createError or supportedLanguages.json: ENOENT
|
||
|
||
May be `src/constants/paths.ts` have wrong value of `__dirname` or `process.resourcesPath` after package, like being `C:\Users\linonetwo\Documents\repo-c\TidGi-Desktop\out\TidGi-win32-x64\resources\app.asar\xxx`
|
||
|
||
Check `src/constants/appPaths.ts` and `src/constants/paths.ts`
|
||
|
||
## error: Your local changes to the following files would be overwritten by checkout
|
||
|
||
Clean up the local `template/wiki` folder. You can simply "Discard change" of that path, using github desktop.
|
||
|
||
## Any error that persist and is from old version of package in node_modules
|
||
|
||
Like you use `pnpm link`, you update the package on another side, but this side is not changed.
|
||
|
||
Try clean the cache by `pnpm run clean:cache`.
|