Cucumber step timeout = 120s (safety net, rarely reached).
Playwright element timeout = 10s (fast fail for missing elements).
Playwright system operations = 120s (process launch, window management).
Log marker wait = 120s (generous ceiling with internal retries).
Quick failures come from PLAYWRIGHT_TIMEOUT (10s), not cucumber.
System operations have room to complete without timeouts.
electron.launch, firstWindow, waitForLoadState are system-level
operations (process creation, window management), not test assertions.
They need generous timeouts independent of measured step time.
Cucumber step timeout still catches truly hung test steps.
electron.launch() is a system-level process creation, not a test step.
It needs a generous timeout independent of measured step time. The
cucumber step timeout (measured from calibration) handles step-level
hangs, but the Playwright-level launch needs room for process startup.
Light operations (element finding, clicks, typing):
- PLAYWRIGHT_TIMEOUT: 10s fixed - fail fast on missing elements
- PLAYWRIGHT_SHORT_TIMEOUT: 5s - very fast checks
Heavy operations (app launch, page load, watch-fs):
- HEAVY_PLAYWRIGHT_TIMEOUT: calibrated - scales with hardware
- CUCUMBER_GLOBAL_TIMEOUT: calibrated - per-step budget
- LOG_MARKER_WAIT_TIMEOUT: calibrated - log markers
Also increase UI_RETRY_ATTEMPTS to compensate for shorter element timeouts
on slower machines (retries based on calibration multiplier).
- Rewrite getLocatorCenter to use page.evaluate instead of locator.evaluate
to avoid Playwright locator resolution timeout on CI
- Add checkbox state verification after unchecking useTidgiConfig
- Rename default workspace in @no-tidgi-config-restart to avoid name collision
causing wrong workspace update
- Memoize sortable data to prevent dnd-kit re-registration loops when
workspaces$ emits new object references (#900)
- Deduplicate workspaces$ and groups$ emissions in main process to
suppress unnecessary renderer re-renders
- Debounce drag state updates to avoid React Maximum update depth
exceeded errors during rapid onDragMove/onDragOver events
- Fix customCollisionDetection priority so own group header outranks
nearby workspace collisions, enabling ungroup on header drop
- Stabilize allDraggableIds during drag by deriving from canonical
order only, avoiding SortableContext re-registration loops
- Clear workspaceGroups during E2E test cleanup to prevent stale
groups from previous runs
- Add pageerror/console.error capture in E2E drag helpers for
diagnosing renderer crashes
Performance & Architecture:
- Remove redundant live DOM fallback (MeasuringStrategy.Always makes it unnecessary)
- Simplify customCollisionDetection by relying on dnd-kit's always-fresh rects
- Remove 16ms delay in handleDragEnd (caused more issues than it solved)
UI Fixes:
- Fix page workspace names showing English instead of i18n during drag
- Add getBuildInPageName/Icon to DragOverlay for proper translation
E2E Test Coverage (6 new scenarios):
- Rapid drag cancellation with Escape key
- Drag workspace from collapsed group
- Cross-group workspace drag
- Reorder workspaces within same group
- Reorder group headers
- Drag ungrouped workspace to zone of grouped workspace
Known Issues (to be addressed separately):
- Group header reordering shows ghost but doesn't commit (backend observable issue)
- Some new E2E tests failing due to zone visibility in grouped contexts
- Add MeasuringStrategy.Always to force dnd-kit to remeasure droppable rects before each collision detection
- Add live DOM rect fallback in customCollisionDetection for group header detection when dnd-kit cache is stale
- Refactor drag state model to use single projected-state source of truth for both preview and drop behavior
- Fix E2E drag helper to measure target coordinates after drag activation to avoid stale positions
- Remove zone droppable registration, use pointer-events:none zone divs for E2E targeting only
- Add hover-and-release E2E test scenario
- Remove unused getPointerYFromDragEvent helper
- All 9 workspace-group E2E scenarios now pass
- Add workspaceGroup.feature with 8 test scenarios
- Implement step definitions for group operations
- Cover create/rename/delete groups
- Test drag-and-drop functionality
- Test collapse/expand behavior
- Verify DOM structure with data-testid attributes
workspaceConfig.feature - two new scenarios:
1. @no-tidgi-config: Import wiki without tidgi.config.json keeps config local
- Creates a synced wiki (SyncedWiki), verifies tidgi.config.json written
- Imports same folder again WITHOUT useTidgiConfig checkbox
- Renames second workspace to LocalWiki - verifies tidgi.config.json NOT modified
- Sets readOnlyMode=true on LocalWiki - verifies it does NOT leak into tidgi.config.json
- Verifies both workspaces visible and useTidgiConfigSync=false in settings.json
2. @no-tidgi-config-restart: Non-synced workspace config survives restart
- Imports wiki as BlogDeploy with readOnlyMode=true and no tidgi.config sync
- Verifies readOnlyMode never written to tidgi.config.json
- Restarts app and verifies BlogDeploy still present with correct settings
wiki.ts step definitions:
- Add 'file {string} should not contain JSON with:' step for asserting
sensitive config values are absent from tidgi.config.json
* fix: hide non-wiki workspaces from menu and disable remove for them (#694)
* fix(workspace): make workspace settings save transactional to prevent data loss
- Move disk write before memory update in Workspace.set()
- Remove error swallowing in writeTidgiConfig() to let errors propagate
- Add error handling in useForm.ts to catch and log save failures
- Add UI error display in EditWorkspace/index.tsx
- Only update Observable after successful persistence
This fixes the issue where save button disappears but changes aren't
persisted to tidgi.config.json, causing data loss when reopening settings.
* feat(i18n): add error messages for workspace save failures
Add SaveError and SaveErrorPrefix translations in English and Chinese
to display error messages when workspace settings fail to save.
* test(e2e): add test for tagNames persistence and missing step definitions
- Add @edit-workspace-save-tagnames scenario to verify tagNames persist
after save to tidgi.config.json
- Add 'I clear and type' step definition for clearing input before typing
- Add 'I close current window' step definition for closing windows
- This test covers the regression where save button disappears but
changes aren't persisted
* use 5.4.0
* fix: spaced file in git op
* fix: menu register race condition
* Update pnpm-lock.yaml
* Update wiki
* fix: regenerate lockfile with pnpm 10.33.0 to fix checksum format
* fix: remove unused import and useless constructor
* fix: address Copilot review comments
- Use new path for rename/copy in git operations
- Ensure transactional workspace save (persist before cache update)
- Normalize null label to undefined in menu
* Remove close-window step; simplify UI typing
Remove the Cucumber step that closed the current window and simplify a UI step by calling locator.fill(...) inline (also replace {tmpDir} in the input). Clean up minor whitespace in gitOperations and fix indentation/extra brace around startWiki error handling in the wiki service to correct control flow and prevent accidental scope issues.
* Improve workspace form, git diff, and UI tests
Refactor EditWorkspace form and UI behavior, make git diff/status handling more robust, and update E2E tests.
- Add hasConfigChanges and related effects in useForm to correctly detect config-only changes and control restart requests; fix save button visibility in EditWorkspace and pass currentWorkspace to restart snackbar. Rename workspace section test id from 'workspace-section-search' to 'preference-section-search'.
- Enhance gitOperations.getFileDiff to use porcelain -z and a helper to parse per-path status (getPorcelainStatusForPath) for reliable untracked/deleted detection.
- Add clickBrowserViewElementWithRetry helper with backoff and text-aware selector handling; replace repetitive click logic in browser view step definitions and remove some redundant browser background assertions and a deprecated clear-and-type step.
- Update feature files (gitLog, editWorkspace, vectorSearch) to reflect selector/id/name changes and i18n fallbacks for tab/button text.
* doc
* Use localized draft selector and show e2e window
Update feature tests to target the localized draft tiddler title (data-tiddler-title$='的草稿') instead of the English prefix selector. Applied the change across features/hibernation.feature and features/tiddler.feature to ensure selectors match localized UI. Also enable SHOW_E2E_WINDOW=1 in the test:manual-e2e script in package.json so manual end-to-end runs open a visible window for debugging.
* fix: move useState/useEffect before conditional early return to fix hooks order error in search mode
* feat: hide friendLinks section from preferences
* feat: add search entry in preferences sidebar that focuses the search input
* feat: remove friendLinks section entirely and split Preference.Search i18n key
* feat: add search entry in workspace sidebar, fix search section title key
* fix: include custom items in search and render info cards in search results
* feat: add missing items to sync/externalAPI/aiAgent schemas for search coverage
* feat: add EmbeddingSection, wire workspace search section, remove old search result views
* fix: apply dark/light palette before serving getIndex to fix startup theme race
* feat: add receiveBundleAndFetch for bundle-based mobile push
* track latest tiddlywiki5 prerelease
* Revert "fix: apply dark/light palette before serving getIndex to fix startup theme race"
This reverts commit e1c096439d.
* Reimplement "fix: apply dark/light palette before serving getIndex to fix startup theme race"
This reverts commit e1c096439d.
* feat: expose runGitCommand, writeTempGitFile, deleteTempGitFile for plugins
Allow TiddlyWiki plugins (like tw-mobile-sync) to run arbitrary git commands
and manage temp files in the .git directory. This reduces the need to rebuild
TidGi Desktop when changing git-related plugin behavior.
Methods include path traversal protection for writeTempGitFile/deleteTempGitFile.
* refactor: replace receiveBundleAndFetch/mergeAfterPush with generic methods
- Removed receiveBundleAndFetch (logic moved to tw-mobile-sync plugin)
- Removed mergeAfterPush (logic moved to tw-mobile-sync plugin)
- Added readWorkspaceFile and writeWorkspaceFile for plugin file I/O
- runGitCommand, writeTempGitFile, deleteTempGitFile remain for plugin git operations
- All mobile-sync-specific logic now lives in the tw-mobile-sync plugin
* test(e2e): deduplicate browser-view palette steps and merge palette scenarios
* test(e2e): isolate palette outline examples by name
* test(e2e): decouple smoke logging assertion from worker lifecycle
* fix: persist workspace immediately on create to survive fast app close
Workspace.create() now calls set() with immediate=true so the new
workspace record is flushed to settings.json synchronously, before any
before-quit handler runs. Previously, if the app was closed while git
init was still running (but after workspace.create had returned), the
workspace record would only be in memory and would be lost on the next
launch, causing Find 0 existing wiki workspaces and a duplicate
default-wiki creation attempt.
Also move applyInitialPaletteBeforeIndexRender from startNodeJSWiki to
IpcServerRoutes.getIndex so the palette is applied on every index
render instead of only at server startup, and thread shouldUseDarkColors
through ipcServerRoutes.setConfig for the same reason.
Rename args param to gitArguments in GitServerService.runGitCommand to
avoid shadowing the outer variable and fix the ESLint no-shadow warning.
* test(e2e): fix browser-view step and wiki-worker restart timing
browserView.ts: replace fixed 10-attempt backoff with a polling loop
that fills the full 25 s Cucumber step budget (210 fast polls), because
WebContentsView creation is async and each failed poll returns in < 1 ms
(no webContents yet), making the old 10-attempt window too narrow.
wiki.ts: replace WIKI_WORKER_STARTED wait before restart with
VIEW_LOADED wait. WIKI_WORKER_STARTED is only written on the direct
startWiki() path; when the app starts via restartWorkspaceViewService
the marker is never emitted. VIEW_LOADED fires after did-stop-loading
and is a reliable proxy that the wiki worker is running and the view is
ready.
application.ts: add launchEnvOverrides map to ApplicationWorld and
thread it into the Electron launch env so scenarios can inject test-only
env vars (e.g. TIDGI_E2E_MOCK_SYSTEM_PALETTE) without modifying the
shared process environment.
* test(e2e): fix @wiki scenario timing and assertions
defaultWiki.feature:
- Explicitly click workspace button before asserting browser-view in
Background; without a click the WebContentsView is never activated.
- Remove the VIEW_LOADED wait after workspace creation (redundant now
that browser-view step polls for the full step budget).
- Replace the fragile 'Test content for lazy-all' text assertion with a
structural check (open tiddler + confirm element exists); in lazy-all
mode TiddlyWiki renders tiddlers lazily so the body text is often the
sidebar/chrome rather than the tiddler body at assertion time.
- Remove the 'move back to wiki-test' tail of the move-workspace
scenario; test-artifacts are wiped before every run so there is no
need to restore the original location.
simplifiedWiki.feature:
- Wait for WORKSPACE_CREATED log marker before closing the app on first
launch; git-init inside initWikiGitTransaction can take several
seconds, and closing too early meant workspace.create() never ran,
leaving settings.json with no wiki workspace on the second launch.
windowRestore.feature:
- Replace the unreliable WIKI_WORKER_STARTED + VIEW_LOADED wait in
Background with WORKSPACE_CREATED + 'browser view should be loaded
and visible'; the former marker is not emitted on the
restartWorkspaceViewService path used at app startup.
* chore: update pnpm-lock and template/wiki submodule
* Update pnpm-lock.yaml
* test(e2e): remove unused browser view retry constants
* test(e2e): stabilize subwiki update and worker readiness wait
* fix: enforce LF line endings in .gitattributes to match .editorconfig
* feat(e2e): implement CPU-based dynamic timeout scaling
Add cpuBenchmark.ts to measure CPU performance at suite startup and derive
a performance multiplier (≥1.0) that scales all E2E timeouts. Fast machines
get tight timeouts for quick bug detection; slow machines get the room they
need without false timeout failures.
- cpuBenchmark.ts: Run ~200ms pure CPU workload, compare to reference (120ms)
- Local dev: enforce ≥1.8× floor (git I/O overhead not reflected in CPU score)
- CI: keep 1.0× (dedicated runners with known performance)
- timeouts.ts: Apply multiplier to CUCUMBER_GLOBAL_TIMEOUT and derived values
- Print diagnostic: [Timeout Config] multiplier=1.80× step budget=45000 ms
* fix(e2e): fix WorkerServicesReady marker search pattern
The log marker is written as 'test-id-WorkerServicesReady' (without brackets)
but tests were searching for '[test-id-WorkerServicesReady]' (with brackets).
ANSI color codes in logs further broke the pattern match.
Also implement proper marker clearing: wait for initial readiness, restart,
clear stale markers, then wait for fresh markers after restart.
Fixes 3 failing scenarios:
- AI button in Git Log window uses AI-generated commit message
- Plain backup button in Git Log window uses default message
- Move workspace to a new location
* fix(e2e): simplify isWikiRunning check to avoid TypeScript assertion in executeJavaScript
Remove TypeScript type assertion from executeJavaScript string code,
use runtime property checks instead to avoid script execution failure.
* Revert "fix(e2e): fix WorkerServicesReady marker search pattern"
This reverts commit 39f91256092d4ce402eb87b9b70d08c40a6d13fb.
* feat(e2e): increase MIN_MULTIPLIER to 2.0× for local dev
Increase from 1.8× to 2.0× to provide 100% timing cushion for slow
machines. This gives 50s timeout budget (25s base × 2.0) which should
be sufficient for browser view loading and wiki worker operations.
* fix: restore lazy AI deleted test. don't delete test, otherwise I will add it back
* feat(e2e): auto-calibrate timeout using @smoke scenario
Remove MIN_MULTIPLIER hack and synthetic CPU benchmark. Instead:
- @smoke scenario automatically measures real E2E performance
- Hooks record duration and calculate multiplier vs CI baseline
- Pure measurement-based scaling, no hardcoded floors
- Fallback to 3.0× only if smoke hasn't run yet
This captures the full stack (CPU, I/O, Electron startup, rendering) in
one real-world measurement, eliminating guesswork. No separate calibration
command needed - just run tests normally.
* fix(e2e): exclude test files from cucumber require pattern
* fix: should save $:/layout
* chore: update 5.4.0 prerelease
* Update test.yml
* fix: Some repo is clone from github, use https to avoid ssh key issue
delete the lock file and pnpm i regenerate fix this
* lint
* fix(ci): restore search section and precompute E2E timeout calibration
Restore the missing search preferences section so schema validation passes in CI.
Also move E2E timeout calibration ahead of cucumber startup so timeout values
are computed before step modules freeze their constants. Use the smoke scenario
as a real-world baseline and derive a heavier timeout family for restart and
browser-view operations that are dominated by I/O and Electron lifecycle work
on slow machines.
* fix(sync): restore mobile merge-after-push hook
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* test(e2e): stabilize selector waits and calibration state
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* test(e2e): remove invalid pre-restart worker wait
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* fix(preferences): remove global embedding section
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* test(e2e): move vector search flow to workspace settings
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* fix(vector-search): validate sqlite row ids before storing embeddings
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* feat(git-log): add multi-select batch actions
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* fix(git-log): support multi-commit undo, fix path traversal, fix search l10n, fix sidebar divider
* fix(test): use data-testid for undo button selector in E2E test
UndoCommit translates to '撤回此提交' in zh-Hans, not '撤销'.
Use data-testid='undo-commit-button' for reliable matching.
* fix(git-log): batch undo via undoCommits, notify git log on tiddler save
- Add undoCommits() to git service: undoes N commits sequentially and fires
only ONE gitStateChange notification at the end, avoiding the race where
rapid-fire events drop refreshes due to loadGitLogInProgress guard
- CommitDetailsPanel.handleUndo now uses undoCommits() instead of looping undoCommit()
- FileSystemAdaptor.saveTiddler now calls git.notifyFileChange after every save
so the git log window auto-refreshes when tiddlers are created/modified, even
when enableFileSystemWatch is false (the default)
* fix(test): mock git.notifyFileChange in FileSystemAdaptor unit tests
* fix(e2e): use BrowserWindow.id to match tidgiMiniWindow Playwright page
The previous code matched the mini window's Playwright page by document.title,
checking for '太记小窗', 'TidGi Mini Window', or 'TidGiMiniWindow'. But the
mini window loads the same index.html as the main window (title='TidGi'), so the
title-based match fails whenever React hasn't yet updated document.title.
Fix: after finding the BrowserWindow by title (getTitle() contains 'Mini Window')
or by dimensions as a fallback, compare each Playwright Page's underlying
BrowserWindow.id to the found window's id. This is reliable regardless of
document.title state.
* fix(lint): remove unnecessary non-null assertion in application.ts
* fix(lint): rename args to searchParams to satisfy unicorn/prevent-abbreviations
* fix(lint): rename searchParams to searchParameters
* fix(window): wait for isVisible() after showWindow() in test mode
In E2E tests, BrowserWindow.show() is asynchronous with respect to
isVisible() returning true. The IPC call to toggleTidgiMiniWindow()
resolves before the OS has actually marked the window as visible,
causing the subsequent 'confirm visible' step to fail.
Add a poll-until-visible loop (50ms interval) after showWindow()
when isTest is true, so the IPC only resolves once isVisible() is
actually true.
---------
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
* chore: upgrade Electron 39->41, forge 7.10->7.11, fix native ABI and preload naming
- electron: 39.2.3 -> 41.1.1
- @electron-forge/*: 7.10.2 -> 7.11.1
- better-sqlite3: 12.4.5 -> 12.8.0 (rebuild against Electron 41 ABI 145)
- electron-unhandled: 5.0.0 -> 4.0.1 (v5 uses top-level await, breaks CJS main build)
- vite.preload.config.ts: emit preload.js (not index.js) to avoid collision with main
- viteEntry.ts: getPreloadPath() -> preload.js, renderer path unchanged
- package.json main: .vite/build/main.js (matches forge lib output)
- package.json: strip UTF-8 BOM that broke Volta manifest parsing
* fix: resolve AbortSignal realm mismatch in Electron 41 for streaming tests
In Electron 41, ELECTRON_RUN_AS_NODE mode uses Chromium-based fetch which
requires Blink's AbortSignal. Node.js AbortSignal fails the instanceof check.
Fixes:
- vitest.config.ts: set features/** to node environment via environmentMatchGlobs
so HTTP-only tests use Node.js fetch (not Chromium fetch)
- setup-vitest.ts: guard all document/window access behind typeof document check
so setup is safe in both jsdom and node environments
- callProviderAPI.ts: no change needed (signal issue is env-specific)
* ci: increase test timeout to 60min, fix find -o with xargs rm
- timeout-minutes: 25 -> 60 (packaging ~22min + unit tests ~1min + e2e needed)
- fix 'find ... -o ... | xargs rm' -> 'find ... \( -o \) ... -exec rm -rf {} +'
(the unparenthesized -o with xargs caused 'rm: invalid option -- o' in CI)
* fix: copy tiddlywiki/core-server to packaged output
TiddlyWiki 5.4.0-prerelease introduced core-server/ directory which contains
commander.js (module-type: global). Without it, \.Commander is undefined
when load-modules.js startup runs \.Commander.initCommands(), crashing the
wiki worker with 'Cannot read properties of undefined (reading initCommands)'.
core-server is loaded by boot.js via loadPluginFolder(\.boot.coreServerPath),
which silently returns null when the directory is missing, so the error was
non-obvious and only manifested when actually starting a wiki workspace.
* perf: only screenshot on failure, revert timeout to 25min
AfterStep was capturing a screenshot after every step (~1191 of 1446 steps).
Each screenshot requires IPC round-trip: getFirstWebContentsView capturePage
serialize PNG transfer buffer fs.writeFile. On CI this costs ~200-400ms
per step, totaling ~6 minutes of pure screenshot overhead.
Now screenshots are only taken for FAILED steps, saving ~6 minutes on CI.
This brings the total test time well within the 25-minute budget.
* fix: flaky tests + merge scenarios to save 8 Electron launches
- crossWindowSync: wait for tiddler to be saved to disk via watch-fs before opening second window
- tidgiMiniWindowWorkspace: add retry backoff to 'should not see elements' step
- tidgiMiniWindow: add explicit window switch after addTiddler
- Merge 5 filesystemPlugin scenarios into 1 (save 4 launches)
- Merge 2 defaultWiki scenarios into 1 (save 1 launch)
- Merge 2 preference scenarios into 1 (save 1 launch)
- Merge smoke + logging into 1 (save 1 launch)
- Merge 2 tiddler scenarios into 1 (save 1 launch)
- Total: 65 57 scenarios (8 fewer Electron launches)
* fix: address CI failures - use IPC for mini window toggle, split talkWithAI clicks
- tidgiMiniWindow: use direct IPC toggle instead of keyboard shortcut after addTiddler
to avoid race condition between TW syncer and keyboard event dispatch
- talkWithAI: split multi-click step into individual clicks so each gets its own
25s timeout budget on CI
* fix: await showWindow() in openTidgiMiniWindow to prevent race condition
The two showWindow() calls were using void (fire-and-forget), meaning
toggleTidgiMiniWindow returned before the window was actually shown.
On CI/Xvfb, the test checked isVisible() before show() completed.
* perf: merge scenarios + split CI steps for faster E2E
- Merge 3 defaultWiki scenarios into 1 (save 2 app launches)
- Merge 2 scheduledTask scenarios into 1 (save 1 app launch)
- Split CI test step into unit/prepare/e2e for visibility
- Add pnpm store cache to CI
- Fix viteEntry.ts: remove UTF-8 BOM, update stale JSDoc comment
- Set E2E timeout to 22min (was 25min in single step)
* fix: address Copilot review - main window lookup and comment clarity
- tidgiMiniWindow.ts: use index.html URL pattern to find main window
(consistent with other step defs, avoids matching preferences window)
- ui.ts: clarify networkidle timeout comment
* fix: use IPC toggle for tidgiMiniWindow sync scenario to avoid flaky keyboard shortcut on CI
---------
Co-authored-by: CI Auto <cidevel@tiddlygit.local>
* Use git service for backups and dynamic AI menus
Switch backup actions to call gitService.commitAndSync(commitOnly) so local backups work without remote auth and AI commit generation is triggered by omitting commitMessage. Make AI-related menu items always registered but use dynamic visibility/enabled checks (isAIEnabled) so they appear/disappear at runtime. Update menu item types/imports accordingly. Optimize workspace persistence to write only the single updated workspace to settings.json (stripping syncable fields when tidgi.config exists) instead of saving all workspaces; remove the old saveWorkspacesToSettings method. Add warnings/logging: warn if git worker observable is undefined, log/notify when cloud sync is skipped due to missing auth/gitUrl. Misc: remove a redundant debug log in tidgiConfig, remove native process monitoring startup call, include commitMessage for CommitDetailsPanel sync, and drop entriesFingerprint/debug noise from git log data.
* fix: avoid rewriting unchanged workspace config
* fix: separate plain and ai backup flows
* feat: add searchable settings views
* fix: narrow sync adaptor revision type
* chore: release tidgi-shared 0.1.3
* Preferences: unify Scheduled/Background tasks and fix skeleton nav
- Remove legacy background task UI/dialogs (use ScheduledTask unified system)
- Attach invisible anchors to skeleton placeholders so sidebar scrollIntoView works while loading
- Add English/zh translation keys for AddAlarm/AddHeartbeat
- Add requestIdleCallback polyfill (tests) and speed up to 0ms for tests
- Search: match English translations (txEn) in SearchResultsView
* Fix view zero-size on minimize; realign on restore/show
Guard view bounds from 0x0 content size to prevent BrowserView disappearing when window is minimized; fall back to safe offscreen size. Add window 'restore' and 'show' handlers to realign views. Add getMemoryUsage() in wiki worker and expose RSS/heap via getWorkersInfo; show worker memory in Developer Tools diagnostics.
* Fix background/quit behavior: synchronous close handler; platform-specific runOnBackground default; add getWindowMetaSync; add forced-exit timeout for before-quit cleanup
* Refactor preferences: add definitions and registry
Add a new structured preferences system: introduce definition schemas, typed item/section types, explicit section files, a registry (allSections/sectionById), side effects, action handlers, and helper builders (zodPreferencesSchema). Add custom preference UI items and registration (customItems, registerCustomSections) and tests validating schemas. Replace previous zod/settings schema files with the new definitions and make IPreferences an explicit TypeScript interface. Small UI updates: use LanguageSelectorItem and WikiUserNameItem in Guide and Help pages. Also remove net.isOnline() pre-checks from Git.commitAndSync and Git.forcePull to avoid false-negative network detections.
* Fix blank wiki after hide+reopen: re-attach orphaned views on realign
Root cause: three compounding issues when the main window is hidden and then re-shown via a second-instance shortcut click.
1. getView() now auto-removes stale entries whose webContents.isDestroyed() == true.
This allows addView() / showWorkspaceView() to recreate destroyed views instead of
silently skipping them (which left the new window blank).
2. realignView() now calls browserWindow.contentView.addChildView(view) before setBounds().
If a view survived window destruction but became orphaned (detached from its parent
BrowserWindow), re-attaching it makes it visible again. addChildView is idempotent
so normal re-entrant calls are safe.
3. window.open() existing-window branch now calls addViewForAllBrowserViews(activeWorkspace)
before realignActiveWorkspace(). This ensures that any destroyed/missing view is
recreated BEFORE the realign attempts to reposition it. The call is a no-op when
views already exist and are healthy.
* Fix blank WebContentsView after restoring hidden window (Windows bug)
Electron on Windows sometimes fails to repaint a WebContentsView that remains attached to a window that is hidden and then shown again. By unconditionally calling \
emoveChildView\ followed by \ddChildView\ during \
ealignView\ and \showView\, we force the Chromium compositor to reparent and paint the view correctly, ensuring the Wiki becomes visible as soon as the user restores the app from the background.
* Fix blank WebView on window restore: show view before realign, fix same-workspace click
Two root causes identified and fixed:
1. openWorkspaceTiddler silently skipped setActiveWorkspaceView when the user
clicked the already-active workspace icon (guard: oldId !== newId). The view
was blank and clicking its icon did nothing. Guard removed setActiveWorkspaceView
is now always called; it is safe with the same ID (hibernation guard is already
correct for that case).
2. The 'show' event handler and window.open() existing-window path were calling
realignActiveWorkspace() which only calls setBounds. On Windows, when a window
transitions from hidden/background to visible the Chromium compositor may not
repaint a WebContentsView whose bounds have not changed. Both paths now call
refreshActiveWorkspaceView() a new lightweight helper that calls showView()
(removeChildView + addChildView + setBounds + webContents.focus) before realigning.
This forces a compositor repaint and makes the wiki page visible immediately.
* Refactor view restore chain: clean up redundant repaint/realign calls
Full chain analysis identified 4 structural problems:
1. refreshActiveWorkspaceView() called TWICE concurrently on window restore:
window.open() called existedWindow.show() which fired the 'show' event
refreshActiveWorkspaceView() AND THEN immediately called refreshActiveWorkspaceView()
again explicitly, creating a race condition on removeChildView+addChildView.
2. realignView() contained removeChildView+addChildView, which ran immediately after
showView() already did removeChildView+addChildView+setBounds+focus. The second
remove+add clobbered the focus state set by showView, breaking keyboard focus.
3. setActiveWorkspaceView() called showWorkspaceView + realignActiveWorkspace, meaning
the view was remove+add+setBounds+focused by showView, then immediately remove+add+
setBounds-without-focus again by realignView. Double bounds, lost focus.
4. Same pattern in refreshActiveWorkspaceView: showWorkspaceView + realignActiveWorkspace.
Clean design after refactor:
- showView() = force-repaint path: remove+add+setBounds+focus (unchanged)
- realignView() = bounds-only: setBounds ONLY, no remove+add
- showWorkspaceView = calls showView for main+mini windows
- realignActiveWorkspace = calls realignView (now just setBounds) + buildMenu;
used for fullscreen/sidebar/resize events
- setActiveWorkspaceView = showWorkspaceView + buildMenu (not +realignActiveWorkspace)
- refreshActiveWorkspaceView = showWorkspaceView + buildMenu (not +realignActiveWorkspace);
called from 'show' window event (fire-and-forget: no rethrow)
- window.open() existing-window = show() only; 'show' event handler calls
refreshActiveWorkspaceView automatically, no duplicate call
* chore: bump electron-ipc-cat to 2.4.0
Rolling Observable timeout (120s initial, 60s idle) fixes git-upload-pack
timeout for large repos (100+ MB) during mobile sync.
* style: unify layout between Preferences and EditWorkspace
Use PageRoot and PageInner from PreferenceComponents to eliminate subtle padding/background differences. Resize EditWorkspace window to match Preferences. Clean up lint errors.
* Add E2E test for window-restore blank-view bug + log markers
Two changes:
1. Log markers added to aid diagnosis and enable E2E verification:
- [test-id-VIEW_SHOWN] in ViewService.showView()
- [test-id-REFRESH_ACTIVE_VIEW_START/DONE] in WorkspaceView.refreshActiveWorkspaceView()
2. New E2E feature: features/windowRestore.feature
Scenario 1: 'Wiki WebContentsView is visible immediately after restoring hidden window'
- hides main window (same path as close+runOnBackground)
- triggers second-instance via app.emit('second-instance')
- asserts [test-id-REFRESH_ACTIVE_VIEW_DONE] and [test-id-VIEW_SHOWN] log markers
- asserts browser view is within visible window bounds
- asserts wiki content is readable
Scenario 2: 'Clicking already-active workspace icon re-shows the WebContentsView'
- verifies the removed oldId !== newId guard: clicking current workspace must
now call setActiveWorkspaceView which fires showView
Two step definitions added to features/stepDefinitions/application.ts:
- 'I hide the main window as if closing with runOnBackground'
calls BrowserWindow.hide() directly in main process
- 'I reopen the main window as second instance would'
emits app 'second-instance' event in main process
* Fix E2E test: correct second-instance emit args, add wiki-ready wait in Background
Three issues found and fixed by running the tests:
1. app.emit('second-instance') argument order wrong
DeepLinkService listener: (_event, commandLine) => commandLine.pop()
Our emit: app.emit('second-instance', [], process.cwd(), {})
This made 'process.cwd()' land in commandLine, .pop() failed on a string.
Fix: app.emit('second-instance', {}, [], '', {}) fake Event first,
then empty argv array, then workingDirectory.
2. In test mode, window.open() skips existedWindow.show() to avoid UI popups.
The 'show' event never fired so refreshActiveWorkspaceView was never called
and the window stayed hidden from Playwright's perspective.
Fix: explicitly call mainWindow.show() via app.evaluate() after emitting
second-instance, replicating what production window.open() does.
3. Background used 'the browser view should be loaded and visible' which has
a 21-second timeout and fails before TiddlyWiki finishes initializing in
the test environment (pre-existing issue in defaultWiki.feature too).
Fix: replaced with deterministic log marker waits:
[test-id-WIKI_WORKER_STARTED] + [test-id-VIEW_LOADED]
plus 'I confirm the main window browser view is positioned within visible
window bounds' for a structural check without content dependency.
Result: both @window-restore scenarios pass (31/31 steps green, ~48s).
* Fix reopened main window restore after recreation and rebind view resize
Root cause on Windows was not the hide/show path, but the close+recreate path when tidgi mini window keeps the app alive while runOnBackground is false.
What was actually happening:
1. The user closed the main window.
2. The app stayed alive because tidgi mini window still existed.
3. A second-instance launch recreated a new main BrowserWindow.
4. The old workspace WebContentsView still existed in ViewService.
5. But the new main window missed the automatic restore because the BrowserWindow 'show' event fired inside handleCreateBasicWindow() before registerBrowserViewWindowListeners() attached the 'show' listener.
6. If the user then clicked the workspace icon, showView() reattached the old view manually, but its resize listener was still bound to the old destroyed BrowserWindow, so resizing the new window no longer resized the view.
Fix:
- ViewService now rebinds the debounced resize handler every time showView() attaches an existing view to a BrowserWindow.
- Window.open() now detects the recreate-main-window case for BrowserView windows and immediately calls refreshActiveWorkspaceView() if the active workspace already has an existing view instance.
This restores the view without waiting for a workspace icon click.
Why old E2E missed it:
- It simulated hide/show (runOnBackground=true) instead of the real user path (main window close + app kept alive by tidgi mini window).
- It only checked that the view was within visible bounds; it did not resize the window and assert the view filled the content area after the reopen.
New E2E coverage:
- Configures tidgiMiniWindow=true and runOnBackground=false before launch.
- Closes the main window, reopens it via second-instance, verifies refresh/view-shown markers, verifies bounds, resizes the recreated main window, and asserts the BrowserView fills the content area after the debounced resize handler runs.
- Scenario passes locally: 1 scenario, 20 steps, all green.
* Update pnpm-lock.yaml
* fix: address Copilot PR review issues
- Restore workspaceID from window.meta() in EditWorkspace (was hard-coded debug value)
- Add missing React/type imports to customComponentRegistry.ts, workspaceCustomComponentRegistry.ts, registerCustomSections.tsx, registerWorkspaceCustomSections.tsx, useSections.ts
- Fix HighlightText regex: use index parity (odd index = match) instead of stateful regex.test() with global flag
- Fix actionHandlers native.pickDirectory to read current preference value instead of passing the key string as a path
- Move PreferenceComponents import before registerCustomSections() call to fix import ordering
* fix: fix import ordering to satisfy dprint/eslint format rules
* fix: stabilize e2e selectors and EditWorkspace loading fallback
- align workspace section testids in e2e features
- migrate background-task e2e to scheduled-task selectors
- add edit workspace fallback loading when metadata/observable is late
- add deterministic switch testid for schema boolean items
- make sync snackbar assertion resilient to progress text changes
- clear draft-check timeout handle in sync service
* fix: add apiKey to test provider config so isAIAvailable() returns true
The AI commit message e2e test expects both commit-now-button and
commit-now-ai-button to appear. The AI button only renders when
isAIGenerateBackupTitleEnabled() returns true, which internally calls
externalAPIService.isAIAvailable(). That method requires a non-empty
apiKey for openAICompatible providers, but the test's
createProviderConfig() never set one, causing isAIAvailable() to
return false and the AI button to never render.
* feat(gitServer): add generateFullArchive for fast mobile clone
- Add generateFullArchive() to IGitServerService interface
- Implement tar archive generation: git archive + system tar append
- Archives working tree + minimal .git metadata (HEAD, refs, objects)
- Cache by HEAD commit hash, auto-cleanup old archives
- Bump tidgi-shared to 0.1.5
* fix(e2e): resolve workspace by runtime name/folder in step defs
* fix(ci): satisfy lint rules in gitServer archive generation
* Improve IPC sync and multi-window browser views
Add robust revision tracking and per-title save serialization to the IPC sync adaptor to ignore stale SSE echoes and prevent overlapping saves (titlesBeingSaved, lastSavedRevisions, pendingSaveOperations, queueSaveOperation, markSaveStart/Finish). Ensure deletions and loads update stored revisions. Disable backgroundThrottling for BrowserWindow/WebContentsView so renderer callbacks (SSE/observables) continue while windows/views are hidden. Update webContents view helpers and step definitions to target a specific window/page (pass Page/currentWindow through executeInBrowserView, getTextContent, click/type/press helpers), and improve view selection by matching target window URL. Update docs to document hidden-window behavior and revision filtering, and add/update feature tests for cross-window sync, hidden TidGi mini window sync, and a rapid-save tiddler scenario.
* Handle main workspace routing for tiddlers
Adjust FileSystemAdaptor routing so that when a tiddler matches the main workspace it uses the main watch path (watchPathBase) instead of treating it as a sub-wiki folder. Add an isMainWorkspaceMatch check to pick the correct target directory and to avoid generating sub-wiki file info for the main workspace.
Also update tests and feature file: extend subWiki.feature to verify routing to the main workspace path when the workspace has a routing tag configured, and add unit tests to assert routing to the main wiki tiddlers folder and to the wiki root when useWikiFolderAsTiddlersPath is enabled.
* review
* v0.13.0-prerelease22
* fix: possible error on wiki creation
* Add isSubWiki/mainWikiToLink and optimize tidgi.config
Introduce new syncable wiki fields (isSubWiki, mainWikiToLink) with schema, types, and defaults; add localization for an autofill note. Expose Database.readWikiConfig over IPC and implement readTidgiConfig usage. When updating workspaces, only write tidgi.config.json if syncable fields actually changed to avoid redundant O(n) disk writes. Update AddWorkspace UI to eagerly read tidgi.config.json (when enabled) to pre-fill form fields and show a helper note. Improve workspace hibernation logic: avoid hibernating page workspaces' servers when switching and prevent concurrent duplicate hibernation calls. Also update template submodule reference.
* Update ErrorDuringRelease.md
* Fix workspace config sync and sub-workspace settings
* adjust menu
* Add sub-workspace UI, view navigation & types
Expose view navigation helpers and types, add sub-workspace UI and related translations, and introduce provider registry types.
- Add canGoBack/canGoForward/goBack/goForward APIs to view service and IPC interface to allow navigating embedded views.
- Implement UI for sub-workspace management in EditWorkspace: list bound sub-workspaces, open sub-workspace settings, and select main workspace for sub-wikis. Add tests IDs and small UX tweaks (cancel button test id).
- Update SaveAndSyncOptions and SubWorkspaceRouting to reflect new sub-workspace flows and remove deprecated main workspace path field.
- Add provider registry interface that re-exports external API types and IPC descriptor (src/services/providerRegistry/interface.ts).
- Add ambient type declarations for @modelcontextprotocol SDK client transports.
- Improve test/e2e support: detect packaged e2e runs via --test-scenario arg in environment constants, update step definition to open edit workspace via the window service using WindowNames, and adjust feature file assertions for sub-wiki bindings.
- Add English and Simplified Chinese translation keys for sub-workspace UI strings.
These changes enable managing sub-workspaces from the Edit Workspace window, provide programmatic view navigation, and add types/interfaces required for integrating external provider tooling and tests.
* fix lint
* Add diagnostics, process monitoring, and menu improvements
Add process diagnostics and monitoring: introduce shared processInfo types, native.getProcessInfo and startProcessMonitoring (30s snapshots + logs), label the main Node process and give descriptive initial window titles; include renderer PIDs in view info and log view creation. Unified Developer Tools panel into a Process & View Diagnostics dialog that shows Node/renderer memory and wiki worker info (wiki.getWorkersInfo). Fix FileSystemAdaptor to pass old fileInfo to generateTiddlerFileInfo to avoid numeric suffixes when overwriting tiddlers. Menu and workspace changes: add a Sync menu and move git items there, simplify context menu generation, remove some developer menu items, and adjust createBackupMenuItems signature. Window and workspace improvements: add recreateUnlessWorkspaceID option and safer window close handling, restore hibernated flag when bringing workspace views up, and improve sub-workspace settings UI. Also add several i18n entries for the new diagnostics and UI text.
* Add renderer metrics; fix hibernation & menus
Collect and display renderer process metrics and harden workspace/window logic.
Highlights:
- Add new i18n keys for renderer PID/CPU/private memory (en and zh-Hans).
- Native service: check and throw on shell.openPath errors; gather per-renderer metrics (private/working set KB and cpu percent) via app.getAppMetrics() and webContents, and improve logging.
- Extend IRendererProcessInfo with private_KB, workingSet_KB and cpu_percent.
- DeveloperTools UI: show PID tooltip, private memory and CPU columns, sort renderers by memory, color-code values, and fix SquirrelTemp path/openPath call.
- Git/menu changes: consolidate backup/sync items to include AI option inline; only show sync for cloud workspaces with a git remote and authenticated user; always show local backup.
- Workspaces/view: prevent races when switching to a workspace by tracking hibernation as awaitable promises (Map), awaiting in-flight hibernations, and re-fetching workspace state before actions.
- View/window safety: add null/undefined checks for view.webContents in several handlers (setupViewEventHandlers, handleAttachToTidgiMiniWindow) to avoid operations on destroyed/closed webContents.
These changes improve diagnostics, prevent race conditions, and make menu behavior more consistent.
* fix: lint errors - remove unused WindowNames import, fix import order and indentation
* fix: address review comments - remove mainWikiToLink from syncable config (absolute path unsafe to sync), fix missing-field detection in syncableChanged, precompute viewsInfo Map in renderer table, use stable pid as row key
* fix: auto-expand SubWorkspaceRouting accordion when bound sub-wikis exist, so e2e test selectors are visible
* fix: update e2e test menu paths - git/sync items moved from Wiki menu to Sync menu
* fix: stabilize sync settings and e2e sync helper
* refactor: replace time-window echo prevention with mtime+size and content checks
FileSystemWatcher: use recorded mtime+size (lastWriteStats) and saving-state
flag (titlesBeingSaved) to skip own-write echoes, plus content identity fallback.
Removes unreliable setTimeout-based exclude/scheduleFileInclusion.
ipcServerRoutes: replace TTL Map with synchronous Set (ipcPendingTitles),
attach changeCount as revision to change Observable.
ipc-syncadaptor: use lastSavedRevisions for revision-based echo prevention,
batch large syncs via requestIdleCallback.
Also: EditWorkspace controlled input fixes, port field local state, agent
framework config setConfig/persistConfig split, misc value ?? '' fixes.
* Enhance e2e screenshots and test logging
Improve end-to-end test reliability and diagnostics:
- Capture window screenshots for non-BrowserView steps: add captureWindowScreenshot and use it in AfterStep to capture the Electron BrowserWindow via webContents.capturePage() when appropriate; keep existing captureScreenshot for BrowserView steps. (features/supports/webContentsViewHelper.ts, features/stepDefinitions/application.ts)
- Prevent wiki restart race: wait for the wiki worker '[test-id-WIKI_WORKER_STARTED]' marker before restarting to avoid DoubleWikiInstanceError. (features/stepDefinitions/wiki.ts)
- Make git-related test markers more visible by switching logger.debug → logger.info for git init/commit/sync/checkout/revert and git-log rendering markers, ensuring e2e tests can reliably detect these events. (src/services/git/index.ts, src/windows/GitLog/useGitLogData.ts)
- Minor feature test tweak: wait for page to load in defaultWiki.feature before interacting with the editWorkspace window.
These changes reduce flaky screenshots and timing races in tests and improve test marker visibility for e2e detection.
* Enhance e2e screenshots and test logging
Improve end-to-end test reliability and diagnostics:
- Capture window screenshots for non-BrowserView steps: add captureWindowScreenshot and use it in AfterStep to capture the Electron BrowserWindow via webContents.capturePage() when appropriate; keep existing captureScreenshot for BrowserView steps. (features/supports/webContentsViewHelper.ts, features/stepDefinitions/application.ts)
- Prevent wiki restart race: wait for the wiki worker '[test-id-WIKI_WORKER_STARTED]' marker before restarting to avoid DoubleWikiInstanceError. (features/stepDefinitions/wiki.ts)
- Make git-related test markers more visible by switching logger.debug → logger.info for git init/commit/sync/checkout/revert and git-log rendering markers, ensuring e2e tests can reliably detect these events. (src/services/git/index.ts, src/windows/GitLog/useGitLogData.ts)
- Minor feature test tweak: wait for page to load in defaultWiki.feature before interacting with the editWorkspace window.
These changes reduce flaky screenshots and timing races in tests and improve test marker visibility for e2e detection.
* Use startTransition to update port on change
Import startTransition from React and update the port input handler to capture the raw value, update local display state, and defer parsing/setting the workspace port inside startTransition. The handler now parses an empty value as 0, validates the number (non-NaN and >= 0) before calling workspaceSetter, improving responsiveness by marking the workspace update as non-urgent. Also removed an obsolete inline comment.
* Improve E2E, view sync, and wiki IPC robustness
Multiple fixes and improvements across E2E tests, view management, wiki IPC, and workspace handling:
- Docs: add SHOW_E2E_WINDOW env var note to allow visible Electron windows during manual E2E runs.
- Features: simplify/adjust cross-window sync scenario and refine hibernation workspace selectors to avoid collisions with similarly named workspaces.
- E2E steps: make AI-request assertion resilient by polling (backOff); replace brittle DOM-driven tiddler creation with direct TiddlyWiki API calls in browserView step definitions for reliability; add small UI click pause and longer click timeout in ui steps.
- Timeouts: unify global timeout to 25s and derive Playwright short/log wait timeouts from it.
- WebContents helpers: prefer the last child wiki view (active one) when multiple views exist and update comments.
- WikiEmbedTabContent: wake workspace on mount and simplify cleanup to always clear custom bounds on unmount; handle errors.
- Chat UI: hide TabListDropdown in split view.
- Agent instances: default missing agentFrameworkID to 'basicPromptConcatHandler' for older definitions.
- View service: add activelyShownViews set to avoid hiding views that were explicitly shown via showView(); clear stale custom bounds when showing views; avoid moving views offscreen when actively shown; ensure cleanup removes active flag.
- IPC server routes: prefer URL-based workspace ID (resolve correct casing via workspace service) to handle cross-session routing; pass effective workspace ID to route handlers.
- Wiki service: add startup timeout to avoid indefinite hangs waiting for worker boot message.
- IPC sync adaptor: implement titlesBeingSaved/titlesBeingLoaded sets to prevent save-back and SSE echo issues; mark titles when saving/loading and suppress spurious saves.
- Wiki worker IPC routes: replace per-subscriber addEventListener with a shared Subject and single change listener to avoid missed events and cross-window sync bugs; forward subject events to subscribers and log readiness.
- Windows: keep windows hidden during tests by default but allow showing them when SHOW_E2E_WINDOW=1.
- Workspaces: compute next insert order so new wiki workspaces appear at the top of regular workspaces (shift others down).
Overall these changes reduce flakiness in tests, prevent cross-window echo and routing bugs, make view lifecycle handling safer, and improve developer ergonomics for debugging E2E runs.
* fix(e2e): bypass system proxy for git HTTP operations in sync test
Git clone/push/fetch to localhost was routed through the system proxy (port 1080),
which returned 502 Bad Gateway. Add -c http.proxy= to disable proxy for all
HTTP git commands in the sync test step definitions.
* fix: address CI lint errors and Copilot review comments
Lint fixes:
- useOptimisticField: rename *Ref/*Fn vars to *Reference/*Function (unicorn/prevent-abbreviations)
- wiki/index: rename args to arguments_ (unicorn/prevent-abbreviations)
- FileSystemWatcher: use specific type assertion for tiddler fields to avoid no-base-to-string warning
- webContentsViewHelper: rename loop var i to index
- interface.ts: merge duplicate imports from same module (dprint)
- ipc-syncadaptor: expand queueMicrotask callback (dprint)
Copilot review fixes:
- ipcServerRoutes: move subscription to outer scope so Observable teardown
is returned synchronously from the constructor, preventing subscription leaks
when observers are disposed before the async IIFE resolves
- useOptimisticField: capture localValue at focus time; on blur only commit
when user actually changed the value (not when serverValue updated while focused)
- FileSystemWatcher.markSaveComplete: guard scheduleGitNotification behind
non-empty absoluteFilePath to avoid spurious git notifications on error paths
* fix(e2e): handle corrupt settings.json in cleanup and use filechooser intercept for image upload
- tidgiMiniWindow cleanup: wrap readJson with try/catch so truncated/empty
settings.json (race between app shutdown write and After hook read) is
handled gracefully instead of throwing SyntaxError
- application.ts: add 'I prepare to select file ... for file chooser' step
that registers a Playwright one-shot filechooser handler BEFORE the click
that triggers fileInput.click(). This prevents the native OS dialog from
appearing entirely (the chooser is resolved directly with the supplied file).
- talkWithAI.feature: replace two-step 'click then setInputFiles' with the
new 'prepare filechooser click' pattern so no OS dialog is shown during
the AI image attachment test
* Add wiki tiddler attachment support to agent chat
Implements the ability to attach wiki tiddlers to agent chat messages. Updates the UI to allow selection of tiddlers from active wiki workspaces, fetches and renders tiddler content as plain text, and appends it to the user message sent to the AI. Includes e2e tests, updates to store actions, service interfaces, and prompt concatenation logic to support this feature.
* fix: callback not useCallback cause autocomplete panel flash
* Add wiki tiddler attachments to message bubbles
Message bubbles now display attached wiki tiddlers as clickable chips, allowing users to navigate directly to the referenced tiddler in the appropriate workspace. Metadata handling and persistence for wiki tiddlers has been updated to include workspaceId, and tests have been added to verify the new UI behavior. The chat view also now closes the TiddlyWiki sidebar for better focus when navigating from a selection.
* Support split view navigation for wiki tiddler attachments
Adds isSplitView prop to ChatTabContent and related components to distinguish between split view and normal tab modes. Wiki tiddler attachment navigation now uses a different strategy in split view, opening tiddlers directly in the browser view. Updates types and tests to reflect the new behavior, and improves robustness of response handling in several places.
* docs: move to .github/instructions/testing.instructions.md
* test: view loading slow on mac
* refactor(e2e): move wiki load steps to Background in talkWithAI.feature; remove all sidebar close delays and polling, only set state when TiddlyWiki is ready; clean up code and logs for sidebar auto-close in split view
* docs: make test inst shorter
* lint
* refactor(view): slim ViewService, move menu to separate file, orchestrate view logic in WorkspaceViewService, update all callers, fix lint floating promise, all unit and e2e tests pass
* fix: add data-testid to attachment listbox for E2E test
- Add slotProps to MUI Autocomplete to ensure attachment-listbox is rendered with correct test-id
- Fix E2E test timeout when waiting for attachment listbox element
* lint
* put 'Talk with AI' menu on top and attachment i18n
Introduce a reusable createTalkWithAIMenuItems helper to build "Talk with AI" menu entries (default agent + other agents submenu) and integrate it into workspace menu generation. Add new i18n keys for Agent.Attachment and WikiEmbed across locales and update UI to use translation keys (remove hardcoded fallback strings). Improve chat input/attachment behavior: expose a test-id for the attachment listbox, use i18n for labels/placeholders, and tweak input component wiring. Fix Cucumber step handling by normalizing expected newline sequences and safely handling empty message content. Also adjust memo deps in SortableWorkspaceSelectorButton to include id.
* feat: enhance AI interaction in workspace context menu with local trigger support
* feat: add tool approval and timeout settings
- Introduced ToolApprovalConfig and related types for managing tool execution approvals.
- Implemented WebFetch and ZxScript tools for fetching web content and executing scripts, respectively.
- Added token estimation utilities for context window management.
- Enhanced ModelInfo interface with context window size and max output tokens.
- Created API Retry Utility for handling transient failures with exponential backoff.
- Updated AIAgent preferences section to include Tool Approval & Timeout Settings dialog.
- Developed ToolApprovalSettingsDialog for configuring tool-specific approval rules and retry settings.
- Modified vitest configuration to support aliasing for easier imports and stubbing.
* Refactor agent instance tools and services for improved modularity and maintainability
- Extracted type definitions and tool registry from defineTool.ts into separate files (defineToolTypes.ts, toolRegistry.ts) to reduce file size and enhance importability.
- Implemented a retry mechanism in ExternalAPIService for stream creation to handle transient failures.
- Updated ToolApprovalSettingsDialog to persist settings using localStorage instead of a preference service.
- Created agentMessagePersistence.ts and agentRepository.ts to manage agent message and instance CRUD operations, reducing the size of AgentInstanceService.
- Added a progress tracker document (AgentTODO.md) for the ongoing enhancement plan of the TidGi Agent.
* feat: add AgentSwitcher component for agent definition switching
- Implemented AgentSwitcher component with dropdown functionality for selecting agent definitions.
- Integrated loading of agent definitions on dropdown open.
- Added visual feedback for current selection and disabled state.
feat: create ToolResultRenderer for generic tool result messages
- Developed ToolResultRenderer to handle rendering of <functions_result> messages.
- Included collapsible parameters and result display with error handling.
- Added truncation for long results in collapsed view.
test: add comprehensive tests for MessageRenderer components
- Implemented tests for AskQuestionRenderer, ToolResultRenderer, ToolApprovalRenderer, and BaseMessageRenderer.
- Ensured proper rendering and functionality for various message types and states.
- Included pattern routing tests for MessageRenderer.
feat: introduce TurnActionBar for action management in agent turns
- Created TurnActionBar component for managing actions like rollback, retry, delete, and copy.
- Integrated visual feedback for file changes and rollback status.
- Added functionality for copying agent responses and full conversation to clipboard.
feat: implement askQuestionPending for managing user responses
- Developed infrastructure for handling pending ask-question requests.
- Implemented promise-based blocking until user responds to agent questions.
- Added timeout handling for ask-question requests.
* feat: Implement background task management for agent instances
- Added functionality to restore heartbeat timers and alarms for active agents upon service initialization.
- Introduced methods to retrieve active background tasks and cancel them via the UI.
- Enhanced alarm clock tool to persist alarm data in the database, ensuring alarms survive app restarts.
- Updated agent instance schema to include scheduled alarm data.
- Modified prompt concatenation logic to support context window size for message history.
- Removed system prompt parameter from model parameters schema and related components.
- Improved UI to display and manage background tasks, including heartbeat and alarm details.
* feat: Implement Scheduled Tasks Management and Background Task Settings
- Add feature for managing scheduled tasks for agents, including viewing, adding, and editing tasks.
- Create tests for agent repository and background task settings APIs.
- Introduce ScheduledTaskManager for unified scheduling of tasks with interval, at, and cron schedules.
- Implement edit-agent-definition tool for modifying agent configurations, including heartbeat and prompt settings.
- Ensure tasks persist across app restarts and respect active hours filtering.
* Update wiki
* fix(security): harden htmlToText against XSS via encoded tags
- Use tolerant script/style regex that handles </script > with spaces
- Stop decoding </> entities to prevent reintroducing HTML tags
- Decode & last to avoid double-unescaping (&lt; < <)
- Fixes all 4 CodeQL findings (bad filtering, incomplete sanitization,
double escaping, incomplete multi-character sanitization)
* fix: lint and format errors (eslint naming, dprint formatting, stub classes)
* fix: exclude tidgi.config.json from template copy and fix log marker pattern
- Skip tidgi.config.json when copying wiki template to prevent overriding workspace name
- Change waitForLogMarker default pattern from 'wiki-' to '*' to match actual log filenames
- Filter tidgi.config.json in e2e step too (fs.copy in wiki creation step)
* perf(e2e): merge 5 scheduledTask scenarios into 2 to reduce app restarts
* perf(e2e): merge crossWindowSync and streamingStatus scenarios to reduce CI time
* ci: increase test timeout to 20min for larger e2e scenario count
* perf(e2e): merge agent scenarios and enable parallel on CI
- Merge agent.feature wiki-search + wiki-operation into one scenario
- Merge agent.feature create-agent-from-newtab + create-agent-from-fallback into one
- Enable cucumber parallel: 2 on CI (7GB RAM, dynamic ports for mock servers)
- Total scenarios: 66 -> 61
* fix: cleanup MCP client processes when deleting or closing agent
* ci: disable parallel (CPU contention), increase timeout to 30min for 61 scenarios
* perf(e2e): merge 3 preference background-task scenarios into 1, increase timeout to 45min
- Preference alarm/heartbeat CRUD merged into single scenario (saves 2 app restarts)
- Total scenarios: 59 (was 66)
- CI timeout 45min for the expanded e2e suite
* fix: restructure e2e scenarios, fix subscription leak and debounce cleanup
- Restructure agent/talkWithAI/streamingStatus feature files for reliability
- Fix talkWithAI scenarios missing mock server startup and app launch
- Remove duplicate subscription in handleSwitchAgent (useEffect already handles it)
- Clean up debounced update functions when agent is deleted/closed
- Use agentId:messageId key for debounced functions to enable per-agent cleanup
* fix(e2e): remove :last-child selectors broken by TurnActionBar, fix tab/dialog selectors, increase CI timeout to 25min
* fix: use const for non-reassigned variable (lint)
* fix(e2e): fix close-all-tabs opacity issue, scheduledTask undefined steps, MUI multiline textarea targeting
* fix(e2e): use tab-list-dropdown to close all tabs, fix selector for actual TabListDropdown component
* fix(e2e): add timing waits for BrowserView repositioning and git log UI refresh
* fix(e2e): make 'should not see' step wait for element to disappear instead of instant check
* fix(e2e): increase executeInBrowserView default timeout from 500ms to 2000ms
The wiki worker log is named after the workspace (e.g., 'Tiddlywiki-NodeJS-Github-Template-*.log'),
not 'wiki-*'. Changing default to '*' to match all .log files, fixing 25 scenario failures.
The stop->update->start approach introduced a race condition that caused
'watch-fs did not stabilize after restart' failures in 25 out of 52 scenarios.
Reverting to the proven update->restartWiki() approach from master while still
supporting enableHTTPAPI restart.
Introduce end-to-end tests and server-side support for mobile-style Smart HTTP git sync. Adds a new mobileSyncConflict.feature and extended sync.step definitions to simulate HTTP clone/sync cycles, pushes, and assertions (including file content checks and HTTP readiness/backoff). Introduces src/services/gitServer/mergeUtilities.ts to resolve .tid conflicts (mobile metadata wins, body merged) and common git helpers, and wires those into the git server (use runGitCollectStdout, DESKTOP_GIT_IDENTITY, and mergeAfterPush endpoint). Misc: update workspace restart flow and settings handling, tweak test helpers (skip screenshot capture for file steps), adjust slugify rules, minor UI/formatting change, and bump git-sync-js dependency (with lockfile update).
* Create ErrorDuringRelease.md
* Enforce test timeouts and add root tiddler scenario
Set global and step timeouts to 5s (local) and 10s (CI) across cucumber config and step definitions to standardize test execution times. Add a new scenario to verify root tiddler configuration and content loading after restart. Enhance start-e2e-app script to accept or auto-detect test scenario names and pass them to the app.
* Improve error handling for window and view initialization
Enhanced error reporting and handling when browser windows are not ready or fail to register in windowService. Updated focus logic to dynamically retrieve the current browser window, improving reliability during workspace hibernation and wake-up scenarios.
* Remove AfterAll hook and add --exit to e2e tests
Eliminates the AfterAll hook that forced process exit in cleanup.ts to prevent hanging after tests. Adds the --exit flag to the cucumber-js command in the e2e test script to ensure proper test process termination.
* Add step to restart workspace in wiki tests
Introduces a new step definition 'I restart workspace {string}' to programmatically restart a wiki workspace during tests. Updates the root tiddler scenario to use this step for verifying lazy-load behavior after workspace restart, improving test reliability and clarity.
* Centralize and standardize E2E test timeouts
Extracted timeout values into features/supports/timeouts.ts and replaced hardcoded timeouts in step definitions with named constants. This ensures consistent timeout handling across local and CI environments, reduces duplication, and clarifies intent. Also improved workspace update logic to check watch-fs state before restart and cleaned up related log marker handling.
* Improve i18n coverage and add Windows installer log access
Expanded and unified i18n keys for error messages and UI labels across multiple languages. Refactored code to remove hardcoded default values from translation calls. Added a Developer Tools option to open the Windows installer log folder (SquirrelTemp) when running on Windows. Introduced a placeholder file to preserve dynamic i18n keys for error messages.
* Initialize Tidgi mini window before workspace views
Moved the initialization of the Tidgi mini window to occur before initializing all workspace views in main.ts to ensure correct view creation. Added a clarifying comment in DeveloperTools.tsx regarding the SquirrelSetup.log path.
* Refactor Tidgi mini window initialization logic
Tidgi mini window creation now only creates the window; view creation is deferred to initializeAllWorkspaceView. Updated related comments and logging for clarity. Also fixed formatting in French translations and improved documentation for error handling during release.
* Add model feature chips to model selection UI
Introduces a ModelFeatureChip component to visually display model features in the model selector and new model dialog. Updates defaultProviders to include new models with features, and enhances the UI to show feature chips for each model, improving clarity for users selecting models.
* Add image attachment support to chat messages
This update enables users to attach image files to chat messages, including UI changes for file selection and preview, backend persistence of attachments, and prompt concatenation logic to include images in AI requests. It also adds error handling and i18n for model vision support, updates message rendering to display images, and improves logging and API validation for vision-capable models.
* Improve streaming status handling for agent messages
Adds a failsafe to clear streaming status when an agent reaches a terminal state and refines logic to prevent marking completed messages as streaming. Also updates message stream completion in AgentInstanceService to ensure proper cleanup and delivery of IPC messages. Includes new feature tests for message streaming status and image upload scenarios.
* Add cross-window sync feature and test steps
Introduces a new feature file for cross-window synchronization scenarios. Adds step definitions to open workspaces in new windows and execute TiddlyWiki code programmatically. Removes obsolete wiki.ts.backup file and updates agentActions for related actions.
* feat(sync): fix cross-window synchronization via SSE
- Remove overly aggressive echo prevention in backend that blocked all SSE updates
- Backend now forwards all wiki change events to subscribers
- Add comprehensive cross-window sync tests verifying bidirectional updates
- Test main->new window sync and new->main window sync scenarios
- Version bump to 0.13.0-prerelease19
* Improve file attachment handling in chat and tests
Refactors file input handling in chat tests to use Playwright's setInputFiles, updates message sending types to support optional file attachments, and enhances file metadata persistence and logging. Adjusts test expectations and UI logic to better handle and display image attachments, and clarifies combobox value assertions in ExternalAPI tests.
* Add file input validation and improve i18n messages
Added image type and size validation (10MB limit) to file input in InputContainer. Improved image preview logic. Updated French, Japanese, and Russian translations with new error messages for missing/default model and vision support. Enhanced type safety in promptConcatWithImage tests and messagePersistence logging. Fixed race condition in ExternalAPIService lazy initialization. Updated CommitDetailsPanel to use common cancel translation key.
* review
* Update browserView.ts
* Update timeouts.ts
* Update cucumber.config.js
* Update cucumber.config.js
* Move global timeout config to separate module
Extracted global timeout setup from cucumber.config.js to features/supports/timeout-config.ts using setDefaultTimeout. This ensures the timeout is set via code rather than config, improving clarity and maintainability.
* Update newAgent.feature
* fix: not removed
* Optimize tidgi.config.json writes for workspace updates
Update logic to write tidgi.config.json only for the modified workspace instead of all wiki workspaces on each update. This reduces redundant file operations and improves performance during workspace updates.
* Refactor workspace saving and UI update logic
Introduced a private saveWorkspacesToSettings method to centralize logic for saving workspaces and removing syncable fields from wiki workspaces. The set and setWorkspaces methods now support skipping UI updates for batch operations, improving performance. Fixed minor issues in legacy migration and error messages.
* Add 'Ask AI' context menu and wiki embed split view
Introduces an 'Ask AI' option to the wiki context menu, enabling users to send selected text to an agent chat in a split view with the wiki embedded. Implements new tab type WIKI_EMBED, updates tab and channel types, adds localization, manages BrowserView bounds for embedding, and ensures persistence and IPC wiring for the new workflow.
* Update wiki
* electron chrome mcp mode sometimes wont show browser view
Clarified troubleshooting steps in docs/MCP.md regarding browser view issues and updated the instructions. Reordered the 'start:dev:mcp' script in package.json for better organization.
* Add agent selection to 'Talk with AI' context menu
Replaces the 'Ask AI' context menu with 'Talk with AI' and adds a submenu for selecting different agent definitions. Updates translations for all supported languages, modifies the askAIWithSelection channel to support agentDefId, and refactors tab creation logic to support split view with agent selection. Improves robustness in view management by handling case-insensitive workspace IDs and custom bounds logic.
* Add e2e test and refactor 'Talk with AI' split view logic
Introduces a new Cucumber feature for 'Talk with AI' from wiki selection, adds a step definition to trigger the workflow via IPC, and refactors split view tab creation to reuse existing tabs when possible. Updates the agent browser service to support finding or creating the appropriate split view tab, and adjusts menu and view services for improved robustness and code clarity. Also adds test IDs to relevant components for more reliable UI testing.
* Update defaultWiki.feature
* Add config error handling and i18n for agent errors
Introduces a new feature test for configuration error handling, adds step definition to remove AI settings for testing, and updates error message rendering to support new error types. Internationalized error messages and button labels for configuration issues are added in both English and Chinese locales. The error message renderer now uses a data-testid for easier testing and recognizes additional error types as fixable in settings.
* Refactor feature files to use two-column selector tables
Updated all feature files to use a standardized two-column format for selector tables, with explicit 'element description' and 'selector' columns. Step definitions in ui.ts were refactored to support this format, improving readability and maintainability of test steps and error handling.
* Delete tiddlywiki
* test: allow parallel
* test: implement scenario isolation for E2E tests
- Isolate each test scenario in test-artifacts/{scenarioSlug}/ directory
- Use dynamic ports for mock OpenAI server to avoid port conflicts
- Log VIEW_LOADED event via did-finish-load in main process (more reliable)
- Search all .log files when waiting for log markers
- Increase timeout for log marker steps to 15 seconds
- Fix ts-node cache issues by clearing cache before tests
- Move application launch to individual scenarios (required for mock server setup)
All 45 E2E test scenarios now pass consistently.
* refactor: optimize agent.feature by moving common steps to Background
- Add MockOpenAIServer.addRules() method to append responses dynamically
- Add 'I have started the mock OpenAI server without rules' step for Background
- Add 'I add mock OpenAI responses:' step to inject responses per scenario
- Move application launch and navigation to Background (shared by all scenarios)
- Keep scenario-specific mock responses in individual scenarios
This improves test maintainability by reducing duplication while keeping
scenario-specific configuration flexible.
* lint
* Refactor scenario path helpers into shared module
Moved scenario-specific path helper functions from individual step definition files to a centralized 'features/supports/paths.ts' module. Updated imports in step definitions to use the shared helpers, improving code reuse and maintainability. Also enhanced test for ContextService to skip optional runtime keys.
* Refactor slug generation to use shared slugify helper
Introduced a new src/helpers/slugify.ts utility for consistent slug generation across the codebase. Updated appPaths.ts to use the shared slugify function, improving maintainability and ensuring identical behavior for test scenario slugs. Added documentation and clarified slugification rules in relevant files. Minor comments and clarifications were added to E2E and mock server code.
* Enforce strict timeout rules in E2E test steps
Added and clarified critical warnings for AI agents regarding timeout modifications in application, cleanup, and wiki step definitions. All timeouts are now strictly limited to 5s local and 10s CI, with explicit comments and environment-based values. Updated documentation and code comments to reinforce that timeouts indicate real bugs and should not be increased.
* Update features/stepDefinitions/application.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor E2E helpers, improve test reliability and cleanup
Centralizes data table parsing for UI step definitions, refactors mock OpenAI server setup, and improves workspace settings path handling for tests. Adjusts timeouts for window and app closing to better reflect real-world performance. Fixes type usage in workspace ID lookups and adds error handling for resize observer and cleanup in WikiEmbedTabContent. Enhances agent browser tab logic and view service cleanup to prevent memory leaks and catch workspace ID casing issues.
* Update agent.ts
* fix: resolve all E2E test timeout issues
* fix: improve CI test reliability with better timing and cleanup
- Use exponential-backoff library for agent creation retry logic
- Extend agent cancel delay to 1000ms for CI environments
- Fix git log refresh marker timing with queueMicrotask
- Improve cleanup timeout handling with force close strategy
All E2E tests passing locally including previously failing CI tests.
* Improve Git log E2E signal and add debug logging
Renames the test artifact in the CI workflow for clarity. Moves the E2E test timing log in useGitLogData to after entries are rendered, using a more reliable signal. Adds a debug log to notifyGitStateChange for better traceability.
* test-artifacts-ci
* Optimize test artifact handling and Git log logging
Update CI workflow to clean up large cache folders in test artifacts and only upload logs, settings, and screenshots to reduce artifact size. Refactor useGitLogData to log immediately after state updates for improved E2E test reliability, removing unnecessary setTimeout.
* Update useGitLogData.ts
* Improve Git log E2E test logging and .gitignore
Added 'test-artifacts-ci.zip' to .gitignore. Moved the '[test-id-git-log-refreshed]' log to immediately after data load for more reliable E2E test detection, and removed redundant logging from the render effect in useGitLogData.ts.
* Update useGitLogData.ts
* Update useGitLogData.ts
* Fix git log refresh marker not appearing in CI
- Move git-log-refreshed marker before RAF to ensure it's recorded
- RAF callbacks may not execute reliably in headless CI environments
- Add debug logging to track loadGitLog execution
- Add try-catch around log call to catch any errors
- Keep git-log-data-rendered in useEffect for UI tracking
* Update useGitLogData.ts
* Update useGitLogData.ts
* Add comprehensive logging to diagnose git-log-refreshed issue
- Log before RAF and inside RAF to pinpoint exact failure location
- Add try-catch to capture any errors
- Two log markers: before-raf and in-raf
- This will definitively show where the logging fails in CI
* Fix race condition: prevent concurrent loadGitLog calls
Root cause: commit triggers 2 refreshes (gitStateChange$ + handleCommitSuccess)
- First loadGitLog (refreshTrigger=1) succeeds
- Second loadGitLog (refreshTrigger=2) starts but never completes
- Add loadGitLogInProgress guard to prevent concurrent execution
- Log when loadGitLog is skipped due to in-progress call
This ensures git-log-refreshed is always logged after commit.
* Remove redundant triggerRefresh calls causing race condition
- handleCommitSuccess/Revert/Undo no longer call triggerRefresh
- gitStateChange\$ observable already triggers refresh for these operations
- Redundant calls caused 2 concurrent loadGitLog, causing CI test failures
- Local tests passed because both completed; CI failed because 2nd never completed
This ensures only 1 loadGitLog runs per git operation.
* Remove unused triggerRefresh parameter from useCommitSelection
- triggerRefresh no longer used in handlers
- Remove from interface and call site
- Clean up lint errors
* Remove triggerRefresh completely - no longer needed
- Observable subscription handles all git state changes
- Remove function definition and exports
- Fix all lint errors
Root cause resolved: commit triggered double refresh causing race condition.
Now only single refresh via observable.
* Remove fixed time waits from gitLog.feature and fix race condition
- Remove all fixed time wait steps from gitLog.feature (14 instances)
- Remove redundant triggerRefresh calls in handleCommitSuccess/Revert/Undo
- Add loadGitLogInProgress guard to prevent concurrent loadGitLog
- Root cause: commit triggered 2 refreshes causing race condition
- Only gitStateChange\$ observable now triggers refresh
- All 4 gitLog tests pass locally
* Fix clear timing: clear log BEFORE commit, not after
Root cause: test cleared git-log-refreshed AFTER commit completed
- But commit already triggered refresh and logged git-log-refreshed
- Clear deleted it, then test waited for new log that would never come
- Solution: clear BEFORE clicking commit button
- This way commit's git-log-refreshed is the first one after clear
Test now passes locally.
* Update cleanup.ts
* Initial commit when init a new git.
* Refactor feature steps for multi-element and log marker tables
Updated multiple feature files and step definitions to support table-driven steps for clicking and asserting multiple elements, and for waiting for multiple log markers in sequence. This reduces redundant waits, improves test reliability, and streamlines Gherkin syntax for multi-element actions and assertions. Also removed unnecessary manual wait steps where content or element checks now handle waiting automatically.
* Minor code cleanup and formatting improvements
Reordered imports in browserView.ts, fixed whitespace in cleanup.ts and useGitLogData.ts, and improved line formatting in GitLog/index.tsx for better readability and consistency.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: tidgi <tiddlygit@gmail.com>
* fix: missing return
* feat: showApiKey
* feat: undo commit
* feat: amend commit
* fix: file name quoted in git log
* fix: wikiWorkspaceDefaultValues
* fix: no ai commit message sometimes
* Persist only non-default preferences to storage
Added a utility to store only preferences that differ from defaults, reducing storage size and improving config readability. Updated the setPreferences method to use this utility before saving preferences.
* fix: External Attachment Handling in fs plugin instead of ext-attachment-plugin to handle direct tag update case which won't trigger th-saving-tiddler hook
* feat: api for plugin to create base64 file
* Show all untracked files and recreate Git history window
Updated git status commands to use '-uall' for displaying all untracked files, not just directories. Modified windowService.open calls for Git history to include the { recreate: true } option, ensuring the window is refreshed when opened from various menus.
* fix: handling of external attachments with _canonical_uri
Ensure tiddlers with _canonical_uri are always saved as .tid files, not as binary files, by forcing the .tid extension in FileSystemAdaptor. Update tests to verify this behavior. Also, skip loading files from the external attachments folder in loadWikiTiddlersWithSubWikis to prevent them from being loaded as separate tiddlers.
* Refactor external attachment utilities to module exports
Refactored externalAttachmentUtilities to use ES module exports instead of attaching functions to $tw.utils. Updated imports and mocks accordingly, removed related type definitions from ExtendedUtilities, and cleaned up obsolete meta file.
* disable enableFileSystemWatch to prevent bug for innocent users
* fix: test that requires enableFileSystemWatch use new step set to true
* Fix extension filter usage and sync workspace state after save
Refactored variable naming for extension filters in FileSystemAdaptor to improve clarity and fixed their usage in generateTiddlerFileInfo calls. Removed an unused import in routingUtilities.type.ts. Added a useEffect in useForm to sync workspace state with originalWorkspace after save, ensuring the save button disappears as expected.
* fix: review
* lint
* feat: unify AI commit entry points and add availability check - Unified all AI commit message generation to use syncService.syncWikiIfNeeded() for consistent business logic handling - Added externalAPI.isAIAvailable() method to check if AI provider and model are properly configured - Updated gitService.isAIGenerateBackupTitleEnabled() to use the new availability check - Removed redundant logging code since generateFromAI() automatically logs to database when externalAPIDebug is enabled - Simplified menu item creation logic in menuItems.ts - Ensured AI menu options only appear when both API credentials and free model are configured - Updated documentation to reflect the unified architecture
* Improve AI commit message diff filtering and API checks
Renamed the AI commit message entry points doc for clarity. Enhanced the AI availability check to better handle provider API key requirements, including support for providers that do not require keys. Improved plugin diff filtering to retain small config file diffs while omitting large plugin file contents, optimizing AI token usage.
* Update wiki
* Refactor and enhance Tidgi mini window initialization and sync
Refactors Tidgi mini window startup to use a new initializeTidgiMiniWindow method, improving workspace selection logic and view management. Adds concurrency locks to prevent race conditions during open/close operations. Enhances workspace sync/fixed mode handling, view cleanup, and error logging. Updates interfaces and utilities to support new behaviors and improves robustness of tray icon creation and view realignment.
* Refactor file system sync to use $tw.syncer.syncFromServer()
Introduces FileSystemWatcher to monitor file changes and collect updates for the syncer, replacing direct wiki updates in WatchFileSystemAdaptor. Updates documentation to describe the new syncer-driven architecture, echo prevention, and event handling. WatchFileSystemAdaptor now delegates file change detection and lazy loading to FileSystemWatcher, improving batch change handling and eliminating echo loops.
* Improve logging and cleanup in file system watcher and git ops
Added detailed logging to WatchFileSystemAdaptor and FileSystemWatcher for better traceability during initialization and test stabilization. Introduced a constant for the temporary git index prefix in gitOperations. Removed the unused comparison.ts utility for tiddler comparison. Enhanced comments and logging for AI commit message generation context.
* Improve GitLog i18n test and config refresh logic
Updated gitLog.feature to use only Chinese selectors for actions, revert, and discard buttons, improving i18n test reliability. In FileSystemWatcher, re-fetch workspace config before checking enableFileSystemWatch to ensure latest settings are respected. In useGitLogData, prevent file-change events from overriding commit/undo events to maintain correct auto-selection behavior.
* Improve Git log selection and test stability
Refines auto-selection logic in the Git log window to better handle uncommitted changes, commits, reverts, and undos. Updates the feature test to explicitly verify selection and UI state after each operation, improving reliability. Removes unnecessary config re-fetch in FileSystemWatcher and enhances logging for more accurate DOM update detection.
* Implement workspace config sync via tidgi.config.json
Adds support for syncing workspace configuration to tidgi.config.json in the wiki folder, enabling settings persistence and migration across devices. Introduces new documentation, feature tests, and supporting utilities for config file reading, writing, migration, and validation. Updates step definitions and test helpers to support config sync scenarios, and refactors database config utilities for modularity.
* Improve workspace config handling and sync logic
Enhances workspace lookup in step definitions to check both settings.json and tidgi.config.json, ensuring properties are found even if moved. Updates tidgiConfig write logic to remove the config file if all values are default. Refactors workspace save logic to always write syncable config to tidgi.config.json for all wiki workspaces before removing those fields from settings.json, preventing config loss.
* Update .gitignore
* Update wiki.ts
* Add delay before waiting for git log render after revert
- Add 1 second wait after clearing git-log-data-rendered markers following revert
- This gives UI time to start refreshing before we check for the new marker
- Fixes CI timing issue where revert operation needs more time to trigger UI refresh
* Update test log markers for git log refresh events
Replaces '[test-id-git-log-data-rendered]' with '[test-id-git-log-refreshed]' in gitLog.feature to better reflect UI refresh events after commit and revert actions. Adds a debug log marker '[test-id-git-revert-complete]' in revertCommit for improved test synchronization.
* Fix git revert refresh timing - remove intermediate step and rely on git-log-refreshed
* Add detailed logging to handleRevert for CI debugging
* Fix git log refresh by adding manual triggerRefresh fallback
- Add triggerRefresh function to useGitLogData hook for manual refresh
- Call triggerRefresh in handleCommitSuccess, handleRevertSuccess, and handleUndoSuccess
- This fixes cross-process IPC observable subscription issues where gitStateChange$
notifications from main process may not reach renderer process reliably
- Add detailed logging to handleRevert for CI debugging
* Update index.tsx
* lint
* fix: Use macos-15 (Intel) for x64 builds to get correct dugite git binaries
* Refactor routing utilities and improve files/ external in sub-wiki
Moves routing utility functions to be exported via $tw.utils and updates type usage for better plugin integration. Adds support for excluding external attachments folders (configurable via $:/config/ExternalAttachments/WikiFolderToMove) from file watching. Updates build script to include new entry points and adjusts loader to use the correct module path. Adds and renames relevant .meta and type definition files.
* Add sub-wiki support for external file access
Introduces sub-wiki path management and updates file retrieval logic to search both main and sub-wiki external attachment folders, as configured by `$:/config/ExternalAttachments/WikiFolderToMove`. Adds documentation for sub-wiki features and ensures consistent file access and exclusion across main and sub-wikis.
* Update FileSystemAdaptor.routing.test.ts
* Update fix-location-info.ts
* Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix: test
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* refactor: each model config has provider infomation
* Update WatchFileSystemAdaptor.ts
* refactor: split edit workspace UI code
* feat: allow IgnoreSymlinks and default true to prevent error on old user's workspace with sub wiki
* fix: assign default value to ignoreSymlinks
* Update FileSystemAdaptor.routing.test.ts
* Update wiki
* feat: scroll loading and search git history
* feat: better git search
* lint
* fix: test
* Update WatchFileSystemAdaptor.ts
* Update index.tsx
* fix: changed test selector
* Update index.tsx
* fix: different out path on macos
* fix: let go hibernation promise, so it's faster on macos
* log marker [test-id-TIDGI_MINI_WINDOW_CREATED]
* Skip registerShortcutByKey in test
* fix: mini window on mac
* Remove useless log marker
* Update handleAttachToTidgiMiniWindow.ts
* fix: log marker check all log files
* lint
* fix: open in new window now showing wiki title
* Update package.json
* feat: basic load and save to sub wiki using in-tag-tree-of
* fix: load sub-wiki content and prevent echo
* fix: test and ui logic
* test: refactor subwiki test logic to a file
* refactor: shorten steps by using dedicated step, and test underlying micro steps
* fix: review
* refactor: remove outdated method signature
* test: unit cover adaptor subwiki routing
* Update FileSystemAdaptor.routing.test.ts
* fix: merge issue
