mirrors/TidGi-Desktop
1
Fork 0
mirror of https://github.com/tiddly-gittly/TidGi-Desktop.git synced 2026-05-10 22:31:05 -07:00
Code Issues Projects Releases Packages Wiki Activity

Revert "fix(e2e): prevent ELECTRON_RUN_AS_NODE from leaking into E2E launch env"

Browse source 
This reverts commit ca4382f23e.
This commit is contained in:
linonetwo 2026-04-29 22:23:03 +08:00
parent 493dca50f6
commit 8aec2d388c
1 changed files with 14 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

34
features/stepDefinitions/application.ts
View file

@ -269,26 +269,20 @@ async function launchTidGiApplication(world: ApplicationWorld): Promise<void> {
]
: []),
],
env: (() => {
const launchEnv: Record<string, string> = {
...process.env as Record<string, string>,
...world.launchEnvOverrides,
NODE_ENV: 'test',
E2E_TEST: 'true',
LANG: process.env.LANG || 'zh-Hans.UTF-8',
LANGUAGE: process.env.LANGUAGE || 'zh-Hans:zh',
LC_ALL: process.env.LC_ALL || 'zh-Hans.UTF-8',
ELECTRON_DISABLE_SECURITY_WARNINGS: 'true',
};
// Prevent ELECTRON_RUN_AS_NODE from leaking into E2E (e.g. from test:unit script),
// which would cause Electron to run as Node.js and reject Chromium flags like --remote-debugging-port.
delete launchEnv.ELECTRON_RUN_AS_NODE;
if (process.env.CI) {
launchEnv.ELECTRON_ENABLE_LOGGING = 'true';
launchEnv.ELECTRON_DISABLE_HARDWARE_ACCELERATION = 'true';
}
return launchEnv;
})(),
env: {
...process.env,
...world.launchEnvOverrides,
NODE_ENV: 'test',
E2E_TEST: 'true',
LANG: process.env.LANG || 'zh-Hans.UTF-8',
LANGUAGE: process.env.LANGUAGE || 'zh-Hans:zh',
LC_ALL: process.env.LC_ALL || 'zh-Hans.UTF-8',
ELECTRON_DISABLE_SECURITY_WARNINGS: 'true',
...(process.env.CI && {
ELECTRON_ENABLE_LOGGING: 'true',
ELECTRON_DISABLE_HARDWARE_ACCELERATION: 'true',
}),
},
cwd: process.cwd(),
timeout: PLAYWRIGHT_TIMEOUT,
});