mirrors/stable-diffusion-webui
1
Fork 0
mirror of https://github.com/AUTOMATIC1111/stable-diffusion-webui.git synced 2026-03-25 23:50:45 -07:00
Code Issues Projects Releases Packages Wiki Activity

M01: Add --no-build-isolation to clip install in launch_utils

Browse source 
Fixes pkg_resources in pip's isolated build env. Build-time fix only.

Made-with: Cursor
This commit is contained in:
Michael Cahill 2026-03-07 15:38:39 -08:00
parent cb4b152935
commit 9ae76265ba
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.github/workflows/run_tests.yaml vendored
View file

@ -43,7 +43,6 @@ jobs:
env:
PIP_DISABLE_PIP_VERSION_CHECK: "1"
PIP_PROGRESS_BAR: "off"
PIP_NO_BUILD_ISOLATION: "1"
TORCH_INDEX_URL: https://download.pytorch.org/whl/cpu
WEBUI_LAUNCH_LIVE_OUTPUT: "1"
PYTHONUNBUFFERED: "1"

2
docs/milestones/M01/M01_plan.md
View file

@ -16,7 +16,7 @@ Stabilize CI before any refactor work begins. Make CI a trustworthy signal for s
## Scope
1. **Fix CI environment failure** — CLIP/pkg_resources: install setuptools before env setup; add `--do-not-download-clip` to setup step
1. **Fix CI environment failure** — CLIP/pkg_resources: install setuptools before env setup; add `--no-build-isolation` to clip pip install in launch_utils (avoids isolated build env lacking pkg_resources)
2. **Ensure CI runs on all PRs** — Remove same-repo PR skip condition from both workflows
3. **Introduce smoke validation** — Fast startup check before full test suite
4. **Add minimal coverage gate** — `--cov-fail-under=60`

3
docs/milestones/M01/M01_toolcalls.md
View file

@ -10,4 +10,5 @@
| 2025-03-07 | write | Create .gitattributes | .gitattributes | done |
| 2025-03-07 | search_replace | Update milestone ledger | docs/serena.md | done |
| 2025-03-07 | run | git push, CI run 22809624907 | Tests failed at Setup env (CLIP pkg_resources) | done |
| 2025-03-07 | search_replace | Add PIP_NO_BUILD_ISOLATION for CLIP build | .github/workflows/run_tests.yaml | in_progress |
| 2025-03-07 | search_replace | Add PIP_NO_BUILD_ISOLATION for CLIP build | .github/workflows/run_tests.yaml | done (reverted - env not passed to pip subprocess) |
| 2025-03-07 | search_replace | Add --no-build-isolation to clip install in launch_utils | modules/launch_utils.py | done |

2
modules/launch_utils.py
View file

@ -391,7 +391,7 @@ def prepare_environment():
startup_timer.record("torch GPU test")
if not is_installed("clip"):
run_pip(f"install {clip_package}", "clip")
run_pip(f"install {clip_package} --no-build-isolation", "clip")
startup_timer.record("install clip")
if not is_installed("open_clip"):