mirror of
https://github.com/AUTOMATIC1111/stable-diffusion-webui.git
synced 2026-03-22 14:20:39 -07:00
docs(M09): closeout — run1, run2, audit, summary, ledger
Made-with: Cursor
This commit is contained in:
Michael Cahill
parent
2c6a251043
commit
292115c8f0
5 changed files with 508 additions and 0 deletions
143
docs/milestones/M09/M09_audit.md
Normal file
143
docs/milestones/M09/M09_audit.md
Normal file
|
|
@ -0,0 +1,143 @@
|
|||
# M09 Audit — Execution Context Introduction
|
||||
|
||||
**Milestone:** M09
|
||||
**Title:** Execution context introduction
|
||||
**Mode:** DELTA AUDIT
|
||||
**Range:** 710a0abd (M08) → 2c6a2510 (M09 merge)
|
||||
**CI Status:** Green (Quality 22986731960)
|
||||
**Refactor Posture:** Behavior-Preserving
|
||||
**Audit Verdict:** 🟢 Milestone objectives met. Runtime context introduced. Phase II complete. Proceed to M10.
|
||||
|
||||
---
|
||||
|
||||
## 1. Executive Summary (Delta-First)
|
||||
|
||||
**Wins:**
|
||||
* Introduced RuntimeContext dataclass grouping model, opts_snapshot, device, state, cmd_opts
|
||||
* Attached p.runtime_context in process_images_inner() after opts_snapshot creation
|
||||
* Additive only; no migration of shared.* reads; no behavior change
|
||||
* Fifth Phase II runtime seam; completes Phase II — Runtime Seam Preparation
|
||||
* New module runtime_context.py 100% covered by quality tests
|
||||
|
||||
**Risks:** None identified.
|
||||
|
||||
**Next action:** Proceed to M10 (ProcessingRunner skeleton).
|
||||
|
||||
---
|
||||
|
||||
## 2. Delta Map & Blast Radius
|
||||
|
||||
| Changed | Impact |
|
||||
|---------|--------|
|
||||
| modules/runtime_context.py | New — RuntimeContext dataclass |
|
||||
| modules/processing.py | Modified — import + p.runtime_context assignment |
|
||||
| docs/milestones/M09/* | Plan, toolcalls, run1, run2, audit, summary |
|
||||
|
||||
**Consumer surfaces touched:** None. API, CLI, file formats, extension API unchanged.
|
||||
|
||||
**Blast radius:** process_images_inner initialization only. Context is write-only; no reads migrated. Breakage would require RuntimeContext construction failure — covered by smoke/quality tests exercising full generation path.
|
||||
|
||||
---
|
||||
|
||||
## 3. Architecture & Modularity Review
|
||||
|
||||
* **Boundary violations:** None. RuntimeContext is a simple data container.
|
||||
* **Coupling added:** Minimal — processing imports runtime_context; no new circular deps.
|
||||
* **Dead abstractions:** None. Context will be consumed in Phase III.
|
||||
* **Layering leaks:** None.
|
||||
|
||||
**Keep:** Current structure. **Fix now:** None. **Defer:** None.
|
||||
|
||||
---
|
||||
|
||||
## 4. CI/CD & Workflow Audit
|
||||
|
||||
| Check | Result |
|
||||
|-------|--------|
|
||||
| Smoke Tests (PR #26) | 22984770373 ✓ |
|
||||
| Linter (PR #26) | 22984770390 ✓ |
|
||||
| Quality Tests (post-merge) | 22986731960 ✓ |
|
||||
| Coverage | ≥40% gate satisfied (40% combined) |
|
||||
| verify_pinned_deps | ✓ Passed |
|
||||
| pip-audit | Informational (M27) |
|
||||
|
||||
**CI Root Cause Summary:** N/A (all green).
|
||||
**Minimal Fix Set:** None.
|
||||
**Guardrails:** Unchanged from M08.
|
||||
|
||||
---
|
||||
|
||||
## 5. Tests, Coverage, and Invariants (Delta-Only)
|
||||
|
||||
* **Coverage delta:** runtime_context.py 100% covered; overall 40% maintained.
|
||||
* **New tests:** None added; existing smoke/quality tests cover critical path (process_images_inner invoked).
|
||||
* **Invariant verification:** PASS — generation behavior, file output, extension compat, API, CLI preserved.
|
||||
* **Flaky tests:** None introduced.
|
||||
|
||||
**Missing Invariants:** None.
|
||||
**Missing Tests:** None for M09 scope.
|
||||
**Fast Fixes:** None.
|
||||
|
||||
---
|
||||
|
||||
## 6. Security & Supply Chain (Delta-Only)
|
||||
|
||||
* **Dependency deltas:** None. No new dependencies.
|
||||
* **Secrets exposure:** None.
|
||||
* **Workflow trust boundary:** Unchanged.
|
||||
* **pip-audit:** Informational; vulns deferred to M27 (M04 baseline).
|
||||
|
||||
---
|
||||
|
||||
## 7. Refactor Guardrail Compliance Check
|
||||
|
||||
| Guardrail | Status |
|
||||
|-----------|--------|
|
||||
| Invariant declaration | PASS — M09 plan declared invariants; verified by CI |
|
||||
| Baseline discipline | PASS — Range 710a0abd...2c6a2510; delta vs M08 documented |
|
||||
| Consumer contract protection | PASS — API/CLI/schema unchanged; smoke tests exercise contracts |
|
||||
| Extraction/split safety | N/A |
|
||||
| No silent CI weakening | PASS — All gates enforced |
|
||||
|
||||
---
|
||||
|
||||
## 8. Top Issues (Max 7, Ranked)
|
||||
|
||||
None. No issues identified for M09.
|
||||
|
||||
---
|
||||
|
||||
## 9. PR-Sized Action Plan
|
||||
|
||||
| ID | Task | Category | Acceptance Criteria | Risk | Est |
|
||||
|----|------|----------|---------------------|------|-----|
|
||||
| — | None required | — | — | — | — |
|
||||
|
||||
---
|
||||
|
||||
## 10. Deferred Issues Registry (Cumulative)
|
||||
|
||||
| ID | Issue | Discovered | Deferred To | Reason | Blocker? | Exit Criteria |
|
||||
|----|-------|------------|-------------|--------|----------|---------------|
|
||||
| SEC-001 | pip-audit vulns | M04 | M27 | Supply-chain evidence milestone | No | pip-audit clean or documented |
|
||||
|
||||
---
|
||||
|
||||
## 11. Score Trend (Cumulative)
|
||||
|
||||
| Milestone | Invariants | Compat | Arch | CI | Sec | Tests | DX | Docs | Overall |
|
||||
|-----------|------------|--------|------|-----|-----|-------|-----|------|---------|
|
||||
| M08 | 5 | 5 | 5 | 5 | 5 | 5 | 5 | 5 | 5.0 |
|
||||
| M09 | 5 | 5 | 5 | 5 | 5 | 5 | 5 | 5 | 5.0 |
|
||||
|
||||
M09 maintains 5.0. Execution context is additive; no new risk surface.
|
||||
|
||||
---
|
||||
|
||||
## 12. Flake & Regression Log (Cumulative)
|
||||
|
||||
| Item | Type | First Seen | Current Status | Last Evidence | Fix/Defer |
|
||||
|------|------|------------|----------------|--------------|-----------|
|
||||
| — | — | — | — | — | — |
|
||||
|
||||
No flaky tests or behavior-drift events for M09.
|
||||
139
docs/milestones/M09/M09_run1.md
Normal file
139
docs/milestones/M09/M09_run1.md
Normal file
|
|
@ -0,0 +1,139 @@
|
|||
# M09 CI Run 1 — Execution Context Introduction
|
||||
|
||||
**Date:** 2026-03-12
|
||||
**Branch:** m09-execution-context
|
||||
**PR:** #26
|
||||
**Trigger:** pull_request (PR to main)
|
||||
|
||||
---
|
||||
|
||||
## 1. Workflow Identity
|
||||
|
||||
| Workflow | Run ID | Trigger | Branch | Commit | Status |
|
||||
|----------|--------|---------|--------|--------|--------|
|
||||
| Linter | 22984770390 | pull_request | m09-execution-context | 398e281d | ✓ success |
|
||||
| Smoke Tests | 22984770373 | pull_request | m09-execution-context | 398e281d | ✓ success |
|
||||
|
||||
**Quality Tests:** Not yet run (triggered on push to main; will run post-merge).
|
||||
|
||||
---
|
||||
|
||||
## 2. Change Context
|
||||
|
||||
| Item | Value |
|
||||
|------|-------|
|
||||
| Milestone | M09 — Execution Context Introduction |
|
||||
| Phase | Phase II — Runtime Seam Preparation |
|
||||
| Posture | Behavior-preserving |
|
||||
| Refactor target | `modules/runtime_context.py` (new), `modules/processing.py` (attach p.runtime_context) |
|
||||
| Run type | First CI verification of M09 implementation |
|
||||
|
||||
---
|
||||
|
||||
## 3. Step 1 — Workflow Inventory
|
||||
|
||||
### Linter (22984770390)
|
||||
|
||||
| Job | Required? | Purpose | Pass/Fail |
|
||||
|-----|-----------|---------|-----------|
|
||||
| ruff | Yes | Python lint | ✓ |
|
||||
| eslint | Yes | JS lint | ✓ |
|
||||
|
||||
**Duration:** ~19s
|
||||
|
||||
### Smoke Tests (22984770373)
|
||||
|
||||
| Job / Step | Required? | Purpose | Pass/Fail |
|
||||
|------------|-----------|---------|-----------|
|
||||
| Verify repository | Yes | Guardrail: m-cahill/serena only | ✓ |
|
||||
| Verify base branch | Yes | Guardrail: PR targets main | ✓ |
|
||||
| Checkout Code | Yes | Fetch PR branch | ✓ |
|
||||
| Set up Python 3.10 | Yes | Runtime | ✓ |
|
||||
| Cache models | Yes | Deterministic model path | ✓ |
|
||||
| Install test dependencies | Yes | pytest, coverage | ✓ |
|
||||
| Install runtime dependencies | Yes | torch, CLIP, open_clip, requirements_versions | ✓ |
|
||||
| Create stub repositories | Yes | CI fake inference support | ✓ |
|
||||
| Setup environment | Yes | launch.py --exit | ✓ |
|
||||
| Smoke startup | Yes | Verify server can start | ✓ |
|
||||
| Start test server | Yes | Live server for API tests | ✓ |
|
||||
| **Run smoke tests** | **Yes** | **pytest test/smoke** | **✓** |
|
||||
| Kill test server | Yes | Cleanup | ✓ |
|
||||
| Upload main app output | No (always) | Artifact for debugging | ✓ |
|
||||
|
||||
**Duration:** 2m59s
|
||||
|
||||
---
|
||||
|
||||
## 4. Step 2 — Refactor Signal Integrity
|
||||
|
||||
### A) Tests
|
||||
|
||||
- **Tier:** Smoke only (test/smoke)
|
||||
- **Coverage of refactor target:** Smoke tests exercise txt2img and img2img API endpoints, which call `process_images()` → `process_images_inner()`. The new `p.runtime_context` is attached immediately after `p.opts_snapshot`; the generation path is unchanged. Smoke tests verify generation and save behavior.
|
||||
- **Failures:** None
|
||||
- **Golden/snapshot:** Smoke tests use CI fake inference (deterministic 1×1 PNG); no golden image comparison. API contract (response schema) and save paths exercised.
|
||||
- **Missing:** Quality tier tests will run on push to main (coverage ≥40%, pip-audit, verify_pinned_deps).
|
||||
|
||||
### B) Coverage
|
||||
|
||||
- Smoke run does not enforce a coverage gate (Quality Tests do, on push to main).
|
||||
- Coverage gate: ≥40% (M04 baseline).
|
||||
- Post-merge Quality run will report coverage.
|
||||
|
||||
### C) Static Gates
|
||||
|
||||
- Ruff and eslint passed. No new lint issues introduced by M09 changes.
|
||||
- New module `runtime_context.py` passes ruff.
|
||||
|
||||
---
|
||||
|
||||
## 5. Step 3 — Delta Analysis
|
||||
|
||||
### Change Inventory
|
||||
|
||||
| File | Change |
|
||||
|------|--------|
|
||||
| modules/runtime_context.py | **New:** RuntimeContext dataclass (model, opts_snapshot, device, state, cmd_opts) |
|
||||
| modules/processing.py | Import RuntimeContext; attach p.runtime_context in process_images_inner() after opts_snapshot |
|
||||
| docs/milestones/M09/M09_plan.md | Populated full plan |
|
||||
| docs/milestones/M09/M09_toolcalls.md | Tool call log |
|
||||
|
||||
**Unchanged (per M09 rules):** All `shared.sd_model`, `shared.device`, `shared.state`, `shared.cmd_opts` reads remain. Context is write-only; no migration yet.
|
||||
|
||||
### Expected vs Observed
|
||||
|
||||
- **Expected:** Same inputs → same outputs; no behavior change; p.runtime_context populated but not consumed.
|
||||
- **Observed:** All smoke tests pass. No regressions.
|
||||
|
||||
---
|
||||
|
||||
## 6. Step 4 — Invariant Verification
|
||||
|
||||
| Invariant | Verification | Status |
|
||||
|-----------|--------------|--------|
|
||||
| Generation behavior unchanged | Smoke tests pass; context is additive only | ✓ |
|
||||
| File output behavior | Save paths and format unchanged | ✓ |
|
||||
| Extension compatibility | shared.* unchanged; extensions unaffected | ✓ |
|
||||
| API responses | txt2img/img2img smoke tests pass | ✓ |
|
||||
| CLI behavior | No CLI changes | ✓ |
|
||||
|
||||
---
|
||||
|
||||
## 7. Blast Radius
|
||||
|
||||
**Files changed:**
|
||||
- `modules/runtime_context.py` (new)
|
||||
- `modules/processing.py` (modified)
|
||||
- `docs/milestones/M09/*`
|
||||
|
||||
**No other modules changed.** Invariant registry surfaces (CLI, API, file formats, extension API, generation semantics) preserved.
|
||||
|
||||
---
|
||||
|
||||
## 8. Verdict
|
||||
|
||||
**CI Status:** Green (Linter ✓, Smoke Tests ✓)
|
||||
|
||||
**Refactor posture:** Behavior-preserving. Fifth Phase II runtime seam: generation pipeline now exposes `p.runtime_context` grouping model, opts_snapshot, device, state, cmd_opts. Write-only; no consumption yet.
|
||||
|
||||
**Next step:** Await merge permission. Post-merge Quality Tests will run (coverage, pip-audit, verify_pinned_deps). M09 run analysis complete; ready for M09 audit and summary generation after closeout.
|
||||
62
docs/milestones/M09/M09_run2.md
Normal file
62
docs/milestones/M09/M09_run2.md
Normal file
|
|
@ -0,0 +1,62 @@
|
|||
# M09 CI Run 2 — Post-Merge Quality Verification
|
||||
|
||||
**Date:** 2026-03-12
|
||||
**Branch:** main (post-merge)
|
||||
**Merge commit:** 2c6a2510
|
||||
**Trigger:** push (Merge PR #26)
|
||||
|
||||
---
|
||||
|
||||
## 1. Workflow Identity
|
||||
|
||||
| Workflow | Run ID | Trigger | Branch | Commit | Status |
|
||||
|----------|--------|---------|--------|--------|--------|
|
||||
| Quality Tests | **22986731960** | push | main | 2c6a2510 | ✓ success |
|
||||
| Linter | 22986731933 | push | main | 2c6a2510 | ✓ success |
|
||||
|
||||
---
|
||||
|
||||
## 2. Quality Tests (22986731960)
|
||||
|
||||
| Job / Step | Required? | Purpose | Pass/Fail |
|
||||
|------------|-----------|---------|-----------|
|
||||
| Verify repository | Yes | Guardrail: m-cahill/serena only | ✓ |
|
||||
| Verify ref | Yes | Guardrail: push to main | ✓ |
|
||||
| Checkout Code | Yes | Fetch merge commit | ✓ |
|
||||
| Set up Python 3.10 | Yes | Runtime | ✓ |
|
||||
| Cache models | Yes | Deterministic model path | ✓ |
|
||||
| Install dependencies | Yes | torch, CLIP, requirements_versions | ✓ |
|
||||
| Dependency vulnerability scan (pip-audit) | Informational | Dependency vuln scan | ⚠ (deferred M27) |
|
||||
| Verify pinned dependencies | Yes | Pinned deps enforcement | ✓ |
|
||||
| Create stub repositories | Yes | CI fake inference | ✓ |
|
||||
| Setup environment | Yes | launch.py --exit | ✓ |
|
||||
| Start test server | Yes | Live server for API tests | ✓ |
|
||||
| **Run quality tests** | **Yes** | **pytest test** (coverage ≥40%) | **✓** |
|
||||
| Kill test server | Yes | Cleanup | ✓ |
|
||||
| Show coverage | Yes | --fail-under=40 | ✓ |
|
||||
| Upload artifacts | No (always) | coverage.xml, htmlcov, output | ✓ |
|
||||
|
||||
**Duration:** 3m37s
|
||||
|
||||
**Annotation:** pip-audit found vulnerabilities. Remediation deferred to M27. See M04_audit.md.
|
||||
|
||||
---
|
||||
|
||||
## 3. CI Confirmation
|
||||
|
||||
| Check | Status |
|
||||
|-------|--------|
|
||||
| Quality Tests | ✓ |
|
||||
| Coverage | 40% (≥40% gate passed) |
|
||||
| pip-audit | Informational (M27) |
|
||||
| verify_pinned_deps | ✓ |
|
||||
|
||||
**Coverage note:** Combined coverage (server + tests) 40%. New module `runtime_context.py` 100% covered.
|
||||
|
||||
---
|
||||
|
||||
## 4. Verdict
|
||||
|
||||
**CI Status:** Green
|
||||
|
||||
All gates passed. M09 closeout verified. Ready for audit and summary generation.
|
||||
161
docs/milestones/M09/M09_summary.md
Normal file
161
docs/milestones/M09/M09_summary.md
Normal file
|
|
@ -0,0 +1,161 @@
|
|||
# M09 Summary — Execution Context Introduction
|
||||
|
||||
📌 Milestone Summary — M09: Execution Context Introduction
|
||||
==========================================================
|
||||
|
||||
**Project:** Serena
|
||||
**Phase:** Phase II — Runtime Seam Preparation
|
||||
**Milestone:** M09 — Execution context introduction
|
||||
**Timeframe:** 2026-03-11 → 2026-03-12
|
||||
**Status:** Closed
|
||||
**Baseline:** 710a0abd (M08 merge)
|
||||
**Refactor Posture:** Behavior-Preserving
|
||||
|
||||
---
|
||||
|
||||
## 1. Milestone Objective
|
||||
|
||||
M09 existed to introduce a lightweight runtime execution context that groups model, opts_snapshot, device, state, and cmd_opts. The context is attached to the processing object as `p.runtime_context` but is write-only in M09 — no migration of `shared.*` reads yet.
|
||||
|
||||
**What would remain unsafe or ungoverned if this refactor did not occur?** The runtime would lack a single object grouping its dependencies, blocking Phase III ProcessingRunner and testable runtime extraction. Extensions would remain coupled to global shared state with no seam for future isolation.
|
||||
|
||||
---
|
||||
|
||||
## 2. Scope Definition
|
||||
|
||||
### In Scope
|
||||
|
||||
* `modules/runtime_context.py` — New RuntimeContext dataclass (model, opts_snapshot, device, state, cmd_opts)
|
||||
* `modules/processing.py` — Attach p.runtime_context in process_images_inner() after opts_snapshot creation
|
||||
* CI: Linter, Smoke Tests (PR), Quality Tests (post-merge)
|
||||
* Documentation: M09_plan.md, M09_toolcalls.md, M09_run1.md, M09_run2.md
|
||||
|
||||
### Out of Scope
|
||||
|
||||
* Migration of shared.sd_model, shared.device, shared.state, shared.cmd_opts reads
|
||||
* Extension interface changes
|
||||
* Sampling behavior changes
|
||||
* API/CLI changes
|
||||
|
||||
---
|
||||
|
||||
## 3. Refactor Classification
|
||||
|
||||
### Change Type
|
||||
|
||||
**Mechanical refactor** — Add new dataclass and assign it to p.runtime_context. No logic change; additive only.
|
||||
|
||||
### Observability
|
||||
|
||||
* **API responses:** Unchanged
|
||||
* **CLI output:** Unchanged
|
||||
* **File formats / save paths:** Unchanged
|
||||
* **Model outputs:** Unchanged
|
||||
|
||||
---
|
||||
|
||||
## 4. Work Executed
|
||||
|
||||
* Created modules/runtime_context.py with RuntimeContext dataclass
|
||||
* Added import and assignment in process_images_inner() after p.opts_snapshot
|
||||
* No functional logic changed; context populated from shared.* but not consumed
|
||||
* Files changed: modules/runtime_context.py (new), modules/processing.py, docs/milestones/M09/*
|
||||
|
||||
---
|
||||
|
||||
## 5. Invariants & Compatibility
|
||||
|
||||
### Declared Invariants (must by default Not Change)
|
||||
|
||||
* Generation behavior unchanged (same inputs → same outputs)
|
||||
* File output behavior unchanged
|
||||
* Extension compatibility (shared.* unchanged)
|
||||
* API compatibility (txt2img/img2img)
|
||||
* CLI behavior unchanged
|
||||
|
||||
### Compatibility Notes
|
||||
|
||||
* Backward compatibility preserved: Yes
|
||||
* Breaking changes introduced: No
|
||||
* Deprecations introduced: No
|
||||
|
||||
---
|
||||
|
||||
## 6. Validation & Evidence
|
||||
|
||||
| Evidence Type | Tool/Workflow | Result | Notes |
|
||||
|--------------|---------------|--------|-------|
|
||||
| Linter | ruff, eslint | ✓ | PR #26 |
|
||||
| Smoke Tests | pytest test/smoke | ✓ | PR #26, run 22984770373 |
|
||||
| Quality Tests | pytest test/smoke test/quality | ✓ | Post-merge 22986731960 |
|
||||
| Coverage | ≥40% gate | ✓ | 40% combined; runtime_context.py 100% |
|
||||
| verify_pinned_deps | scripts/ci/verify_pinned_deps.sh | ✓ | Quality Tests |
|
||||
| pip-audit | Informational | ⚠ | Deferred M27 |
|
||||
|
||||
---
|
||||
|
||||
## 7. CI / Automation Impact
|
||||
|
||||
* Workflows affected: None (unchanged)
|
||||
* Checks added/removed: None
|
||||
* Enforcement: Unchanged
|
||||
* Signal drift: None observed
|
||||
|
||||
---
|
||||
|
||||
## 8. Issues, Exceptions, and Guardrails
|
||||
|
||||
No new issues were introduced during this milestone.
|
||||
|
||||
---
|
||||
|
||||
## 9. Deferred Work
|
||||
|
||||
* pip-audit vulnerabilities: Pre-existing from M04; deferred to M27. Status unchanged.
|
||||
|
||||
---
|
||||
|
||||
## 10. Governance Outcomes
|
||||
|
||||
* Runtime seam stack now includes execution context: fifth Phase II seam
|
||||
* Phase II — Runtime Seam Preparation complete
|
||||
* Invariants preserved and verified by CI
|
||||
|
||||
**What is now provably true that was not provably true before?** The generation runtime exposes `p.runtime_context` grouping model, opts_snapshot, device, state, cmd_opts. This completes Phase II and enables Phase III ProcessingRunner and shared state reduction.
|
||||
|
||||
---
|
||||
|
||||
## 11. Exit Criteria Evaluation
|
||||
|
||||
| Criterion | Status | Evidence |
|
||||
|-----------|--------|----------|
|
||||
| RuntimeContext introduced | Met | modules/runtime_context.py |
|
||||
| Context attached to processing object | Met | p.runtime_context in process_images_inner |
|
||||
| CI fully green | Met | Linter, Smoke, Quality ✓ |
|
||||
| No behavior change | Met | Smoke + quality pass |
|
||||
| Milestone artifacts generated | Met | Plan, toolcalls, run1, run2, audit, summary |
|
||||
| Ledger updated | Met | docs/serena.md |
|
||||
| Tag created | Met | v0.0.09-m09 |
|
||||
|
||||
---
|
||||
|
||||
## 12. Final Verdict
|
||||
|
||||
Milestone objectives met. Refactor verified safe. Phase II complete. Proceed to Phase III (M10).
|
||||
|
||||
---
|
||||
|
||||
## 13. Authorized Next Step
|
||||
|
||||
M10 — ProcessingRunner skeleton. No additional constraints.
|
||||
|
||||
---
|
||||
|
||||
## 14. Canonical References
|
||||
|
||||
* Commit: 2c6a2510 (merge)
|
||||
* PR: #26 (https://github.com/m-cahill/serena/pull/26)
|
||||
* CI Run 1 — Linter: 22984770390; Smoke: 22984770373
|
||||
* CI Run 2 — Quality: 22986731960; Linter: 22986731933
|
||||
* Tag: v0.0.09-m09
|
||||
* Documents: docs/milestones/M09/M09_plan.md, M09_run1.md, M09_run2.md, M09_audit.md, M09_summary.md
|
||||
|
|
@ -138,6 +138,7 @@ Core principles:
|
|||
| M06 | Prompt/seed prep extraction | Completed | m06-prompt-seed-prep | #20 | 6744152a | Quality 22890285319 ✓ | 5.0 / 5 | 2026-03-10 |
|
||||
| M07 | Opts snapshot introduction | Completed | m07-opts-snapshot | #22 | 8ea50d35 | Quality 22983583947 ✓ | 5.0 / 5 | 2026-03-12 |
|
||||
| M08 | Opts snapshot threading | Completed | m08-snapshot-threading | #24 | 710a0abd | Quality 22984445599 ✓ | 5.0 / 5 | 2026-03-12 |
|
||||
| M09 | Execution context introduction | Completed | m09-execution-context | #26 | 2c6a2510 | Quality 22986731960 ✓ | 5.0 / 5 | 2026-03-12 |
|
||||
|
||||
**M05:** Introduced `temporary_opts()` context manager — first Phase II runtime seam. Isolates override_settings mutation from global `shared.opts`; preserves behavior (opts.set, setattr restore, k in opts.data). Model/VAE reload and token merging remain in process_images. Enables future opts snapshot injection (M07).
|
||||
|
||||
|
|
@ -147,6 +148,8 @@ Core principles:
|
|||
|
||||
**M08:** Threaded p.opts_snapshot into process_images_inner for save-related reads. Fourth Phase II runtime seam. Migrated 12 opts (save_images_before_face_restoration, samples_format, grid_save, etc.) from shared.opts to p.opts_snapshot. save_samples(), sample_hr_pass(), metadata unchanged. Enables M09 execution context.
|
||||
|
||||
**M09:** Introduced RuntimeContext in modules/runtime_context.py. Fifth Phase II runtime seam. Attached p.runtime_context in process_images_inner() after opts_snapshot (model, opts_snapshot, device, state, cmd_opts). Write-only in M09; no migration of shared.* reads yet. Completes Phase II — Runtime Seam Preparation. Enables Phase III ProcessingRunner.
|
||||
|
||||
---
|
||||
|
||||
## 5. Standing Invariants
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue