mirrors/nebula
1
Fork 0
mirror of https://github.com/slackhq/nebula.git synced 2026-01-24 05:21:11 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make DNS add* functions private and remove unneccisary locking

Browse source
This commit is contained in:
Andreas Bell Martinsen 2026-01-02 15:05:14 +01:00
parent 1e82d35b00
commit 6262ef6e35
1 changed files with 16 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

37
dns_server.go
View file

@ -34,9 +34,7 @@ func newDnsRecords(l *logrus.Logger) *dnsRecords {
}
}
func (d *dnsRecords) AddA(name string, addresses []netip.Addr) {
d.Lock()
defer d.Unlock()
func (d *dnsRecords) addA(name string, addresses []netip.Addr) {
q := dns.Question{Name: name, Qclass: dns.ClassINET, Qtype: dns.TypeA}
d.dnsMap[q] = nil
@ -50,11 +48,9 @@ func (d *dnsRecords) AddA(name string, addresses []netip.Addr) {
}
}
}
}
}
func (d *dnsRecords) AddAAAA(name string, addresses []netip.Addr) {
d.Lock()
defer d.Unlock()
func (d *dnsRecords) addAAAA(name string, addresses []netip.Addr) {
q := dns.Question{Name: name, Qclass: dns.ClassINET, Qtype: dns.TypeAAAA}
d.dnsMap[q] = nil
@ -68,12 +64,9 @@ func (d *dnsRecords) AddAAAA(name string, addresses []netip.Addr) {
}
}
}
}
func (d *dnsRecords) AddPTR(name string, addresses []netip.Addr) {
d.Lock()
defer d.Unlock()
}
func (d *dnsRecords) addPTR(name string, addresses []netip.Addr) {
for _, addr := range addresses {
arpa, err := dns.ReverseAddr(addr.String())
if err == nil {
@ -86,11 +79,9 @@ func (d *dnsRecords) AddPTR(name string, addresses []netip.Addr) {
}
}
}
}
}
func (d *dnsRecords) AddTXT(name string, crt cert.Certificate) {
d.Lock()
defer d.Unlock()
func (d *dnsRecords) addTXT(name string, crt cert.Certificate) {
q := dns.Question{Name: name, Qclass: dns.ClassINET, Qtype: dns.TypeTXT}
d.dnsMap[q] = nil
@ -100,14 +91,18 @@ func (d *dnsRecords) AddTXT(name string, crt cert.Certificate) {
d.dnsMap[q] = []dns.RR{rr}
d.l.Debugf("DNS record added %s", rr.String())
}
}
}
func (d *dnsRecords) Add(crt cert.Certificate, addresses []netip.Addr) {
host := dns.Fqdn(strings.ToLower(crt.Name() + dnsSuffix))
d.AddA(host, addresses)
d.AddAAAA(host, addresses)
d.AddPTR(host, addresses)
d.AddTXT(host, crt)
d.Lock()
defer d.Unlock()
d.addA(host, addresses)
d.addAAAA(host, addresses)
d.addPTR(host, addresses)
d.addTXT(host, crt)
}
func (d *dnsRecords) parseQuery(m *dns.Msg) {