1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 14:30:50 -08:00
emacs/lisp/emacs-lisp
João Távora fcd43287b3 Don't needlessly request docs from ElDoc functions
Fixes: bug#42421

Do this conservatively for now: if the ElDoc helper buffer (as
returned by eldoc--doc-buffer) is visible and showing documentation
for the very same "situation" (as computed by the the new
eldoc--request-state helper), don't request that documentation from
sources again.

Before this change, not only was that request inefficient but if the
user invoked scroll-other-window to see more of the helper buffer,
that would eventually cause it to be reformatted and unexpectedly
recentered.

Later on, when a customizable list of documentation "sinks" is offered
to the user, say, something like eldoc-display-functions, this process
must be consolidated.  In those circumstances, as soon as one of those
sinks signals that it doesn't have up-to-date documentation for the
state computed by eldoc--request-state, documentation will have to be
requested anew from eldoc-documentation-functions via
eldoc--invoke-strategy.

* lisp/emacs-lisp/eldoc.el (eldoc--request-docs-p): Rework from
eglot-display-message-p.
(eldoc--last-request-state): New variable.
(eldoc--request-state): New helper.
(eldoc--handle-docs): Memorize state of request in doc buffer.
(eldoc-print-current-symbol-info): Pass a token to
eldoc--request-docs-p.
(Version): Bump to 1.6.0
2020-07-23 11:57:27 +01:00
..
advice.el
autoload.el Merge from origin/emacs-27 2020-04-15 07:50:15 -07:00
avl-tree.el
backquote.el
backtrace.el
benchmark.el Revert last change in benchmark.el 2020-06-21 19:01:40 +01:00
bindat.el Add new tests to bindat-tests.el 2020-04-29 09:52:34 +02:00
byte-opt.el Optimise assoc and rassoc with symbol key to assq and rassq 2020-07-07 17:55:20 +02:00
byte-run.el Merge from origin/emacs-27 2020-05-09 10:03:21 -07:00
bytecomp.el Merge from origin/emacs-27 2020-06-01 22:26:32 -07:00
cconv.el
chart.el
check-declare.el Use lexical-binding in check-declare.el and add tests 2020-05-03 19:50:57 +02:00
checkdoc.el Merge from origin/emacs-27 2020-04-20 07:50:19 -07:00
cl-extra.el Make cl-concatenate an alias of seq-concatenate 2020-03-23 18:58:21 -04:00
cl-generic.el
cl-indent.el Remove redundant :groups args missed in last commit 2020-05-03 16:21:51 +02:00
cl-lib.el
cl-macs.el * lisp/emacs-lisp/cl-macs.el (cl-deftype-satisfies): Add keyword 2020-07-06 18:04:54 -04:00
cl-preloaded.el
cl-print.el
cl-seq.el
copyright.el
crm.el
cursor-sensor.el * lisp/emacs-lisp/cursor-sensor.el (cursor-sensor--detect): Change last fix 2020-02-24 09:55:09 -05:00
debug.el * lisp/emacs-lisp/debug.el (debug): Merge the non-interactive cases 2020-01-31 16:09:42 +02:00
derived.el
disass.el
easy-mmode.el
easymenu.el
edebug.el Fix bug #40992 whilst still allowing breakpoint highlights in edebug 2020-05-11 20:05:54 +00:00
eieio-base.el Revert "Inhibit modification hooks when saving eieio-persistent's" 2020-05-12 21:06:22 +02:00
eieio-compat.el
eieio-core.el Un-deprecate oset and oset-default 2020-06-06 17:24:00 +01:00
eieio-custom.el
eieio-datadebug.el
eieio-opt.el
eieio-speedbar.el
eieio.el Un-deprecate oset and oset-default 2020-06-06 17:24:00 +01:00
eldoc.el Don't needlessly request docs from ElDoc functions 2020-07-23 11:57:27 +01:00
elint.el
elp.el ; Fix some typos and doc issues (bug#40695) 2020-04-18 17:10:02 +02:00
ert-x.el
ert.el
ewoc.el
faceup.el
find-func.el load-library, locate-library: Use read-library-name 2020-04-03 14:54:49 +03:00
float-sup.el Use lexical-binding in float-sup.el and add tests 2020-04-29 09:25:02 +02:00
generator.el Band-aid for edebugging generator bodies (Bug#40434). 2020-06-14 20:01:28 +02:00
generic.el
gv.el Ensure that getters and setters can be edebugged at the same time. 2020-06-14 18:18:13 +02:00
helper.el
inline.el
let-alist.el
lisp-mnt.el Globally sanitize single-file package long descriptions (Bug#37548) 2020-01-23 22:57:23 +01:00
lisp-mode.el * lisp/emacs-lisp/lisp-mode.el: Add new indentation convention 2020-05-29 00:26:09 -04:00
lisp.el
macroexp.el
map-ynp.el
map.el * lisp/emacs-lisp/map.el: Add keyword-only pattern abbreviation 2020-02-04 12:30:31 -05:00
nadvice.el
package-x.el
package.el Evaluate some unnecessarily quoted lambdas 2020-06-21 13:42:14 +01:00
pcase.el * lisp/emacs-lisp/pcase.el (pcase--fgrep): Look inside vectors 2020-05-11 09:53:37 -04:00
pp.el
radix-tree.el
re-builder.el Fix void-variable n-reb in re-builder (Bug#40409) 2020-04-04 20:06:54 -04:00
regexp-opt.el Remove the optional KEEP-ORDER argument to regexp-opt 2020-02-13 20:43:42 +01:00
regi.el
ring.el
rmc.el
rx.el Various battery.el improvements (bug#41808) 2020-06-18 12:58:28 +01:00
seq.el Fix byte-compilation warning in project.el 2020-06-26 10:15:46 +03:00
shadow.el Fix edge case errors in filename-matching regexps 2020-04-14 12:25:16 +02:00
smie.el * lisp/emacs-lisp/package.elm lisp/emacs-lisp/smie.el: Fix indent 2020-05-29 15:01:58 -04:00
subr-x.el gnus-shorten-url: Improve and avoid args-out-of-range error 2020-04-13 12:12:00 +02:00
syntax.el Allow back-references in syntax-propertize-rules. 2020-05-19 20:50:14 +02:00
tabulated-list.el
tcover-ses.el
tcover-unsafep.el
testcover.el
text-property-search.el Fix NOT-CURRENT behaviour in text-property-search-backward 2020-07-17 18:44:49 +02:00
thunk.el
timer-list.el Support sorting timer-list-mode by column (Bug#40854) 2020-05-12 19:10:20 +02:00
timer.el Simplify run-at-time 2020-03-08 00:25:38 -08:00
tq.el
trace.el Clarify semantics of trace-function CONTEXT argument 2020-04-25 09:55:37 -04:00
unsafep.el
warnings.el