1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-30 20:32:00 -08:00
emacs/test/lisp
Stefan Kangas 61e51fee9c Base bookmark-bmenu-mode on tabulated-list-mode (Bug#39293)
Rewriting bookmark-bmenu-mode to be based on 'tabulated-list-mode'
allows us to greatly simplify the code in several cases.  In addition,
we get some features for free, such as sorting by column.

The only functional step backwards is that we no longer support the
optional "inline" header line, a bookmark.el-specific feature to have
a header without using 'header-line-format'.  This feature is believed
to be not very useful or widely used.

* lisp/bookmark.el (tabulated-list): Require.
(bookmark-bmenu-mode): Inherit from 'tabulated-list-mode' instead of
'special-mode' and make the necessary changes to support that.
(bookmark-bmenu-mode-map): Inherit from 'tabulated-list-mode-map'
instead of 'special-mode-map'.  Remove now duplicate key bindings.
(bookmark-bmenu--revert): New function to show the bookmark list using
'tabulated-list-mode'.
(bookmark-bmenu-list): Simplify by using above new function.
(bookmark-bmenu-bookmark): Adapt to 'tabulated-list-mode'.
(bookmark-bmenu--name-predicate)
(bookmark-bmenu--file-predicate): New functions used by
'tabulated-list-mode' to sort.

(bookmark-bmenu-set-header): Redefine as obsolete function alias for
'tabulated-list-init-header'.
(bookmark-bmenu-toggle-filenames, bookmark-bmenu-show-filenames)
(bookmark-bmenu-hide-filenames, bookmark-bmenu-mark)
(bookmark-bmenu-mark-all, bookmark-bmenu-unmark-all)
(bookmark-bmenu-delete-all, bookmark-bmenu-unmark)
(bookmark-bmenu-delete, bookmark-bmenu-delete-backwards): Simplify now
that we can depend on 'tabulated-list-mode' to do more work.

(bookmark-bmenu-use-header-line)
(bookmark-bmenu-inline-header-height): Declare variables relating to
the now unsupported "inline" header obsolete.
(bookmark-bmenu-ensure-position)
(bookmark-bmenu-execute-deletions): Remove code to handle "inline" header.

* test/lisp/bookmark-tests.el
(bookmark-test-bmenu-edit-annotation/show-annotation)
(bookmark-test-bmenu-unmark, bookmark-test-bmenu-mark): Update tests
for minor changes when using 'tabulated-list-mode'.
2020-10-17 17:56:44 +02:00
..
bookmark-resources Add ability to mark/unmark/delete all bookmarks 2020-08-09 15:13:05 -05:00
calc Calc: allow infinite binary word size (bug#43764) 2020-10-13 11:29:01 +02:00
calendar Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
cedet Mark some tests as expensive 2020-09-10 20:25:19 +02:00
custom-resources Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
emacs-lisp Fix file-name problems in several tests 2020-10-16 16:49:47 +03:00
emulation Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
erc Make the erc /ignore command prompt for a timeout 2020-08-05 10:27:40 +02:00
eshell Use lexical-binding in more tests 2020-08-29 22:41:51 +02:00
gnus Make Gnus more liberal when interpreting Face headers again 2020-10-15 08:39:00 +02:00
image Make gravatar-build-url respect dynamically bound variables again 2020-07-31 04:19:03 +02:00
international Fix mule-util-tests after recent truncation changes 2020-10-06 03:48:00 +02:00
mail * test/lisp/mail/rfc822-tests.el: New file. 2020-10-17 15:55:42 +02:00
net Make last change in tramp-archive-tests.el backward compatible 2020-10-16 16:51:25 +02:00
nxml Convert a manual test for nxml-mode to unit test 2020-09-21 18:47:55 +02:00
obsolete Silence byte-compiler in two tests 2020-10-01 15:34:46 +02:00
org * test/lisp/org/org-tests.el: Use lexical-binding. 2020-09-10 19:32:53 +02:00
pcmpl-linux-resources Use lexical-binding in pcmpl-linux.el and add tests 2020-09-02 12:53:02 +02:00
play Fix animate test that somehow changed recently 2020-10-06 03:51:17 +02:00
progmodes Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
saveplace-resources Use lexical-binding in saveplace.el and add tests 2020-08-08 01:40:38 +02:00
so-long-tests ; shorten https://lists.gnu.org/archive/html/... links 2020-10-09 12:23:02 +02:00
term Update copyright year to 2020 2020-01-01 00:59:52 +00:00
textmodes Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
url Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
vc Stop using a dynamically bound 'generated-autoload-file' variable 2020-10-02 04:34:31 +02:00
abbrev-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
allout-tests.el Convert allout unit tests to ERT 2020-09-23 20:03:19 +02:00
allout-widgets-tests.el Convert allout unit tests to ERT 2020-09-23 20:03:19 +02:00
apropos-tests.el Use lexical-binding in apropos.el and add tests 2020-04-18 18:43:23 +02:00
arc-mode-tests.el Silence some byte-compiler warnings 2020-09-26 12:03:07 +02:00
auth-source-pass-tests.el * test/lisp/auth-source-pass-tests.el: Test for multiple ports. 2020-01-22 07:37:01 +01:00
auth-source-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
autoinsert-tests.el Evaluate some unnecessarily quoted lambdas 2020-06-21 13:42:14 +01:00
autorevert-tests.el Mark some tests as expensive 2020-09-10 20:25:19 +02:00
battery-tests.el Improve battery.el UPower support 2020-06-18 13:11:17 +01:00
bookmark-tests.el Base bookmark-bmenu-mode on tabulated-list-mode (Bug#39293) 2020-10-17 17:56:44 +02:00
buff-menu-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
button-tests.el Substitute command keys in button help-echo values 2020-10-16 09:32:48 +02:00
char-fold-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
color-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
comint-tests.el Match OpenBSD doas password prompt in comint 2020-10-09 06:57:07 +02:00
completion-tests.el Convert some completion.el tests to ERT 2020-09-23 20:03:19 +02:00
custom-tests.el Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
dabbrev-tests.el Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
delim-col-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
descr-text-tests.el Update tests for recent changes 2020-07-08 17:35:54 -07:00
dired-aux-tests.el ; Fix typos 2020-09-21 14:26:42 +02:00
dired-tests.el Move dired-jump from dired-x to dired (Bug#21981) 2020-09-12 03:42:37 +02:00
dired-x-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
dom-tests.el ; Fix last addition to dom-tests.el 2020-04-30 10:46:54 +01:00
electric-tests.el Merge from origin/emacs-27 2020-10-02 09:38:24 -07:00
elide-head-tests.el Use lexical-binding in elide-head.el and add tests 2020-04-19 08:04:57 +02:00
epg-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
faces-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
ffap-tests.el Add support for ffap guessing at file names containing spaces 2020-08-15 12:11:41 +02:00
filenotify-tests.el Mark some tests as expensive 2020-09-10 20:25:19 +02:00
files-tests.el Merge from origin/emacs-27 2020-10-02 09:38:24 -07:00
files-x-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
font-lock-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
format-spec-tests.el Fix and extend format-spec (bug#41758) 2020-06-18 12:46:21 +01:00
help-fns-tests.el Adjust some tests so that they work in symlinked environs 2020-10-16 10:33:19 +02:00
help-mode-tests.el Use lexical-binding in help-mode.el and add tests 2020-05-09 20:01:37 +02:00
help-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
hi-lock-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
htmlfontify-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
ibuffer-tests.el Remove (or double) redundant backslashes in string literals 2020-01-24 23:04:34 +01:00
ido-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
image-file-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
image-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
imenu-tests.el Silence some warnings in tests 2020-06-21 12:50:34 +01:00
info-xref-tests.el Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
isearch-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
jit-lock-tests.el Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
json-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
jsonrpc-tests.el ; Fix typos 2020-09-21 14:26:42 +02:00
kmacro-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
ls-lisp-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
makesum-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
man-tests.el Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
md4-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
minibuffer-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
misc-tests.el Use lexical-binding in misc.el and add tests 2020-04-26 00:30:37 +02:00
mouse-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
mwheel-tests.el Use mouse-wheel-up-event in mwheel-tests.el 2020-09-08 18:31:15 +02:00
obarray-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
paren-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
password-cache-tests.el Don’t attempt to modify constant strings 2020-05-16 22:25:07 -07:00
pcmpl-linux-tests.el Use new resource directory macros in tests (Bug#43792) 2020-10-16 11:28:09 +02:00
ps-print-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
register-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
replace-tests.el occur: Add bindings for next-error-no-select 2020-05-31 12:31:27 +02:00
rot13-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
saveplace-tests.el Fix file-name problems in several tests 2020-10-16 16:49:47 +03:00
scroll-lock-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
ses-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
shadowfile-tests.el Mark some tests as expensive 2020-09-10 20:25:19 +02:00
shell-tests.el Fix shell-tests failures 2020-01-20 15:52:27 +01:00
simple-tests.el Merge from origin/emacs-27 2020-10-10 07:50:20 -07:00
sort-tests.el ; Fix license statements. 2020-08-27 02:53:25 +02:00
soundex-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
startup-tests.el Fix documentation related to 'command-switch-alist'. 2020-05-14 19:29:14 +02:00
subr-tests.el ; * test/lisp/subr-tests.el (string-replace): Add more test cases 2020-09-27 13:32:27 +02:00
tabify-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
tar-mode-tests.el Combine archive-int-to-mode and tar-grind-file-mode 2020-05-14 18:43:15 +02:00
tempo-tests.el Allow tempo-define-template to reassign tags to new templates 2020-02-21 11:15:00 +02:00
term-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
thingatpt-tests.el Use lexical-binding in most remaining tests 2020-05-01 13:05:26 +02:00
thread-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
time-stamp-tests.el Merge from origin/emacs-27 2020-01-01 01:08:16 +00:00
timezone-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
version-tests.el Use lexical-binding in version.el and add tests 2020-04-28 23:35:52 +02:00
wdired-tests.el Fix bug in wdired-get-filename 2020-10-01 23:34:01 +02:00
whitespace-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
wid-edit-tests.el Allow the newline character in the character widget (Bug#15925) 2020-09-23 15:45:36 +02:00
xdg-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00
xml-tests.el Repurpose libxml test for obsolete argument 2020-09-26 11:48:09 +02:00
xt-mouse-tests.el Update copyright year to 2020 2020-01-01 00:59:52 +00:00