1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 14:30:50 -08:00
emacs/lisp/calc
Paul Eggert f18af6cd5c Audit use of lsh and fix glitches
I audited use of lsh in the Lisp source code, and fixed the
glitches that I found.  While I was at it, I replaced uses of lsh
with ash when either will do.  Replacement is OK when either
argument is known to be nonnegative, or when only the low-order
bits of the result matter, and is a (minor) win since ash is a bit
more solid than lsh nowadays, and is a bit faster.
* lisp/calc/calc-ext.el (math-check-fixnum):
Prefer most-positive-fixnum to (lsh -1 -1).
* lisp/vc/vc-hg.el (vc-hg-state-fast): When testing fixnum width,
prefer (zerop (ash most-positive-fixnum -32)) to (zerop (lsh -1
32)) (Bug#32485#11).
* lisp/emacs-lisp/bytecomp.el (byte-compile-lapcode):
Tighten sanity-check for bytecode overflow, by checking that the
result of (ash pc -8) is nonnegative.  Formerly this check was not
needed since lsh was used and the number overflowed differently.
* lisp/net/dns.el (dns-write): Fix some obvious sign typos in
shift counts.  Evidently this part of the code has never been
exercised.
* lisp/progmodes/hideif.el (hif-shiftleft, hif-shiftright):
* lisp/term/common-win.el (x-setup-function-keys):
Simplify.
* admin/unidata/unidata-gen.el, admin/unidata/uvs.el:
* doc/lispref/keymaps.texi, doc/lispref/syntax.texi:
* doc/misc/calc.texi, doc/misc/cl.texi, etc/NEWS.19:
* lisp/arc-mode.el, lisp/calc/calc-bin.el, lisp/calc/calc-comb.el:
* lisp/calc/calc-ext.el, lisp/calc/calc-math.el:
* lisp/cedet/semantic/wisent/comp.el, lisp/composite.el:
* lisp/disp-table.el, lisp/dos-fns.el, lisp/edmacro.el:
* lisp/emacs-lisp/bindat.el, lisp/emacs-lisp/byte-opt.el:
* lisp/emacs-lisp/bytecomp.el, lisp/emacs-lisp/cl-extra.el:
* lisp/erc/erc-dcc.el, lisp/facemenu.el, lisp/gnus/message.el:
* lisp/gnus/nndoc.el, lisp/gnus/nnmaildir.el, lisp/image.el:
* lisp/international/ccl.el, lisp/international/fontset.el:
* lisp/international/mule-cmds.el, lisp/international/mule.el:
* lisp/json.el, lisp/mail/binhex.el, lisp/mail/rmail.el:
* lisp/mail/uudecode.el, lisp/md4.el, lisp/net/dns.el:
* lisp/net/ntlm.el, lisp/net/sasl.el, lisp/net/socks.el:
* lisp/net/tramp.el, lisp/obsolete/levents.el:
* lisp/obsolete/pgg-parse.el, lisp/org/org.el:
* lisp/org/ox-publish.el, lisp/progmodes/cc-defs.el:
* lisp/progmodes/ebnf2ps.el, lisp/progmodes/hideif.el:
* lisp/ps-bdf.el, lisp/ps-print.el, lisp/simple.el:
* lisp/tar-mode.el, lisp/term/common-win.el:
* lisp/term/tty-colors.el, lisp/term/xterm.el, lisp/vc/vc-git.el:
* lisp/vc/vc-hg.el, lisp/x-dnd.el, test/src/data-tests.el:
Prefer ash to lsh when either will do.
2018-08-21 13:44:32 -07:00
..
calc-aent.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-alg.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-arith.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-bin.el Audit use of lsh and fix glitches 2018-08-21 13:44:32 -07:00
calc-comb.el Audit use of lsh and fix glitches 2018-08-21 13:44:32 -07:00
calc-cplx.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-embed.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-ext.el Audit use of lsh and fix glitches 2018-08-21 13:44:32 -07:00
calc-fin.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-forms.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-frac.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-funcs.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-graph.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-help.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-incom.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-keypd.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-lang.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-macs.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-map.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-math.el Audit use of lsh and fix glitches 2018-08-21 13:44:32 -07:00
calc-menu.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-misc.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-mode.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-mtx.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-nlfit.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-poly.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-prog.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-rewr.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-rules.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-sel.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-stat.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-store.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-stuff.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-trail.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-undo.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-units.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-vec.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc-yank.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calc.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calcalg2.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calcalg3.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calccomp.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00
calcsel2.el Update copyright year to 2018 2018-01-01 00:57:59 -08:00