1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-09 15:50:40 -08:00
emacs/lisp/erc
F. Jason Park f8b710e54f Prevent unwanted recursion in erc-nickbar-disable
* lisp/erc/erc-speedbar.el (erc-status-sidebar-mode--unhook): Remove
forward declaration.
(erc-speedbar--toggle-nicknames-sidebar): Inline
`erc-speedbar-close-nicknames-window'.  Don't call
`erc-speedbar-browser' and thus avoid adding excess timers.
(erc-speedbar--ensure): Inline `speedbar-enable-update' to avoid
unneeded call to `speedbar-set-timer', and ensure it only runs in
`speedbar-buffer'.
(erc-speedbar--shutting-down-p): New flag variable to avoid recursive
calls to `dframe-close-frame' and friends.
(erc-nickbar-mode, erc-nickbar-enable, erc-nickbar-disable): Move
logic formerly performed by `speedbar-disable-update' to
`erc-speedbar--toggle-nicknames-sidebar'.  When disabling, guard
against recursive calls to `dframe-close-frame' and friends.
(erc-speedbar--get-timers): New utility function, also for use in
testing.
(erc-speedbar--dframe-controlled): Bind
`erc-speedbar--shutting-down-p' flag non-nil around call to
`erc-nickbar-mode'.  Remove excess timer left behind due to
incompatible behavior from `dframe-close-frame'.  Let caller kill
buffer.
(erc-speedbar-close-nicknames-window): Remove unused command, new in
ERC 5.6 and Emacs 30.
* test/lisp/erc/erc-scenarios-status-sidebar.el
(erc-speedbar-close-nicknames-window): Remove forward declaration.
(erc-speedbar--get-timers): Add forward declaration.
(erc-scenarios-status-sidebar--nickbar): Fix faulty expectations of
desired behavior when disabling module.  Ensure timers canceled.
* test/lisp/erc/resources/erc-scenarios-common.el
(erc-scenarios-common--make-bindings): Shadow `timer-idle-list' to
avoid polluting global test environment with stray timers.
(Bug#63595)
2023-08-25 14:47:07 -07:00
..
ChangeLog.1 ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
ChangeLog.2 ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-autoaway.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-backend.el Make erc-fill-wrap work with left-sided stamps 2023-07-22 07:33:07 -07:00
erc-button.el Ignore erc-response objects in error-notice helper 2023-08-25 14:47:07 -07:00
erc-capab.el Don't associate ERC modules with undefined groups 2023-04-08 14:23:51 -07:00
erc-common.el Ignore erc-response objects in error-notice helper 2023-08-25 14:47:07 -07:00
erc-compat.el Make erc-fill-wrap work with left-sided stamps 2023-07-22 07:33:07 -07:00
erc-dcc.el Fix command-line parsing regression in erc-cmd-DCC 2023-07-13 18:45:31 -07:00
erc-desktop-notifications.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-ezbounce.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-fill.el Add line-wise movement commands for erc-fill-wrap 2023-08-15 17:13:52 -07:00
erc-goodies.el Delete some Emacs 19/21 compat code 2023-08-20 18:39:51 +02:00
erc-ibuffer.el Don't require erc-goodies in erc.el 2023-04-08 14:23:51 -07:00
erc-identd.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-imenu.el Define missing groups for ERC modules 2023-06-11 20:53:48 -07:00
erc-join.el Allow custom display-buffer actions in ERC 2023-07-13 18:45:31 -07:00
erc-lang.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-list.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-log.el Warn about implicit logging in erc-truncate-mode 2023-08-25 14:47:07 -07:00
erc-match.el Improve ERC's internal invisibility API 2023-07-22 07:33:07 -07:00
erc-menu.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-netsplit.el ; Silence byte compiler in erc-netsplit-JOIN 2023-05-21 18:59:33 -07:00
erc-networks.el Ignore erc-response objects in error-notice helper 2023-08-25 14:47:07 -07:00
erc-nicks.el ; Prefer HTTPS to HTTP in more links 2023-08-02 23:32:28 +02:00
erc-notify.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-page.el Don't require erc-goodies in erc.el 2023-04-08 14:23:51 -07:00
erc-pcomplete.el Leverage loaddefs for migrating ERC modules 2023-04-08 14:23:50 -07:00
erc-replace.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc-ring.el Preprocess prompt input linewise in ERC 2023-05-05 17:18:01 -07:00
erc-sasl.el Add helper for restoring local session vars in ERC 2023-05-13 07:05:22 -07:00
erc-services.el Redo erc-nickname-in-use-functions as a local module 2023-07-01 07:21:30 -07:00
erc-sound.el Define missing groups for ERC modules 2023-06-11 20:53:48 -07:00
erc-speedbar.el Prevent unwanted recursion in erc-nickbar-disable 2023-08-25 14:47:07 -07:00
erc-spelling.el Define missing groups for ERC modules 2023-06-11 20:53:48 -07:00
erc-stamp.el Make erc-fill-wrap work with left-sided stamps 2023-07-22 07:33:07 -07:00
erc-status-sidebar.el Simplify multi-frame behavior in erc-bufbar-mode 2023-07-28 16:39:04 -07:00
erc-track.el Fix buffer-mismatch bug in erc-scroll-to-bottom 2023-07-13 18:45:31 -07:00
erc-truncate.el Warn about implicit logging in erc-truncate-mode 2023-08-25 14:47:07 -07:00
erc-xdcc.el ; Add 2023 to copyright years. 2023-01-01 05:31:12 -05:00
erc.el Improve ERC's internal invisibility API 2023-07-22 07:33:07 -07:00