mirror of
git://git.sv.gnu.org/emacs.git
synced 2026-01-26 07:00:35 -08:00
207ee94b1d
Without this fix, (ceiling most-negative-fixnum -1.0) returns most-negative-fixnum instead of correctly signaling range-error, and similarly for floor, round, and truncate. * configure.ac (trunc): Add a check, since Gnulib’s doc says ‘trunc’ is missing from MSVC 9. The Gnulib doc says ‘trunc’ is also missing from some other older operating systems like Solaris 9 which I know we don’t care about any more, so MSVC is the only reason to worry about ‘trunc’ here. * src/editfns.c (styled_format): Formatting a float with %c is now an error. The old code did not work in general, because FIXNUM_OVERFLOW_P had rounding errors. Besides, the "if (FLOATP (...))" was in there only as a result of my misunderstanding old code that I introduced 2011. Although %d etc. is sometimes used on floats that represent huge UIDs or PIDs etc. that do not fit in fixnums, this cannot happen with characters. * src/floatfns.c (rounding_driver): Rework to do the right thing when the intermediate result equals 2.305843009213694e+18, i.e., is exactly 1 greater than MOST_POSITIVE_FIXNUM on a 64-bit host. Simplify so that only one section of code checks for overflow, rather than two. (double_identity): Remove. All uses changed to ... (emacs_trunc): ... this new function. Add replacement for platforms that lack ‘trunc’. * src/lisp.h (FIXNUM_OVERFLOW_P, make_fixnum_or_float): Make it clear that the arg cannot be floating point. * test/src/editfns-tests.el (format-c-float): New test. * test/src/floatfns-tests.el: New file, to test for this bug. |
||
|---|---|---|
| .. | ||
| data | ||
| lisp | ||
| manual | ||
| src | ||
| ChangeLog.1 | ||
| file-organization.org | ||
| make-test-deps.emacs-lisp | ||
| Makefile.in | ||
| README | ||
Copyright (C) 2008-2017 Free Software Foundation, Inc. See the end of the file for license conditions. This directory contains files intended to test various aspects of Emacs's functionality. Please help add tests! See the file file-organization.org for the details of the directory structure and file-naming conventions. Emacs uses ERT, Emacs Lisp Regression Testing, for testing. See (info "(ert)") or https://www.gnu.org/software/emacs/manual/html_node/ert/ for more information on writing and running tests. The Makefile in this directory supports the following targets: * make check Run all tests as defined in the directory. Expensive tests are suppressed. The result of the tests for <filename>.el is stored in <filename>.log. * make check-maybe Like "make check", but run only the tests for files which have unresolved prerequisites. * make check-expensive Like "make check", but run also the tests marked as expensive. * make <filename> or make <filename>.log Run all tests declared in <filename>.el. This includes expensive tests. In the former case the output is shown on the terminal, in the latter case the output is written to <filename>.log. ERT offers selectors, which make it possible to filter out which test cases shall run. The make variable $(SELECTOR) gives you a simple mean to use your own selectors. The ERT manual describes how selectors are constructed, see (info "(ert)Test Selectors") or https://www.gnu.org/software/emacs/manual/html_node/ert/Test-Selectors.html You could use predefined selectors of the Makefile. "make <filename> SELECTOR='$(SELECTOR_DEFAULT)'" runs all tests for <filename>.el except the tests tagged as expensive. If your test file contains the tests "test-foo", "test2-foo" and "test-foo-remote", and you want to run only the former two tests, you could use a selector regexp: "make <filename> SELECTOR='\"foo$$\"'". (Also, see etc/compilation.txt for compilation mode font lock tests.) This file is part of GNU Emacs. GNU Emacs is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. GNU Emacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.