1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-30 00:51:50 -08:00
emacs/test/lisp
F. Jason Park 752e860db4 Address long-standing ERC buffer-naming issues
* lisp/erc/erc-backend.el (erc-server-connected): Revise doc string.
(erc-server-reconnect, erc-server-JOIN): Reuse original ID param from
the first connection when calling `erc-open'.
(erc-server-NICK): Apply same name generation process used by
`erc-open'; except here, do so for the purpose of "re-nicking".
Update network identifier and maybe buffer names after a user's own
nick changes.

* lisp/erc/erc-networks.el (erc-networks--id, erc-networks--id-fixed,
erc-networks--id-qualifying): Define new set of structs to contain all
info relevant to specifying a unique identifier for a network context.
Add a new variable `erc-networks--id' to store a local reference to a
`erc-networks--id' object, shared among all buffers in a logical
session.
(erc-networks--id-given, erc-networks--id-create,
erc-networks--id-on-connect, erc-networks--id--equal-p,
erc-networks--id-qualifying-init-parts,
erc-networks--id-qualifying-init-symbol,
erc-networks--id-qualifying-grow-id,
erc-networks--id-qualifying-reset-id,
erc-networks--id-qualifying-prefix-length,
erc-networks--id-qualifying-update, erc-networks--id-reload,
erc-networks--id-ensure-comparable, erc-networks--id-sort-buffers):
Add new functions to support management of `erc-networks--id' struct
instances.
(erc-networks--id-sep): New variable for to help when formatting
buffer names.
(erc-obsolete-var): Define new generic context rewriter.
(erc-networks-shrink-ids-and-buffer-names,
erc-networks--refresh-buffer-names,
erc-networks--shrink-ids-and-buffer-names-any): Add functions to
reassess all network IDs and shrink them if necessary along with
affected buffer names.  Also add function to rename buffers so that
their names are unique.  Register these on all three of ERC's
kill-buffer hooks because an orphaned target buffer is enough to keep
its session alive.
(erc-networks-rename-surviving-target-buffer): Add new function that
renames a target buffer when it becomes the sole bearer of a name
based on a target that has become unique across all sessions and, in
most cases, all networks.  IOW, remove the @NETWORK-ID suffix from the
last remaining channel or query buffer after its namesakes have all
been killed off.  Register this function with ERC's target-related
kill-buffer hooks.
(erc-networks--examine-targets): Add new utility function that visits
all ERC buffers and runs callbacks when a buffer-name collision is
encountered.
(erc-networks--qualified-sep): Add constant to hold separator between
target and suffix.
(erc-networks--construct-target-buffer-name,
erc-networks--ensure-unique-target-buffer-name,
erc-networks--ensure-unique-server-buffer-name,
erc-networks--maybe-update-buffer-name): Add helpers to support
`erc-networks--reconcile-buffer-names' and friends.
(erc-networks--reconcile-buffer-names): Add new buffer-naming strategy
function and helper for `erc-generate-new-buffer-name' that only run
in target buffers.
(erc-determine-network, erc-networks--determine): Deprecate former and
partially replace with latter, which demotes RPL_ISUPPORT-derived
NETWORK name to fallback in favor of known `erc-networks-alist'
members as part of shift to network-based connection-identity policy.
Return sentinel on failure.  Expect `erc-server-announced-name' to be
set, and signal when it's not.
(erc-networks--name-missing-sentinel): Value returned when new
function `erc-networks--determine' fails to find network name.  The
rationale for not making this customizable is that the value signifies
the pathological case where a user of an uncommon IRC setup has not
yet set a mapping from announced- to network name.  And the chances of
there being multiple unknown networks is low.
(erc-set-network-name, erc-networks--set-name): Deprecate former and
partially replace with latter.  Ding with helpful message, and don't
set `erc-network' when network name is not found.
(erc-networks--ensure-announced): Add new fallback function to ensure
`erc-server-announced-name' is set.  Register with post-MOTD hooks.
(erc-unset-network-name): Deprecate function unused internally.
(erc-networks--insert-transplanted-content,
erc-networks--reclaim-orphaned-target-buffers,
erc-networks--copy-over-server-buffer-contents,
erc--update-server-identity): Add helpers for
`erc-networks--rename-server-buffer'.  The first re-associates all
existing target buffers that ought to be owned by the new server
process.  The second grabs buffer text from an old, dead server buffer
before killing it.  It then inserts that text above everything in the
current, replacement server buffer.  The other two massage the IDs of
related sessions, possibly renaming them as well.  They may also
uniquify the current session's network ID.
(erc-networks--init-identity): Add new function to perform one-time
session-related setup.  This could be combined with
`erc-set-network-name'.
(erc-networks--rename-server-buffer): Add new function to replace
`erc-unset-network-name' as default `erc-disconnected-hook' member;
renames server buffers once network is discovered; added to/removed
from `erc-after-connect' hook on `erc-networks' minor mode.
(erc-networks--bouncer-targets): Add constant to hold target symbols
of well known bouncer-configuration bots.
(erc-networks-on-MOTD-end): Add primary network-context handler to run
on 376/422 functions, just before logical connection is officially
established.
(erc-networks-enable, erc-networks-mode): Register main network-setup
handler with 376/422 hooks.

* lisp/erc/erc.el (erc-rename-buffers): Change this option's default
to t, remove the only instance where it's actually used, and make it
an obsolete variable.
(erc-reuse-buffers): Make this an obsolete variable, but take pains to
ensure its pre-28.1 behavior is preserved.  That is, undo the
regression involving unwanted automatic reassociation of channel
buffers during joins, which arrived in ERC 5.4 and effectively
inverted the meaning of this variable, when nil, for channel buffers,
all without accompanying documentation or announcement.
(erc-generate-new-buffer-name): Replace current policy of appending a
slash and the invocation host name.  Favor instead temporary names for
server buffers and network-based uniquifying suffixes for channels and
query buffers.  Fall back to the TCP host:port<n> convention when
necessary.  Accept additional optional params after the others.
(erc-get-buffer-create): Don't generate a new name when reconnecting,
just return the same buffer.  `erc-open' starts from a clean slate
anyway, so this just keeps things simple.  Also add optional params.
(erc-open): Add new ID param to for a network identifier explicitly
passed to an entry-point command.  This is stored in the `given' slot
of the `erc-network--id' object.  Also initialize the latter in new
connections and otherwise copy it over.  As part of the push to recast
erc-networks.el as an essential library, set `erc-network' explicitly,
when known, rather than via hooks.
(erc, erc-tls): Add new ID keyword parameter and pass it to
`erc-open'.
(erc-log-irc-protocol): Use `erc--network-id' instead of the function
`erc-network' to determine preferred peer name.
(erc-format-target-and/or-network): This is called frequently from
mode-line updates, so renaming buffers here is not ideal.  Instead, do
so in `erc-networks--rename-server-buffer'.
(erc-kill-server-hook): Add `erc-networks-shrink-ids-and-buffer-names'
as default member.
(erc-kill-channel-hook, erc-kill-buffer-hook): Add
`erc-networks-shrink-ids-and-buffer-names' and
`erc-networks-rename-surviving-target-buffer' as default member.

* test/lisp/erc/erc-tests.el (erc-log-irc-protocol): Use network-ID
focused internal API.

* test/lisp/erc/erc-networks-tests.el: Add new file that includes
tests for the above network-ID focused functions.

See bug#48598 for background on all of the above.
2022-06-30 15:03:26 -07:00
..
align-resources Add some tests for align.el 2020-12-29 08:38:25 +01:00
bookmark-resources Add ability to mark/unmark/delete all bookmarks 2020-08-09 15:13:05 -05:00
calc Audit quoting the quote character in doc strings 2022-04-22 16:17:22 +02:00
calendar icalendar-tests no longer assumes TZ = wall 2022-06-15 23:06:08 -05:00
cedet Fix misplaced interactive spec 2022-06-17 11:23:41 +02:00
custom-resources Avoid saving session customizations in the custom-file 2021-05-10 13:33:32 +02:00
dired-resources/insert-directory Change how Dired displays available space 2021-12-01 23:27:19 +01:00
emacs-lisp Make two text-property-search tests easier to read 2022-06-29 13:54:51 +02:00
emulation Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
epg-resources Move epg.el test data to follow our conventions 2020-10-24 02:36:55 +02:00
erc Address long-standing ERC buffer-naming issues 2022-06-30 15:03:26 -07:00
eshell When closing an Eshell process target, send EOF three times 2022-06-26 18:27:20 +02:00
faces-resources ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
files-resources * test/lisp/files-resources/compile-utf8.el: Use lexical-binding 2022-05-26 12:16:04 -04:00
gnus Tag an mml-sec test 2022-01-25 09:38:50 -08:00
hfy-cmap-resources * test/lisp/hfy-cmap-resources/rgb.txt: Add comment line. 2020-11-12 03:20:39 +01:00
image Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
international Recognise hybrid IPv6/IPv4 addresses in textsec (bug#54624) 2022-04-11 16:29:24 +02:00
loadhist-resources (function-history): New symbol property (bug#53632) 2022-01-31 11:07:26 -05:00
mail Fix undigest-tests on MS-Windows 2022-05-14 11:30:54 +03:00
mh-e ; Pacify unknown fun warning in mh-utils-tests.el. 2022-06-26 15:08:57 +03:00
minibuffer-resources Move more test data to follow our conventions 2020-10-23 21:07:26 +02:00
net Fix Tramp test 2022-06-16 19:29:55 +02:00
nxml ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
obsolete Fix misplaced interactive spec 2022-06-17 11:23:41 +02:00
org ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
pcmpl-linux-resources Use lexical-binding in pcmpl-linux.el and add tests 2020-09-02 12:53:02 +02:00
play ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
progmodes test/lisp/progmodes/python-tests.el: add test for nav end of block 2022-06-29 12:13:34 +02:00
saveplace-resources Use lexical-binding in saveplace.el and add tests 2020-08-08 01:40:38 +02:00
so-long-tests Merge from origin/emacs-28 2022-06-24 13:52:51 +02:00
term ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
textmodes Recognize some more SCSS selectors 2022-05-15 16:42:56 +02:00
time-resources Add missed file needed by time-tests.el 2020-10-22 18:51:00 +02:00
url Adapt url-tramp-tests 2022-06-20 15:45:46 +02:00
vc Speed up generation of loaddefs files 2022-05-31 18:08:33 +02:00
xdg-resources Move more test data to follow our conventions 2020-10-23 21:07:26 +02:00
abbrev-tests.el Don't signal errors in abbrev-table-p 2022-02-14 12:00:22 +01:00
align-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
allout-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
allout-widgets-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
ansi-color-tests.el ; Fix typos 2022-05-15 11:15:06 +02:00
apropos-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
arc-mode-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
auth-source-pass-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
auth-source-tests.el Use 'auth-info-password' in tests 2022-01-10 20:52:20 -05:00
autoinsert-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
autorevert-tests.el Factor out test configuration for remote files 2022-06-08 12:06:56 +02:00
battery-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
bookmark-tests.el Update bookmark tests for recent change 2022-06-17 20:08:55 +02:00
buff-menu-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
button-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
calculator-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
char-fold-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
color-tests.el Fix color-lighten-hsl logic 2022-03-22 15:28:02 +01:00
comint-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
completion-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
cus-edit-tests.el Fix a compilation warning in cus-edit-tests.el 2022-02-20 19:17:49 +01:00
custom-tests.el Fix cl-generic bootstrap problems 2022-06-24 11:04:51 +02:00
dabbrev-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
delim-col-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
descr-text-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
desktop-tests.el Load desktop without prompting if process is dead 2022-03-24 09:23:31 +01:00
dired-aux-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
dired-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
dired-x-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
dnd-tests.el Update dnd-tests.el to make sure remote files are removed when Emacs quits 2022-06-29 20:14:41 +08:00
dom-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
edmacro-tests.el test/lisp/edmacro-tests.el: Adjust to recent changes 2022-04-04 09:55:03 -04:00
electric-tests.el Silence byte-compiler in two tests 2022-02-04 14:18:35 +01:00
elide-head-tests.el New minor mode elide-head-mode 2022-01-09 11:12:06 +01:00
epg-config-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
epg-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
faces-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
ffap-tests.el Rename compare-window-configurations and update doc 2022-05-20 04:23:32 +02:00
filenotify-tests.el Factor out test configuration for remote files 2022-06-08 12:06:56 +02:00
files-tests.el Reinstate the Qload file name handler 2022-06-02 11:51:09 +02:00
files-x-tests.el Make application configurable in 'with-connection-local-variables' 2022-03-18 12:25:32 +01:00
find-cmd-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
font-lock-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
format-spec-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
help-fns-tests.el Fix describe-function-1 test failure from previous change 2022-02-08 08:15:08 +01:00
help-mode-tests.el Allow using xref buttons in non-*Help* buffers 2022-06-06 16:12:39 +02:00
help-tests.el Don't error out on invalid literal key substitutions 2022-06-25 12:25:58 +02:00
hfy-cmap-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
hi-lock-tests.el Fix thinko in previous hi-lock-read-face-name change 2022-01-20 14:53:12 +01:00
hl-line-tests.el Fix hl-line tests 2022-03-23 20:25:33 +08:00
htmlfontify-tests.el Don't generate separate autoload file for htmlfontify 2022-06-05 18:23:17 +02:00
ibuffer-tests.el Adjust ibuffer test 2022-06-15 18:36:58 +02:00
ido-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
image-dired-tests.el ; Add 2022 to copyright years. 2022-01-01 07:07:15 -05:00
image-file-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
image-tests.el Fix failing image test on nox builds 2022-05-01 01:19:51 +03:00
imenu-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
info-tests.el ; Add 2022 to copyright years. 2022-01-01 07:07:15 -05:00
info-xref-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
isearch-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
jit-lock-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
json-tests.el Allow plist-get/plist-put/plist-member to take a comparison function 2022-06-27 12:22:05 +02:00
jsonrpc-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
kmacro-tests.el kmacro: Represent it as an OClosure 2022-04-01 20:07:33 -04:00
loadhist-tests.el (function-history): New symbol property (bug#53632) 2022-01-31 11:07:26 -05:00
lpr-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
ls-lisp-tests.el Fix sorting in ls-lisp.el under -v 2022-06-05 09:52:09 +03:00
makesum-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
man-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
md4-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
minibuffer-tests.el * lisp/simple.el (completion-auto-wrap): Rename from completion-wrap-movement. 2022-06-14 10:04:56 +03:00
misc-tests.el duplicate-line: fix optional argument and add test (bug#46621) 2022-06-22 16:03:46 +02:00
mouse-tests.el Fix handling double-click-time nil or t 2022-05-02 12:03:08 +02:00
mwheel-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
newcomment-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
obarray-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
paren-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
password-cache-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
pcmpl-linux-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
ps-print-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
register-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
repeat-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
replace-tests.el * test/lisp/replace-tests.el (query-replace-tests): Add more tests (bug#54733) 2022-04-29 20:40:15 +03:00
rot13-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
saveplace-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
scroll-lock-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
ses-tests.el ses-test Prefix used symbols by ses-- 2022-04-10 00:26:33 +02:00
shadowfile-tests.el Factor out test configuration for remote files 2022-06-08 12:06:56 +02:00
shell-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
simple-tests.el zap-to-char: case sensitive for upper-case characters 2022-05-21 11:23:55 +02:00
sort-tests.el Make some recently added tests actually run 2022-05-03 22:30:39 +02:00
soundex-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
startup-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
subr-tests.el Add new type predicate plistp 2022-06-27 12:36:37 +02:00
tab-bar-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
tabify-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
tar-mode-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
tempo-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
term-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
thingatpt-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
thread-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
thumbs-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
time-stamp-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
time-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
timezone-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
version-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
wdired-tests.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
whitespace-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
wid-edit-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
x-dnd-tests.el Add tests for x-dnd Motif value parsing logic 2022-06-10 13:11:20 +08:00
xdg-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
xml-tests.el Audit quoting the quote character in doc strings 2022-04-22 16:17:22 +02:00
xt-mouse-tests.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
yank-media-tests.el Fix yank-media utf-16 detection 2022-02-05 08:50:05 +01:00