F. Jason Park 2f5fe1a48e Cancel ERC autojoin timer in the server buffer ... * lisp/erc/erc-join.el (erc-autojoin-channels-delayed): Only cancel `erc--autojoin-timer' in the server buffer in which it's local. After Emacs 28 brought commit fc66ec3322 "Prefer defvar-local in erc", customizing `erc-autojoin-timing' to `ident' led to ERC emitting redundant JOINs before `erc-autojoin--join' was factored out. Additionally, don't bother binding options around the call to `erc-autojoin-channels' to shape its behavior, preferring instead to call the internal workhorse function directly. Ever since bug#5521 introduced those options, the logic in `erc-autojoin-channels' has ignored `erc-autojoin-delay' anyway, so long as `erc-autojoin-timing' isn't `ident'. This change may break third party advice. (erc-autojoin-after-ident): Restore code to cancel timer. It was erroneously deleted in 959fbcf34b "favor network identities in erc-join". * test/lisp/erc/erc-join-tests.el: Require erc-tests-common atop file so tests can take advantage of common utilities. (erc-autojoin-channels--connect): Replace with a function and three separate tests. (erc-join-tests--autojoin-channels-connect): New function. (erc-autojoin-channels/server, erc-autojoin-channels/network) (erc-autojoin-channels/nomatch): New tests. (erc-autojoin-channels--delay): Replace with a function and three separate tests. Remove guard to skip test on Solaris. (erc-join-tests--autojoin-channels-ident): New function. (erc-autojoin-channels-delayed/server) (erc-autojoin-channels-delayed/network) (erc-autojoin-channels-delayed/nomatch): New tests. (erc-autojoin-channels--ident): Replace with function and two separate tests. (erc-join-tests--autojoin-after-ident): New function. (erc-autojoin-after-ident/server) (erc-autojoin-after-ident/network): New tests. (erc-join-tests--autojoin-add--common) (erc-join-tests--autojoin-add): Rename former to latter. (erc-autojoin-add--network) (erc-autojoin-add--network-extended-syntax) (erc-autojoin-add--network-id): Adjust arguments to fixture. (erc-autojoin-add--server): Use common utils. (erc-join-tests--autojoin-remove--common) (erc-join-tests--autojoin-remove): Rename former to latter. (erc-autojoin-remove--network) (erc-autojoin-remove--network-id): Adjust args for fixture. (erc-autojoin-remove--server): Use common utils. * test/lisp/erc/erc-scenarios-join-timing.el: New file. * test/lisp/erc/resources/erc-scenarios-common.el (erc-scenarios-common--run-in-term): In subprocess, don't use failure tally as exit status unless body form succeeds. * test/lisp/erc/resources/erc-tests-common.el (erc-tests-common-init-server-proc): Use `make-process' instead of `start-process'. (erc-tests-common-make-server-buf): Use `erc-server-current-nick' to create the `erc-networks--id' as a `erc-networks--id-qualifying' instance, which is more realistic than a "fixed" variant. * test/lisp/erc/resources/join/timing/connect-both.eld: New file. * test/lisp/erc/resources/join/timing/ident-both.eld: New file. (Bug#79017)		2025-07-27 19:57:28 -07:00
..
base	Reuse process in erc-server-delayed-check-reconnect	2024-12-27 15:14:21 -08:00
commands	Make erc-cmd-AMSG session local; add /GMSG, /AME and /GME	2024-02-23 18:45:44 -08:00
dcc/chat	; Attempt to fix race in erc-buffer-display test	2023-11-01 16:14:10 -07:00
erc-d	Don't round-trip auto-reconnect probe in ERC	2025-04-16 17:30:13 -07:00
fill	Fix date-stamp regression in erc-fill-wrap	2024-05-27 16:47:24 -07:00
join	Cancel ERC autojoin timer in the server buffer	2025-07-27 19:57:28 -07:00
keep-place	Fix regression in erc-keep-place-indicator-mode	2023-12-31 06:56:32 -08:00
match/fools	Manage some text props for ERC insertion-hook members	2023-10-13 07:47:01 -07:00
networks	; Fix typos	2023-01-15 02:14:19 +01:00
sasl	Add format-catalog entry for unknown chan mode in ERC	2024-05-08 17:11:26 -07:00
scrolltobottom	Consider all windows in erc-scrolltobottom-mode	2023-09-10 17:58:20 -07:00
services	Run erc-services-regain-mode callback on a timer	2025-02-02 14:35:19 -08:00
spelling	Improve use of Flyspell's API in erc-spelling	2025-01-07 17:31:18 -08:00
erc-scenarios-common.el	Cancel ERC autojoin timer in the server buffer	2025-07-27 19:57:28 -07:00
erc-tests-common.el	Cancel ERC autojoin timer in the server buffer	2025-07-27 19:57:28 -07:00