mirror of
git://git.sv.gnu.org/emacs.git
synced 2026-01-02 02:10:46 -08:00
9c4e3097b5
'let' and 'let*' document that their first argument has to be a list, but don't check for that; instead, they allow (and silently ignore) other types. Introduce an explicit type check. * src/eval.c (Flet, FletX): Check that the variable list is indeed a list. * test/src/eval-tests.el: Add unit tests.
60 lines
2.2 KiB
EmacsLisp
60 lines
2.2 KiB
EmacsLisp
;;; eval-tests.el --- unit tests for src/eval.c -*- lexical-binding: t; -*-
|
||
|
||
;; Copyright (C) 2016-2017 Free Software Foundation, Inc.
|
||
|
||
;; Author: Philipp Stephani <phst@google.com>
|
||
|
||
;; This file is part of GNU Emacs.
|
||
|
||
;; GNU Emacs is free software: you can redistribute it and/or modify
|
||
;; it under the terms of the GNU General Public License as published by
|
||
;; the Free Software Foundation, either version 3 of the License, or
|
||
;; (at your option) any later version.
|
||
|
||
;; GNU Emacs is distributed in the hope that it will be useful,
|
||
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
;; GNU General Public License for more details.
|
||
|
||
;; You should have received a copy of the GNU General Public License
|
||
;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
|
||
|
||
;;; Commentary:
|
||
|
||
;; Unit tests for src/eval.c.
|
||
|
||
;;; Code:
|
||
|
||
(require 'ert)
|
||
|
||
(ert-deftest eval-tests--bug24673 ()
|
||
"Checks that Bug#24673 has been fixed."
|
||
;; This should not crash.
|
||
(should-error (funcall '(closure)) :type 'invalid-function))
|
||
|
||
(ert-deftest eval-tests--bugs-24912-and-24913 ()
|
||
"Checks that Emacs doesn’t accept weird argument lists.
|
||
Bug#24912 and Bug#24913."
|
||
(dolist (args '((&optional) (&rest) (&optional &rest) (&rest &optional)
|
||
(&optional &rest a) (&optional a &rest)
|
||
(&rest a &optional) (&rest &optional a)
|
||
(&optional &optional) (&optional &optional a)
|
||
(&optional a &optional b)
|
||
(&rest &rest) (&rest &rest a)
|
||
(&rest a &rest b)))
|
||
(should-error (eval `(funcall (lambda ,args)) t) :type 'invalid-function)
|
||
(should-error (byte-compile-check-lambda-list args))
|
||
(let ((byte-compile-debug t))
|
||
(should-error (eval `(byte-compile (lambda ,args)) t)))))
|
||
|
||
|
||
(dolist (form '(let let*))
|
||
(dolist (arg '(1 "a" [a]))
|
||
(eval
|
||
`(ert-deftest ,(intern (format "eval-tests--%s--%s" form (type-of arg))) ()
|
||
,(format "Check that the first argument of `%s' cannot be a %s"
|
||
form (type-of arg))
|
||
(should-error (,form ,arg) :type 'wrong-type-argument))
|
||
t)))
|
||
|
||
;;; eval-tests.el ends here
|