1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-02 02:10:46 -08:00
emacs/test/lisp/ffap-tests.el
Noam Postavsky fd6b829d91 Improve ffap-gopher-at-point handling of long lines
* lisp/ffap.el (ffap-gopher-regexp): Only match the KEY part.  Note
setting to nil is now supported.
(ffap--gopher-var-on-line): New function.
(ffap-gopher-at-point): Use it instead of the old ffap-gopher-regexp
which could overflow the regexp stack on long lines (Bug#25391).  Use
`let-alist' instead of calling `set' on local variables.
* test/lisp/ffap-tests.el (ffap-gopher-at-point): New test.
2017-01-15 13:04:54 -05:00

71 lines
2.2 KiB
EmacsLisp

;;; ffap-tests.el --- Test suite for ffap.el -*- lexical-binding: t -*-
;; Copyright (C) 2016-2017 Free Software Foundation, Inc.
;; Author: Tino Calancha <tino.calancha@gmail.com>
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
;;; Commentary:
;;; Code:
(require 'ert)
(require 'ffap)
(ert-deftest ffap-tests-25243 ()
"Test for http://debbugs.gnu.org/25243 ."
(let ((file (make-temp-file "test-Bug#25243")))
(unwind-protect
(with-temp-file file
(let ((str "diff --git b/lisp/ffap.el a/lisp/ffap.el
index 3d7cebadcf..ad4b70d737 100644
--- b/lisp/ffap.el
+++ a/lisp/ffap.el
@@ -203,6 +203,9 @@ ffap-foo-at-bar-prefix
"))
(transient-mark-mode 1)
(when (natnump ffap-max-region-length)
(insert
(concat
str
(make-string ffap-max-region-length #xa)
(format "%s ENDS HERE" file)))
(mark-whole-buffer)
(should (equal "" (ffap-string-at-point)))
(should (equal '(1 1) ffap-string-at-point-region)))))
(and (file-exists-p file) (delete-file file)))))
(ert-deftest ffap-gopher-at-point ()
(with-temp-buffer
(insert "\
Type = 1
Name = foo
Path = /the/path
Port = 7070
Host = example.com\n")
(should-not (ffap-gopher-at-point))
(goto-char (point-min))
(should (equal (ffap-gopher-at-point)
"gopher://example.com:7070/1/the/path"))
(should (equal ffap-string-at-point-region
(list (point-min) (point-max))))
(let ((ffap-gopher-regexp nil))
(should-not (ffap-gopher-at-point)))))
(provide 'ffap-tests)
;;; ffap-tests.el ends here