Lars Ingebrigtsen
6c7fad4ac4
Fix defcustom type in sql.el for sql-postgres-login-params
...
* lisp/progmodes/sql.el (sql-login-params): Fix defcustom type to
match sql-postgres-login-params value.
2020-09-25 15:42:35 +02:00
Lars Ingebrigtsen
c27096296f
Fix a defcustom type in gdb-mi.el
...
* lisp/progmodes/gdb-mi.el (gdb-display-source-buffer-action): Fix
defcustom type to match the value.
2020-09-25 15:38:53 +02:00
Lars Ingebrigtsen
a9ad0bbf14
Fix defcustom type in whitespace.el
...
* lisp/whitespace.el (whitespace-space-after-tab-regexp)
(whitespace-indentation-regexp): The first string here isn't a
regexp, it's a string (that's expanded with format to be a regexp).
2020-09-25 15:35:23 +02:00
Lars Ingebrigtsen
bf1b3714cc
Fix the defcustom type fix in python.el
...
* lisp/progmodes/python.el (python-pdbtrack-exit-command): Fix
defcustom type (bug#30990).
2020-09-25 15:17:36 +02:00
Lars Ingebrigtsen
e1c33e29d5
Fix some defcustom types
...
* lisp/whitespace.el (whitespace-style):
* lisp/gnus/message.el (message-screenshot-command):
* lisp/progmodes/compile.el (compilation-transform-file-match-alist):
* lisp/progmodes/gdb-mi.el (gdb-default-window-configuration-file):
* lisp/progmodes/python.el (python-pdbtrack-exit-command): Fix the
defcustom types.
* lisp/progmodes/sql.el (sql-password-wallet): Fix the value.
2020-09-25 15:15:21 +02:00
Lars Ingebrigtsen
664927b525
Add an expensive test for defcustom types
...
* admin/cus-test.el (cus-test-opts): Return the tests.
* test/lisp/custom-tests.el (check-for-wrong-custom-types): Test
custom types (bug#30990).
2020-09-25 14:46:36 +02:00
Lars Ingebrigtsen
79762ffa61
Mark string-search as being side effect free
...
* lisp/emacs-lisp/byte-opt.el (side-effect-free-fns): Add
string-search.
2020-09-25 14:30:13 +02:00
Noam Postavsky
9fd9c9c2c0
Make the Man completion code work better if man -k fails
...
* lisp/man.el (Man-completion-table): Check the return code for
"man -k" and assume it failed if there's a non-zero exit code
(bug#16722).
2020-09-25 13:39:24 +02:00
Tino Calancha
830e876d94
Use the char history in zap-up-to-char
...
* lisp/misc.el (zap-up-to-char): Use read-char-from-minibuffer
(bug#39154).
2020-09-25 13:25:14 +02:00
Mattias Engdegård
8a253a96a0
Fix replace-in-string infloop with empty pattern string (bug#43598)
...
* lisp/subr.el (replace-in-string): Raise an error if FROMSTRING is
empty.
* test/lisp/subr-tests.el (replace-in-string): Add test case.
2020-09-25 13:15:42 +02:00
Lars Ingebrigtsen
d964375ad3
Tweak updating the process mark in set-process-buffer
...
* src/process.c (Fset_process_buffer): Only update the process
mark if we actually change the buffer.
2020-09-25 11:47:59 +02:00
Eli Zaretskii
ba635a19fb
* lisp/hi-lock.el (hi-lock-auto-select-face): Doc fix. (Bug#43600)
2020-09-25 12:41:54 +03:00
Lars Ingebrigtsen
d067ac5b9e
Remove more compat code from prolog.el
...
* lisp/progmodes/prolog.el (prolog-font-lock-keywords): Remove
compat test for a face that's always defined.
2020-09-25 11:37:45 +02:00
Eli Zaretskii
cc8fef2bdd
Avoid infinite recursion with 'relative' line numbers display
...
* src/xdisp.c (display_count_lines_visually): Bind
'display-line-numbers' to 'relative' around 'start_display' as
well, since that can invoke 'move_it_to' internally, thus
causing infinite recursion. (Bug#43589)
2020-09-25 11:55:51 +03:00
Stefan Monnier
09e07fb008
* lisp/progmodes/ruby-mode.el (ruby-use-smie): Declare obsolete
...
(ruby-mode-map, ruby-mode-menu): Don't use ruby-for/backward-sexp any more.
(ruby-mode-variables): Always setup SMIE navigation.
Still obey `ruby-use-smie` for indentation.
(ruby-forward-sexp, ruby-backward-sexp): Mark as obsolete.
2020-09-24 23:02:06 -04:00
Lars Ingebrigtsen
040c30295e
Remove some XEmacs compat code from prolog.el
...
* lisp/progmodes/prolog.el (prolog-replace-in-string): Remove XEmacs
compat code and make obsolete.
(prolog-guess-fill-prefix): Adjust callers.
(prolog-uncomment-region): Make obsolete.
(prolog-mode-syntax-table): syntax-propertize-rules is always defined.
(prolog-syntax-propertize-function): Ditto.
(prolog-face-name-p): Make into obsolete alias.
(prolog-font-lock-keywords): Adjust callers.
2020-09-25 03:46:59 +02:00
Lars Ingebrigtsen
d27b137289
Clean up replace-in-string slightly
...
* lisp/subr.el (replace-in-string): Clean up previous fix slightly.
2020-09-25 02:27:01 +02:00
Lars Ingebrigtsen
09adf92644
Fix previous replace-in-string rewrite
...
* lisp/subr.el (replace-in-string): Fix logic errors in previous
patch.
2020-09-25 02:07:05 +02:00
Lars Ingebrigtsen
7f9ad5980c
Fix replace-in-string multibyteness problems with string-search
...
* lisp/subr.el (replace-in-string): Simplify by using the new
string-search function (bug#43598).
2020-09-25 01:53:16 +02:00
Lars Ingebrigtsen
e51a98b0c2
Add a new function 'string-search'
...
* doc/lispref/strings.texi (Text Comparison): Document it.
* src/fns.c (Fstring_search): New function.
2020-09-25 01:53:16 +02:00
Stefan Monnier
e7a69c9204
* lisp/help-fns.el (help-fns--first-release): Use etc/NEWS as well
2020-09-24 18:15:39 -04:00
Glenn Morris
976b8464fb
Update a failing lisp test
...
* test/lisp/emacs-lisp/lisp-tests.el (up-list-no-cross-string):
Update for recent "Don't signal scan-error" change.
2020-09-24 12:46:19 -07:00
Juri Linkov
1e7f636576
Horizontal scrolling for mouse wheel with Shift modifier (bug#43568)
...
* lisp/mwheel.el (mouse-wheel-scroll-amount): Change 'shift' default value
from 5 to 'hscroll'. Add new option "Scroll horizontally" for 'hscroll'.
(mwheel-scroll): Handle value 'hscroll' and call mwheel-scroll-left-function
or mwheel-scroll-right-function.
* doc/emacs/frames.texi (Mouse Commands): Update for horizontal scrolling
with Shift modifier.
2020-09-24 22:25:03 +03:00
Theodor Thornhill
89dd8cd215
Set mwheel default scroll value to 1 (bug#43380)
...
* lisp/mwheel.el (mouse-wheel-scroll-amount): Change default value 5 to 1
and shift default value from 1 to 5.
Default value is changed as discussed in etc/TODO.
2020-09-24 21:59:30 +03:00
Juri Linkov
4bc4d19bd1
* lisp/simple.el (goto-line-read-args): More relevant default line number.
2020-09-24 21:52:22 +03:00
Glenn Morris
9bf9f699b1
Add skip condition for some dbus tests
...
* test/lisp/net/dbus-tests.el (dbus-test01-type-conversion)
(dbus-test01-basic-types): Add skip for hydra.nixos.org failures.
; Standardize license notice
2020-09-24 11:47:11 -07:00
Lars Ingebrigtsen
7b3e94b664
Make set-process-buffer also update the process mark
...
* src/process.c (Fset_process_buffer): Update the process mark
(bug#43573).
2020-09-24 17:14:25 +02:00
Lars Ingebrigtsen
8463687b5d
Refactor process mark setting
...
* src/process.c (update_process_mark): Make into its own function.
(Fmake_process, Fmake_pipe_process, Fmake_serial_process)
(connect_network_socket): Use it.
2020-09-24 17:08:30 +02:00
dickmao
5df652d614
Add sanity check for Gnus groups that belong to no topic
...
* lisp/gnus/gnus-topic.el (gnus-topic-change-level): Do not change
gnus-topic-alist when group is outside "topology" (bug#43582).
2020-09-24 16:49:15 +02:00
Eli Zaretskii
897ea41d39
Fix last change in resize_mini_window
...
* src/xdisp.c (resize_mini_window): Prevent recentering the
mini-window once its start position is computed. (Bug#43572)
2020-09-24 17:13:43 +03:00
Lars Ingebrigtsen
7e7a010d85
Fix recent simple.el compilation warning
...
* lisp/simple.el (goto-line-relative): Suppress byte compilation
warning about goto-line.
2020-09-24 15:50:25 +02:00
Michael Albinus
de54cd6f0e
Minor Tramp cleanup
...
* doc/misc/tramp.texi: Some stylistic changes.
(Frequently Asked Questions): Mention ProxyCommand and ProxyJump.
* lisp/net/tramp-sh.el (tramp-use-ssh-controlmaster-options):
Fix docstring.
2020-09-24 10:17:03 +02:00
Andrea Corallo
e5b052d60d
Rename comp--subr-safe-advice -> comp-subr-safe-advice
...
* lisp/emacs-lisp/comp.el (comp-subr-safe-advice): Rename
comp--subr-safe-advice -> comp-subr-safe-advice.
* lisp/emacs-lisp/nadvice.el (advice--add-function): Likewise.
* lisp/emacs-lisp/advice.el (ad-add-advice): Likewise.
2020-09-24 09:57:17 +02:00
Andrea Corallo
6d83902ffd
* lisp/emacs-lisp/comp.el (comp-body-eff): Improve style.
2020-09-24 09:57:17 +02:00
Andrea Corallo
94736c413f
Do not install a subr trampoline twice
...
* src/comp.c (syms_of_comp): Define and initialize
'Vcomp_installed_trampolines_h'.
(Fcomp__install_trampoline): Fill 'Vcomp_installed_trampolines_h'
* lisp/emacs-lisp/comp.el (comp--subr-safe-advice): Make use of
`comp-installed-trampolines-h' to guard against installing a
trampoline twice.
2020-09-24 09:57:17 +02:00
Andrea Corallo
b94a0a931e
* lisp/emacs-lisp/comp.el (comp-never-optimize-functions): Clean-up.
2020-09-24 09:57:17 +02:00
Andrea Corallo
0cc1804d42
Add a test for primitive advicing effectiveness
...
* test/src/comp-test-funcs.el (comp-test-primitive-advice-f): New
function.
* test/src/comp-tests.el (comp-test-primitive-advice): New test.
2020-09-24 09:57:17 +02:00
Andrea Corallo
db354ffd57
Call `comp--subr-safe-advice' from the advice machinery
...
* lisp/emacs-lisp/nadvice.el (advice--add-function): Call
`comp--subr-safe-advice' when necessary.
* lisp/emacs-lisp/advice.el (ad-add-advice): Likewhise.
2020-09-24 09:57:17 +02:00
Andrea Corallo
3ec1b932c9
* Add `comp--subr-safe-advice' entry point
...
Add a Lisp side entry-point to be called to make primitive adivicing
effective.
* lisp/emacs-lisp/comp.el (comp-trampoline-sym)
(comp-trampoline-filename): New substs.
(comp-make-lambda-list-from-subr, comp-search-trampoline)
(comp-tampoline-compile): New functions
2020-09-24 09:57:17 +02:00
Eric Abrahamsen
e542b4b785
Write Gnus active files with quotes around group names
...
* lisp/gnus/gnus-util.el (gnus-write-active-file): In case of group
names with spaces in them (see Bug#42823). Names are later read with
`read', so this should be quite robust.
2020-09-23 16:01:38 -07:00
Juri Linkov
dc86c4cc0b
New command goto-line-relative (bug#5042, bug#9917)
...
* lisp/simple.el (goto-line-read-args): New function with code from goto-line.
(goto-line): New arg RELATIVE. Also use 'widen-automatically' to
leave all lines accessible in the narrowed buffer.
(goto-line-relative): New command.
* lisp/info.el (Info-mode-map): Remap 'goto-line' to 'goto-line-relative'.
* doc/emacs/basic.texi (Moving Point):
* doc/emacs/display.texi (Optional Mode Line): Mention goto-line-relative.
2020-09-23 22:39:32 +03:00
Andrea Corallo
2f78ac32bb
* Add `comp--install-trampoline' machinery
...
* src/comp.c (Fcomp__install_trampoline): New function to
install a subr trampoline into the function relocation table.
Once this is done any call from native compiled Lisp to the
related primitive will go through the `funcall' trampoline
making advicing effective.
2020-09-23 21:08:02 +02:00
Andrea Corallo
2ab0966b2f
Make CHECK_SUBR public
...
* src/data.c (CHECK_SUBR): Move from here to...
* src/lisp.h (CHECK_SUBR): ...to here.
2020-09-23 20:53:33 +02:00
Stefan Kangas
ad285e0eb8
Remove TODO to convert files to unit tests
...
* test/lisp/textmodes/css-mode-tests.el:
* test/lisp/progmodes/ruby-mode-tests.el: Remove TODO to convert test
files into unit tests. The files are still useful for debugging.
Ref: https://lists.gnu.org/r/emacs-devel/2020-09/msg01906.html
2020-09-23 20:53:06 +02:00
Andrea Corallo
9d4fd669cf
* lisp/emacs-lisp/comp.el (comp-final): Log when interactively invoked.
2020-09-23 20:48:23 +02:00
Andrea Corallo
63c65b4fe0
* lisp/emacs-lisp/comp.el (native-compile): Add OUTPUT parameter.
2020-09-23 20:47:34 +02:00
Stefan Kangas
37a2a427e4
Convert some completion.el tests to ERT
...
* test/lisp/completion-tests.el: New file.
* lisp/completion.el: Move commented out tests to completion-tests.el.
2020-09-23 20:03:19 +02:00
Stefan Kangas
610b771d4a
Convert allout unit tests to ERT
...
* test/lisp/allout-tests.el: New file.
* lisp/allout.el (allout-run-unit-tests-on-load)
(allout-run-unit-tests): Remove.
(allout-tests-obliterate-variable)
(allout-tests-globally-unbound, allout-tests-globally-true)
(allout-tests-locally-true, allout-test-resumptions): Move to
allout-tests.el
* test/lisp/allout-widgets-tests.el: New file.
* lisp/allout-widgets.el (allout-widgets-run-unit-tests-on-load)
(allout-widgets-run-unit-tests): Remove.
(allout-test-range-overlaps): Move to allout-widgets-tests.el.
2020-09-23 20:03:19 +02:00
Stefan Kangas
acf958667b
* lisp/repeat.el: Remove obsolete comment.
2020-09-23 20:03:19 +02:00
Michael Albinus
441e875019
* test/lisp/net/dbus-tests.el (dbus-test01-basic-types): Adapt test.
2020-09-23 19:57:03 +02:00