1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-12 22:40:46 -08:00
Commit graph

73882 commits

Author SHA1 Message Date
Federico Tedin
36bf5534bf Allow gamegrid-add-score to treat lower scores as better.
* lisp/play/gamegrid.el (gamegrid-add-score): Add 'reverse' parameter.
(gamegrid-add-score-with-update-game-score): Add 'reverse' parameter.
(gamegrid-add-score-with-update-game-score-1): Add 'reverse'
parameter.  Pass on "-r" argument to update-game-score.
(gamegrid-add-score-insecure): Add 'reverse' parameter, reverse scores
when it's non-nil.  (Bug#36867)

* etc/NEWS: Announce the change.
2019-09-14 11:20:32 +03:00
Gemini Lasswell
5c40c21a47 Improve performance of backtrace printing (bug#36566)
* lisp/emacs-lisp/cl-print.el (cl-print-to-string-with-limit): Reduce
print-level and print-length more quickly when the structure being
printed is very large.
2019-09-13 13:43:07 -07:00
Gemini Lasswell
2093395dbf Improve print output options commands in backtrace-mode (bug#36566)
* lisp/emacs-lisp/backtrace.el (backtrace-view): Mention
:print-gensym in docstring.
(backtrace-mode-map): Add keyboard binding for
backtrace-toggle-print-gensym.  Add menu entries for
backtrace-toggle-print-circle and backtrace-toggle-print-gensym.
(backtrace--with-output-variables): Bind print-gensym with value
of :print-gensym found in view plist.
(backtrace-toggle-print-circle): Remove description of
implementation details from docstring.
(backtrace-toggle-print-gensym): New command.
(backtrace--toggle-feature): Add echo area message describing result
of command.

* test/lisp/emacs-lisp/backtrace-tests.el
(backtrace-tests--print-circle): New test.

* doc/lispref/debugging.texi (Backtraces): Document keyboard
binding for backtrace-toggle-print-gensym.
2019-09-13 13:43:07 -07:00
Stefan Kangas
224534ab8d * lisp/help-mode.el (help-mode-menu): Fix typo. (Bug#36485) 2019-09-13 20:51:06 +02:00
Stefan Kangas
45b01f2d7f Remove leftover XEmacs compat code and doc fixes
* lisp/mail/feedmail.el (top-level): Remove outdated comment.
(feedmail-run-the-queue): Remove leftover XEmacs compat code.
(feedmail-nuke-bcc): Doc fix.

* lisp/emulation/viper.el (top-level, viper-mode)
* lisp/net/rfc2104.el (top-level): Doc fix.

* lisp/textmodes/table.el (top-level): Remove obsolete todo.
2019-09-13 18:37:15 +02:00
Stefan Kangas
897540069f Change gui--selection-value-internal comment into doc string
* lisp/select.el (gui--selection-value-internal): Change comment into
doc string.  (Bug#25528)
2019-09-13 14:57:23 +02:00
Michael Albinus
8af6b3ef42 ; Fix a typo by last commit 2019-09-13 14:33:06 +02:00
Michael Albinus
89a63c9186 ; Add traces in shadowfile.el 2019-09-13 14:25:56 +02:00
Michael Albinus
d8c7bf6683 Make recent Tramp patch work for tramp-archive.el
* lisp/net/tramp.el (tramp-connectable-p): Make it work also for
tramp-archive.el.
2019-09-13 12:08:02 +02:00
Jack Coughlin
a4c471c984 Fix saving user-defined calc commands with compositions (Bug#36720)
* lisp/calc/calc-prog.el (calc-user-define-permanent): Correctly save
the composition when the user specifies their formula by its command
name or key.

Copyright-paperwork-exempt: yes
2019-09-12 20:25:30 -04:00
Noam Postavsky
cbb8a8ad97 Fix fill-paragraph in python docstrings (Bug#36056)
* lisp/progmodes/python.el (python-do-auto-fill): New function.
(python-mode): Set it as normal-auto-fill-function, and don't set
fill-indent-according-to-mode.  Having the latter set during
fill-paragraph gives wrongs result, because python-indent-line doesn't
remove indentation added by filling.
* test/lisp/progmodes/python-tests.el (python-fill-docstring): New
test.
2019-09-12 20:25:30 -04:00
Stefan Monnier
421084d2cb * lisp/progmodes/sh-script.el (sh--assignment-collect): Only after =! 2019-09-12 15:43:50 -04:00
Stefan Monnier
7fbabaf96a * lisp/progmodes/sh-script.el (sh-mode-map): Don't bind =
(sh-shell-initialize-variables): Use sh--assignment-collect on
post-self-insert-hook instead.
(sh--assignment-collect): New function, extracted from sh-assignment.
(sh-assignment): Use it and mark as obsolete.
2019-09-12 14:26:40 -04:00
Karl Fogel
bbadc6e05f Add `isearch-yank-until-char'
* lisp/isearch.el (isearch-yank-until-char): New function.
  (isearch-mode-map, isearch-menu-bar-yank-map): Add it.
  (isearch-forward): Document the new binding.

* doc/emacs/search.texi (Isearch Yanking): Document the feature.

* etc/NEWS: Mention the above.
2019-09-12 12:42:13 -05:00
Michael Albinus
5e8d477d63 Optimize host name completion in Tramp
* lisp/net/tramp-adb.el (tramp-adb-maybe-open-connection):
* lisp/net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
* lisp/net/tramp-rclone.el (tramp-rclone-maybe-open-connection):
* lisp/net/tramp-sh.el (tramp-maybe-open-connection):
* lisp/net/tramp-smb.el (tramp-smb-maybe-open-connection):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-maybe-open-connection):
Throw `non-essential' at the beginning of the function.

* lisp/net/tramp.el (tramp-handle-file-exists-p):
* lisp/net/tramp-sh.el (tramp-sh-handle-file-exists-p):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-file-exists-p):
Run only when host is connectable.  This is due to host name
completion, which shall be optimized.

* lisp/net/tramp-smb.el (tramp-smb-do-file-attributes-with-stat)
(tramp-smb-get-file-entries): Access connection buffer only after
sending the command.

* lisp/net/tramp.el (tramp-get-buffer, tramp-get-connection-buffer):
New argument DONT-CREATE.
(tramp-message): Use it.
(tramp-get-mutex): Check, whether host is connectable.
(tramp-file-name-handler): Set thread only when host is connectable.
(tramp-connectable-p): Allow also VEC as argument.
(tramp-completion-handle-file-name-completion): Do not expand directory.
2019-09-12 16:38:48 +02:00
Paul Eggert
636856faa4 Fix auto-save with user-emacs-directory
* lisp/startup.el (auto-save-list-file-prefix): Delay initialization,
since the value depends on user-emacs-directory (Bug#37354).
2019-09-11 08:50:41 -07:00
Mattias Engdegård
4d90fadf27 * lisp/emacs-lisp/elint.el (elint-directory-skip-re): Fix doc typo. 2019-09-11 11:18:38 +02:00
Katsumi Yamaoka
4b9f9324a8 Create a new overlay used to mark Attachment header (bug#37370)
* lisp/gnus/gnus-art.el (gnus-mime-inline-part)
(gnus-mm-display-part, gnus-mime-buttonize-attachments-in-header):
Create a new overlay used to mark Attachment header instead of
using existing overlays.
2019-09-11 02:41:34 +00:00
Stephen Leake
3d44231288 Merge commit '74e9799bd8' 2019-09-10 03:37:51 -07:00
Stephen Leake
ac1a2e260e Support `cl-defstruct' in autoloads
* lisp/emacs-lisp/autoload.el (make-autoload): Add `cl-defstruct' to
"complex cases" list.

* lisp/emacs-lisp/cl-macs.el (cl-defstruct): Add :autoload-end to
limit what is declared in autoloads.el for a defstruct.
2019-09-10 03:36:15 -07:00
Ulf Jasper
74e9799bd8 Handle missing start-time when importing ical event (Bug#33277)
* lisp/calendar/icalendar.el (icalendar--convert-ical-to-diary): Set
start time only if it is explicitly given in ical.  Do not use
start-time as default for end-time (Bug#33277).

* test/lisp/calendar/icalendar-tests.el (icalendar-import-bug-33277):
New.  Test fix for Bug#33277.
2019-09-09 18:35:02 +02:00
Stefan Kangas
4042dad139 Match Python 3 code object names in "M-x pdb"
* lisp/progmodes/gud.el (gud-pdb-marker-regexp): Match Python 3 code
object names.  (Bug#11679)
2019-09-09 04:33:07 +02:00
Stefan Kangas
a1e93c1633 ; * lisp/ps-print.el: Doc fix. 2019-09-09 01:13:54 +02:00
Stefan Kangas
c86f91caf0 Remove final XEmacs compat code from dframe.el
* lisp/dframe.el (top-level): Doc fix.
(dframe-frame-parameter): Redefine as an obsolete function alias for
'frame-parameter'.
2019-09-09 01:13:54 +02:00
Stefan Monnier
69db930c7e * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Define setter functions.
When :noinline is specified one can't rely on setf expanding the
inlinable function to construct the setter.
Fixes bug#37283.
2019-09-08 18:41:43 -04:00
Stefan Kangas
e94d01f1ac Remove support for upgrading from old bookmark file format
* lisp/bookmark.el (bookmark-alist-from-buffer): Remove support for
old bookmark file format.  (Bug#37122)
(bookmark-upgrade-version-0-alist)
(bookmark-upgrade-file-format-from-0)
(bookmark-grok-file-format-version)
(bookmark-maybe-upgrade-file-format): Declare obsolete.
(bookmark-load): Don't call 'bookmark-maybe-upgrade-file-format'.
* etc/NEWS: Announce it.
2019-09-08 22:48:20 +02:00
Juri Linkov
7f85a5569d * lisp/tmm.el: Fix broken tmm-prompt (bug#34517)
* lisp/tmm.el (tmm-prompt): Don't duplicate items of tmm--history.
Don't reverse tmm-km-list for completion.  Don't set the initial
position of 'tmm--history.  Use reverse tmm--history as the list
of default values for M-n.
(tmm-add-prompt): Don't insert initial value to the minibuffer.
2019-09-08 23:27:23 +03:00
Alan Mackenzie
034f9363e3 Fix untidinesses in compile.el.
* lisp/progmodes/compile.el (compilation--margin-string): Renamed from
compilation-margin-string.  Use defconst rather than defvar.  Use propertize
rather than a separate put-text-property.  Trim the doc string.
2019-09-08 10:44:27 +00:00
Michael Albinus
d42d46d111 Fix Bug#36090
* lisp/vc/vc-hg.el (vc-hg--pushpull, vc-hg-merge-branch)
(vc-hg-command): Disable pager.  (Bug#36090)
2019-09-08 12:01:41 +02:00
Stefan Kangas
8e93e6da7c Use derived-mode-p consistently in info.el
* lisp/info.el (Info-hide-note-references, info-display-manual)
(info--manual-names): Use derived-mode-p.  (Bug#27583)
2019-09-08 00:17:25 +02:00
Noam Postavsky
8c0ae0f93a Let byte-compiler recognize that local-variable-p implies boundp
* lisp/emacs-lisp/bytecomp.el (byte-compile-maybe-guarded): Add
arguments to local-variable-p to the bound list.
* lisp/image-mode.el (image-toggle-display-image): Remove no longer
needed boundp check.
2019-09-07 17:00:39 -04:00
Joel Rosdahl
8d588f09e9 Fix flymake-proc temporary file deletion bug
* list/progmodes/flymake-proc.el (flymake-proc-create-temp-inplace):
Include a time string part (hour + minute + second + nanosecond) in
the temporary name to make it unique enough.
(flymake-proc-legacy-flymake): Store temporary file names in the
process for usage in the sentinel.
(flymake-proc--process-sentinel): Bind values of temporary file names
dynamically to values stored in the process so that the cleanup
function will delete the correct temporary file(s).

Fixes bug#31981.
2019-09-07 16:51:24 -04:00
Eli Zaretskii
14875443ff Support visiting compressed image files
* lisp/image-mode.el (image-toggle-display-image): Support
visiting compressed image files which are uncompressed by
jka-compr.el.  (Bug#37330)
2019-09-07 15:53:57 +03:00
Michael Albinus
01a04880ca Add traces in shadowfile
* lisp/shadowfile.el (shadow-add-to-todo)
(shadow-remove-from-todo, shadow-save-todo-file):
* test/lisp/shadowfile-tests.el (shadow-test08-shadow-todo):
Add traces.
2019-09-07 12:31:31 +02:00
Evgeny Zajcev
52f83af1f3 Fix input method operation on read-only text
* lisp/international/quail.el (quail-input-method): Check also
read-only property of text in addition to the buffer's
read-only state.
2019-09-07 13:04:36 +03:00
Eli Zaretskii
40eb4c51a4 ; (server-goto-toplevel): Fix comment to reflect the code. 2019-09-07 12:42:52 +03:00
Eli Zaretskii
cac8152c8e Allow client connections when in recursive-edit
* lisp/server.el (server-goto-toplevel): Check minibuffer
depth, not recursion depth.  This avoids exiting
recursive-edit if a client connection is accepted during
recursive-edit.  (Bug#37176)
2019-09-07 12:33:03 +03:00
Eli Zaretskii
7eaca940ce Allow Zs characters to be composed
* src/composite.c (char_composable_p): Allow SPC and other Zs
characters to be composed.

* lisp/composite.el (compose-gstring-for-graphic): Don't
reject characters whose general category is Zs.  (Bug#14461)
2019-09-07 12:19:06 +03:00
Eli Zaretskii
f425099559 Revert "file-truename now uses realpath for local files"
This reverts commit a59839d755.
This commit broke the MS-Windows build (because there's no
realpath on MS-Windows).  Even if I change the implementation
to always signal an error on MS-Windows, the build fails.
2019-09-07 10:14:31 +03:00
Paul Eggert
a59839d755 file-truename now uses realpath for local files
This uses fewer syscalls on GNU/Linux and other GNUish platforms.
* lisp/files.el (file-truename): Try fileio--truename
if there are no handlers.
* src/fileio.c: Include stdlib.h, for realpath.
(Ffileio__truename): New function.
2019-09-06 14:31:38 -07:00
Mauro Aranda
5b117511aa Improve file name completion in file and directory widgets (Bug#7779)
* lisp/wid-edit.el (widget 'file, widget 'directory): Respect the option
read-file-name-completion-ignore-case.
(widget 'directory): Filter the file names, to only perform directory name
completion.
2019-09-06 17:02:08 -04:00
Amin Bandali
ff0f4c7312 Fix erc-lurker-update-status (bug#36843)
Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding".

* lisp/erc/erc.el (erc-message-parsed): New variable.
(erc-display-message): Dynamically bind it.
(erc-lurker-update-status): Check it instead of using `parsed'
directly.  This results in `erc-lurker-state' being properly updated
to keep track of non-lurkers, and thus `erc-lurker-p' returning
correct results rather than return t for everyone.
2019-09-05 19:56:14 -04:00
Lars Ingebrigtsen
2180852c72 Further fix for network-security-protocol-checks
* lisp/net/nsm.el (network-security-protocol-checks): Fix the
defcustom type some more (bug#37306).
2019-09-05 13:26:08 +02:00
Lars Ingebrigtsen
71964ccc10 Fix defcustom type of network-security-protocol-checks
* lisp/net/nsm.el (network-security-protocol-checks): Fix the
defcustom type (bug#37306).
2019-09-05 13:23:11 +02:00
Robert Pluim
95becaaf3b Don't check for :safe-renegotiation with TLS1.3
* lisp/net/nsm.el (nsm-protocol-check--renegotiation-info-ext): Don't
check when using TLS1.3, renegotiation has been removed from TLS.
Reported in
<https://lists.gnu.org/archive/html/help-gnu-emacs/2019-09/msg00005.html>
2019-09-04 23:46:31 +02:00
Robert Pluim
fc9ed61a43 Fix nsm for unencrypted connections
When connecting using a cleartext connection, nsm was erroring out and
tearing down the connection because it was trying to display
nonexistent certificate information.

* lisp/net/nsm.el (nsm-query-user): Only format certificate status
when it is valid.  (Bug#37221)
2019-09-04 23:46:31 +02:00
Mattias Engdegård
2aee20fbf8 Correct arguments to `skip-syntax-forward'
* lisp/wid-edit.el (widget-sexp-validate): Fix bad calls to
`skip-syntax-forward', whose argument is not a regexp.
2019-09-04 16:27:02 +02:00
Lars Ingebrigtsen
4c3a40a9b7 Make the NSM not pop up an X dialogue on non-mouse actions
* lisp/emacs-lisp/rmc.el (read-multiple-choice): Don't pop up X
dialogues on (url-retrieve "https://expired.badssl.com/" #'ignore)
and the like.
2019-09-04 15:20:00 +02:00
Lars Ingebrigtsen
9df72ecb63 Preserve more markers when reverting .gpg files
* lisp/epa-file.el (epa-file--replace-text): Gingerly replace the
text in the buffer to preserve as many markers as possible
(bug#34720).  This emulates the behaviour of Finsert_file_contents
more accurately.
(epa-file-decode-and-insert): Remove compat code.
(epa-file-insert-file-contents): Use the new function.

* lisp/emacs-lisp/cl-lib.el (cl-incf): Add autoload cookie.
2019-09-04 15:20:00 +02:00
Mattias Engdegård
3f30d98af9 Repair change to compilation-context-lines (bug#36832)
* lisp/progmodes/compile.el (compilation-set-window):
Restore proper behaviour when compilation-context-lines is nil,
which is the default.
2019-09-04 14:35:18 +02:00