mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-25 06:50:46 -08:00
Code Issues Projects Releases Wiki Activity

It's neater to pad out free segments instead of adding a field to the segment structure.

Browse source 
Copied from Perforce
 Change: 187231
 ServerID: perforce.ravenbrook.com
This commit is contained in:
Gareth Rees 2014-10-13 11:07:16 +01:00
parent fa4429dae1
commit fce7e87366
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
mps/code/poolsnc.c
View file

@ -200,7 +200,6 @@ typedef struct SNCSegStruct *SNCSeg;
typedef struct SNCSegStruct {
GCSegStruct gcSegStruct; /* superclass fields must come first */
SNCSeg next; /* Next segment in chain, or NULL */
Bool free; /* Segment is free? */
Sig sig;
} SNCSegStruct;
@ -211,9 +210,6 @@ typedef struct SNCSegStruct {
#define sncSegSetNext(seg, nextseg) \
((void)(SegSNCSeg(seg)->next = SegSNCSeg(nextseg)))
#define sncSegFree(seg) RVALUE(SegSNCSeg(seg)->free)
#define sncSegSetFree(seg, _free) ((void)(SegSNCSeg(seg)->free = (_free)))
ATTRIBUTE_UNUSED
static Bool SNCSegCheck(SNCSeg sncseg)
{
@ -222,7 +218,6 @@ static Bool SNCSegCheck(SNCSeg sncseg)
if (NULL != sncseg->next) {
CHECKS(SNCSeg, sncseg->next);
}
CHECKL(BoolCheck(sncseg->free));
return TRUE;
}
@ -249,7 +244,6 @@ static Res sncSegInit(Seg seg, Pool pool, Addr base, Size size,
return res;
sncseg->next = NULL;
sncseg->free = TRUE;
sncseg->sig = SNCSegSig;
AVERT(SNCSeg, sncseg);
return ResOK;
@ -277,7 +271,6 @@ static void sncRecordAllocatedSeg(Buffer buffer, Seg seg)
AVERT(Seg, seg);
AVER(sncSegNext(seg) == NULL);
sncSegSetFree(seg, FALSE);
sncSegSetNext(seg, sncBufferTopSeg(buffer));
sncBufferSetTopSeg(buffer, seg);
}
@ -296,7 +289,9 @@ static void sncRecordFreeSeg(SNC snc, Seg seg)
SegSetGrey(seg, TraceSetEMPTY);
SegSetRankAndSummary(seg, RankSetEMPTY, RefSetEMPTY);
sncSegSetFree(seg, TRUE);
/* Pad the whole segment so we don't try to walk it. */
(*SNCPool(snc)->format->pad)(SegBase(seg), SegSize(seg));
sncSegSetNext(seg, snc->freeSegs);
snc->freeSegs = seg;
}
@ -678,7 +673,7 @@ static void SNCWalk(Pool pool, Seg seg, FormattedObjectsVisitor f,
/* Avoid applying the function to grey objects. */
/* They may have pointers to old-space. */
if (SegGrey(seg) == TraceSetEMPTY && !sncSegFree(seg)) {
if (SegGrey(seg) == TraceSetEMPTY) {
Addr object = SegBase(seg);
Addr nextObject;
Addr limit;