mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

Sink calls to byte-compile-warning-enabled-p

Browse source 
* lisp/emacs-lisp/bytecomp.el (byte-compile--check-arity-bytecode)
(byte-compile-warn-about-unresolved-functions, byte-compile-form)
(byte-compile-free-vars-warn):
Delay checking whether a warning is enabled until we are about to emit
such a warning, since most warnings are enabled most of the time but
finding something to warn about is rare.
This commit is contained in:
Mattias Engdegård 2025-10-23 13:49:57 +02:00
parent a78bf76fb9
commit c2b23a04c2
1 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

42
lisp/emacs-lisp/bytecomp.el
View file

@ -1581,8 +1581,7 @@ when printing the error message."
(defun byte-compile--check-arity-bytecode (form bytecode)
"Check that the call in FORM matches that allowed by BYTECODE."
(when (and (byte-code-function-p bytecode)
(byte-compile-warning-enabled-p 'callargs))
(when (byte-code-function-p bytecode)
(let* ((actual-args (length (cdr form)))
(arity (func-arity bytecode))
(min-args (car arity))
@ -1883,18 +1882,19 @@ It is too wide if it has any lines longer than the largest of
;; defined, issue a warning enumerating them.
;; `unresolved' in the list `byte-compile-warnings' disables this.
(defun byte-compile-warn-about-unresolved-functions ()
(when (byte-compile-warning-enabled-p 'unresolved)
(let ((byte-compile-current-form :end))
;; Separate the functions that will not be available at runtime
;; from the truly unresolved ones.
(dolist (urf byte-compile-unresolved-functions)
(let ((f (car urf)))
(when (not (memq f byte-compile-new-defuns))
(byte-compile-warn-x
f
(if (fboundp f) "the function `%s' might not be defined at runtime." "the function `%s' is not known to be defined.")
(car urf)))))))
nil)
(let ((byte-compile-current-form :end))
;; Separate the functions that will not be available at runtime
;; from the truly unresolved ones.
(dolist (urf byte-compile-unresolved-functions)
(let ((f (car urf)))
(when (and (not (memq f byte-compile-new-defuns))
(byte-compile-warning-enabled-p 'unresolved))
(byte-compile-warn-x
f
(if (fboundp f)
"the function `%s' might not be defined at runtime."
"the function `%s' is not known to be defined.")
(car urf)))))))
;; Dynamically bound in byte-compile-from-buffer.
@ -3428,11 +3428,11 @@ lambda-expression."
(let ((hook (car-safe (cdr form))))
(if (eq (car-safe hook) 'quote)
(byte-compile-check-variable (cadr hook) nil))))
(when (and (byte-compile-warning-enabled-p 'suspicious)
(macroexp--const-symbol-p fn))
(when (and (macroexp--const-symbol-p fn)
(byte-compile-warning-enabled-p 'suspicious))
(byte-compile-warn-x fn "`%s' called as a function" fn))
(when (and (byte-compile-warning-enabled-p 'interactive-only fn)
interactive-only)
(when (and interactive-only
(byte-compile-warning-enabled-p 'interactive-only fn))
(byte-compile-warn-x fn "`%s' is for interactive use only%s"
fn
(cond ((stringp interactive-only)
@ -3842,12 +3842,12 @@ VAR must not be lexically bound.
ARG is a position argument, used by `byte-compile-warn-x'.
If optional argument ASSIGNMENT is non-nil, this is treated as an
assignment (i.e. `setq')."
(unless (or (not (byte-compile-warning-enabled-p 'free-vars var))
(boundp var)
(unless (or (boundp var)
(memq var byte-compile-bound-variables)
(memq var (if assignment
byte-compile-free-assignments
byte-compile-free-references)))
byte-compile-free-references))
(not (byte-compile-warning-enabled-p 'free-vars var)))
(let* ((varname (prin1-to-string var))
(desc (if assignment "assignment" "reference"))
(suggestions (help-uni-confusable-suggestions varname)))