From ac65a856ac9b2a5fd2199ebe31c4f2cab5d694cf Mon Sep 17 00:00:00 2001
From: Gareth Rees <gdr@ravenbrook.com>
Date: Mon, 2 Jul 2018 09:05:03 +0100
Subject: [PATCH] Fix issues identified in review by gdr.

Copied from Perforce
 Change: 194339
---
 mps/code/poolmv.c   |  2 +-
 mps/code/poolmvff.c |  4 ++--
 mps/code/poolmvff.h | 10 +++++-----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/mps/code/poolmv.c b/mps/code/poolmv.c
index 946f5b01476..c34ee164329 100644
--- a/mps/code/poolmv.c
+++ b/mps/code/poolmv.c
@@ -62,7 +62,7 @@ DECLARE_CLASS(Pool, MVDebugPool, MVPool);
 #define mvBlockPool(mv) MFSPool(&(mv)->blockPoolStruct)
 #define mvSpanPool(mv) MFSPool(&(mv)->spanPoolStruct)
 
-#define MVPool(mv) (&(mv)->poolStruct)
+#define MVPool(mv) RVALUE(&(mv)->poolStruct)
 #define PoolMV(pool) PARENT(MVStruct, poolStruct, pool)
 
 
diff --git a/mps/code/poolmvff.c b/mps/code/poolmvff.c
index bdb8e352f74..dc35724c06d 100644
--- a/mps/code/poolmvff.c
+++ b/mps/code/poolmvff.c
@@ -8,8 +8,8 @@
  *                   pool, since it is used to implement that pool.
  *
  * .purpose: This is a pool class for manually managed objects of
- * variable size where address-ordered first fit is an appropriate
- * policy.  Provision is made to allocate in reverse.
+ * variable size where address-ordered first (or last) fit is an
+ * appropriate policy.
  *
  * .design: <design/poolmvff>
  *
diff --git a/mps/code/poolmvff.h b/mps/code/poolmvff.h
index c823a4587c7..65c5283392a 100644
--- a/mps/code/poolmvff.h
+++ b/mps/code/poolmvff.h
@@ -1,12 +1,12 @@
 /* poolmvff.h: First Fit Manual Variable Pool
  *
  * $Id$
- * Copyright (c) 2001-2014 Ravenbrook Limited.  See end of file for license.
+ * Copyright (c) 2001-2018 Ravenbrook Limited.  See end of file for license.
  * Portions copyright (C) 2002 Global Graphics Software.
  *
  * .purpose: This is a pool class for manually managed objects of
- * variable size where address-ordered first fit is an appropriate
- * policy.  Provision is made to allocate in reverse.
+ * variable size where address-ordered first (or last) fit is an
+ * appropriate policy.
  *
  * .design: See <design/poolmvff/>
  */
@@ -24,7 +24,7 @@ extern PoolClass PoolClassMVFF(void);
 
 extern Bool MVFFCheck(MVFF mvff);
 
-#define MVFFPool(mvff) (&(mvff)->poolStruct)
+#define MVFFPool(mvff) RVALUE(&(mvff)->poolStruct)
 
 
 #endif /* poolmvff_h */
@@ -32,7 +32,7 @@ extern Bool MVFFCheck(MVFF mvff);
 
 /* C. COPYRIGHT AND LICENSE
  *
- * Copyright (C) 2001-2014 Ravenbrook Limited <http://www.ravenbrook.com/>.
+ * Copyright (C) 2001-2018 Ravenbrook Limited <http://www.ravenbrook.com/>.
  * All rights reserved.  This is an open source license.  Contact
  * Ravenbrook for commercial licensing options.
  *