mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-15 10:30:25 -08:00
Code Issues Projects Releases Wiki Activity

Support setting umask symbolically in Eshell

Browse source 
* lisp/eshell/em-basic.el (eshell/umask): Handle setting umask
symbolically, and make setting umask take precedence over "-S".

* test/lisp/eshell/em-basic-tests.el
(em-basic-test/umask-print-numeric, em-basic-test/umask-read-symbolic,
em-basic-test/umask-set): Rename to...
(em-basic-test/umask/print-numeric)
(em-basic-test/umask/print-symbolic, em-basic-test/umask/set-numeric):
... these.
(em-basic-test/umask/set-symbolic, em-basic-test/umask/set-with-S):
New tests.

* etc/NEWS: Announce this change.
This commit is contained in:
Jim Porter 2023-03-04 22:11:23 -08:00
parent 236317e5d2
commit a3cd284b90
3 changed files with 52 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

24
lisp/eshell/em-basic.el
View file

@ -160,6 +160,18 @@ or `eshell-printn' for display."
:preserve-args
:usage "[-S] [mode]")
(cond
(args
(let* ((mask (car args))
(modes
(if (stringp mask)
(if (string-match (rx bos (+ (any "0-7")) eos) mask)
(- #o777 (string-to-number mask 8))
(file-modes-symbolic-to-number
mask (default-file-modes)))
(- #o777 mask))))
(set-default-file-modes modes)
(eshell-print
"Warning: umask changed for all new files created by Emacs.\n")))
(symbolic-p
(let ((mode (default-file-modes)))
(eshell-printn
@ -173,17 +185,9 @@ or `eshell-printn' for display."
(concat (and (= (logand mode 1) 1) "r")
(and (= (logand mode 2) 2) "w")
(and (= (logand mode 4) 4) "x"))))))
((not args)
(eshell-printn (format "%03o" (logand (lognot (default-file-modes))
#o777))))
(t
(when (stringp (car args))
(if (string-match "^[0-7]+$" (car args))
(setcar args (string-to-number (car args) 8))
(error "Setting umask symbolically is not yet implemented")))
(set-default-file-modes (- #o777 (car args)))
(eshell-print
"Warning: umask changed for all new files created by Emacs.\n")))
(eshell-printn (format "%03o" (logand (lognot (default-file-modes))
#o777)))))
nil))
(put 'eshell/umask 'eshell-no-numeric-conversions t)