From 85ea3f7f47ef1a767aa2954be896d4aaef3163c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miha=20Rihtar=C5=A1i=C4=8D?= Date: Mon, 25 Oct 2021 15:24:29 +0200 Subject: [PATCH 1/2] Fix issue with interpreting ANSI codes in eshell * lisp/eshell/esh-mode.el (eshell-mode): Make window point advance on insertion. (eshell-output-filter): Don't use insert-before-markers (bug#45380). --- lisp/eshell/esh-mode.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el index 98e89037f33..8e6506c301c 100644 --- a/lisp/eshell/esh-mode.el +++ b/lisp/eshell/esh-mode.el @@ -315,6 +315,8 @@ and the hook `eshell-exit-hook'." (setq-local bookmark-make-record-function #'eshell-bookmark-make-record) (setq local-abbrev-table eshell-mode-abbrev-table) + (setq-local window-point-insertion-type t) + (setq-local list-buffers-directory (expand-file-name default-directory)) ;; always set the tab width to 8 in Eshell buffers, since external @@ -696,13 +698,10 @@ This is done after all necessary filtering has been done." (setq oend (+ oend nchars))) ;; Let the ansi-color overlay hooks run. (let ((inhibit-modification-hooks nil)) - (insert-before-markers string)) + (insert string)) (if (= (window-start) (point)) (set-window-start (selected-window) (- (point) nchars))) - (if (= (point) eshell-last-input-end) - (set-marker eshell-last-input-end - (- eshell-last-input-end nchars))) (set-marker eshell-last-output-start ostart) (set-marker eshell-last-output-end (point)) (force-mode-line-update)) From 4779d3ba193174cac02ddae4daed621dac3fd782 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Mon, 25 Oct 2021 15:34:48 +0200 Subject: [PATCH 2/2] * doc/lispref/functions.texi (Mapping Functions): Use #' when mapping. --- doc/lispref/functions.texi | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi index 91118b7ae05..cb14d02d449 100644 --- a/doc/lispref/functions.texi +++ b/doc/lispref/functions.texi @@ -910,11 +910,11 @@ length of @var{sequence}. For example: @example @group -(mapcar 'car '((a b) (c d) (e f))) +(mapcar #'car '((a b) (c d) (e f))) @result{} (a c e) -(mapcar '1+ [1 2 3]) +(mapcar #'1+ [1 2 3]) @result{} (2 3 4) -(mapcar 'string "abc") +(mapcar #'string "abc") @result{} ("a" "b" "c") @end group @@ -930,14 +930,14 @@ Return the list of results." ;; @r{If no list is exhausted,} (if (not (memq nil args)) ;; @r{apply function to @sc{car}s.} - (cons (apply function (mapcar 'car args)) - (apply 'mapcar* function + (cons (apply function (mapcar #'car args)) + (apply #'mapcar* function ;; @r{Recurse for rest of elements.} - (mapcar 'cdr args))))) + (mapcar #'cdr args))))) @end group @group -(mapcar* 'cons '(a b c) '(1 2 3 4)) +(mapcar* #'cons '(a b c) '(1 2 3 4)) @result{} ((a . 1) (b . 2) (c . 3)) @end group @end example @@ -954,10 +954,10 @@ the results (which must be lists), by altering the results (using @example @group ;; @r{Contrast this:} -(mapcar 'list '(a b c d)) +(mapcar #'list '(a b c d)) @result{} ((a) (b) (c) (d)) ;; @r{with this:} -(mapcan 'list '(a b c d)) +(mapcan #'list '(a b c d)) @result{} (a b c d) @end group @end example @@ -986,7 +986,7 @@ string. @example @group -(mapconcat 'symbol-name +(mapconcat #'symbol-name '(The cat in the hat) " ") @result{} "The cat in the hat"