mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-07 06:50:23 -08:00
Code Issues Projects Releases Wiki Activity

Don't allow implicit package name arg for binders

Browse source 
It's unlikely that

    (use-package foopkg :bind "<some-key>")

intendes to bind <some-key> to 'foopkg command.
This commit is contained in:
Noam Postavsky 2016-08-05 18:43:34 -04:00
parent 65c7b42a14
commit 9688d2f64b
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lisp/use-package/use-package.el
View file

@ -712,6 +712,10 @@ If RECURSED is non-nil, recurse into sublists."
(defun use-package-normalize-binder (name keyword args) (defun use-package-normalize-binder (name keyword args)
(use-package-as-one (symbol-name keyword) args (use-package-as-one (symbol-name keyword) args
(lambda (label arg) (lambda (label arg)
(unless (consp arg)
(use-package-error
(concat label " a (<string or vector> . <symbol or string>)"
" or list of these")))
(use-package-normalize-pairs (lambda (k) (or (stringp k) (vectorp k))) (use-package-normalize-pairs (lambda (k) (or (stringp k) (vectorp k)))
(lambda (b) (or (symbolp b) (stringp b))) (lambda (b) (or (symbolp b) (stringp b)))
name label arg)))) name label arg))))

2
test/lisp/use-package/use-package-tests.el
View file

@ -32,6 +32,8 @@
(should (equal (use-package-normalize-binder (should (equal (use-package-normalize-binder
'foopkg :bind good-values) 'foopkg :bind good-values)
good-values))) good-values)))
(should-error (use-package-normalize-binder
'foopkg :bind '("foo")))
(should-error (use-package-normalize-binder (should-error (use-package-normalize-binder
'foopkg :bind '("foo" . 99))) 'foopkg :bind '("foo" . 99)))
(should-error (use-package-normalize-binder (should-error (use-package-normalize-binder