mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-30 00:51:50 -08:00
Code Issues Projects Releases Wiki Activity

Simplify code relating to UI thread synchronization

Browse source 
* java/org/gnu/emacs/EmacsContextMenu.java (display):

* java/org/gnu/emacs/EmacsDialog.java (display):

* java/org/gnu/emacs/EmacsService.java (getEmacsView)
(getLocationOnScreen, getClipboardManager)
(requestDirectoryAccess): Replace manual synchronization within
Runnable objects by usage of FutureTask.
(syncRunnable): Accept FutureTask<V> in place of Runnables, and
obtain and return results from calls to its get method.
This commit is contained in:
Po Lu 2023-12-30 10:57:11 +08:00
parent fe2b68d405
commit 94e3d11593
3 changed files with 118 additions and 149 deletions
Download patch file Download diff file Expand all files Collapse all files

28
java/org/gnu/emacs/EmacsContextMenu.java
View file

@ -22,6 +22,9 @@ package org.gnu.emacs;
import java.util.List;
import java.util.ArrayList;
import java.util.concurrent.Callable;
import java.util.concurrent.FutureTask;
import android.content.Context;
import android.content.Intent;
@ -344,8 +347,7 @@ public final class EmacsContextMenu
display (final EmacsWindow window, final int xPosition,
final int yPosition, final int serial)
{
Runnable runnable;
final EmacsHolder<Boolean> rc;
FutureTask<Boolean> task;
/* Android will permanently cease to display any popup menus at
all if the list of menu items is empty. Prevent this by
@ -354,25 +356,17 @@ public final class EmacsContextMenu
if (menuItems.isEmpty ())
return false;
rc = new EmacsHolder<Boolean> ();
rc.thing = false;
runnable = new Runnable () {
task = new FutureTask<Boolean> (new Callable<Boolean> () {
@Override
public void
run ()
public Boolean
call ()
{
synchronized (this)
{
lastMenuEventSerial = serial;
rc.thing = display1 (window, xPosition, yPosition);
notify ();
}
lastMenuEventSerial = serial;
return display1 (window, xPosition, yPosition);
}
};
});
EmacsService.syncRunnable (runnable);
return rc.thing;
return EmacsService.<Boolean>syncRunnable (task);
}
/* Dismiss this context menu. WINDOW is the window where the