mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-04-21 05:21:37 -07:00
Code Issues Projects Releases Wiki Activity

Flymake: more fixes to flymake--highlight-line

Browse source 
Make it robust to diagonstics with invalid bounds.

* lisp/progmodes/flymake.el (flymake--highlight-line): Robustify.
This commit is contained in:
João Távora 2023-09-21 00:03:32 +01:00
parent e0ce4409b2
commit 8b1947ffdd
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lisp/progmodes/flymake.el
View file

@ -757,9 +757,9 @@ Return nil or the overlay created."
(setq beg a end b))))
(setf (flymake--diag-beg diagnostic) beg
(flymake--diag-end diagnostic) end)
;; Try to fix the remedy the situation if there is the same
;; diagnostic is already registered in the same place, which only
;; happens for clashes between domestic and foreign diagnostics
;; Try to remedy the situation if the same diagnostic is already
;; registered in the same place. This happens for clashes between
;; domestic and foreign diagnostics
(cl-loop for e in (flymake-diagnostics beg end)
for eov = (flymake--diag-overlay e)
when (flymake--equal-diagnostic-p e diagnostic)
@ -778,7 +778,12 @@ Return nil or the overlay created."
(flymake--diag-end e)
(flymake--diag-orig-end e))
(flymake--delete-overlay eov)))
(setq ov (make-overlay end beg))
(setq ov (make-overlay beg end))
(when (= (overlay-start ov) (overlay-end ov))
;; Some backends report diagnostics with invalid bounds. Don't
;; bother.
(delete-overlay ov)
(cl-return-from flymake--highlight-line nil))
(setf (flymake--diag-beg diagnostic) (overlay-start ov)
(flymake--diag-end diagnostic) (overlay-end ov))
;; First set `category' in the overlay