From 85c1287c260bcf18b54c388a64da20188ab13eec Mon Sep 17 00:00:00 2001 From: Koen van Greevenbroek Date: Wed, 10 Aug 2022 10:59:44 +0200 Subject: [PATCH 1/2] Make sure that bind-key's `override-global-mode` is initially on In 4004dde the arguments to `define-minor-mode` were changed erroneously. Whereas the `override-global-mode` was initially defined as `(define-minor-mode override-global-mode "..." t "")`, the two latter arguments where changed to `:global t :lighter ""`. However, the two original arguments corresponded to the keywords `:init-value` and `:lighter`, respectively. With `:init-value t` now missing, the minor mode isn't enabled by default, and `bind-key*` appears not to work. Copyright-paperwork-exempt: yes --- lisp/use-package/bind-key.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/use-package/bind-key.el b/lisp/use-package/bind-key.el index bf5785ff5b4..14784b09a15 100644 --- a/lisp/use-package/bind-key.el +++ b/lisp/use-package/bind-key.el @@ -131,6 +131,7 @@ (define-minor-mode override-global-mode "A minor mode so that keymap settings override other modes." + :init-value t :global t :lighter "") From a05b9e28edfa443480a42998b95b9ff30fb1b14b Mon Sep 17 00:00:00 2001 From: realcomplex Date: Thu, 11 Aug 2022 09:08:25 +0200 Subject: [PATCH 2/2] Go back to making `override-global-mode` non-global Copyright-paperwork-exempt: yes --- lisp/use-package/bind-key.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/use-package/bind-key.el b/lisp/use-package/bind-key.el index 14784b09a15..1f775711ef3 100644 --- a/lisp/use-package/bind-key.el +++ b/lisp/use-package/bind-key.el @@ -132,7 +132,6 @@ (define-minor-mode override-global-mode "A minor mode so that keymap settings override other modes." :init-value t - :global t :lighter "") ;; the keymaps in `emulation-mode-map-alists' take precedence over