From be7a0e46495b336ce3019e6d1dc6e602d703494a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 24 Apr 2016 10:31:23 -0400 Subject: [PATCH 1/3] Don't pass a constant as the state for use-package-process-keywords, because the function may modify the list object. Modifying a quoted constant can lead to unexpected side effects (e.g. values from previous use-package forms end up in subsequent ones). --- lisp/use-package/use-package.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/use-package/use-package.el b/lisp/use-package/use-package.el index cdff6ce772e..ffe2dac3e46 100644 --- a/lisp/use-package/use-package.el +++ b/lisp/use-package/use-package.el @@ -1167,7 +1167,7 @@ this file. Usage: (let ((body (macroexp-progn (use-package-process-keywords name args* - (and use-package-always-defer '(:deferred t)))))) + (and use-package-always-defer (list :deferred t)))))) (if use-package-debug (display-buffer (save-current-buffer From 71057bc20f2170f2a1250caa949201297dfa8dde Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 6 Sep 2015 22:28:50 -0400 Subject: [PATCH 2/3] use-package-as-string: use noerror parameter --- lisp/use-package/use-package.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/use-package/use-package.el b/lisp/use-package/use-package.el index ffe2dac3e46..dd1e3426993 100644 --- a/lisp/use-package/use-package.el +++ b/lisp/use-package/use-package.el @@ -212,8 +212,8 @@ convert it to a string and return that." "Return a form which will load or require NAME depending on whether it's a string or symbol." (if (stringp name) - `(load ,name 'noerror) - `(require ',name nil 'noerror))) + `(load ,name ',noerror) + `(require ',name nil ',noerror))) (defun use-package-expand (name label form) "FORM is a list of forms, so `((foo))' if only `foo' is being called." From 79c38c5184e174c11922ed59568e1070201112f7 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 17 Jul 2016 22:28:25 -0400 Subject: [PATCH 3/3] Fix declare-function call: FILE must be a string --- lisp/use-package/use-package.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/use-package/use-package.el b/lisp/use-package/use-package.el index dd1e3426993..f81b64a02c7 100644 --- a/lisp/use-package/use-package.el +++ b/lisp/use-package/use-package.el @@ -46,7 +46,7 @@ (eval-when-compile (require 'cl)) (eval-when-compile (require 'regexp-opt)) -(declare-function package-installed-p 'package) +(declare-function package-installed-p "package") (defgroup use-package nil "A use-package declaration for simplifying your `.emacs'."