mirror of
git://git.sv.gnu.org/emacs.git
synced 2026-03-25 08:12:11 -07:00
Converting more "@@@@" markers to notes or action-oriented todos.
Copied from Perforce Change: 179692 ServerID: perforce.ravenbrook.com
This commit is contained in:
parent
5bd983c745
commit
7baf794761
4 changed files with 8 additions and 6 deletions
|
|
@ -139,7 +139,7 @@ Res PoolInitV(Pool pool, Arena arena, PoolClass class, va_list args)
|
|||
/* putting another lock in the code. */
|
||||
class->labelled = TRUE;
|
||||
classId = EventInternString(class->name);
|
||||
/* @@@@ this breaks <design/type/#addr.use> */
|
||||
/* NOTE: this breaks <design/type/#addr.use> */
|
||||
EventLabelAddr((Addr)class, classId);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1444,7 +1444,7 @@ static Res amcScanNailedOnce(Bool *totalReturn, Bool *moreReturn,
|
|||
Bool total = TRUE;
|
||||
Size bytesScanned = 0;
|
||||
|
||||
EVENT3(AMCScanBegin, amc, seg, ss); /* @@@@ use own event */
|
||||
EVENT3(AMCScanBegin, amc, seg, ss); /* TODO: consider using own event */
|
||||
|
||||
format = pool->format;
|
||||
amcSegNailboard(seg)->newMarks = FALSE;
|
||||
|
|
@ -1499,7 +1499,7 @@ static Res amcScanNailedOnce(Bool *totalReturn, Bool *moreReturn,
|
|||
AVER(p == limit);
|
||||
|
||||
returnGood:
|
||||
EVENT3(AMCScanEnd, amc, seg, ss); /* @@@@ use own event */
|
||||
EVENT3(AMCScanEnd, amc, seg, ss); /* TODO: consider using own event */
|
||||
|
||||
AVER(bytesScanned <= SegSize(seg));
|
||||
ss->scannedSize += bytesScanned;
|
||||
|
|
@ -1707,7 +1707,9 @@ static Res AMCFixEmergency(Pool pool, ScanState ss, Seg seg,
|
|||
ShieldCover(arena, seg);
|
||||
if(newRef != (Addr)0) {
|
||||
/* Object has been forwarded already, so snap-out pointer. */
|
||||
/* Useful weak pointer semantics not implemented. @@@@ */
|
||||
/* TODO: Implement weak pointer semantics in emergency fixing. This
|
||||
would be a good idea since we really want to reclaim as much as
|
||||
possible in an emergency. */
|
||||
*refIO = newRef;
|
||||
return ResOK;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -859,7 +859,7 @@ Bool MVCheck(MV mv)
|
|||
CHECKL(mv->extendBy > 0);
|
||||
CHECKL(mv->avgSize > 0);
|
||||
CHECKL(mv->extendBy >= mv->avgSize);
|
||||
/* @@@@ Could do more checks here. */
|
||||
/* TODO: More checks are possible. Consider what else could be checked. */
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -141,7 +141,7 @@ static Res NDescribe(Pool pool, mps_lib_FILE *stream)
|
|||
poolN = PoolPoolN(pool);
|
||||
AVERT(PoolN, poolN);
|
||||
|
||||
UNUSED(stream); /* @@@@ should output something here */
|
||||
UNUSED(stream); /* TODO: should output something here */
|
||||
|
||||
return ResOK;
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue