mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-26 23:31:55 -08:00
Code Issues Projects Releases Wiki Activity

Avoid assertion violations in set_text_properties_1

Browse source 
* src/textprop.c (set_text_properties): If the call to
modify_text_properties modifies the interval tree as side effect,
recalculate the correct interval for START and END.  (Bug#32265)
This commit is contained in:
Eli Zaretskii 2018-08-02 16:29:54 +03:00
parent 15458a8301
commit 7669bf7880
1 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/textprop.c
View file

@ -1350,6 +1350,7 @@ set_text_properties (Lisp_Object start, Lisp_Object end, Lisp_Object properties,
{
register INTERVAL i;
Lisp_Object ostart, oend;
bool first_time = true;
ostart = start;
oend = end;
@ -1372,6 +1373,7 @@ set_text_properties (Lisp_Object start, Lisp_Object end, Lisp_Object properties,
return Qt;
}
retry:
i = validate_interval_range (object, &start, &end, soft);
if (!i)
@ -1391,8 +1393,22 @@ set_text_properties (Lisp_Object start, Lisp_Object end, Lisp_Object properties,
return Qnil;
}
if (BUFFERP (object) && !NILP (coherent_change_p))
modify_text_properties (object, start, end);
if (BUFFERP (object) && !NILP (coherent_change_p) && first_time)
{
ptrdiff_t prev_length = LENGTH (i);
ptrdiff_t prev_pos = i->position;
modify_text_properties (object, start, end);
/* If someone called us recursively as a side effect of
modify_text_properties, and changed the intervals behind our
back, we cannot continue with I, because its data changed.
So we restart the interval analysis anew. */
if (LENGTH (i) != prev_length || i->position != prev_pos)
{
first_time = false;
goto retry;
}
}
set_text_properties_1 (start, end, properties, object, i);