mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-01-03 10:31:37 -08:00
Code Issues Projects Releases Wiki Activity

(pp-fill): Cut before parens and dots

Browse source 
The `pp-fill` code sometimes end up generating things like:

    (foo .
         bar)

instead of

    (foo
     .  bar)

so make sure we cut before rather than after the dot (and open
parens while we're at it).

* lisp/emacs-lisp/pp.el (pp-fill): Cut before parens and dots.

* test/lisp/emacs-lisp/pp-tests.el (pp-tests--dimensions): New function.
(pp-tests--cut-before): New test.
This commit is contained in:
Stefan Monnier 2024-03-22 16:46:28 -04:00
parent accd79c939
commit 7269a2f158
2 changed files with 39 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

30
test/lisp/emacs-lisp/pp-tests.el
View file

@ -36,4 +36,34 @@
(ert-deftest test-indentation ()
(ert-test-erts-file (ert-resource-file "code-formats.erts")))
(defun pp-tests--dimensions ()
(save-excursion
(let ((width 0)
(height 0))
(goto-char (point-min))
(while (not (eobp))
(end-of-line)
(setq height (1+ height))
(setq width (max width (current-column)))
(forward-char 1))
(cons width height))))
(ert-deftest pp-tests--cut-before ()
(with-temp-buffer
(lisp-data-mode)
(pp '(1 (quite-a-long-package-name
. [(0 10 0) ((avy (0 5 0))) "Quickly switch windows." tar
((:url . "https://github.com/abo-abo/ace-window")
(:maintainer "Oleh Krehel" . "ohwoeowho@gmail.com")
(:authors ("Oleh Krehel" . "ohwoeowho@gmail.com"))
(:keywords "window" "location"))]))
(current-buffer))
;; (message "Filled:\n%s" (buffer-string))
(let ((dimensions (pp-tests--dimensions)))
(should (< (car dimensions) 80))
(should (< (cdr dimensions) 8)))
(goto-char (point-min))
(while (search-forward "." nil t)
(should (not (eolp))))))
;;; pp-tests.el ends here.