From 7203f2f03aa76008f87c9bed596dcbe48ea2d533 Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Wed, 20 Jan 2016 11:44:28 +0000 Subject: [PATCH] Adding reference to job for improving definalization. see . Copied from Perforce Change: 188929 ServerID: perforce.ravenbrook.com --- mps/code/poolmrg.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mps/code/poolmrg.c b/mps/code/poolmrg.c index f329b87f110..2cb5e7a2f21 100644 --- a/mps/code/poolmrg.c +++ b/mps/code/poolmrg.c @@ -745,7 +745,12 @@ Res MRGRegister(Pool pool, Ref ref) } -/* MRGDeregister -- deregister (once) an object for finalization */ +/* MRGDeregister -- deregister (once) an object for finalization + * + * TODO: Definalization loops over all finalizable objects in the heap, + * and so using it could accidentally be disastrous for performance. + * See job003953 and back out changelist 187123 if this is fixed. + */ Res MRGDeregister(Pool pool, Ref obj) {