mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

* lisp/emacs-lisp/cl-generic.el (cl-defgeneric): Warn suspicious args

Browse source
This commit is contained in:
Stefan Monnier 2022-03-17 10:07:35 -04:00
parent e55ceca8c7
commit 693484d36b
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lisp/emacs-lisp/cl-generic.el
View file

@ -262,6 +262,16 @@ DEFAULT-BODY, if present, is used as the body of a default method.
(declarations nil)
(methods ())
(options ())
(warnings
(let ((nonsymargs
(delq nil (mapcar (lambda (arg) (unless (symbolp arg) arg))
args))))
(when nonsymargs
(list
(macroexp-warn-and-return
(format "Non-symbol arguments to cl-defgeneric: %s"
(mapconcat #'prin1-to-string nonsymargs ""))
nil nil nil nonsymargs)))))
next-head)
(while (progn (setq next-head (car-safe (car options-and-methods)))
(or (keywordp next-head)
@ -284,6 +294,7 @@ DEFAULT-BODY, if present, is used as the body of a default method.
(setq name (gv-setter (cadr name))))
`(prog1
(progn
,@warnings
(defalias ',name
(cl-generic-define ',name ',args ',(nreverse options))
,(if (consp doc) ;An expression rather than a constant.