Force stackhot not to be inlined, avoiding the problem described in <https://info.ravenbrook.com/mail/2018/07/11/09-48-49/0/>

Copied from Perforce
 Change: 194577

mps/code/config.h

@@ -278,8 +278,20 @@
 #define ATTRIBUTE_NO_SANITIZE_ADDRESS
 #endif
 
+/* Attribute for functions that must not be inlined.
+ * GCC: <http://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html>
+ * MSVC: <https://docs.microsoft.com/en-us/cpp/cpp/noinline>
+ */
+#if defined(MPS_BUILD_GC) || defined(MPS_BUILD_LL)
+#define ATTRIBUTE_NOINLINE __attribute__((__noinline__))
+#elif defined(MPS_BUILD_MV)
+#define ATTRIBUTE_NOINLINE __declspec(noinline)
+#else
+#define ATTRIBUTE_NOINLINE
+#endif
+
 /* Attribute for functions that do not return.
- * GCC: <http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html>
+ * GCC: <http://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html>
  * Clang: <http://clang.llvm.org/docs/AttributeReference.html#id1>
  */
 #if defined(MPS_BUILD_GC) || defined(MPS_BUILD_LL)
@@ -289,7 +301,7 @@
 #endif
 
 /* Attribute for functions that may be unused in some build configurations.
- * GCC: <http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html>
+ * GCC: <http://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html>
  *
  * This attribute must be applied to all Check functions, otherwise
  * the RASH variety fails to compile with -Wunused-function. (It

mps/code/ss.c

@@ -32,6 +32,7 @@ SRCID(ss, "$Id$");
  * is a hot stack pointer.  See design.mps.ss.sol.stack.hot.
  */
 
+ATTRIBUTE_NOINLINE
 void StackHot(void **stackOut)
 {
   *stackOut = &stackOut;