mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-06 06:20:55 -08:00
Code Issues Projects Releases Wiki Activity

Quote configure.ac arguments more consistently

Browse source 
This should help avoid further Autoconf portability gotchas such as
the one recently fixed in 2022-06-27T04:26:01Z!meyering@fb.com.
* autogen.sh (autoconf_min): Adjust pattern to match
updated configure.ac.
* configure.ac: Quote arguments more consistently,
as per the Autoconf manual.
This commit is contained in:
Paul Eggert 2022-07-04 23:12:45 -05:00
parent e93d9e0f5d
commit 59206529a1
3 changed files with 810 additions and 696 deletions
Download patch file Download diff file Expand all files Collapse all files

2
autogen.sh
View file

@ -35,7 +35,7 @@
progs="autoconf" progs="autoconf"
## Minimum versions we need: ## Minimum versions we need:
autoconf_min=`sed -n 's/^ *AC_PREREQ(\([0-9\.]*\)).*/\1/p' configure.ac` autoconf_min=`sed -n 's/^ *AC_PREREQ(\[\([0-9\.]*\)]).*/\1/p' configure.ac`
## $1 = program, eg "autoconf". ## $1 = program, eg "autoconf".

1502
configure.ac
View file

File diff suppressed because it is too large Load diff

2
etc/compilation.txt
View file

@ -542,7 +542,7 @@ cf90-113 f90comp: ERROR NSE, File = Hoved.f90, Line = 16, Column = 3
* ShellCheck * ShellCheck
In autogen.sh line 38: In autogen.sh line 38:
autoconf_min=`sed -n 's/^ *AC_PREREQ(\([0-9\.]*\)).*/\1/p' configure.ac` autoconf_min=`sed -n 's/^ *AC_PREREQ(\[\([0-9\.]*\)]).*/\1/p' configure.ac`
^----------^ SC2034: autoconf_min appears unused. Verify use (or export if used externally). ^----------^ SC2034: autoconf_min appears unused. Verify use (or export if used externally).
^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^-- SC2006: Use $(...) notation instead of legacy backticked `...`.