mirrors/emacs
1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2025-12-07 06:50:23 -08:00
Code Issues Projects Releases Wiki Activity

Checkdoc would bug out on empty files

Browse source 
* lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring): Don't
bug out on malformed Emacs Lisp (bug#34760).
(checkdoc-file-comments-engine): Don't bug out on empty buffers.
This commit is contained in:
Lars Ingebrigtsen 2019-07-09 18:24:26 +02:00
parent 29fc462263
commit 547800dade
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lisp/emacs-lisp/checkdoc.el
View file

@ -929,7 +929,10 @@ don't move point."
(pcase (save-excursion (condition-case nil
(read (current-buffer))
;; Conservatively skip syntax errors.
(invalid-read-syntax)))
(invalid-read-syntax)
;; Don't bug out if the file is empty (or a
;; definition ends prematurely.
(end-of-file)))
(`(,(or 'defun 'defvar 'defcustom 'defmacro 'defconst 'defsubst 'defadvice)
,(pred symbolp)
;; Require an initializer, i.e. ignore single-argument `defvar'
@ -2250,7 +2253,10 @@ Code:, and others referenced in the style guide."
(re-search-forward "^(require" nil t)
(re-search-forward "^(" nil t))
(beginning-of-line))
(t (re-search-forward ";;; .* --- .*\n")))
((not (re-search-forward ";;; .* --- .*\n" nil t))
(checkdoc-create-error
"You should have a summary line (\";;; .* --- .*\")"
nil nil t)))
(if (checkdoc-y-or-n-p
"You should have a \";;; Commentary:\", add one? ")
(insert "\n;;; Commentary:\n;; \n\n")