1
Fork 0
mirror of git://git.sv.gnu.org/emacs.git synced 2026-04-06 22:31:13 -07:00

Fix erc-track-faces-normal-list regression

* lisp/erc/erc-track.el (erc-track--select-mode-line-face): Check
whether ranked faces in the message appear in the value of the option
`erc-track-faces-normal-list' rather than repeatedly checking if the
current nominee does, usually the highest ranked face in the message.
Failure to do so caused ERC to treat faces absent from the option's
value as being present and thus eligible to replace ranked faces in the
mode line segment.  This bug was introduced in ERC 5.6 and is also part
of 5.6.1.  (Bug#80659)

Copyright-paperwork-exempt: yes
This commit is contained in:
Ivan 2026-03-21 20:01:15 +01:00 committed by F. Jason Park
parent bb3c103968
commit 52e5dbd2da

View file

@ -1006,7 +1006,7 @@ Failing that, choose the first face in both NEW-FACES and NORMALS."
(dolist (candidate (cdr ranks))
(when (and (not (equal candidate choice))
(gethash candidate (car new-faces))
(gethash choice normals))
(gethash candidate normals))
(throw 'face candidate)))
;; Otherwise, go with any "normal" face other than
;; `choice' in the region.